October 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15586) Reduce size of hibernate-core JAR

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15586 ( https://hibernate.atlassian.net/browse/HHH-15586?atlOrigin=eyJpIjoiODAyYj... ) Re: Reduce size of hibernate-core JAR ( https://hibernate.atlassian.net/browse/HHH-15586?atlOrigin=eyJpIjoiODAyYj... ) Yes I understand - but it’s actually not very useful to keep non-actionable issues open. We have thousands of open issues and they won’t be tracked appropriately. What I can (and will) do is to try identify some actions that we could take; for example I’m now exploring https://hibernate.atlassian.net/browse/HHH-15600 ( https://hibernate.atlassian.net/browse/HHH-15600 ) - that might reduce the size of your overall footprint a fair bit. Other similar ideas would be welcome, feel free to make suggestions or prototype patches. ( https://hibernate.atlassian.net/browse/HHH-15586#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15586#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15600) Consider distributing the ByteBuddy based enhancer as a separate module

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZDk0YzAzYzE2... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15600?atlOrigin=eyJpIjoiZDk0Yz... ) HHH-15600 ( https://hibernate.atlassian.net/browse/HHH-15600?atlOrigin=eyJpIjoiZDk0Yz... ) Consider distributing the ByteBuddy based enhancer as a separate module ( https://hibernate.atlassian.net/browse/HHH-15600?atlOrigin=eyJpIjoiZDk0Yz... ) Issue Type: Improvement Assignee: Unassigned Created: 12/Oct/2022 08:08 AM Priority: Major Reporter: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Having the ByteBuddy enhancers integrated in hibernate-core has been handy, but there are several situations in which it would be better off as a separate artifact: * When building GraalVM native images, this code should not be reachable as bytecode manilupation isn’t possible within the closed world set - this is currently a challenge to maintain and it would be simpler if it was contained in its separate compilation unit. * When people use the build-time enhancer, they won’t actually need all this code and its dependencies to be included in the runtime that they ship to production. This is beneficial both in terms of size (not including our enhancer code nor ByteBuddy itself) and security, as a system with less dependencies is intrinsecarlly safer. * It’s also good to limit dependencies, as it makes alignment challenges simpler; e.g. ByteBuddy is very popular and used in other libraries as well - it’s simpler to manage if we only need it within the scope of the enhancement tasks, which could be limited to build time. ( https://hibernate.atlassian.net/browse/HHH-15600#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15600#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

[JIRA] (HSEARCH-4719) Factorize all code related to POJO tree processing

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiMGYxYzcw... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-4719?atlOrigin=eyJpIjoiMGY... ) HSEARCH-4719 ( https://hibernate.atlassian.net/browse/HSEARCH-4719?atlOrigin=eyJpIjoiMGY... ) Factorize all code related to POJO tree processing ( https://hibernate.atlassian.net/browse/HSEARCH-4719?atlOrigin=eyJpIjoiMGY... ) Issue Type: Task Assignee: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: mapper-pojo-base Created: 12/Oct/2022 07:49 AM Fix Versions: 7.x-backlog Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) There is a lot (and I mean a LOT) of duplicated code between all three tree processing facilities: * PojoIndexingProcessorNode * PojoImplicitReindexingResolverNode * PojoImplicitReindexingAssociationInverseSideResolverNode Those are all basically about going through a tree of objects and applying operations to some of them. We’ve already started standardizing that processing with org.hibernate.search.mapper.pojo.extractor.impl.ContainerExtractorHolder#wrap / ValueProcessor (used in PojoIndexingProcessorContainerElementNode and PojoImplicitReindexingResolverContainerElementNode in particular). Maybe we could go one step further and provide generic implementations of value processors that extract a property or apply a typecast? Then we’d use that for all three tree processing facilities, the only specific parts being operations applied to nodes to mark them for reindexin/etc. ( https://hibernate.atlassian.net/browse/HSEARCH-4719#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4719#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15598) Remove unused legacy SPIs: InstrumentedClassLoader, ByteCodeHelper

by Sanne Grinovero (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15597) Unable to enhance class with Hibernate 6 Gradle plugin

by sdeleuze (JIRA)

sdeleuze ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=634667c... ) *commented* on HHH-15597 ( https://hibernate.atlassian.net/browse/HHH-15597?atlOrigin=eyJpIjoiOTQ5YT... ) Re: Unable to enhance class with Hibernate 6 Gradle plugin ( https://hibernate.atlassian.net/browse/HHH-15597?atlOrigin=eyJpIjoiOTQ5YT... ) I just tried to remove the id 'org.graalvm.buildtools.native' version '0.9.14' plugin which in turn disables Spring Boot 3 AOT transformation. As a result, I have a pure Spring Boot 3 + Hibernate project usable on the JVM with nothing specific. I am also using a recent Liberica JDK ( sdk use java 17.0.4.1-librca ) and when running./gradlew clean compileJava I get the same Unable to enhance class : com.example.data.jpa.CLR error. So unless I miss something, looks like at least Spring Boot 3 + Java 17 + Hibernate 6 + enhancer plugin use case is broken. This application seems pretty standard, I don’t think we do something special here. The fact that this is working with Maven Hibernate 6 plugin but not the Gradle one + the fact we had similar use case working with Hibernate 5 Gradle plugin make me think that’s a regression of Hibernate 6 Gradle plugin. ( https://hibernate.atlassian.net/browse/HHH-15597#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15597#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15597) Unable to enhance class with Hibernate 6 Gradle plugin

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15597 ( https://hibernate.atlassian.net/browse/HHH-15597?atlOrigin=eyJpIjoiYmYwY2... ) Re: Unable to enhance class with Hibernate 6 Gradle plugin ( https://hibernate.atlassian.net/browse/HHH-15597?atlOrigin=eyJpIjoiYmYwY2... ) Going to need a little more information. What is “unique” about your build? Or are you claiming it just NeverWorks? ( https://hibernate.atlassian.net/browse/HHH-15597#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15597#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15558) Hibernate's Gradle plugin does not work with three-part source set names

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15558 ( https://hibernate.atlassian.net/browse/HHH-15558?atlOrigin=eyJpIjoiYzMwM2... ) Re: Hibernate's Gradle plugin does not work with three-part source set names ( https://hibernate.atlassian.net/browse/HHH-15558?atlOrigin=eyJpIjoiYzMwM2... ) This does come from the work for https://hibernate.atlassian.net/browse/HHH-15314 ( https://hibernate.atlassian.net/browse/HHH-15314 ). The problem centers on being able to understand the task that compiles the sources to be able to apply a task dependency so that the enhancement runs whenever the compilation runs. Originally, the plugin implicitly dealt directly with the main SourceSet and Gradle provides easy mapping from SourceSet and task names for Java SourceSets. Most likely the fix would involve leveraging SourceSet#getTaskName [1] or SourceSet#getCompileTaskName [2]. I am not familiar enough in anger with either of those to say for sure atm [1] https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/SourceSet.ht... ( https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/SourceSet.ht... ) [2] https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/SourceSet.ht... ( https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/SourceSet.ht... ) ( https://hibernate.atlassian.net/browse/HHH-15558#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15558#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

[JIRA] (HSEARCH-4718) Do not reindex when irrelevant changes occur inside embedded objects

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-4718 ( https://hibernate.atlassian.net/browse/HSEARCH-4718?atlOrigin=eyJpIjoiOTV... ) Re: Do not reindex when irrelevant changes occur inside embedded objects ( https://hibernate.atlassian.net/browse/HSEARCH-4718?atlOrigin=eyJpIjoiOTV... ) I had to work around that in some tests for https://hibernate.atlassian.net/browse/HSEARCH-4708 ( https://hibernate.atlassian.net/browse/HSEARCH-4708 ). Look for the key of this ticket (4718) in the source code to find reproducers. ( https://hibernate.atlassian.net/browse/HSEARCH-4718#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4718#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

[JIRA] (HSEARCH-4718) Do not reindex when irrelevant changes occur inside embedded objects

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZjJjM2Rl... ) / Improvement ( https://hibernate.atlassian.net/browse/HSEARCH-4718?atlOrigin=eyJpIjoiZjJ... ) HSEARCH-4718 ( https://hibernate.atlassian.net/browse/HSEARCH-4718?atlOrigin=eyJpIjoiZjJ... ) Do not reindex when irrelevant changes occur inside embedded objects ( https://hibernate.atlassian.net/browse/HSEARCH-4718?atlOrigin=eyJpIjoiZjJ... ) Issue Type: Improvement Assignee: Unassigned Components: mapper-orm Created: 12/Oct/2022 05:11 AM Fix Versions: 7.x-backlog Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Whenever an entity is modified and something changes in an embedded object, Hibernate ORM will trigger an event that mentions “that embedded object changed”, but it won't tell us *what* changed exactly inside that embeddable ( org.hibernate.event.spi.PostUpdateEvent#dirtyProperties contains the index of the embeddable property, nothing more). As a result, if the indexing of an entity depends on one property (P1) inside an embeddable, and another property (P2) in that embeddable changes, Hibernate Search currently has to reindex the entity “just to be safe”, because it doesn’t know whether P1 changed or P2 changed, just that “either P1 or P2 changed”. In short, we’ll reindex more often than necessary. This is actually a limitation of Hibernate ORM, so we should investigate whether we can improve things in Hibernate ORM itself. Maybe it’s already solved in Hibernate ORM 6? I doubt that, though. ( https://hibernate.atlassian.net/browse/HSEARCH-4718#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4718#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15599) Support conditional order-by clauses in QueryBuilder

by Patrick Lübbecke (JIRA)

Patrick Lübbecke ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=61a7428... ) *commented* on HHH-15599 ( https://hibernate.atlassian.net/browse/HHH-15599?atlOrigin=eyJpIjoiMzIxY2... ) Re: Support conditional order-by clauses in QueryBuilder ( https://hibernate.atlassian.net/browse/HHH-15599?atlOrigin=eyJpIjoiMzIxY2... ) There is a good chance that we will upgrade to 6.1 once we’re done upgrading from 3.6 to 5.6. Thank you for the hint that this might already be solved. ( https://hibernate.atlassian.net/browse/HHH-15599#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15599#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )

1 year, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues October 2022