October 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15604) Identically-named association in entity root and elementcollection of embeddables leads to assertion error

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15604 ( https://hibernate.atlassian.net/browse/HHH-15604?atlOrigin=eyJpIjoiN2MyND... ) Re: Identically-named association in entity root and elementcollection of embeddables leads to assertion error ( https://hibernate.atlassian.net/browse/HHH-15604?atlOrigin=eyJpIjoiN2MyND... ) You can find a reproducer here: https://github.com/hibernate/hibernate-orm/pull/5411 ( https://github.com/hibernate/hibernate-orm/pull/5411 ) ( https://hibernate.atlassian.net/browse/HHH-15604#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15604#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:492d0ce )

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-15604) Identically-named association in entity root and elementcollection of embeddables leads to assertion error

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNmE1MzQyZTUx... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15604?atlOrigin=eyJpIjoiNmE1Mz... ) HHH-15604 ( https://hibernate.atlassian.net/browse/HHH-15604?atlOrigin=eyJpIjoiNmE1Mz... ) Identically-named association in entity root and elementcollection of embeddables leads to assertion error ( https://hibernate.atlassian.net/browse/HHH-15604?atlOrigin=eyJpIjoiNmE1Mz... ) Issue Type: Bug Assignee: Unassigned Components: hibernate-core Created: 14/Oct/2022 06:09 AM Fix Versions: 6.2.0 Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Affects Hibernate ORM 6.2, probably also 6.1 and 6.0, but definitely not 5.6. This model: @Entity(name = "entityA") public static class EntityA { @Id private Integer id; @OneToOne(mappedBy = "identicallyNamedAssociation", fetch = FetchType.LAZY) private EntityB b; public Integer getId() { return id; } public void setId(Integer id) { this.id = id; } public EntityB getB() { return b; } public void setB(EntityB b) { this.b = b; } } @Entity(name = "entityB") public static class EntityB { @Id private Integer id; @OneToOne @JoinColumn(name = "entityA_id") private EntityA identicallyNamedAssociation; @ElementCollection @Embedded @OrderColumn(name = "idx") @CollectionTable(name = "elemcollect") private List<EmbeddableB> elementCollection = new ArrayList<>(); public Integer getId() { return id; } public void setId(Integer id) { this.id = id; } public EntityA getIdenticallyNamedAssociation() { return identicallyNamedAssociation; } public void setIdenticallyNamedAssociation(EntityA a) { this.identicallyNamedAssociation = a; } public List<EmbeddableB> getElementCollection() { return elementCollection; } } @Embeddable public static class EmbeddableB { @OneToOne @JoinColumn(name = "emb_entityA_id") private EntityA identicallyNamedAssociation; public EntityA getIdenticallyNamedAssociation() { return identicallyNamedAssociation; } public void setIdenticallyNamedAssociation(EntityA a) { this.identicallyNamedAssociation = a; } } Leads to this stack trace: java.lang.AssertionError at org.hibernate.metamodel.mapping.internal.ToOneAttributeMapping.withRegisteredAssociationKeys(ToOneAttributeMapping.java:1492) at org.hibernate.metamodel.mapping.internal.ToOneAttributeMapping.generateFetch(ToOneAttributeMapping.java:1232) at org.hibernate.metamodel.mapping.internal.ToOneAttributeMapping.generateFetch(ToOneAttributeMapping.java:106) at org.hibernate.sql.results.graph.FetchParent.generateFetchableFetch(FetchParent.java:105) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.lambda$createFetchableBiConsumer$9(LoaderSelectBuilder.java:842) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.lambda$visitFetches$8(LoaderSelectBuilder.java:681) at java.base/java.util.ArrayList.forEach(ArrayList.java:1541) at org.hibernate.metamodel.mapping.internal.EmbeddableMappingTypeImpl.visitAttributeMappings(EmbeddableMappingTypeImpl.java:726) at org.hibernate.metamodel.mapping.internal.EmbeddableMappingTypeImpl.visitSubParts(EmbeddableMappingTypeImpl.java:736) at org.hibernate.metamodel.mapping.internal.EmbeddedCollectionPart.visitSubParts(EmbeddedCollectionPart.java:286) at org.hibernate.sql.results.graph.FetchableContainer.visitFetchables(FetchableContainer.java:35) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.visitFetches(LoaderSelectBuilder.java:680) at org.hibernate.loader.ast.internal.LoaderSqlAstCreationState.visitFetches(LoaderSqlAstCreationState.java:118) at org.hibernate.sql.results.graph.AbstractFetchParent.afterInitialize(AbstractFetchParent.java:32) at org.hibernate.sql.results.graph.embeddable.internal.EmbeddableFetchImpl.<init>(EmbeddableFetchImpl.java:75) at org.hibernate.metamodel.mapping.internal.EmbeddedCollectionPart.generateFetch(EmbeddedCollectionPart.java:162) at org.hibernate.sql.results.graph.FetchParent.generateFetchableFetch(FetchParent.java:105) at org.hibernate.collection.spi.InitializerProducerBuilder.createListInitializerProducer(InitializerProducerBuilder.java:153) at org.hibernate.collection.spi.InitializerProducerBuilder.createCollectionTypeWrapperInitializerProducer(InitializerProducerBuilder.java:255) at org.hibernate.collection.internal.CustomCollectionTypeSemantics.createInitializerProducer(CustomCollectionTypeSemantics.java:79) at org.hibernate.collection.spi.CollectionSemantics.createInitializerProducer(CollectionSemantics.java:94) at org.hibernate.sql.results.graph.collection.internal.CollectionDomainResult.<init>(CollectionDomainResult.java:64) at org.hibernate.metamodel.mapping.internal.PluralAttributeMappingImpl.createDomainResult(PluralAttributeMappingImpl.java:370) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.generateSelect(LoaderSelectBuilder.java:450) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.createSelect(LoaderSelectBuilder.java:177) at org.hibernate.loader.ast.internal.CollectionLoaderSingleKey.<init>(CollectionLoaderSingleKey.java:61) at org.hibernate.persister.collection.AbstractCollectionPersister.createCollectionLoader(AbstractCollectionPersister.java:869) at org.hibernate.persister.collection.AbstractCollectionPersister.postInstantiate(AbstractCollectionPersister.java:750) at java.base/java.util.concurrent.ConcurrentHashMap$ValuesView.forEach(ConcurrentHashMap.java:4772) at org.hibernate.metamodel.model.domain.internal.MappingMetamodelImpl.finishInitialization(MappingMetamodelImpl.java:240) at org.hibernate.metamodel.internal.RuntimeMetamodelsImpl.finishInitialization(RuntimeMetamodelsImpl.java:60) at org.hibernate.internal.SessionFactoryImpl.<init>(SessionFactoryImpl.java:309) at org.hibernate.boot.internal.SessionFactoryBuilderImpl.build(SessionFactoryBuilderImpl.java:415) at org.hibernate.testing.orm.junit.SessionFactoryExtension.lambda$createSessionFactoryScope$0(SessionFactoryExtension.java:151) ( https://hibernate.atlassian.net/browse/HHH-15604#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15604#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:492d0ce )

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-4305) No automatic reindexing when setting a property annotated with @OneToOne(mappedBy = ...) @IndexedEmbedded to null

by Automation for Jira (JIRA)

Automation for Jira ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiYmVhYzA2... ) / Bug ( https://hibernate.atlassian.net/browse/HSEARCH-4305?atlOrigin=eyJpIjoiYmV... ) HSEARCH-4305 ( https://hibernate.atlassian.net/browse/HSEARCH-4305?atlOrigin=eyJpIjoiYmV... ) No automatic reindexing when setting a property annotated with @OneToOne(mappedBy = ...) @IndexedEmbedded to null ( https://hibernate.atlassian.net/browse/HSEARCH-4305?atlOrigin=eyJpIjoiYmV... ) Change By: Automation for Jira ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Pull Request: https://github.com/hibernate/hibernate-search/pull/3268 Status: In Progress Pull Request Sent ( https://hibernate.atlassian.net/browse/HSEARCH-4305#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4305#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:492d0ce )

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-3567) Automatic reindexing on one-sided association updates

by Automation for Jira (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-4708) No automatic reindexing when changing a property annotated with @OneToOne(mappedBy = ...) @IndexedEmbedded

by Automation for Jira (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-14798) No PostUpdateEvent fired when setting a property with @OneToOne(mappedBy = ...) to null

by Yoann Rodière (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-3567) Automatic reindexing on one-sided association updates

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiYjFjYTA2... ) / Improvement ( https://hibernate.atlassian.net/browse/HSEARCH-3567?atlOrigin=eyJpIjoiYjF... ) HSEARCH-3567 ( https://hibernate.atlassian.net/browse/HSEARCH-3567?atlOrigin=eyJpIjoiYjF... ) Automatic reindexing on one-sided association updates ( https://hibernate.atlassian.net/browse/HSEARCH-3567?atlOrigin=eyJpIjoiYjF... ) Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Let's imagine a model with two entity types {{A}} and {{B}}, pointing to each other through an association: {{A.b}} and {{B.a}}. {{A}} is an indexed entity, and its indexed document includes some parts of {{B}} through the association {{A.b}} (e.g. there's a field {{b.c}} in A's indexed document). When the user updates the association between {{A}} and {{B}}, we expect him to update both sides of the association: {{A.b}} *and* {{B.a}}. If the user were to only update {{B.a}}, we would know that the entity previously pointed to by B.a needs to be reindexed, but we wouldn't know which entity this was, since {{B.a}} was updated (set to null or to another entity)... There are two problems with this limitations: 1. ORM allows only updating one side of the association (the owning side), which means users are likely to only update one side from time to time. When they do, Hibernate Search will silently "forget" to reindex. Best case, users will spot the problem, will assume Search is buggy and painstakingly update their application to update both sides of the association; worst case they will not spot the problem and they will ship a buggy application. 2. This effectively precludes us from allowing unidirectional associations, where {{A.b}} doesn't exist and is replaced with a query: if we did that, we wouldn't be able to reindex when the association is updated on the {{B}} side. In Search 5 (and 6 after HSEARCH-4303), we partially support such asymmetric one-sided association updates: if {{B}} was completely deleted and the association {{B.a}} was left untouched, we walk through that association and reindex {{A}}. However this only works when the association is updated implicitly though deletion of {{B}}, and {{B.a}} is eager or already loaded, {{A.b}} is lazy. I think we should support support asymmetric one-sided association updates. We would only have to store in the work plan, for each entity and each relevant association from that entity, the list of entities removed from associations: * When a {{*ToOne}} association is set to null, or simply changed, we'd use the entity update event to find the previous value of that association. * When a {{*ToMany}} association is updated or replaced, we'd use the collection update or replace event to find the entities removed from the association. * When an entity is deleted, we'd use the before delete event to load every relevant association, and add updates to the work plan for the inverse side of each association. This might be a bit heavy resource wise, but we would only need to do that for associations from an "indexedEmbedded" or otherwise contained type to its containing type. There may be ways to optimize this. The big question is, of course, would extracting this information be easy, or even possible at all? ( https://hibernate.atlassian.net/browse/HSEARCH-3567#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3567#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:492d0ce )

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-3567) Automatic reindexing on one-sided association updates

by Yoann Rodière (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-15603) Querying the object containing json before saving other objects will trigger the object to also be saved

by 于文瑾 (JIRA)

于文瑾 ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5cb02d8... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiY2IyYzAyNWU1... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15603?atlOrigin=eyJpIjoiY2IyYz... ) HHH-15603 ( https://hibernate.atlassian.net/browse/HHH-15603?atlOrigin=eyJpIjoiY2IyYz... ) Querying the object containing json before saving other objects will trigger the object to also be saved ( https://hibernate.atlassian.net/browse/HHH-15603?atlOrigin=eyJpIjoiY2IyYz... ) Issue Type: Bug Affects Versions: 5.3.22 Assignee: Unassigned Attachments: bug1.png, bug2.png, bug3.png Components: hibernate-core Created: 14/Oct/2022 00:25 AM Environment: spring data jpa: 2.7.3 postgresql: 9.6.11 Priority: Major Reporter: 于文瑾 ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5cb02d8... ) ( https://hibernate.atlassian.net/browse/HHH-15603#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15603#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:492d0ce )

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-4720) Throw exceptions instead of logging warnings for failures to configure association inverse path resolution

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZDZlODUy... ) / Improvement ( https://hibernate.atlassian.net/browse/HSEARCH-4720?atlOrigin=eyJpIjoiZDZ... ) HSEARCH-4720 ( https://hibernate.atlassian.net/browse/HSEARCH-4720?atlOrigin=eyJpIjoiZDZ... ) Throw exceptions instead of logging warnings for failures to configure association inverse path resolution ( https://hibernate.atlassian.net/browse/HSEARCH-4720?atlOrigin=eyJpIjoiZDZ... ) Issue Type: Improvement Assignee: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: mapper-orm, mapper-pojo-base Created: 13/Oct/2022 09:40 AM Fix Versions: 7.0-backlog Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) For my work on https://hibernate.atlassian.net/browse/HSEARCH-4708 ( https://hibernate.atlassian.net/browse/HSEARCH-4708 ) , I’ve been extra careful not to fail, and as a result I decided to log warnings whenever anything goes wrong on the features I added to fix that bug. Whenever we can (and if we can), we should break backwards compatibility and simply throw exceptions instead of logging warnings. See occurrences of this ticket’s key in the source code. ( https://hibernate.atlassian.net/browse/HSEARCH-4720#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4720#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:492d0ce )

2 years, 2 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues October 2022