February 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16128) Parameters out of order on inner join with entities with @Inheritance(strategy = InheritanceType.JOINED)

by Jose Freire (JIRA)

Jose Freire ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMjhmZDNjNDMw... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16128?atlOrigin=eyJpIjoiMjhmZD... ) HHH-16128 ( https://hibernate.atlassian.net/browse/HHH-16128?atlOrigin=eyJpIjoiMjhmZD... ) Parameters out of order on inner join with entities with @Inheritance(strategy = InheritanceType.JOINED) ( https://hibernate.atlassian.net/browse/HHH-16128?atlOrigin=eyJpIjoiMjhmZD... ) Change By: Jose Freire ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Having the following entities: {code:java}@Entity @Inheritance(strategy = InheritanceType.JOINED) public class TestClassSuper implements Serializable { private static final long serialVersionUID = 1L; private Long id; private String text; private Date date; private BigDecimal number; .... } @Entity public class TestClassA extends TestClassSuper { private static final long serialVersionUID = 1L; private Long id; .... } @Entity public class TestClassB extends TestClassSuper { private static final long serialVersionUID = 1L; private Long id; .... }{code} The following HQL: {code:sql}SELECT a.id FROM org.hibernate.bugs.testclassa a LEFT JOIN org.hibernate.bugs.testclassa c ON a.id = c.id AND c.date = :date LEFT JOIN org.hibernate.bugs.testclassb b ON a.id = b.id AND a.text = :text{code} Produces the SQL: {code:sql}SELECT testclassa0_.id AS col_0_0_ FROM testclassa testclassa0_ INNER JOIN testclasssuper testclassa0_1_ ON testclassa0_.id = testclassa0_1_.id LEFT OUTER JOIN ( testclassa testclassa1_ INNER JOIN testclasssuper testclassa1_1_ ON testclassa1_.id = testclassa1_1_.id ) ON ( testclassa0_.id = testclassa1_.id AND testclassa1_1_.date = ? ) LEFT OUTER JOIN ( testclassb testclassb2_ INNER JOIN testclasssuper testclassb2_1_ ON testclassb2_.id = testclassb2_1_.id ) ON ( testclassa0_.id = testclassb2_.id AND testclassa0_1_.text = ? ){code} However, by changing the first LEFT JOIN to INNER JOIN in the HQL: {code:sql}SELECT a.id FROM org.hibernate.bugs.testclassa a INNER JOIN org.hibernate.bugs.testclassa c ON a.id = c.id AND c.date = :date LEFT JOIN org.hibernate.bugs.testclassb b ON a.id = b.id AND a.text = :text{code} Produces the SQL: {code:sql}SELECT testclassa0_.id AS col_0_0_ FROM testclassa testclassa0_ INNER JOIN testclasssuper testclassa0_1_ ON testclassa0_.id = testclassa0_1_.id INNER JOIN testclassa testclassa1_ ON 1 = 1 INNER JOIN testclasssuper testclassa1_1_ ON testclassa1_.id = testclassa1_1_.id LEFT OUTER JOIN ( testclassb testclassb2_ INNER JOIN testclasssuper testclassb2_1_ ON testclassb2_.id = testclassb2_1_.id ) ON ( testclassa0_.id = testclassb2_.id AND testclassa0_1_.text = ? ) WHERE ( testclassa0_.id = testclassa1_.id AND testclassa1_1_.date = ? ){code} The parameter sequence has changed! In the first query the parameter sequence in the query is: date, text. In the second query the parameter sequence in the query is: text, date. But the binding order for the second query is the same as the first query, thus the cast exception on SQL Server: {code:java}Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: Conversion failed when converting date and/or time from character string. at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:265) at com.microsoft.sqlserver.jdbc.SQLServerResultSet$FetchBuffer.nextRow(SQLServerResultSet.java:5479) at com.microsoft.sqlserver.jdbc.SQLServerResultSet.fetchBufferNext(SQLServerResultSet.java:1798) at com.microsoft.sqlserver.jdbc.SQLServerResultSet.next(SQLServerResultSet.java:1056) at org.hibernate.loader.Loader.getRowsFromResultSet(Loader.java:1043) at org.hibernate.loader.Loader.processResultSet(Loader.java:998) at org.hibernate.loader.Loader.doQuery(Loader.java:967) at org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:357) at org.hibernate.loader.Loader.doList(Loader.java:2868){code} Hibernate is binding the parameter of type ‘date’ into the binding position ‘0', but the ‘date’ parameter position has changed to the binding position '1’. - Attached is a test case, however I couldn’t reproduce with H2 database. My guess is that H2 doesn’t care, because the generated SQL is identical -. Attached a new test case (TestCase-ParametersOutOfOrder-2.tar.gz), much simpler and works with H2 database. ( https://hibernate.atlassian.net/browse/HHH-16128#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16128#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:fcee39f )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16128) Parameters out of order on inner join with entities with @Inheritance(strategy = InheritanceType.JOINED)

by Jose Freire (JIRA)

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16013) Lazy loading fails with "Generation of HibernateProxy instances at runtime is not allowed" when run as native

by cstrobl (JIRA)

cstrobl ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=630ccdd... ) *commented* on HHH-16013 ( https://hibernate.atlassian.net/browse/HHH-16013?atlOrigin=eyJpIjoiNDYwNT... ) Re: Lazy loading fails with "Generation of HibernateProxy instances at runtime is not allowed" when run as native ( https://hibernate.atlassian.net/browse/HHH-16013?atlOrigin=eyJpIjoiNDYwNT... ) Thank you Sanne. True, usage of org.hibernate.bytecode.internal.none.BytecodeProviderImpl will error by default, thus no potentially already enhanced type won't be able to serve the needs here. The current approach where frameworks need to plug in their own eg. BytecodeProvider / ProxyFactoryFactory (like Quarkus is doing) can lead to a different experience for users depending on the way they happen to consume hibernate. May this be using hibernate standalone, with quarkus or spring. Currently each framework would have to maintain their own flavor of ProxyFactoryFactory and StandardServiceInitiator<ProxyFactoryFactory> plus all the code to mix them together in order to provide sufficient enough native image experience. Decoupling the current arrangement with org.hibernate.bytecode.internal.bytebuddy.BytecodeProviderImpl being the default, adding a third option, able to pick up already enhanced/precomputed types would lead to less friction. If there was some API to call that creates the Proxy at build time (which can be invoked by any AOT processing engine or even the hibernate maven/gradle plugins) would allow to include precomputed proxies in the image being discoverable eg. via conventions. Furthermore, depending on the actual implementation of it, the GraalVM native image analysis could then be optimized so that code paths, that currently lead to the inclusion of ByteBuddy types in the native image, can be cut off, resulting in smaller executables. ( https://hibernate.atlassian.net/browse/HHH-16013#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16013#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:fcee39f )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-15999) Hibernate 6.1.6.Final TableGenerator produces negative ID's

by Andrea Boriero (JIRA)

Andrea Boriero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15999 ( https://hibernate.atlassian.net/browse/HHH-15999?atlOrigin=eyJpIjoiNWE1MW... ) Re: Hibernate 6.1.6.Final TableGenerator produces negative ID's ( https://hibernate.atlassian.net/browse/HHH-15999?atlOrigin=eyJpIjoiNWE1MW... ) I checked your reproducer and I saw you are creating an hibernate_sequance table with an auto increment column name id , Hibernate is not aware of this column but instead expects a table with 2 columns, sequence_name that is a Primary key and next_val. ( https://hibernate.atlassian.net/browse/HHH-15999#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15999#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:fcee39f )

1 year, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-4616) Rename automatic indexing to something more explicit

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-4616 ( https://hibernate.atlassian.net/browse/HSEARCH-4616?atlOrigin=eyJpIjoiOTE... ) Re: Rename automatic indexing to something more explicit ( https://hibernate.atlassian.net/browse/HSEARCH-4616?atlOrigin=eyJpIjoiOTE... ) Note that Marko Bekhta ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) already started the renaming in https://github.com/hibernate/hibernate-search/pull/3384/files# ( https://github.com/hibernate/hibernate-search/pull/3384/files# ) / https://hibernate.atlassian.net/browse/HSEARCH-4620 ( https://hibernate.atlassian.net/browse/HSEARCH-4620 ) by renaming the “automatic indexing synchronization strategy” to “indexing plan synchronization strategy”. However, there’s still documentation that needs to be reorganized (to refer to indexing plans rather than automatic indexing) and a bunch of concepts that need to be renaming (automatic_indexing.enabled, automatic_indexing.enable_dirty_checks, …). By the way, automatic_indexing.enable_dirty_checks is rather broken (it’s true by default and setting it to false just removes a bunch of essential features), so we might want to deprecate it without replacement/renaming, for removal in Search 8. ( https://hibernate.atlassian.net/browse/HSEARCH-4616#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4616#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:fcee39f )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16003) Wrong alias used in subquery generated from JPQL

by Marco Belladelli (JIRA)

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16130) Unable to invoke Postgres date_trunc function via CriteriaApi

by Réda Housni Alaoui (JIRA)

Réda Housni Alaoui ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMDRiYTYyYjc2... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16130?atlOrigin=eyJpIjoiMDRiYT... ) HHH-16130 ( https://hibernate.atlassian.net/browse/HHH-16130?atlOrigin=eyJpIjoiMDRiYT... ) Unable to invoke Postgres date_trunc function via CriteriaApi ( https://hibernate.atlassian.net/browse/HHH-16130?atlOrigin=eyJpIjoiMDRiYT... ) Issue Type: Bug Affects Versions: 6.1.6 Assignee: Unassigned Created: 02/Feb/2023 01:30 AM Priority: Major Reporter: Réda Housni Alaoui ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) The following snippet was working on version 5.6.14 on Postgres 14: CriteriaBuilder criteriaBuilder = entityManager.getCriteriaBuilder(); CriteriaQuery<Date> query = criteriaBuilder.createQuery(Date.class); query.select(criteriaBuilder.function( "date_trunc" , Date.class, criteriaBuilder.literal( "year" ), criteriaBuilder.currentTimestamp())); entityManager.createQuery(query).getSingleResult(); On 6.1.6, it fails with arameter 1 of function date_trunc() has type TEMPORAL_UNIT, but argument is of type java.lang. Object org.hibernate.QueryException: Parameter 1 of function date_trunc() has type TEMPORAL_UNIT, but argument is of type java.lang. Object at app //org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.throwError(ArgumentTypesValidator.java:251) at app //org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.validate(ArgumentTypesValidator.java:111) at app //org.hibernate.query.sqm.function.AbstractSqmFunctionDescriptor.generateSqmExpression(AbstractSqmFunctionDescriptor.java:104) at app //org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.function(SqmCriteriaNodeBuilder.java:1643) at app //org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.function(SqmCriteriaNodeBuilder.java:176) at app //org.hibernate.orm.test.query.hql.FunctionTests.lambda$testDateTruncFunctionViaCriteriaApi$22(FunctionTests.java:542) at app //org.hibernate.testing.orm.transaction.TransactionUtil.wrapInTransaction(TransactionUtil.java:49) at app //org.hibernate.testing.orm.transaction.TransactionUtil.inTransaction(TransactionUtil.java:24) at app //org.hibernate.testing.orm.junit.SessionFactoryExtension$SessionFactoryScopeImpl.inTransaction(SessionFactoryExtension.java:375) at app //org.hibernate.testing.orm.junit.SessionFactoryExtension$SessionFactoryScopeImpl.inTransaction(SessionFactoryExtension.java:352) at app //org.hibernate.orm.test.query.hql.FunctionTests.testDateTruncFunctionViaCriteriaApi(FunctionTests.java:536) But https://github.com/Cosium/hibernate-orm/blob/94b20bafc84d3f26fa37bf41ed79... ( https://github.com/Cosium/hibernate-orm/blob/94b20bafc84d3f26fa37bf41ed79... ) proves it works via HQL . ( https://hibernate.atlassian.net/browse/HHH-16130#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16130#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16129) @Converter(autoapply=true) slow

by boutss (JIRA)

boutss ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMTgyNmEzYmU4... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16129?atlOrigin=eyJpIjoiMTgyNm... ) HHH-16129 ( https://hibernate.atlassian.net/browse/HHH-16129?atlOrigin=eyJpIjoiMTgyNm... ) @Converter(autoapply=true) slow ( https://hibernate.atlassian.net/browse/HHH-16129?atlOrigin=eyJpIjoiMTgyNm... ) Change By: boutss ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Hi, I opened a discussion on the forum about a performance issue using @AttributConverter(autoApply=true) which is much slower than using @RegistrationConverter which uses the domain type to reference a Converter [@Converter(autoapply=true) slow - Hibernate ORM - Hibernate|https://discourse.hibernate.org/t/converter-autoapply-true-slow...] In my case I have 500 converters and 800 class attributes. For the performance we spend 30’000ms to apply the autoapply of the converters. If we use @ConversionRegister we are at 700 ms. Unfortunately I have no solution to propose to modify the code (see the .5). # Retrieval of the type to apply the converter # This is my solution which is faster, to exploit the registerConversionByDomainType # The performance problem because we loop on all existing converters # In addition to the time-consuming converter application test # It is the verification that only one converter is compatible. I tell myself that this is the reason why we loop over all the converters to make sure that we are not multiple compatible converters. But in itself, we could know it upstream by using a map which also contains the type of the domain as a key. !AttributConverterManager.png|width=1295,height=1087! I use arthas for performance testing [https://github.com/alibaba/arthas|https://github.com/alibaba/arthas|smart...] The command to test : {noformat}monitor org.hibernate.boot.model.convert.internal.AttributeConverterManager locateMatchingConverter -c 10{noformat} ( https://hibernate.atlassian.net/browse/HHH-16129#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16129#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16129) @Converter(autoapply=true) slow

by boutss (JIRA)

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16129) @Converter(autoapply=true) slow

by boutss (JIRA)

boutss ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiOTVjMjk4MDgy... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16129?atlOrigin=eyJpIjoiOTVjMj... ) HHH-16129 ( https://hibernate.atlassian.net/browse/HHH-16129?atlOrigin=eyJpIjoiOTVjMj... ) @Converter(autoapply=true) slow ( https://hibernate.atlassian.net/browse/HHH-16129?atlOrigin=eyJpIjoiOTVjMj... ) Issue Type: Bug Affects Versions: 6.1.6 Assignee: Unassigned Attachments: 7a5ab3186e098aa7a9969079fa4d232c90568d77[1].png Components: hibernate-core Created: 02/Feb/2023 01:12 AM Environment: hibernate 6.1.6 / OpenJDK / Windows 11 / Oracle Priority: Major Reporter: boutss ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Hi, I opened a discussion on the forum about a performance issue using @AttributConverter(autoApply=true) which is much slower than using @RegistrationConverter which uses the domain type to reference a Converter @Converter(autoapply=true) slow - Hibernate ORM - Hibernate ( https://discourse.hibernate.org/t/converter-autoapply-true-slow/7215 ) In my case I have 500 converters and 800 class attributes. For the performance we spend 30’000ms to apply the autoapply of the converters. If we use @ConversionRegister we are at 700 ms. Unfortunately I have no solution to propose to modify the code (see the .5). * Retrieval of the type to apply the converter * This is my solution which is faster, to exploit the registerConversionByDomainType * The performance problem because we loop on all existing converters * In addition to the time-consuming converter application test * It is the verification that only one converter is compatible. I tell myself that this is the reason why we loop over all the converters to make sure that we are not multiple compatible converters. But in itself, we could know it upstream by using a map which also contains the type of the domain as a key. I use arthas for performance testing https://github.com/alibaba/arthas ( https://github.com/alibaba/arthas ) The command to test : monitor org.hibernate.boot.model.convert.internal.AttributeConverterManager locateMatchingConverter -c 10 ( https://hibernate.atlassian.net/browse/HHH-16129#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16129#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )

1 year, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues February 2023