February 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16128) Parameters out of order on inner join with entities with @Inheritance(strategy = InheritanceType.JOINED)

by Jose Freire (JIRA)

Jose Freire ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiN2MyYjU4OTQy... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16128?atlOrigin=eyJpIjoiN2MyYj... ) HHH-16128 ( https://hibernate.atlassian.net/browse/HHH-16128?atlOrigin=eyJpIjoiN2MyYj... ) Parameters out of order on inner join with entities with @Inheritance(strategy = InheritanceType.JOINED) ( https://hibernate.atlassian.net/browse/HHH-16128?atlOrigin=eyJpIjoiN2MyYj... ) Issue Type: Bug Affects Versions: 5.4.33, 5.6.14 Assignee: Unassigned Attachments: TestCase-ParametersOutOfOrder.tar.gz Components: hibernate-core Created: 01/Feb/2023 16:52 PM Environment: Hibernate 5.6.14.Final, SQL Server, Amazon Correto Priority: Major Reporter: Jose Freire ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Having the following entities: @Entity @Inheritance(strategy = InheritanceType.JOINED) public class TestClassSuper implements Serializable { private static final long serialVersionUID = 1L; private Long id; private String text; private Date date; private BigDecimal number; .... } @Entity public class TestClassA extends TestClassSuper { private static final long serialVersionUID = 1L; private Long id; .... } @Entity public class TestClassB extends TestClassSuper { private static final long serialVersionUID = 1L; private Long id; .... } The following HQL: SELECT a.id FROM org.hibernate.bugs.testclassa a LEFT JOIN org.hibernate.bugs.testclassa c ON a.id = c.id AND c. date = : date LEFT JOIN org.hibernate.bugs.testclassb b ON a.id = b.id AND a. text = : text Produces the SQL: SELECT testclassa0_.id AS col_0_0_ FROM testclassa testclassa0_ INNER JOIN testclasssuper testclassa0_1_ ON testclassa0_.id = testclassa0_1_.id LEFT OUTER JOIN ( testclassa testclassa1_ INNER JOIN testclasssuper testclassa1_1_ ON testclassa1_.id = testclassa1_1_.id ) ON ( testclassa0_.id = testclassa1_.id AND testclassa1_1_. date = ? ) LEFT OUTER JOIN ( testclassb testclassb2_ INNER JOIN testclasssuper testclassb2_1_ ON testclassb2_.id = testclassb2_1_.id ) ON ( testclassa0_.id = testclassb2_.id AND testclassa0_1_. text = ? ) However, by changing the first LEFT JOIN to INNER JOIN in the HQL: SELECT a.id FROM org.hibernate.bugs.testclassa a INNER JOIN org.hibernate.bugs.testclassa c ON a.id = c.id AND c. date = : date LEFT JOIN org.hibernate.bugs.testclassb b ON a.id = b.id AND a. text = : text Produces the SQL: SELECT testclassa0_.id AS col_0_0_ FROM testclassa testclassa0_ INNER JOIN testclasssuper testclassa0_1_ ON testclassa0_.id = testclassa0_1_.id INNER JOIN testclassa testclassa1_ ON 1 = 1 INNER JOIN testclasssuper testclassa1_1_ ON testclassa1_.id = testclassa1_1_.id LEFT OUTER JOIN ( testclassb testclassb2_ INNER JOIN testclasssuper testclassb2_1_ ON testclassb2_.id = testclassb2_1_.id ) ON ( testclassa0_.id = testclassb2_.id AND testclassa0_1_. text = ? ) WHERE ( testclassa0_.id = testclassa1_.id AND testclassa1_1_. date = ? ) The parameter sequence has changed! In the first query the parameter sequence in the query is: date, text. In the second query the parameter sequence in the query is: text, date. But the binding order for the second query is the same as the first query, thus the cast exception on SQL Server: Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: Conversion failed when converting date and/or time from character string. at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:265) at com.microsoft.sqlserver.jdbc.SQLServerResultSet$FetchBuffer.nextRow(SQLServerResultSet.java:5479) at com.microsoft.sqlserver.jdbc.SQLServerResultSet.fetchBufferNext(SQLServerResultSet.java:1798) at com.microsoft.sqlserver.jdbc.SQLServerResultSet.next(SQLServerResultSet.java:1056) at org.hibernate.loader.Loader.getRowsFromResultSet(Loader.java:1043) at org.hibernate.loader.Loader.processResultSet(Loader.java:998) at org.hibernate.loader.Loader.doQuery(Loader.java:967) at org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:357) at org.hibernate.loader.Loader.doList(Loader.java:2868) Hibernate is binding the parameter of type ‘date’ into the binding position ‘0', but the ‘date’ parameter position has changed to the binding position '1’. Attached is a test case, however I couldn’t reproduce with H2 database. My guess is that H2 doesn’t care, because the generated SQL is identical. ( https://hibernate.atlassian.net/browse/HHH-16128#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16128#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16105) Hibernate no longer detects HashMap property with AttributeConverter as dirty

by Steve Ebersole (JIRA)

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16127) Support for `@Immutable` on AttributeConverter implementations

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMzM2NWJmN2Qw... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16127?atlOrigin=eyJpIjoiMzM2NW... ) HHH-16127 ( https://hibernate.atlassian.net/browse/HHH-16127?atlOrigin=eyJpIjoiMzM2NW... ) Support for `@Immutable` on AttributeConverter implementations ( https://hibernate.atlassian.net/browse/HHH-16127?atlOrigin=eyJpIjoiMzM2NW... ) Issue Type: Improvement Assignee: Unassigned Created: 01/Feb/2023 13:27 PM Priority: Major Reporter: Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Here, we are talking about the internal state of a value. So, e.g. a String is immutable (we cannot change its internal state) while a Date is mutable (its internal state can be changed). Effectively this tells Hibernate a few important pieces of detail - * Can we use == for dirty detection, or must we use #equals ? * How do we make copies of those values. * etc When an AttributeConverter is in the mix, there is also a big performance impact. Basically anytime we need to make a copy, which happens quite a bit internally, we need to use the converter. So ideally we want to allow users to indicate that a converted attribute should be treated as immutable. Now we already have this capability using @Immutable on the attribute itself. But for repeated conversions (especially auto-applied conversions), that gets tedious. Allow @Immutable to be specified on the converter itself. ( https://hibernate.atlassian.net/browse/HHH-16127#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16127#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16122) Named type [class xxx] did not implement BasicType nor UserType

by Alexander Savov (JIRA)

Alexander Savov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16122 ( https://hibernate.atlassian.net/browse/HHH-16122?atlOrigin=eyJpIjoiOTVlYm... ) Re: Named type [class xxx] did not implement BasicType nor UserType ( https://hibernate.atlassian.net/browse/HHH-16122?atlOrigin=eyJpIjoiOTVlYm... ) @artyom From my observation and experimentation, it does work “when @Type is applied to a field/getter in a @MappedSuperclass“. The point is that, as the comment states, it should be defined on @MappedSuperclass *public* {{ }} *static* {{ }} *class* {{ MultiTenantDocument}} but not on @MappedSuperclass *public* {{ }} *static* {{ }} *class* {{ TaskServiceDocument}} So have you considered other hypothesis? ( https://hibernate.atlassian.net/browse/HHH-16122#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16122#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16081) Hibernate 6 attribute converter assumes values are immutable

by Steve Ebersole (JIRA)

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-16081) Hibernate 6 attribute converter assumes values are immutable

by Alexander Schwartz (JIRA)

Alexander Schwartz ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6267ec4... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZjk3YzlkOGFh... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16081?atlOrigin=eyJpIjoiZjk3Yz... ) HHH-16081 ( https://hibernate.atlassian.net/browse/HHH-16081?atlOrigin=eyJpIjoiZjk3Yz... ) Hibernate 6 attribute converter assumes values are immutable ( https://hibernate.atlassian.net/browse/HHH-16081?atlOrigin=eyJpIjoiZjk3Yz... ) Change By: Alexander Schwartz ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6267ec4... ) During a migration from H5 to H6 with the Keycloak project, I found a change in the behavior how attribute converters are handled. It seems that a property which results from an attribute converter must not be changed / are assumed to be immutable, as they are not be found by H6 dirty checking. Our example: * Read an entity from the DB where property is converted from JSON to a HashMap * Modify the contents of the HashMap * While H5 marks the entity as dirty and writes it to the DB, H6 doesn't recognize it as dirty, and doesn't write it to the database. The workaround is to first clone the map for the attribute before modifying it. Then dirty tracking works as before. Another possible workaround is to add a {{@Mutability(...)}} to the field. Here's a reproducer example: * Link to PR to see the diff: [https://github.com/hibernate/hibernate-test-case-templates/compare/main.....] * Link to the Branch with the tests: [https://github.com/ahus1/hibernate-test-case-templates/tree/is-HHH-xxxx-a...] In the Zulip Chat Gavin King suggested that Hibernate might default to non-mutable properties for converted attributes by default: [https://hibernate.zulipchat.com/#narrow/stream/132096-hibernate-user/topi...] ( https://hibernate.atlassian.net/browse/HHH-16081#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16081#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-15970) Issue when combining Postgres driver, @MappedSuperclass, generics and enums

by Andrea Boriero (JIRA)

1 year, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-4736) OperationSubmitter to "retry from another thread"

by Automation for Jira (JIRA)

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-13860) @Immutable entities generate warning even if they are not referenced in query

by Jeff Meyers (JIRA)

Jeff Meyers ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5c7fd80... ) *commented* on HHH-13860 ( https://hibernate.atlassian.net/browse/HHH-13860?atlOrigin=eyJpIjoiYmY3Mj... ) Re: @Immutable entities generate warning even if they are not referenced in query ( https://hibernate.atlassian.net/browse/HHH-13860?atlOrigin=eyJpIjoiYmY3Mj... ) Also happening in 5.6.2 for me. I think the problem is *more critical* than a nuisance warning. I am issuing an update query for the mutable entity and it is not happening so my data is now incorrect. It appears as if the @Immutable annotation applies to the table, not the entity. Although sometimes it works, so it feels like which entity Hibernate chooses to look at is random? In this case it’s not looking at the entity referenced in the query. ( https://hibernate.atlassian.net/browse/HHH-13860#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13860#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )

1 year, 2 months

1
0
0 / 0

[JIRA] (HHH-15969) Inheritance: org.hibernate.PropertyAccessException Exception

by Andrea Boriero (JIRA)

1 year, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues February 2023