[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3486?page=c...
]
Steve Ebersole closed HHH-3486.
-------------------------------
Resolution: Rejected
Ceki, while I agree to an extent, the flip side is that you are putting pressure on
frameworks to add unnecessary "no op" bindings just so that noobs can get up and
running with these frameworks. The exact flip side of what you said is that given that
some framework does decide to add such an extraneous binding just to appease users is that
users will be left scratching their heads why they are getting no logging when they
actually do add a binding (because the "no op" one gets picked up first). And
worse, if frameworks are doing this there is no central place to find this reasoning (we
have enough faqs to deal with w/o duplicating slf4j faqs). Also, I think there is a
difference between whatever code is recognizing this situation and instead using a noop
set of impls versus adding "no op" binding to the classpath by default. In the
later case you in fact do run into these "which jar wins out" issues; in the
former there is no such danger...
Sam, I agree about it being a shame that this does not "work out of the box" by
just doing no logging. However I feel very strongly that it is not Hibernate's job to
specify this logging backend or that logging back end. At any rate, never would I choose
to specify a "real" binding; if forced to it, I would choose the "no
op" approach (see danger above). Feel free to open a ticket in slf4j requesting such
an enhancement.
Like I said above, to me this fundamentally comes down to the end user making a choice so
I am going to reject this as anything to do from Hibernate. Though, yes, I agree that I
can see how it would be better if slf4j handled this a little differently.
Include one ore more SLF4J "adapters"
-------------------------------------
Key: HHH-3486
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3486
Project: Hibernate Core
Issue Type: Improvement
Components: build
Affects Versions: 3.3.0.GA, 3.3.0.SP1, 3.3.1
Reporter: Chris Bredesen
Assignee: Steve Ebersole
Hibernate, as of 3.3, no longer distributes all jars needed to run the framework. SLF4J
requires the inclusion of the SLF4J library as well as either a native or a wrapped
implementation. The manual vaguely references such a need but it's never quite clear
that the user must visit the SLF4J website and obtain these jars himself. Maven users are
of course unaffected since the additional SLF4J jars are published in the central repo.
"Adapter" may be the wrong term here but I think the point has been made :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira