11:51 p.m.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6.patch
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:04 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield updated HHH-3646:
---------------------------------
Attachment: hib-core-query-collection-of-elements-3_2_6-ver2.patch
obsoletes previous version. cleaner. also implements collection-of-value querying
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:41 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Sergey Pulyaev commented on HHH-3646:
-------------------------------------
What about collections of simple values?
@CollectionOfElements
Set<Long> lineItems;
How to access their elements?
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:17 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Sergey Pulyaev commented on HHH-3646:
-------------------------------------
There is a problem if we have Many-To-Many collection.
In this situation function CriterionJoinWalker.generateTableAlias is called twice - for
reference table and then - for destination table,
so there will be two aliases with the same name in query - and it will crush with error:
Caused by: java.sql.SQLException: The correlation name '111' is specified multiple
times in a FROM clause.
Sample SQL generated:
select
this_.id as y0_,
sr1_.id as y1_
from
roles this_
inner join
role_inheritors sr1_
on (
this_.id=sr1_.role_id
)
inner join
roles sr1_
on (
sr1_.inherit_id=sr1_.id
)
where
this_.id<>sr1_.id
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:40 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield commented on HHH-3646:
--------------------------------------
my latest patch fixes (I think) this and all other issues. i'll attach it.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:42 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield updated HHH-3646:
---------------------------------
Attachment: hib-core-query-collection-of-elements-3_3_1-ver5.patch
latest version implements query of collection-of-element and collection-of-value and some
other misc fixes
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:18 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Sergey Pulyaev commented on HHH-3646:
-------------------------------------
What about files, declared as "Only in" in patch file?
Only in hibernate/src/org/hibernate/loader/criteria:
ComponentCollectionCriteriaInfoProvider.java
Only in hibernate/src/org/hibernate/loader/criteria: ComponentCriteriaInfoProvider.java
Only in hibernate/src/org/hibernate/loader/criteria: CriteriaInfoProvider.java
Only in hibernate/src/org/hibernate/loader/criteria: EntityCriteriaInfoProvider.java
Only in hibernate/src/org/hibernate/loader/criteria:
ScalarCollectionCriteriaInfoProvider.java
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:01 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield commented on HHH-3646:
--------------------------------------
oops. that patch looks bogus then. I'll have to regen. this out of my cvs repo.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:48 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Emmanuel Bernard commented on HHH-3646:
---------------------------------------
would be nice to get the unit tests too with the patch :)
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:31 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Kai Moritz commented on HHH-3646:
---------------------------------
Hi David,
I would like to test out your patch for this issue (HHH-3646) from November the 12. 2009.
But it looks bogus and on November the 23 you addmited that and said, that you would
regenerate ist.
Unfortunatly I cannot find the new patch.
Or is it already included in one of the newer releases (3.3.2 or 3.5.0-Beta-2), so that I
can use that release to solve the issue? (I cannot find it in the release-notes...)
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:07 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield updated HHH-3646:
---------------------------------
Attachment: hib-core-query-collection-of-elements-3_3_1-ver6.patch
latest patch is attached which should address the issues with previously uploaded patch.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:33 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Olivier Dedieu commented on HHH-3646:
-------------------------------------
Thanks for this patch.
How does it work with collection-of-value? Could you provide an example?
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:20 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Olivier Dedieu commented on HHH-3646:
-------------------------------------
David, Thank you very much for this wonderful patch.
I'v applied your patch (hib-core-query-collection-of-elements-3_3_1-ver6.patch) on
Hibernate 3.3.2-GA.
It works great.
As I didn't know how to query against a particular value of the collection I've
explored your patch and used the restriction on the
CollectionPropertyNames.COLLECTION_ELEMENTS (i.e. "elements").
I've tested with a query against a collection of values, with a code similar to the
following one:
session.createCriteria(User.class).createCriteria("emails").add(Restrictions.eq(CollectionPropertyNames.COLLECTION_ELEMENTS,
"olivier(a)example.com"));
I checked the SQL query and it contains the inner join on the collection. It produces
something like :
select ... from user this_ inner join user_emails user_emails1_ on
this_.ROW_ID=user_emails1_.J_ITEM_ID where
user_emails1_.J_VALUE='olivier(a)example.com'
Is it the correct way to do that ?
I hope your patch (or something similar) will be added in the next release of Hibernate.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield updated HHH-3646:
---------------------------------
Attachment: 0003-implement-criteria-query-of-collection-of-component-.patch
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch
0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch
patches 1-3 (of 5) for patching against 3.5.0-Beta-3
see next set of attachments for patches 4-5.
Patch 0001: In the JoinWalker, we assemble an SQL select list fragment
from a list of Joinables. Reading the existing code, we see it's
possible for the fragment generated to be empty. However if the LAST
joinable generates an empty fragment, we put a spurious comma into the
fragment. Fix this by only prepending a comma when necessary.
Patch 0002: In the CriteriaQueryTranslator, we process the path given by
a SubCriteria object looking for the entity name for the property. If
the SubCriteria was mistakenly created on a component type, we will exit
the loop using the owning entity, and will eventually end up failing
(throwing an exception) trying to lookup up the restricted property
against the entity, instead of against the component. Fix this by
throwing a more informative exception, and modify the documentation to
be explicit about how to do this properly.
Patch 0003: Implement the enhancement named. This includes the
documentation changes. The general approach is:
- create an interface called the CriteriaInfoProvider which abstracts
the operations that are different for the different types of Criteria
targets.
- change the getPathEntityName method to be a factory method for
creating the proper implementation of the interface
- change the rest of CriteriaQueryTranslator to use the interface
instead of using the previous entity-only implementation
- implementations of the interface exist for
Entity: this implements the same code as currently exists
ComponentCollection: for collection-of-component
ScalarCollection: for collection-of-value
Component: for components
- update the logic in CriteriaJoinWalker which has to be very careful
about how it works since the walker walks certain property paths twice.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield updated HHH-3646:
---------------------------------
Attachment: 0005-implement-a-test-case-for-query-collection-of-compon.patch
0004-implement-a-test-case-for-query-collection-of-value.patch
patches 4 and 5 of 5 against 3.5.0-beta-3
Patch 0004: the test case for collection-of-value
Patch 0005: the test case for collection-of-component
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:24 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield commented on HHH-3646:
--------------------------------------
ok. a new set of patches which are now complete have been attached including
Documentation and test cases.
this is against 3.5.0-Beta-3.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 1 day
Remaining Estimate: 1 day
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:42 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Jean-Noel Rivasseau commented on HHH-3646:
------------------------------------------
This patch includes documentation and unit tests, solves one of the most voted for issues
in Hibernate, but still has not been applied. Please, someone, shedule this bug for a fix
version...
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:43 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Steve Ebersole updated HHH-3646:
--------------------------------
Assignee: Steve Ebersole
Fix Version/s: 4.0.0.Alpha1
I will try to get this into the 4.0 alpha 1 or alpha 2. We cannot apply it to 3.6 as it
is adding a new feature, not fixing a bug.
If someone were to fork the main Hibernate GitHub repo and redo this work there as a
rebased pull request it would help out immensely. If not, I will try my best to get to
it
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha1
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:41 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Steve Ebersole updated HHH-3646:
--------------------------------
Fix Version/s: (was: 4.0.0.Alpha1)
4.0.0.Alpha2
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha2
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:20 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield commented on HHH-3646:
--------------------------------------
Are you still looking for someone to create a git branch? I'm willing to port my
patch forward to 4.0 if needs be.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha2
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield commented on HHH-3646:
--------------------------------------
just looking for a heads-up as to whether you are still looking for a branch to pull from.
also sent an email to the dev list and didn't see any response.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha2
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:18 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Emmanuel Bernard commented on HHH-3646:
---------------------------------------
Hi David,
Definitely a github pull request based off master (4.x version) would make the patch
application much easier.
add a comment to the issue when you're done I should be notified.
Emmanuel
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha2
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Steve Ebersole commented on HHH-3646:
-------------------------------------
I replied twice to the dev mailing list :)
http://lists.jboss.org/pipermail/hibernate-dev/2011-March/006180.html
http://lists.jboss.org/pipermail/hibernate-dev/2011-March/006212.html
Anyway, yes, please do. We will make sure it gets integrated. As my last email (link)
states, just be aware that Alpha2 is only a a few days away (April 6)
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha2
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:42 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3646) implement Criteria API querying of collection-of-component
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
David Mansfield commented on HHH-3646:
--------------------------------------
great. thanks. i'll be done before apr. 6.
implement Criteria API querying of collection-of-component
----------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha2
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:37 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3646) implement Criteria API querying of collection-of-component (David Mansfield)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Steve Ebersole updated HHH-3646:
--------------------------------
Summary: implement Criteria API querying of collection-of-component (David Mansfield)
(was: implement Criteria API querying of collection-of-component)
implement Criteria API querying of collection-of-component (David
Mansfield)
----------------------------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha2
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:39 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-3646) implement Criteria API querying of collection-of-component (David Mansfield)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646?page=c...
]
Steve Ebersole closed HHH-3646.
-------------------------------
Resolution: Fixed
Applied patch from David via https://github.com/hibernate/hibernate-core/pull/57
implement Criteria API querying of collection-of-component (David
Mansfield)
----------------------------------------------------------------------------
Key: HHH-3646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3646
Project: Hibernate Core
Issue Type: Patch
Components: query-criteria
Affects Versions: 3.2.6
Environment: hibernate 3.2.6, tested on linux 64-bit openjdk 1.6 (jdk1.5 for
compiling). mapping created under annotations 3.3.1ga
Reporter: David Mansfield
Assignee: Steve Ebersole
Fix For: 4.0.0.Alpha2
Attachments: 0001-only-prepend-the-a-comma-when-we-definitely-have-a-s.patch,
0002-throw-a-better-exception-if-an-attempt-is-mado-to-pu.patch,
0003-implement-criteria-query-of-collection-of-component-.patch,
0004-implement-a-test-case-for-query-collection-of-value.patch,
0005-implement-a-test-case-for-query-collection-of-compon.patch,
hib-core-query-collection-of-elements-3_2_6-ver2.patch,
hib-core-query-collection-of-elements-3_2_6.patch,
hib-core-query-collection-of-elements-3_3_1-ver5.patch,
hib-core-query-collection-of-elements-3_3_1-ver6.patch
Original Estimate: 8h
Remaining Estimate: 8h
the attached patch implements a first cut, extremely rough, yet working extension of the
CriteriaQueryTranslator class to allow for querying of properties of components inside a
collection, or querying properties of associated elements of components inside a
collection. eg for
* code is lightly tested, this example is for illustrative purposes only
* i use annotations, so my example is expressed in those terms, and i've only tested
with mappings generated via annotations, however, the modifications only apply to the
core.
@Entity
class Order {
@Id
String id;
@CollectionOfElements
Set<OrderLineItem> lineItems;
}
@Embeddable
class OrderLineItem {
@ManyToOne
Product product;
Integer quantity;
}
@Entity
class Product {
String name;
}
Then we can now do:
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.add(Restrictions.gt("quantity", new Integer(1))
.list();
or
Criteria c = session.createCriteria(Order.class)
.createCriteria("lineItems")
.createCriteria("product")
.add(Restrictions.like("name", "cake%")
.list();
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4923
days inactive
5762
days old
hibernate-issues@lists.jboss.org
25 comments
7 participants
participants (7)
-
David Mansfield (JIRA) -
Emmanuel Bernard (JIRA)
-
Jean-Noel Rivasseau (JIRA)
-
Kai Moritz (JIRA)
-
Olivier Dedieu (JIRA)
-
Sergey Pulyaev (JIRA)
-
Steve Ebersole (JIRA)