[JBoss JIRA] (ISPN-3335) JMX statistics for Queries partially doesn't work
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-3335?page=com.atlassian.jira.plugin.... ]
Work on ISPN-3335 started by Adrian Nistor.
> JMX statistics for Queries partially doesn't work
> -------------------------------------------------
>
> Key: ISPN-3335
> URL: https://issues.jboss.org/browse/ISPN-3335
> Project: Infinispan
> Issue Type: Bug
> Components: Querying
> Affects Versions: 6.0.0.Alpha1
> Reporter: Anna Manukyan
> Assignee: Adrian Nistor
> Priority: Critical
> Labels: 620
> Fix For: 6.1.0.Final
>
> Attachments: QueryMBeanTest.java
>
>
> I was playing around with Query JMX statistics, and found out that there are several attributes like SearchQueryTotalTime are always 0 (this attr. represents the duration of query in nano-seconds), even though I'm running the infinispan query.
> The only attribute which is updated and returns proper value is StatisticsEnabled. Also the following operations work as expected:
> getNumberOfIndexedEntities(String entity)
> clear()
> I've tried also to retrieve the statistics using the following method:
> {code}
> Search.getSearchManager(cacheManager.getCache(CACHE_NAME)).getSearchFactory().getStatistics().getSearchQueryTotalTime()
> {code}
> and it returns the same results as if getting via JMX.
> You can find the whole running test attached.
> Best regards,
> Anna.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (ISPN-3335) JMX statistics for Queries partially doesn't work
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-3335?page=com.atlassian.jira.plugin.... ]
Adrian Nistor commented on ISPN-3335:
-------------------------------------
This seems to be caused by a bug in the way MutableSearchFactory of Hibernate Search is reconfigured when new indexable classes are found in cache. A new copy of the factory is created and all configs are copied from the previous. The statistics object is not (including the enable statistics flag) - this was overlooked maybe. This can be immediately worked around in Infinispan by reimplementing the query statistics mbean to not rely on it being copied during search factory reconfiguration, as the original one does. But this is a messy workaround, so I'll file an issue on Hibernate Search and see when can they provide a proper fix.
> JMX statistics for Queries partially doesn't work
> -------------------------------------------------
>
> Key: ISPN-3335
> URL: https://issues.jboss.org/browse/ISPN-3335
> Project: Infinispan
> Issue Type: Bug
> Components: Querying
> Affects Versions: 6.0.0.Alpha1
> Reporter: Anna Manukyan
> Assignee: Adrian Nistor
> Priority: Critical
> Labels: 620
> Fix For: 6.1.0.Final
>
> Attachments: QueryMBeanTest.java
>
>
> I was playing around with Query JMX statistics, and found out that there are several attributes like SearchQueryTotalTime are always 0 (this attr. represents the duration of query in nano-seconds), even though I'm running the infinispan query.
> The only attribute which is updated and returns proper value is StatisticsEnabled. Also the following operations work as expected:
> getNumberOfIndexedEntities(String entity)
> clear()
> I've tried also to retrieve the statistics using the following method:
> {code}
> Search.getSearchManager(cacheManager.getCache(CACHE_NAME)).getSearchFactory().getStatistics().getSearchQueryTotalTime()
> {code}
> and it returns the same results as if getting via JMX.
> You can find the whole running test attached.
> Best regards,
> Anna.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (ISPN-3048) Eviction needs to be transactional
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-3048?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo commented on ISPN-3048:
-----------------------------------
[~dan.berindei] the size-based eviction is performed under the segment lock in BCHM. How can you loose data? With passivation enabled, I understand that, currently, data can be lost.
> Eviction needs to be transactional
> ----------------------------------
>
> Key: ISPN-3048
> URL: https://issues.jboss.org/browse/ISPN-3048
> Project: Infinispan
> Issue Type: Bug
> Components: Eviction
> Affects Versions: 5.3.0.Alpha1
> Reporter: Paul Ferraro
> Assignee: Pedro Ruivo
> Priority: Critical
> Labels: 620
> Fix For: 6.1.0.Final
>
>
> Currently, Infinispan eviction is non-transactional. This makes Infinispan's eviction manager virtually unusable, since non-transactional eviction can cause phantom reads and data loss because it violates the isolation of concurrent transactions. This is especially problematic when using a passivation-enabled cache store. In this case, a cache eviction/passivation can cause a concurrently executed cache retrieval to return null - even though the act of passivation does not change the data - it only changes where it is stored.
> We work around this in the AS by performing eviction manually, using pessimistic locking in combination with eager lock acquisition prior to eviction. This is unfortunate, since it prevents me from leveraging Infinispan's build-in eviction strategies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (ISPN-3740) AbstractCacheTest.getDefaultClusteredCacheConfig() should not disable state transfer
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-3740?page=com.atlassian.jira.plugin.... ]
Work on ISPN-3740 started by Pedro Ruivo.
> AbstractCacheTest.getDefaultClusteredCacheConfig() should not disable state transfer
> ------------------------------------------------------------------------------------
>
> Key: ISPN-3740
> URL: https://issues.jboss.org/browse/ISPN-3740
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 6.0.0.Final
> Reporter: Dan Berindei
> Assignee: Pedro Ruivo
> Fix For: 7.0.0.Alpha1
>
>
> The number of tests that use {{AbstractCacheTest.getDefaultClusteredCacheConfig()}} and actually require state transfer to be disabled is insignificant: after commenting out the line that disables ST, I got 0 failures.
> The Infinispan default is to have state transfer enabled, so developers naturally assume that state transfer is enabled all the time. It would be much clearer if {{AbstractCacheTest.getDefaultClusteredCacheConfig()}} used the same defaults.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (ISPN-3756) Unnecessary wall clock call for immortal entries
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-3756?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño reassigned ISPN-3756:
--------------------------------------
Assignee: Galder Zamarreño (was: Mircea Markus)
> Unnecessary wall clock call for immortal entries
> ------------------------------------------------
>
> Key: ISPN-3756
> URL: https://issues.jboss.org/browse/ISPN-3756
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 6.0.0.Final
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Fix For: 6.1.0.Final
>
>
> When updating immortal entries Infinispan calls up the wall clock time unnecessarily.
> {code}
> if (e != null) {
> e.setValue(v);
> InternalCacheEntry original = e;
> e = entryFactory.update(e, metadata);
> // we have the same instance. So we need to reincarnate.
> if (original == e) {
> --> e.reincarnate(timeService.wallClockTime());
> }
> } else {
> // this is a brand-new entry
> e = entryFactory.create(k, v, metadata);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (ISPN-3756) Unnecessary wall clock call for immortal entries
by Galder Zamarreño (JIRA)
Galder Zamarreño created ISPN-3756:
--------------------------------------
Summary: Unnecessary wall clock call for immortal entries
Key: ISPN-3756
URL: https://issues.jboss.org/browse/ISPN-3756
Project: Infinispan
Issue Type: Bug
Affects Versions: 6.0.0.Final
Reporter: Galder Zamarreño
Assignee: Mircea Markus
Fix For: 6.1.0.Final
When updating immortal entries Infinispan calls up the wall clock time unnecessarily.
{code}
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, metadata);
// we have the same instance. So we need to reincarnate.
if (original == e) {
--> e.reincarnate(timeService.wallClockTime());
}
} else {
// this is a brand-new entry
e = entryFactory.create(k, v, metadata);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month