[JBoss JIRA] (ISPN-3560) Size after a suspended transaction is resumed is incorrectly calculated
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-3560?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-3560:
-------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Size after a suspended transaction is resumed is incorrectly calculated
> -----------------------------------------------------------------------
>
> Key: ISPN-3560
> URL: https://issues.jboss.org/browse/ISPN-3560
> Project: Infinispan
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 5.3.0.Final, 6.0.0.Beta1
> Reporter: Galder Zamarreño
> Assignee: William Burns
> Fix For: 6.0.0.CR1, 6.0.0.Final
>
>
> {code}
> public void testSizeAfterClearInBranchedTransaction() throws Exception {
> cache.put(1, "v1");
> tm().begin();
> try {
> assertEquals("v1", cache.get(1));
> Transaction suspended = tm().suspend();
> tm().begin();
> try {
> cache.clear();
> } finally {
> tm().commit();
> tm().resume(suspended);
> assertEquals(1, cache.size()); // assertion fails
> assertEquals("v1", cache.get(1));
> }
> } finally {
> tm().commit();
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (ISPN-3571) Remote Query response missing numResults field in compatibility mode
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-3571?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-3571:
--------------------------------
Fix Version/s: (was: 6.0.0.CR1)
> Remote Query response missing numResults field in compatibility mode
> --------------------------------------------------------------------
>
> Key: ISPN-3571
> URL: https://issues.jboss.org/browse/ISPN-3571
> Project: Infinispan
> Issue Type: Bug
> Components: Querying
> Affects Versions: 6.0.0.Beta2
> Reporter: Martin Gencur
> Assignee: Adrian Nistor
>
> Sample exception:
> {code}
> testSampleDomainQuery2(org.infinispan.it.compatibility.RemoteQueryDslConditionsTest) Time elapsed: 0.002 sec <<< FAILURE!
> java.lang.IllegalStateException: Field numResults is required but is not present in the stream
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.readPrimitive(ProtoStreamReaderImpl.java:176)
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.readInt(ProtoStreamReaderImpl.java:188)
> at org.infinispan.query.remote.client.QueryResponseMarshaller.readFrom(QueryResponseMarshaller.java:18)
> at org.infinispan.query.remote.client.QueryResponseMarshaller.readFrom(QueryResponseMarshaller.java:13)
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.read(ProtoStreamReaderImpl.java:72)
> at org.infinispan.protostream.ProtobufUtil.readFrom(ProtobufUtil.java:45)
> at org.infinispan.protostream.ProtobufUtil.readFrom(ProtobufUtil.java:49)
> at org.infinispan.protostream.ProtobufUtil.fromByteArray(ProtobufUtil.java:53)
> at org.infinispan.client.hotrod.impl.operations.QueryOperation.executeOperation(QueryOperation.java:71)
> at org.infinispan.client.hotrod.impl.operations.QueryOperation.executeOperation(QueryOperation.java:26)
> at org.infinispan.client.hotrod.impl.operations.RetryOnFailureOperation.execute(RetryOnFailureOperation.java:46)
> at org.infinispan.client.hotrod.impl.query.RemoteQuery.executeQuery(RemoteQuery.java:79)
> at org.infinispan.client.hotrod.impl.query.RemoteQuery.list(RemoteQuery.java:69)
> at org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest.testSampleDomainQuery2(RemoteQueryDslConditionsTest.java:773)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:722)
> {code}
> I'll attach tests shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (ISPN-3571) Remote Query response missing numResults field in compatibility mode
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-3571?page=com.atlassian.jira.plugin.... ]
Adrian Nistor commented on ISPN-3571:
-------------------------------------
[~mgencur] It seems this is not a bug in protostream. The actual problem is the selection of the query facade implementation. In your case the order of dependencies lead to the selection of DummyQueryFacade instead of QueryFacadeImpl, which really cannot work. I've fixed the order of dependencies in my branch here: https://github.com/anistor/infinispan/commit/5d660960e5f07a107d7e5966d9e8...
> Remote Query response missing numResults field in compatibility mode
> --------------------------------------------------------------------
>
> Key: ISPN-3571
> URL: https://issues.jboss.org/browse/ISPN-3571
> Project: Infinispan
> Issue Type: Bug
> Components: Querying
> Affects Versions: 6.0.0.Beta2
> Reporter: Martin Gencur
> Assignee: Adrian Nistor
> Fix For: 6.0.0.CR1
>
>
> Sample exception:
> {code}
> testSampleDomainQuery2(org.infinispan.it.compatibility.RemoteQueryDslConditionsTest) Time elapsed: 0.002 sec <<< FAILURE!
> java.lang.IllegalStateException: Field numResults is required but is not present in the stream
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.readPrimitive(ProtoStreamReaderImpl.java:176)
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.readInt(ProtoStreamReaderImpl.java:188)
> at org.infinispan.query.remote.client.QueryResponseMarshaller.readFrom(QueryResponseMarshaller.java:18)
> at org.infinispan.query.remote.client.QueryResponseMarshaller.readFrom(QueryResponseMarshaller.java:13)
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.read(ProtoStreamReaderImpl.java:72)
> at org.infinispan.protostream.ProtobufUtil.readFrom(ProtobufUtil.java:45)
> at org.infinispan.protostream.ProtobufUtil.readFrom(ProtobufUtil.java:49)
> at org.infinispan.protostream.ProtobufUtil.fromByteArray(ProtobufUtil.java:53)
> at org.infinispan.client.hotrod.impl.operations.QueryOperation.executeOperation(QueryOperation.java:71)
> at org.infinispan.client.hotrod.impl.operations.QueryOperation.executeOperation(QueryOperation.java:26)
> at org.infinispan.client.hotrod.impl.operations.RetryOnFailureOperation.execute(RetryOnFailureOperation.java:46)
> at org.infinispan.client.hotrod.impl.query.RemoteQuery.executeQuery(RemoteQuery.java:79)
> at org.infinispan.client.hotrod.impl.query.RemoteQuery.list(RemoteQuery.java:69)
> at org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest.testSampleDomainQuery2(RemoteQueryDslConditionsTest.java:773)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:722)
> {code}
> I'll attach tests shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (ISPN-3571) Remote Query response missing numResults field in compatibility mode
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-3571?page=com.atlassian.jira.plugin.... ]
Adrian Nistor resolved ISPN-3571.
---------------------------------
Resolution: Rejected
> Remote Query response missing numResults field in compatibility mode
> --------------------------------------------------------------------
>
> Key: ISPN-3571
> URL: https://issues.jboss.org/browse/ISPN-3571
> Project: Infinispan
> Issue Type: Bug
> Components: Querying
> Affects Versions: 6.0.0.Beta2
> Reporter: Martin Gencur
> Assignee: Adrian Nistor
> Fix For: 6.0.0.CR1
>
>
> Sample exception:
> {code}
> testSampleDomainQuery2(org.infinispan.it.compatibility.RemoteQueryDslConditionsTest) Time elapsed: 0.002 sec <<< FAILURE!
> java.lang.IllegalStateException: Field numResults is required but is not present in the stream
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.readPrimitive(ProtoStreamReaderImpl.java:176)
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.readInt(ProtoStreamReaderImpl.java:188)
> at org.infinispan.query.remote.client.QueryResponseMarshaller.readFrom(QueryResponseMarshaller.java:18)
> at org.infinispan.query.remote.client.QueryResponseMarshaller.readFrom(QueryResponseMarshaller.java:13)
> at org.infinispan.protostream.impl.ProtoStreamReaderImpl.read(ProtoStreamReaderImpl.java:72)
> at org.infinispan.protostream.ProtobufUtil.readFrom(ProtobufUtil.java:45)
> at org.infinispan.protostream.ProtobufUtil.readFrom(ProtobufUtil.java:49)
> at org.infinispan.protostream.ProtobufUtil.fromByteArray(ProtobufUtil.java:53)
> at org.infinispan.client.hotrod.impl.operations.QueryOperation.executeOperation(QueryOperation.java:71)
> at org.infinispan.client.hotrod.impl.operations.QueryOperation.executeOperation(QueryOperation.java:26)
> at org.infinispan.client.hotrod.impl.operations.RetryOnFailureOperation.execute(RetryOnFailureOperation.java:46)
> at org.infinispan.client.hotrod.impl.query.RemoteQuery.executeQuery(RemoteQuery.java:79)
> at org.infinispan.client.hotrod.impl.query.RemoteQuery.list(RemoteQuery.java:69)
> at org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest.testSampleDomainQuery2(RemoteQueryDslConditionsTest.java:773)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:722)
> {code}
> I'll attach tests shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months
[JBoss JIRA] (ISPN-3405) Entries are passivated with wrong ID in DB
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/ISPN-3405?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on ISPN-3405:
-----------------------------------------------
Jakub Markos <jmarkos(a)redhat.com> made a comment on [bug 996877|https://bugzilla.redhat.com/show_bug.cgi?id=996877]
False alarm, our tests were outdated, sorry.
> Entries are passivated with wrong ID in DB
> ------------------------------------------
>
> Key: ISPN-3405
> URL: https://issues.jboss.org/browse/ISPN-3405
> Project: Infinispan
> Issue Type: Bug
> Components: Eviction
> Affects Versions: 5.3.0.Final, 6.0.0.Alpha1
> Reporter: Vitalii Chepeliuk
> Assignee: Galder Zamarreño
> Fix For: 6.0.0.Alpha4, 6.0.0.CR1
>
>
> Entry passivation into DB, concretly this class LockSupportCacheStore and method store. Look at lines with "<<<" string for more info
> {code:title=LockSupportCacheStore.java|borderStyle=solid}
> @Override
> public final void store(InternalCacheEntry ed) throws CacheLoaderException {
> if (trace) {
> log.tracef("store(%s)", ed);
> }
> if (ed == null) {
> return;
> }
> if (ed.canExpire() && ed.isExpired(timeService.wallClockTime())) {
> if (containsKey(ed.getKey())) {
> if (trace) {
> log.tracef("Entry %s is expired! Removing!", ed);
> }
> remove(ed.getKey());
> } else {
> if (trace) {
> log.tracef("Entry %s is expired! Not doing anything.", ed);
> }
> }
> return;
> }
> L keyHashCode = getLockFromKey(ed.getKey()); <<< here key is generated like ed.getKey().hashCode() & 0xfffffc00;
> lockForWriting(keyHashCode);
> try {
> storeLockSafe(ed, keyHashCode); <<< here it should be stored into Bucket and then stored in DB
> } finally {
> unlock(keyHashCode);
> }
> if (trace) {
> log.tracef("exit store(%s)", ed);
> }
> }
> {code}
> When I use RemoteCacheManager and RemoteCache I am putting entries into cache
> {code:title=Test.java|borderStyle=solid}
> cache.put("key1", "v1");
> cache.put("key2", "v2");
> cache.put("key3", "v3");
> {code}
> Then 2 entries are passivated and stored in DB
> ||ID||DATA||TIMESTAMP||
> |183713792|0301fe032a01034c422b21033e286d7942657374506572736f6e616c4b657957686963684861734e657665724265656e426574746572420521033e02763203620003630000000000000002|-1|
> |23486464|0301fe032a01034c420721033e046b657931420521033e02763103620003630000000000000001|-1|
> IDs are generated from method above and
> {code:title=Test.java|borderStyle=solid}
> byte[] keyBytes = marshaller.objectToByteBuffer("key1"); <<< key is marshalled
> long keyID = ByteArrayEquivalence.INSTANCE.hashCode(keyBytes) & 0xfffffc00 //computation taken from BucketBasedCacheStore <<< this does not work for me
> {code}
> And next step I'd like to retrieve data from DB
> SELECT ID, DATA FROM JDBC_BINARY_DEFAULT WHERE ID=keyID
> But in method
> {code:title=BucketBasedCacheStore.java|borderStyle=solid}
> @Override
> public Integer getLockFromKey(Object key) {
> return key.hashCode() & 0xfffffc00; <<< here should be used Arrays.hashCode((byte[])key) & 0xfffffc00), if key is represented as byte array, or used ByteArrayEquivalence instead of simple byte array(byte[]) as argument
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 2 months