[JBoss JIRA] (ISPN-7141) LimitedExecutorTest.testConcurrencyLimit random failures
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-7141?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-7141:
-------------------------------
Status: Open (was: New)
> LimitedExecutorTest.testConcurrencyLimit random failures
> --------------------------------------------------------
>
> Key: ISPN-7141
> URL: https://issues.jboss.org/browse/ISPN-7141
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 9.0.0.Beta1
>
>
> The test reuses a single executor for all test methods, and it is limited to 1 thread. It can take some time between the completion of the {{CompletableFuture}} that the test waits for and the executor thread being actually releases, and that can make the next test method throw a {{RejectedExecutionException}}.
> {noformat}
> 20:37:37,952 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.executors.LimitedExecutorTest.testConcurrencyLimit
> java.util.concurrent.RejectedExecutionException: Task org.infinispan.executors.LimitedExecutor$Runner@5bda0b48 rejected from java.util.concurrent.ThreadPoolExecutor@34d8a229[Running, pool size = 1, active threads = 1, queued tasks = 0, completed tasks = 1]
> at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) ~[?:1.8.0_101]
> at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) ~[?:1.8.0_101]
> at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369) ~[?:1.8.0_101]
> at org.infinispan.executors.LimitedExecutor.tryExecute(LimitedExecutor.java:117) ~[classes/:?]
> at org.infinispan.executors.LimitedExecutor.executeInternal(LimitedExecutor.java:92) ~[classes/:?]
> at org.infinispan.executors.LimitedExecutor.execute(LimitedExecutor.java:82) ~[classes/:?]
> at org.infinispan.executors.LimitedExecutorTest.testConcurrencyLimit(LimitedExecutorTest.java:51) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
8 years, 4 months
[JBoss JIRA] (ISPN-7141) LimitedExecutorTest.testConcurrencyLimit random failures
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-7141?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-7141:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/4633
> LimitedExecutorTest.testConcurrencyLimit random failures
> --------------------------------------------------------
>
> Key: ISPN-7141
> URL: https://issues.jboss.org/browse/ISPN-7141
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 9.0.0.Beta1
>
>
> The test reuses a single executor for all test methods, and it is limited to 1 thread. It can take some time between the completion of the {{CompletableFuture}} that the test waits for and the executor thread being actually releases, and that can make the next test method throw a {{RejectedExecutionException}}.
> {noformat}
> 20:37:37,952 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.executors.LimitedExecutorTest.testConcurrencyLimit
> java.util.concurrent.RejectedExecutionException: Task org.infinispan.executors.LimitedExecutor$Runner@5bda0b48 rejected from java.util.concurrent.ThreadPoolExecutor@34d8a229[Running, pool size = 1, active threads = 1, queued tasks = 0, completed tasks = 1]
> at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) ~[?:1.8.0_101]
> at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) ~[?:1.8.0_101]
> at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369) ~[?:1.8.0_101]
> at org.infinispan.executors.LimitedExecutor.tryExecute(LimitedExecutor.java:117) ~[classes/:?]
> at org.infinispan.executors.LimitedExecutor.executeInternal(LimitedExecutor.java:92) ~[classes/:?]
> at org.infinispan.executors.LimitedExecutor.execute(LimitedExecutor.java:82) ~[classes/:?]
> at org.infinispan.executors.LimitedExecutorTest.testConcurrencyLimit(LimitedExecutorTest.java:51) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
8 years, 4 months
[JBoss JIRA] (ISPN-7141) LimitedExecutorTest.testConcurrencyLimit random failures
by Dan Berindei (JIRA)
Dan Berindei created ISPN-7141:
----------------------------------
Summary: LimitedExecutorTest.testConcurrencyLimit random failures
Key: ISPN-7141
URL: https://issues.jboss.org/browse/ISPN-7141
Project: Infinispan
Issue Type: Bug
Components: Test Suite - Core
Reporter: Dan Berindei
Assignee: Dan Berindei
Priority: Critical
Fix For: 9.0.0.Beta1
The test reuses a single executor for all test methods, and it is limited to 1 thread. It can take some time between the completion of the {{CompletableFuture}} that the test waits for and the executor thread being actually releases, and that can make the next test method throw a {{RejectedExecutionException}}.
{noformat}
20:37:37,952 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.executors.LimitedExecutorTest.testConcurrencyLimit
java.util.concurrent.RejectedExecutionException: Task org.infinispan.executors.LimitedExecutor$Runner@5bda0b48 rejected from java.util.concurrent.ThreadPoolExecutor@34d8a229[Running, pool size = 1, active threads = 1, queued tasks = 0, completed tasks = 1]
at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) ~[?:1.8.0_101]
at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823) ~[?:1.8.0_101]
at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369) ~[?:1.8.0_101]
at org.infinispan.executors.LimitedExecutor.tryExecute(LimitedExecutor.java:117) ~[classes/:?]
at org.infinispan.executors.LimitedExecutor.executeInternal(LimitedExecutor.java:92) ~[classes/:?]
at org.infinispan.executors.LimitedExecutor.execute(LimitedExecutor.java:82) ~[classes/:?]
at org.infinispan.executors.LimitedExecutorTest.testConcurrencyLimit(LimitedExecutorTest.java:51) ~[test-classes/:?]
{noformat}
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
8 years, 4 months
[JBoss JIRA] (ISPN-7140) Concurrent modifications succeed in pessimistic cache
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-7140?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-7140:
-------------------------------
Labels: testsuite_stability (was: )
> Concurrent modifications succeed in pessimistic cache
> -----------------------------------------------------
>
> Key: ISPN-7140
> URL: https://issues.jboss.org/browse/ISPN-7140
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.0.0.Alpha4
> Reporter: Radim Vansa
> Labels: testsuite_stability
> Attachments: log2.txt
>
>
> During node crash, two concurrent modifications in can both succeed in pessimistic tx cache.
> This also causes random failures in {{InfinispanNodeFailureTest}}:
> 1. TX1 originating on A acquires lock for key X, A is primary owner
> 2. C is killed and B becomes primary owner of key X
> 3. TX2 originating on B acquires lock for key X, B is now primary owner
> 4. TX1 commits the tx, Prepare is sent with the new topology id so it commits fine
> 5. TX2 also commits the transaction
> Log attached (this is not master but changes should not be related).
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
8 years, 4 months
[JBoss JIRA] (ISPN-7140) Concurrent modifications succeed in pessimistic cache
by Radim Vansa (JIRA)
Radim Vansa created ISPN-7140:
---------------------------------
Summary: Concurrent modifications succeed in pessimistic cache
Key: ISPN-7140
URL: https://issues.jboss.org/browse/ISPN-7140
Project: Infinispan
Issue Type: Bug
Components: Core
Affects Versions: 9.0.0.Alpha4
Reporter: Radim Vansa
Attachments: log2.txt
During node crash, two concurrent modifications in can both succeed in pessimistic tx cache.
This also causes random failures in {{InfinispanNodeFailureTest}}:
1. TX1 originating on A acquires lock for key X, A is primary owner
2. C is killed and B becomes primary owner of key X
3. TX2 originating on B acquires lock for key X, B is now primary owner
4. TX1 commits the tx, Prepare is sent with the new topology id so it commits fine
5. TX2 also commits the transaction
Log attached (this is not master but changes should not be related).
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
8 years, 4 months
[JBoss JIRA] (ISPN-7139) Consistent prefix in property names of Hot Rod client configurations
by Sanne Grinovero (JIRA)
[ https://issues.jboss.org/browse/ISPN-7139?page=com.atlassian.jira.plugin.... ]
Sanne Grinovero updated ISPN-7139:
----------------------------------
Description:
Most Hot Rod configuration properties use the prefix {{infinispan.client.hotrod.}} which makes it easy to recognize them.
Some properties don't use the prefix though, such as all those related to connection pooling, e.g. {{maxActive}}, {{maxTotal}}, ..
This makes it hard to read Hot Rod specific configuration properties from alternative sources. In particular we'd like to embed such properties in an Hibernate configuration file (for Hibernate OGM) but the fact that some properties need special handling forces us to keep a list of these to have special care, rather than being able to use a prefix like it is done in most such cases.
It should be easy to prefix all the properties, and deprecate the names.
was:
Most Hot Rod configuration properties use the prefix {{infinispan.client.hotrod.}} which makes it easy to recognize them.
Some properties don't use the prefix though, such as all those related to connection pooling, e.g. {{maxActive}}, {{maxTotal}}, ..
This makes it hard to read Hot Rod specific configuration properties from alternative sources. In particular we'd like to embed such properties in an Hibernate configuration file (for Hibernate OGM) but the fact that some properties need special handling forces us to keep a list of these to have special care, rather than being able to use a prefix like it is done in most such cases.
> Consistent prefix in property names of Hot Rod client configurations
> --------------------------------------------------------------------
>
> Key: ISPN-7139
> URL: https://issues.jboss.org/browse/ISPN-7139
> Project: Infinispan
> Issue Type: Enhancement
> Components: Configuration, Remote Protocols
> Reporter: Sanne Grinovero
> Fix For: 9.0.0.Beta1
>
>
> Most Hot Rod configuration properties use the prefix {{infinispan.client.hotrod.}} which makes it easy to recognize them.
> Some properties don't use the prefix though, such as all those related to connection pooling, e.g. {{maxActive}}, {{maxTotal}}, ..
> This makes it hard to read Hot Rod specific configuration properties from alternative sources. In particular we'd like to embed such properties in an Hibernate configuration file (for Hibernate OGM) but the fact that some properties need special handling forces us to keep a list of these to have special care, rather than being able to use a prefix like it is done in most such cases.
> It should be easy to prefix all the properties, and deprecate the names.
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
8 years, 4 months
[JBoss JIRA] (ISPN-7139) Consistent prefix in property names of Hot Rod client configurations
by Sanne Grinovero (JIRA)
Sanne Grinovero created ISPN-7139:
-------------------------------------
Summary: Consistent prefix in property names of Hot Rod client configurations
Key: ISPN-7139
URL: https://issues.jboss.org/browse/ISPN-7139
Project: Infinispan
Issue Type: Enhancement
Components: Configuration, Remote Protocols
Reporter: Sanne Grinovero
Fix For: 9.0.0.Beta1
Most Hot Rod configuration properties use the prefix {{infinispan.client.hotrod.}} which makes it easy to recognize them.
Some properties don't use the prefix though, such as all those related to connection pooling, e.g. {{maxActive}}, {{maxTotal}}, ..
This makes it hard to read Hot Rod specific configuration properties from alternative sources. In particular we'd like to embed such properties in an Hibernate configuration file (for Hibernate OGM) but the fact that some properties need special handling forces us to keep a list of these to have special care, rather than being able to use a prefix like it is done in most such cases.
--
This message was sent by Atlassian JIRA
(v7.2.2#72004)
8 years, 4 months