[JBoss JIRA] (ISPN-6464) Possibility to get black (login) background in all console pages
by Martin Sosic (JIRA)
[ https://issues.jboss.org/browse/ISPN-6464?page=com.atlassian.jira.plugin.... ]
Martin Sosic commented on ISPN-6464:
------------------------------------
This is happening because main class of the html element is being set explicitly in the code, and in this case it is not set so background remains black.
We can see here https://github.com/infinispan/infinispan-management-console/blob/master/s... that variable page.htmlClass is being used to set the class on html element, therefore also defining the background.
This variable is set in login controller and main angular js file:
- https://github.com/infinispan/infinispan-management-console/blob/master/s...
- https://github.com/infinispan/infinispan-management-console/blob/master/s...
I think that this is not good approach for two reasons:
1. setting this variable explicitly is prone to errors (as we can see in this issue)
2. setting class on html element is not a good practice
I am suggesting following:
- remove the current approach -> do not set class on html element and do not use page.htmlClass variable at all
- what we want instead, is for each angular view (e.g. view is login.html) to define it's own background. In order to have that possible, css has to be adjusted accordingly, so that most outer div of each angular view spans through the whole screen. This should be done by adjusting css of outer elements, that are out of views. Finally, now we can add appropriate classes to each angular view and define css for them. For example, for login.html we can set class="login" to it's most outer element/div and define in css that black background image is used. For the rest, we can set default css to have white background. In this approach, there is no explicit setting of classes through javascript - instead, they are defined in views (html), and there is no way for errors like this issue to happen.
Small guidance: angular views are render here https://github.com/infinispan/infinispan-management-console/blob/master/s..., inside of tag with ui-view attribute.
> Possibility to get black (login) background in all console pages
> -----------------------------------------------------------------
>
> Key: ISPN-6464
> URL: https://issues.jboss.org/browse/ISPN-6464
> Project: Infinispan
> Issue Type: Bug
> Components: Console
> Reporter: Martin Vrabel
> Assignee: Vladimir Blagojevic
> Priority: Minor
> Attachments: Screenshot from 2016-03-24 15-22-35.png, Screenshot from 2016-03-24 15-22-42.png, Screenshot from 2016-03-24 15-22-47.png
>
>
> Way to reproduce:
> 1. Log into console:
> 2. press back button (pic. 1 , navbar should not be shown )
> 3. press forward button (background from this point on is the same as at login)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 8 months
[JBoss JIRA] (ISPN-6477) Security tests always log a warning during cache manager shutdown
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6477?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6477:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.0.0.Final
Resolution: Done
> Security tests always log a warning during cache manager shutdown
> -----------------------------------------------------------------
>
> Key: ISPN-6477
> URL: https://issues.jboss.org/browse/ISPN-6477
> Project: Infinispan
> Issue Type: Bug
> Components: Security, Test Suite - Core
> Affects Versions: 8.2.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
> Fix For: 9.0.0.Alpha1, 9.0.0.Final
>
>
> The problem is that {{TestingUtil.killCacheManagers()}} first stops each cache explicitly, and then {{DefaultCacheManager.stop()}} fails because it can't access the global ACL cache to perform a security check:
> {noformat}
> 17:07:00,613 WARN (testng-ExecutionAuthorizationTest:[]) [TestingUtil] Problems killing cache manager org.infinispan.manager.DefaultCacheManager@4e83a98@Address:ExecutionAuthorizationTest-NodeB-14717
> org.infinispan.IllegalLifecycleStateException: ISPN000323: ___acl_cache is in 'TERMINATED' state and so it does not accept new invocations. Either restart it or recreate the cache container.
> at org.infinispan.cache.impl.SimpleCacheImpl.getDataContainer(SimpleCacheImpl.java:1044) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.SimpleCacheImpl.computeIfAbsentInternal(SimpleCacheImpl.java:1116) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.StatsCollectingCache.computeIfAbsentInternal(StatsCollectingCache.java:270) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.cache.impl.SimpleCacheImpl.computeIfAbsent(SimpleCacheImpl.java:1111) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationHelper.checkSubjectPermissionAndRole(AuthorizationHelper.java:107) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationHelper.checkPermission(AuthorizationHelper.java:76) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.AuthorizationManagerImpl.checkPermission(AuthorizationManagerImpl.java:42) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.security.impl.SecureCacheImpl.getComponentRegistry(SecureCacheImpl.java:336) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.unregisterCacheMBean(DefaultCacheManager.java:714) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.terminate(DefaultCacheManager.java:671) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.stopCaches(DefaultCacheManager.java:708) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.manager.DefaultCacheManager.stop(DefaultCacheManager.java:688) ~[infinispan-core.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:673) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:656) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.TestingUtil.killCacheManagers(TestingUtil.java:652) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> at org.infinispan.test.MultipleCacheManagersTest.destroy(MultipleCacheManagersTest.java:87) [infinispan-core-tests.jar:9.0.0-SNAPSHOT]
> {noformat}
> {{DefaultCacheManager.stop()}} could check a cache's status before trying to unregister it from JMX, avoiding the security check when the cache is already {{TERMINATED}}.
> {{DefaultCacheManager.unregisterCacheMBean()}} could also extract the cache's component registry from the global component registry and avoid the security check, since {{DefaultCacheManager.stop()}} already performed a security check.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 8 months
[JBoss JIRA] (ISPN-6465) Managent console - launching task with no parameters creates one empty parameter
by Vladimir Blagojevic (JIRA)
[ https://issues.jboss.org/browse/ISPN-6465?page=com.atlassian.jira.plugin.... ]
Vladimir Blagojevic updated ISPN-6465:
--------------------------------------
Status: Open (was: New)
> Managent console - launching task with no parameters creates one empty parameter
> --------------------------------------------------------------------------------
>
> Key: ISPN-6465
> URL: https://issues.jboss.org/browse/ISPN-6465
> Project: Infinispan
> Issue Type: Bug
> Components: Console
> Reporter: Jiří Holuša
> Assignee: Vladimir Blagojevic
>
> Page: Caches -> select cache container -> select Tasks execution tab
> When launching new task, you can specify parameters, which works correctly, if you do. However, if you specify no parameters, you would then expect in your task when calling TaskContext.getParameters() to be null (or at least empty). Currently when you specify no parameters, the getParameters() returns Map with one entry, both empty key and value.
> This issue was not present in previous releases, when if no parameter specified, the getParameters returned null. I went through the history and tracked down the commit which causes it:
> {code}
> commit 6a4d156a9678bcde18d8365ee75fbcea31373949
> Author: vblagoje <vblagoje(a)redhat.com>
> Date: Wed Mar 16 14:57:02 2016 -0400
> Simplify task handling
> {code}
> However, finding the actual cause is below my AngularJS knowledge.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 8 months
[JBoss JIRA] (ISPN-6465) Managent console - launching task with no parameters creates one empty parameter
by Vladimir Blagojevic (JIRA)
[ https://issues.jboss.org/browse/ISPN-6465?page=com.atlassian.jira.plugin.... ]
Vladimir Blagojevic updated ISPN-6465:
--------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan-management-console/pull/79
> Managent console - launching task with no parameters creates one empty parameter
> --------------------------------------------------------------------------------
>
> Key: ISPN-6465
> URL: https://issues.jboss.org/browse/ISPN-6465
> Project: Infinispan
> Issue Type: Bug
> Components: Console
> Reporter: Jiří Holuša
> Assignee: Vladimir Blagojevic
>
> Page: Caches -> select cache container -> select Tasks execution tab
> When launching new task, you can specify parameters, which works correctly, if you do. However, if you specify no parameters, you would then expect in your task when calling TaskContext.getParameters() to be null (or at least empty). Currently when you specify no parameters, the getParameters() returns Map with one entry, both empty key and value.
> This issue was not present in previous releases, when if no parameter specified, the getParameters returned null. I went through the history and tracked down the commit which causes it:
> {code}
> commit 6a4d156a9678bcde18d8365ee75fbcea31373949
> Author: vblagoje <vblagoje(a)redhat.com>
> Date: Wed Mar 16 14:57:02 2016 -0400
> Simplify task handling
> {code}
> However, finding the actual cause is below my AngularJS knowledge.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 8 months
[JBoss JIRA] (ISPN-5775) Clean shutdown cluster action
by Vladimir Blagojevic (JIRA)
[ https://issues.jboss.org/browse/ISPN-5775?page=com.atlassian.jira.plugin.... ]
Vladimir Blagojevic reassigned ISPN-5775:
-----------------------------------------
Assignee: Vladimir Blagojevic (was: Tristan Tarrant)
> Clean shutdown cluster action
> -----------------------------
>
> Key: ISPN-5775
> URL: https://issues.jboss.org/browse/ISPN-5775
> Project: Infinispan
> Issue Type: Sub-task
> Components: Console
> Reporter: Pedro Zapata
> Assignee: Vladimir Blagojevic
>
> As an administrator, I want to gracefully shutdown the cluster for maintenance. For caches which have a cache-store configured, I want their data to get persisted without losing any data. For caches that do not have a cache store configured, data will be lost - therefore, I want prior warning before proceeding
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 8 months
[JBoss JIRA] (ISPN-6480) SecurityManagerCacheAuthorizationTest fails
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6480?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6480:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.0.0.Alpha1
9.0.0.Final
Resolution: Done
> SecurityManagerCacheAuthorizationTest fails
> --------------------------------------------
>
> Key: ISPN-6480
> URL: https://issues.jboss.org/browse/ISPN-6480
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Reporter: Vojtech Juranek
> Assignee: Vojtech Juranek
> Fix For: 9.0.0.Alpha1, 9.0.0.Final
>
>
> {{ SecurityManagerCacheAuthorizationTest.testAllCombinations}} fails with
> {noformat}
> java.security.PrivilegedActionException: java.lang.Exception: Unexpected non-SecurityException
> at org.infinispan.security.Security.doAs(Security.java:145)
> at org.infinispan.security.CacheAuthorizationTest.testAllCombinations(CacheAuthorizationTest.java:143)
> at org.infinispan.security.SecurityManagerCacheAuthorizationTest.testAllCombinations(SecurityManagerCacheAuthorizationTest.java:21)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
> at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
> at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
> at org.testng.SuiteRunner.run(SuiteRunner.java:254)
> at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
> at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
> at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
> at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
> at org.testng.TestNG.run(TestNG.java:1057)
> at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:115)
> at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:205)
> at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:108)
> at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:111)
> at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
> at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> Caused by: java.lang.Exception: Unexpected non-SecurityException
> at org.infinispan.security.CacheAuthorizationTest$5.run(CacheAuthorizationTest.java:162)
> at org.infinispan.security.CacheAuthorizationTest$5.run(CacheAuthorizationTest.java:143)
> at org.infinispan.security.Security.doAs(Security.java:143)
> ... 30 more
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.infinispan.security.CacheAuthorizationTest$5.run(CacheAuthorizationTest.java:147)
> ... 32 more
> Caused by: org.infinispan.IllegalLifecycleStateException: ISPN000324: ___defaultcache is in 'STOPPING' state and this is an invocation not belonging to an on-going transaction, so it does not accept new invocations. Either restart it or recreate the cache container.
> at org.infinispan.transaction.impl.TransactionTable.getOrCreateLocalTransaction(TransactionTable.java:425)
> at org.infinispan.context.TransactionalInvocationContextFactory.createInvocationContext(TransactionalInvocationContextFactory.java:70)
> at org.infinispan.cache.impl.CacheImpl.getInvocationContext(CacheImpl.java:831)
> at org.infinispan.cache.impl.CacheImpl.getInvocationContextWithImplicitTransaction(CacheImpl.java:822)
> at org.infinispan.cache.impl.CacheImpl.putIfAbsent(CacheImpl.java:1248)
> at org.infinispan.cache.impl.CacheImpl.putIfAbsent(CacheImpl.java:1236)
> at org.infinispan.cache.impl.CacheImpl.putIfAbsent(CacheImpl.java:256)
> at org.infinispan.security.impl.SecureCacheImpl.putIfAbsent(SecureCacheImpl.java:204)
> at org.infinispan.security.SecureCacheTestDriver.testPutIfAbsent_Object_Object_long_TimeUnit(SecureCacheTestDriver.java:281)
> ... 37 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 8 months
[JBoss JIRA] (ISPN-6480) SecurityManagerCacheAuthorizationTest fails
by Vojtech Juranek (JIRA)
[ https://issues.jboss.org/browse/ISPN-6480?page=com.atlassian.jira.plugin.... ]
Vojtech Juranek updated ISPN-6480:
----------------------------------
Status: Open (was: New)
> SecurityManagerCacheAuthorizationTest fails
> --------------------------------------------
>
> Key: ISPN-6480
> URL: https://issues.jboss.org/browse/ISPN-6480
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Reporter: Vojtech Juranek
> Assignee: Vojtech Juranek
>
> {{ SecurityManagerCacheAuthorizationTest.testAllCombinations}} fails with
> {noformat}
> java.security.PrivilegedActionException: java.lang.Exception: Unexpected non-SecurityException
> at org.infinispan.security.Security.doAs(Security.java:145)
> at org.infinispan.security.CacheAuthorizationTest.testAllCombinations(CacheAuthorizationTest.java:143)
> at org.infinispan.security.SecurityManagerCacheAuthorizationTest.testAllCombinations(SecurityManagerCacheAuthorizationTest.java:21)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
> at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
> at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
> at org.testng.SuiteRunner.run(SuiteRunner.java:254)
> at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
> at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
> at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
> at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
> at org.testng.TestNG.run(TestNG.java:1057)
> at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:115)
> at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:205)
> at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:108)
> at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:111)
> at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
> at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> Caused by: java.lang.Exception: Unexpected non-SecurityException
> at org.infinispan.security.CacheAuthorizationTest$5.run(CacheAuthorizationTest.java:162)
> at org.infinispan.security.CacheAuthorizationTest$5.run(CacheAuthorizationTest.java:143)
> at org.infinispan.security.Security.doAs(Security.java:143)
> ... 30 more
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.infinispan.security.CacheAuthorizationTest$5.run(CacheAuthorizationTest.java:147)
> ... 32 more
> Caused by: org.infinispan.IllegalLifecycleStateException: ISPN000324: ___defaultcache is in 'STOPPING' state and this is an invocation not belonging to an on-going transaction, so it does not accept new invocations. Either restart it or recreate the cache container.
> at org.infinispan.transaction.impl.TransactionTable.getOrCreateLocalTransaction(TransactionTable.java:425)
> at org.infinispan.context.TransactionalInvocationContextFactory.createInvocationContext(TransactionalInvocationContextFactory.java:70)
> at org.infinispan.cache.impl.CacheImpl.getInvocationContext(CacheImpl.java:831)
> at org.infinispan.cache.impl.CacheImpl.getInvocationContextWithImplicitTransaction(CacheImpl.java:822)
> at org.infinispan.cache.impl.CacheImpl.putIfAbsent(CacheImpl.java:1248)
> at org.infinispan.cache.impl.CacheImpl.putIfAbsent(CacheImpl.java:1236)
> at org.infinispan.cache.impl.CacheImpl.putIfAbsent(CacheImpl.java:256)
> at org.infinispan.security.impl.SecureCacheImpl.putIfAbsent(SecureCacheImpl.java:204)
> at org.infinispan.security.SecureCacheTestDriver.testPutIfAbsent_Object_Object_long_TimeUnit(SecureCacheTestDriver.java:281)
> ... 37 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 8 months