[JBoss JIRA] (ISPN-6395) Unify clustered queries with non clustered queries
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-6395?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes updated ISPN-6395:
------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.2.0.Beta2
Resolution: Done
> Unify clustered queries with non clustered queries
> --------------------------------------------------
>
> Key: ISPN-6395
> URL: https://issues.jboss.org/browse/ISPN-6395
> Project: Infinispan
> Issue Type: Feature Request
> Components: Embedded Querying
> Affects Versions: 9.2.0.Beta1
> Reporter: Gustavo Fernandes
> Assignee: Gustavo Fernandes
> Fix For: 9.2.0.Beta2, 9.2.0.Final
>
>
> Clustered queries currently have a different method, and they work on top on non-shared indexes.
> We should detect (or make it explicitly configurable) the fact that the index is not shared and use clustered query internally, but exposing a single method, with a new parameter to allow doing a query in a single step or two steps (broadcast).
> Last, but not least, we should offer the possibility to broadcast Ickle queries apart from Lucene Queries, as Ickle queries are String and don't have serialization issues.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years
[JBoss JIRA] (ISPN-8628) Simplify QueryEngine handling of Broadcast vs Fetch queries
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-8628?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-8628:
--------------------------------
Status: Open (was: New)
> Simplify QueryEngine handling of Broadcast vs Fetch queries
> -----------------------------------------------------------
>
> Key: ISPN-8628
> URL: https://issues.jboss.org/browse/ISPN-8628
> Project: Infinispan
> Issue Type: Task
> Reporter: Gustavo Fernandes
> Assignee: Gustavo Fernandes
> Priority: Minor
>
> [~anistor] commented
> The existence of RemoteQueryDefinition and HsQueryRequest seems to be a symptom of misplaced responsibility. It all starts with QueryDefinition.initialize, which IMO should actually be placed inside QueryEngine, not QueryDefinition. Doing that refactoring will remove the need for RemoteQueryDefinition, which now exists just to differentiate between embedded and remote case, but that differentiation can be done inside the query engine itself. Also, HsQueryRequest is just a data holder that carries the return value of QueryEngine.createHsQuery. If QueryDefinition.initialize is moved to QueryEngine we would also not need this anymore.
> I did not think about it in detail but maybe we would also need to make QueryDefinition mutable for QueryEngine and immutable for external parties. In that case we can extract QueryDefinition as an immutable interface (exposing getters only) and it's implementation class could have package local setters accessible to QueryEngine only.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years
[JBoss JIRA] (ISPN-8628) Simplify QueryEngine handling of Broadcast vs Fetch queries
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-8628?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes updated ISPN-8628:
------------------------------------
Priority: Minor (was: Major)
> Simplify QueryEngine handling of Broadcast vs Fetch queries
> -----------------------------------------------------------
>
> Key: ISPN-8628
> URL: https://issues.jboss.org/browse/ISPN-8628
> Project: Infinispan
> Issue Type: Task
> Reporter: Gustavo Fernandes
> Assignee: Gustavo Fernandes
> Priority: Minor
>
> [~anistor] commented
> The existence of RemoteQueryDefinition and HsQueryRequest seems to be a symptom of misplaced responsibility. It all starts with QueryDefinition.initialize, which IMO should actually be placed inside QueryEngine, not QueryDefinition. Doing that refactoring will remove the need for RemoteQueryDefinition, which now exists just to differentiate between embedded and remote case, but that differentiation can be done inside the query engine itself. Also, HsQueryRequest is just a data holder that carries the return value of QueryEngine.createHsQuery. If QueryDefinition.initialize is moved to QueryEngine we would also not need this anymore.
> I did not think about it in detail but maybe we would also need to make QueryDefinition mutable for QueryEngine and immutable for external parties. In that case we can extract QueryDefinition as an immutable interface (exposing getters only) and it's implementation class could have package local setters accessible to QueryEngine only.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years
[JBoss JIRA] (ISPN-8628) Simplify QueryEngine handling of Broadcast vs Fetch queries
by Gustavo Fernandes (JIRA)
Gustavo Fernandes created ISPN-8628:
---------------------------------------
Summary: Simplify QueryEngine handling of Broadcast vs Fetch queries
Key: ISPN-8628
URL: https://issues.jboss.org/browse/ISPN-8628
Project: Infinispan
Issue Type: Task
Reporter: Gustavo Fernandes
[~anistor] commented
The existence of RemoteQueryDefinition and HsQueryRequest seems to be a symptom of misplaced responsibility. It all starts with QueryDefinition.initialize, which IMO should actually be placed inside QueryEngine, not QueryDefinition. Doing that refactoring will remove the need for RemoteQueryDefinition, which now exists just to differentiate between embedded and remote case, but that differentiation can be done inside the query engine itself. Also, HsQueryRequest is just a data holder that carries the return value of QueryEngine.createHsQuery. If QueryDefinition.initialize is moved to QueryEngine we would also not need this anymore.
I did not think about it in detail but maybe we would also need to make QueryDefinition mutable for QueryEngine and immutable for external parties. In that case we can extract QueryDefinition as an immutable interface (exposing getters only) and it's implementation class could have package local setters accessible to QueryEngine only.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years
[JBoss JIRA] (ISPN-8628) Simplify QueryEngine handling of Broadcast vs Fetch queries
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-8628?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes reassigned ISPN-8628:
---------------------------------------
Assignee: Gustavo Fernandes
> Simplify QueryEngine handling of Broadcast vs Fetch queries
> -----------------------------------------------------------
>
> Key: ISPN-8628
> URL: https://issues.jboss.org/browse/ISPN-8628
> Project: Infinispan
> Issue Type: Task
> Reporter: Gustavo Fernandes
> Assignee: Gustavo Fernandes
>
> [~anistor] commented
> The existence of RemoteQueryDefinition and HsQueryRequest seems to be a symptom of misplaced responsibility. It all starts with QueryDefinition.initialize, which IMO should actually be placed inside QueryEngine, not QueryDefinition. Doing that refactoring will remove the need for RemoteQueryDefinition, which now exists just to differentiate between embedded and remote case, but that differentiation can be done inside the query engine itself. Also, HsQueryRequest is just a data holder that carries the return value of QueryEngine.createHsQuery. If QueryDefinition.initialize is moved to QueryEngine we would also not need this anymore.
> I did not think about it in detail but maybe we would also need to make QueryDefinition mutable for QueryEngine and immutable for external parties. In that case we can extract QueryDefinition as an immutable interface (exposing getters only) and it's implementation class could have package local setters accessible to QueryEngine only.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years
[JBoss JIRA] (ISPN-8627) Add CacheContainerAdmin.getOrCreateCache() method
by Tristan Tarrant (JIRA)
Tristan Tarrant created ISPN-8627:
-------------------------------------
Summary: Add CacheContainerAdmin.getOrCreateCache() method
Key: ISPN-8627
URL: https://issues.jboss.org/browse/ISPN-8627
Project: Infinispan
Issue Type: Bug
Components: Core, Hot Rod
Affects Versions: 9.2.0.Beta1
Reporter: Tristan Tarrant
Assignee: Tristan Tarrant
Fix For: 9.2.0.Beta2
CacheContainerAdmin has a createCache method which fails if the cache already exists. To make the life of developers easier, it should also have a getOrCreateCache() which returns an existing cache if possible.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years