[JBoss JIRA] (ISPN-7476) Cache get might throw NPE is entry not found in context
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-7476?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño commented on ISPN-7476:
----------------------------------------
[~rvansa] might have found an easy solution for this, trying it out...
> Cache get might throw NPE is entry not found in context
> -------------------------------------------------------
>
> Key: ISPN-7476
> URL: https://issues.jboss.org/browse/ISPN-7476
> Project: Infinispan
> Issue Type: Sub-task
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Priority: Blocker
> Fix For: 9.0.0.Final
>
>
> A key with an incorrect equals implementation (e.g. one that always returns false) will result in NPE:
> {code}
> Caused by: java.lang.NullPointerException
> at org.infinispan.commands.read.GetKeyValueCommand.perform(GetKeyValueCommand.java:49)
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 10 months
[JBoss JIRA] (ISPN-7591) Add org.hibernate.cache to externally marshallable white list
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-7591?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-7591:
-----------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/infinispan/infinispan/pull/4960
> Add org.hibernate.cache to externally marshallable white list
> -------------------------------------------------------------
>
> Key: ISPN-7591
> URL: https://issues.jboss.org/browse/ISPN-7591
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Marshalling
> Affects Versions: 9.0.0.CR3
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Fix For: 9.0.0.Final
>
>
> While running 2LC tests I've discovered that some tests fail with:
> {code}Caused by: java.lang.AssertionError: Check support for: class org.hibernate.cache.spi.entry.StandardCacheEntryImpl
> at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:596)
> {code}
> So, {{org.hibernate.cache.spi.entry.StandardCacheEntryImpl}} is relying on standard serialization. The problem is that this class does not belong to hibernate-infinispan module and hence cannot be made to extend Infinispan's ExternalPojo.
> On the other hand, the white list in ExternallyMarshallable is hardcoded but there are no plans to make this declaratively configurable for now, since the separation between internal and external marshaller will eventually disappear in favour of internal vs user marshaller.
> So, the easiest thing to do here would be to add {{org.hibernate.cache}} package to the white list.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 10 months
[JBoss JIRA] (ISPN-7591) Add org.hibernate.cache to externally marshallable white list
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-7591?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-7591:
-----------------------------------
Status: Open (was: New)
> Add org.hibernate.cache to externally marshallable white list
> -------------------------------------------------------------
>
> Key: ISPN-7591
> URL: https://issues.jboss.org/browse/ISPN-7591
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Marshalling
> Affects Versions: 9.0.0.CR3
> Reporter: Galder Zamarreño
> Fix For: 9.0.0.Final
>
>
> While running 2LC tests I've discovered that some tests fail with:
> {code}Caused by: java.lang.AssertionError: Check support for: class org.hibernate.cache.spi.entry.StandardCacheEntryImpl
> at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:596)
> {code}
> So, {{org.hibernate.cache.spi.entry.StandardCacheEntryImpl}} is relying on standard serialization. The problem is that this class does not belong to hibernate-infinispan module and hence cannot be made to extend Infinispan's ExternalPojo.
> On the other hand, the white list in ExternallyMarshallable is hardcoded but there are no plans to make this declaratively configurable for now, since the separation between internal and external marshaller will eventually disappear in favour of internal vs user marshaller.
> So, the easiest thing to do here would be to add {{org.hibernate.cache}} package to the white list.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 10 months
[JBoss JIRA] (ISPN-7591) Add org.hibernate.cache to externally marshallable white list
by Galder Zamarreño (JIRA)
Galder Zamarreño created ISPN-7591:
--------------------------------------
Summary: Add org.hibernate.cache to externally marshallable white list
Key: ISPN-7591
URL: https://issues.jboss.org/browse/ISPN-7591
Project: Infinispan
Issue Type: Bug
Components: Core, Marshalling
Affects Versions: 9.0.0.CR3
Reporter: Galder Zamarreño
Fix For: 9.0.0.Final
While running 2LC tests I've discovered that some tests fail with:
{code}Caused by: java.lang.AssertionError: Check support for: class org.hibernate.cache.spi.entry.StandardCacheEntryImpl
at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:596)
{code}
So, {{org.hibernate.cache.spi.entry.StandardCacheEntryImpl}} is relying on standard serialization. The problem is that this class does not belong to hibernate-infinispan module and hence cannot be made to extend Infinispan's ExternalPojo.
On the other hand, the white list in ExternallyMarshallable is hardcoded but there are no plans to make this declaratively configurable for now, since the separation between internal and external marshaller will eventually disappear in favour of internal vs user marshaller.
So, the easiest thing to do here would be to add {{org.hibernate.cache}} package to the white list.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 10 months
[JBoss JIRA] (ISPN-7591) Add org.hibernate.cache to externally marshallable white list
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-7591?page=com.atlassian.jira.plugin.... ]
Work on ISPN-7591 started by Galder Zamarreño.
----------------------------------------------
> Add org.hibernate.cache to externally marshallable white list
> -------------------------------------------------------------
>
> Key: ISPN-7591
> URL: https://issues.jboss.org/browse/ISPN-7591
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Marshalling
> Affects Versions: 9.0.0.CR3
> Reporter: Galder Zamarreño
> Assignee: Galder Zamarreño
> Fix For: 9.0.0.Final
>
>
> While running 2LC tests I've discovered that some tests fail with:
> {code}Caused by: java.lang.AssertionError: Check support for: class org.hibernate.cache.spi.entry.StandardCacheEntryImpl
> at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:596)
> {code}
> So, {{org.hibernate.cache.spi.entry.StandardCacheEntryImpl}} is relying on standard serialization. The problem is that this class does not belong to hibernate-infinispan module and hence cannot be made to extend Infinispan's ExternalPojo.
> On the other hand, the white list in ExternallyMarshallable is hardcoded but there are no plans to make this declaratively configurable for now, since the separation between internal and external marshaller will eventually disappear in favour of internal vs user marshaller.
> So, the easiest thing to do here would be to add {{org.hibernate.cache}} package to the white list.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 10 months