[JBoss JIRA] (ISPN-8861) DIST Iteration shouldn't go remote when a shared cache store is present
by William Burns (Jira)
[ https://issues.jboss.org/browse/ISPN-8861?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-8861:
-------------------------------------
Granted I don't think any shared stores have key optimized stores that wouldn't just want to pull the value as well.
> DIST Iteration shouldn't go remote when a shared cache store is present
> -----------------------------------------------------------------------
>
> Key: ISPN-8861
> URL: https://issues.jboss.org/browse/ISPN-8861
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Reporter: William Burns
> Assignee: William Burns
> Priority: Major
> Fix For: 9.4.4.Final
>
>
> When a user runs a distributed iteration operation with a shared cache store, this shouldn't go remote as the local node would have all the data available to it. This is similar to the optimization when we don't go remote if the current node is an owner for all required segments.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 3 months
[JBoss JIRA] (ISPN-8862) Iteration and stream operations with passivation disabled shouldn't use in memory
by William Burns (Jira)
[ https://issues.jboss.org/browse/ISPN-8862?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-8862:
-------------------------------------
The other issue with the former idea is if we had a passivation during the iteration process we could miss an entry :( Thus we would have to listen to passivations and if did happen compare if we already returned that key, which is exactly what we do currently :(
> Iteration and stream operations with passivation disabled shouldn't use in memory
> ---------------------------------------------------------------------------------
>
> Key: ISPN-8862
> URL: https://issues.jboss.org/browse/ISPN-8862
> Project: Infinispan
> Issue Type: Enhancement
> Reporter: William Burns
> Assignee: William Burns
> Priority: Major
> Fix For: 9.4.4.Final
>
>
> When passivation is disabled all entries are assumed to be in the cache loader/store. We currently try to merge these together in a sloppy way [1]. This first reads in memory and then from the store and keeps all keys from in memory to exclude them from the store. Unfortunately the store still has to pull the entries even for the already read keys, but just ignores them. This leads to a lot of inefficiency and memory bloat. Instead we should just return the store entries as is when passivation is disabled.
> [1] https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 3 months
[JBoss JIRA] (ISPN-8862) Iteration and stream operations with passivation disabled shouldn't use in memory
by William Burns (Jira)
[ https://issues.jboss.org/browse/ISPN-8862?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-8862:
-------------------------------------
You are saying keep track if an entry was evicted in the data container when passivation is enabled and if not then only do iteration over the data container, correct?
Yeah iterating over the store keys vs keys and value is interesting, but we have no way to do that currently and putting that logic into the store will complicate them all substantially. To be honest I don't know if there is a good answer
> Iteration and stream operations with passivation disabled shouldn't use in memory
> ---------------------------------------------------------------------------------
>
> Key: ISPN-8862
> URL: https://issues.jboss.org/browse/ISPN-8862
> Project: Infinispan
> Issue Type: Enhancement
> Reporter: William Burns
> Assignee: William Burns
> Priority: Major
> Fix For: 9.4.4.Final
>
>
> When passivation is disabled all entries are assumed to be in the cache loader/store. We currently try to merge these together in a sloppy way [1]. This first reads in memory and then from the store and keeps all keys from in memory to exclude them from the store. Unfortunately the store still has to pull the entries even for the already read keys, but just ignores them. This leads to a lot of inefficiency and memory bloat. Instead we should just return the store entries as is when passivation is disabled.
> [1] https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 3 months
[JBoss JIRA] (ISPN-9683) Remote getBulk methods from RemoteCache
by William Burns (Jira)
[ https://issues.jboss.org/browse/ISPN-9683?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-9683:
-------------------------------------
Unfortunately server side code cannot be removed until we remove the 2.x protocol support, which will be a while. So this will include just the client side changes.
> Remote getBulk methods from RemoteCache
> ---------------------------------------
>
> Key: ISPN-9683
> URL: https://issues.jboss.org/browse/ISPN-9683
> Project: Infinispan
> Issue Type: Sub-task
> Components: Hot Rod
> Reporter: William Burns
> Assignee: William Burns
> Priority: Major
> Fix For: 10.0.0.Final
>
>
> The getBulk methods have been deprecated for a while on the RemoteCache. We have appropriate streaming based methods for keySet, entrySet and retrieveEntries methods which are much better.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 3 months