[JBoss JIRA] (ISPN-9708) Expose threadpool executors via JMX
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-9708?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-9708:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Expose threadpool executors via JMX
> -----------------------------------
>
> Key: ISPN-9708
> URL: https://issues.jboss.org/browse/ISPN-9708
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core, JMX, reporting and management, Server
> Affects Versions: 9.4.1.Final
> Reporter: Tristan Tarrant
> Assignee: Tristan Tarrant
> Priority: Major
> Fix For: 9.4.2.Final, 10.0.0.Alpha1
>
>
> We should expose executors over JMX so that threadpools can be monitored.
> This includes all the global threadpools as well as any protocol server thread pools.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9745) Release fails because compatibility bundle modules don't have source jars
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9745?page=com.atlassian.jira.plugin.... ]
Dan Berindei reopened ISPN-9745:
--------------------------------
> Release fails because compatibility bundle modules don't have source jars
> -------------------------------------------------------------------------
>
> Key: ISPN-9745
> URL: https://issues.jboss.org/browse/ISPN-9745
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 9.4.2.Final, 10.0.0.Alpha1
>
>
> Modules {{client/marshaller/protostuff/protostuff-marshaller-compatibility-bundle}} and {{client/marshaller/protostuff/protostuff-marshaller-compatibility-bundle}} are uber-jars and don't have any sources.
> Prior to the ISPN-9697 changes, a {{DEPENDENCIES.txt}} and {{LICENSES.txt}} was generated in the source directory, and a test-sources jar was created. But after those files were removed, a test-sources jar is no longer generated, and Nexus rejects the artifacts:
> {noformat}
> 11:19:37.492 [ERROR]
> 11:19:37.492 [ERROR] Nexus Staging Rules Failure Report
> 11:19:37.492 [ERROR] ==================================
> 11:19:37.492 [ERROR]
> 11:19:37.493 [ERROR] Repository "jboss_releases_staging_profile-14551" failures
> 11:19:37.493 [ERROR] Rule "sources-staging" failures
> 11:19:37.493 [ERROR] * Missing: no sources jar found in folder '/org/infinispan/infinispan-marshaller-kryo-bundle/9.4.2.Final'
> 11:19:37.493 [ERROR] * Missing: no sources jar found in folder '/org/infinispan/infinispan-marshaller-protostuff-bundle/9.4.2.Final'
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9745) Release fails because compatibility bundle modules don't have source jars
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9745?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9745:
-------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 10.0.0.Alpha1
Resolution: Done
> Release fails because compatibility bundle modules don't have source jars
> -------------------------------------------------------------------------
>
> Key: ISPN-9745
> URL: https://issues.jboss.org/browse/ISPN-9745
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 9.4.2.Final, 10.0.0.Alpha1
>
>
> Modules {{client/marshaller/protostuff/protostuff-marshaller-compatibility-bundle}} and {{client/marshaller/protostuff/protostuff-marshaller-compatibility-bundle}} are uber-jars and don't have any sources.
> Prior to the ISPN-9697 changes, a {{DEPENDENCIES.txt}} and {{LICENSES.txt}} was generated in the source directory, and a test-sources jar was created. But after those files were removed, a test-sources jar is no longer generated, and Nexus rejects the artifacts:
> {noformat}
> 11:19:37.492 [ERROR]
> 11:19:37.492 [ERROR] Nexus Staging Rules Failure Report
> 11:19:37.492 [ERROR] ==================================
> 11:19:37.492 [ERROR]
> 11:19:37.493 [ERROR] Repository "jboss_releases_staging_profile-14551" failures
> 11:19:37.493 [ERROR] Rule "sources-staging" failures
> 11:19:37.493 [ERROR] * Missing: no sources jar found in folder '/org/infinispan/infinispan-marshaller-kryo-bundle/9.4.2.Final'
> 11:19:37.493 [ERROR] * Missing: no sources jar found in folder '/org/infinispan/infinispan-marshaller-protostuff-bundle/9.4.2.Final'
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9745) Release fails because compatibility bundle modules don't have source jars
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9745?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9745:
-------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/6434, https://github.com/infinispan/infinispan/pull/6436 (was: https://github.com/infinispan/infinispan/pull/6434)
> Release fails because compatibility bundle modules don't have source jars
> -------------------------------------------------------------------------
>
> Key: ISPN-9745
> URL: https://issues.jboss.org/browse/ISPN-9745
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 9.4.2.Final
>
>
> Modules {{client/marshaller/protostuff/protostuff-marshaller-compatibility-bundle}} and {{client/marshaller/protostuff/protostuff-marshaller-compatibility-bundle}} are uber-jars and don't have any sources.
> Prior to the ISPN-9697 changes, a {{DEPENDENCIES.txt}} and {{LICENSES.txt}} was generated in the source directory, and a test-sources jar was created. But after those files were removed, a test-sources jar is no longer generated, and Nexus rejects the artifacts:
> {noformat}
> 11:19:37.492 [ERROR]
> 11:19:37.492 [ERROR] Nexus Staging Rules Failure Report
> 11:19:37.492 [ERROR] ==================================
> 11:19:37.492 [ERROR]
> 11:19:37.493 [ERROR] Repository "jboss_releases_staging_profile-14551" failures
> 11:19:37.493 [ERROR] Rule "sources-staging" failures
> 11:19:37.493 [ERROR] * Missing: no sources jar found in folder '/org/infinispan/infinispan-marshaller-kryo-bundle/9.4.2.Final'
> 11:19:37.493 [ERROR] * Missing: no sources jar found in folder '/org/infinispan/infinispan-marshaller-protostuff-bundle/9.4.2.Final'
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9745) Release fails because compatibility bundle modules don't have source jars
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9745?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9745:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/6434
> Release fails because compatibility bundle modules don't have source jars
> -------------------------------------------------------------------------
>
> Key: ISPN-9745
> URL: https://issues.jboss.org/browse/ISPN-9745
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 9.4.2.Final
>
>
> Modules {{client/marshaller/protostuff/protostuff-marshaller-compatibility-bundle}} and {{client/marshaller/protostuff/protostuff-marshaller-compatibility-bundle}} are uber-jars and don't have any sources.
> Prior to the ISPN-9697 changes, a {{DEPENDENCIES.txt}} and {{LICENSES.txt}} was generated in the source directory, and a test-sources jar was created. But after those files were removed, a test-sources jar is no longer generated, and Nexus rejects the artifacts:
> {noformat}
> 11:19:37.492 [ERROR]
> 11:19:37.492 [ERROR] Nexus Staging Rules Failure Report
> 11:19:37.492 [ERROR] ==================================
> 11:19:37.492 [ERROR]
> 11:19:37.493 [ERROR] Repository "jboss_releases_staging_profile-14551" failures
> 11:19:37.493 [ERROR] Rule "sources-staging" failures
> 11:19:37.493 [ERROR] * Missing: no sources jar found in folder '/org/infinispan/infinispan-marshaller-kryo-bundle/9.4.2.Final'
> 11:19:37.493 [ERROR] * Missing: no sources jar found in folder '/org/infinispan/infinispan-marshaller-protostuff-bundle/9.4.2.Final'
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9691) StateTransferFileCacheLoaderFunctionalTest#testConcurrentStateTransfer can hang
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9691?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9691:
-------------------------------
Fix Version/s: 9.4.2.Final
> StateTransferFileCacheLoaderFunctionalTest#testConcurrentStateTransfer can hang
> -------------------------------------------------------------------------------
>
> Key: ISPN-9691
> URL: https://issues.jboss.org/browse/ISPN-9691
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Reporter: William Burns
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 9.4.2.Final, 10.0.0.Alpha1
>
>
> The test can hang and will eventually be killed after the 5 minute timeout. The CI unfortunately doesn't count it as a failure. I have been seeing this quite often when running the core suite locally.
> https://ci.infinispan.org/job/Infinispan/job/master/927
> The stack in the log is:
> {quote}
> Test org.infinispan.statetransfer.StateTransferFileCacheLoaderFunctionalTest.testConcurrentStateTransfer has been running for more than 300 seconds. Interrupting the test thread and dumping thread stacks of the test suite process and its children.
> Dumping thread stacks of process 32404 to /home/infinispan/workspace/Infinispan_master-5OURPVBKVS5PLGVSKVWLBFUZPLIO2DZSV3U7HWSZJBYGBGKYSFXQ/core/threaddump-org_infinispan_statetransfer_StateTransferFileCacheLoaderFunctionalTest_testConcurrentStateTransfer-2018-11-02-32404.log
> Interrupted thread testng-StateTransferFileCacheLoaderFunctionalTest (22).
> Error dumping thread stacks/interrupting threads/killing processes:
> [OK: 11616, KO: 1, SKIP: java.lang.InterruptedException
> 96] Test succeeded: org.infinispan.statetransfer.StateTransferFileCacheLoaderFunctionalTest.testConcurrentStateTransfer
> at java.lang.Object.wait(Native Method)
> at java.lang.Thread.join(Thread.java:1260)
> {quote}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9746) HotRod decoder should release allocated buffers
by Dan Berindei (Jira)
Dan Berindei created ISPN-9746:
----------------------------------
Summary: HotRod decoder should release allocated buffers
Key: ISPN-9746
URL: https://issues.jboss.org/browse/ISPN-9746
Project: Infinispan
Issue Type: Bug
Components: Server
Affects Versions: 9.4.1.Final
Reporter: Dan Berindei
{noformat}
19:09:07,279 ERROR [io.netty.util.ResourceLeakDetector] (HotRod-ServerIO-6-1) LEAK: ByteBuf.release() was not called before it's garbage-collected. See http://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records:
Created at:
io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:331)
io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:185)
io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:176)
io.netty.buffer.AbstractByteBufAllocator.buffer(AbstractByteBufAllocator.java:113)
org.infinispan.server.hotrod.HotRodDecoder.switch3(HotRodDecoder.java:1940)
org.infinispan.server.hotrod.HotRodDecoder.switch1_0(HotRodDecoder.java:156)
org.infinispan.server.hotrod.HotRodDecoder.decode(HotRodDecoder.java:143)
{noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9701) TransactionTable does not shutdown gracefully
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9701?page=com.atlassian.jira.plugin.... ]
Dan Berindei commented on ISPN-9701:
------------------------------------
I think your "naive fix" is just fine [~pferraro]. Marshalling is always synchronous, so it will definitely fix the exception.
True, before this we already left the cache, so the other nodes might have already removed the transaction before we sent the commit and the subsequent {{TxCompletionNotificationCommand}}. In order to fix that, we'd need another component that waits for local txs to finish before leaving the cache, or perhaps splitting the leave in 2 phases.
> TransactionTable does not shutdown gracefully
> ---------------------------------------------
>
> Key: ISPN-9701
> URL: https://issues.jboss.org/browse/ISPN-9701
> Project: Infinispan
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 9.4.1.Final
> Reporter: Paul Ferraro
> Assignee: Dan Berindei
> Priority: Critical
>
> Here's a sample stacktrace during shutdown:
> {noformat}
> 16:54:15,033 WARN [org.wildfly.clustering.web.undertow] (default task-1) ISPN000472: Cache manager is stopping: org.infinispan.IllegalLifecycleStateException: ISPN000472: Cache manager is stopping
> at org.infinispan.marshall.core.GlobalMarshaller.getExternalizer(GlobalMarshaller.java:420)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:400)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:355)
> at org.infinispan.marshall.core.GlobalMarshaller.writeObjectOutput(GlobalMarshaller.java:183)
> at org.infinispan.marshall.core.GlobalMarshaller.writeObjectOutput(GlobalMarshaller.java:176)
> at org.infinispan.marshall.core.GlobalMarshaller.objectToBuffer(GlobalMarshaller.java:305)
> at org.infinispan.remoting.transport.jgroups.JGroupsTransport.marshallRequest(JGroupsTransport.java:1009)
> at org.infinispan.remoting.transport.jgroups.JGroupsTransport.sendCommand(JGroupsTransport.java:1209)
> at org.infinispan.remoting.transport.jgroups.JGroupsTransport.performAsyncRemoteInvocation(JGroupsTransport.java:1105)
> at org.infinispan.remoting.transport.jgroups.JGroupsTransport.invokeRemotelyAsync(JGroupsTransport.java:246)
> at org.infinispan.remoting.rpc.RpcManagerImpl.invokeRemotelyAsync(RpcManagerImpl.java:291)
> at org.infinispan.remoting.rpc.RpcManagerImpl.invokeRemotely(RpcManagerImpl.java:323)
> at org.infinispan.transaction.impl.TransactionTable.removeTransactionInfoRemotely(TransactionTable.java:900)
> at org.infinispan.transaction.impl.TransactionTable.releaseLocksForCompletedTransaction(TransactionTable.java:886)
> at org.infinispan.transaction.xa.XaTransactionTable.forgetSuccessfullyCompletedTransaction(XaTransactionTable.java:195)
> at org.infinispan.transaction.xa.XaTransactionTable.commit(XaTransactionTable.java:128)
> at org.infinispan.transaction.xa.TransactionXaAdapter.commit(TransactionXaAdapter.java:68)
> at org.infinispan.commons.tx.TransactionImpl.finishResource(TransactionImpl.java:419)
> at org.infinispan.commons.tx.TransactionImpl.commitResources(TransactionImpl.java:466)
> at org.infinispan.commons.tx.TransactionImpl.runCommit(TransactionImpl.java:335)
> at org.infinispan.commons.tx.TransactionImpl.commit(TransactionImpl.java:110)
> {noformat}
> The problem seems to be that shutDownGracefully() first waits for the localTransactions map to be empty. However, when the cache is clustered, releaseLocksForCompletedTransaction(...) removes the transaction from the localTransactions map *before* invoking removeTransactionInfoRemotely(...), which means that the subsequent TxCompletionNotificationCommand can fail to marshal (see above), or the transport might close before this command is sent.
> A naive fix would simply reorder the removeLocalTransaction(...) to happen after the call to removeTransactionInfoRemotely(...) within the releaseLocksForCompletedTransaction(...) method, but I'm sure there's more to it.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month