[JBoss JIRA] (ISPN-9932) Avoid creating MarshallableEntry instances if no CacheWriter enabled
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9932?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9932:
-------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Avoid creating MarshallableEntry instances if no CacheWriter enabled
> --------------------------------------------------------------------
>
> Key: ISPN-9932
> URL: https://issues.jboss.org/browse/ISPN-9932
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Affects Versions: 10.0.0.Alpha3
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta1
>
>
> The (Dist)CacheWriterIntercepter is enabled if any loader/store is configured. The problem, is that the interceptor assumes that a CacheWriter is always configured. However, it is possible that only a CacheLoader has been configured, in which case when a write command visits the interceptor, MarshallableEntry instances are created unnecessarily in order to call the various PersistenceManager write operations.
> To avoid unnecessary allocations and the marshalling of key/value/metadata that is never stored, we should ensure that calls to PersistenceManager write methods are only called if a CacheWriter is actually configured.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (ISPN-9933) Cache components are not stopped after startup error
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9933?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9933:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/6590
> Cache components are not stopped after startup error
> ----------------------------------------------------
>
> Key: ISPN-9933
> URL: https://issues.jboss.org/browse/ISPN-9933
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 10.0.0.Alpha3, 9.4.6.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 10.0.0.Beta1, 9.4.7.Final
>
>
> When a cache fails to start (e.g. because a store is not available on startup), the cache is not registered in {{DefaultCacheManager's}} map, and stopping the cache manager does not stop any of the components that already started (or even the component that failed).
> E.g. in {{NonStringKeyPreloadTest}}, the store is not available on startup, and the threads created by HikariCP on startup (in 9.4.x) are not released. The test also leaks an Agroal thread on master, but that is because the test is keeping the connection pool factory in a static field.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (ISPN-9935) CDI RemoteCacheProducer leaks thread
by Dan Berindei (Jira)
Dan Berindei created ISPN-9935:
----------------------------------
Summary: CDI RemoteCacheProducer leaks thread
Key: ISPN-9935
URL: https://issues.jboss.org/browse/ISPN-9935
Project: Infinispan
Issue Type: Bug
Components: CDI
Affects Versions: 9.4.6.Final, 10.0.0.Alpha3
Reporter: Dan Berindei
Fix For: 10.0.0.Final
{{RemoteCacheProducer}} injects an (optional?) default {{RemoteCacheManager}}, which is created with a custom bean registered by {{InfinispanExtensionRemote.createDefaultRemoteCacheManagerBean()}}.
In the CDI remote tests, however, the default {{RemoteCacheManager}} is not used, so it's not created. Instead, Weld creates a proxy {{RemoteCacheManager}}, and since {{RemoteCacheManager}} is a class, its default constructor is invoked, connecting to the server and starting the async thread pool. But since it's not a proper bean, only a proxy, Weld never invokes {{stop()}} and leaks the thread.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (ISPN-9934) infinispan-protocol-parser-generator-maven-plugin fails on Windows
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-9934?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant closed ISPN-9934.
---------------------------------
Resolution: Duplicate Issue
ISPN-9931
> infinispan-protocol-parser-generator-maven-plugin fails on Windows
> ------------------------------------------------------------------
>
> Key: ISPN-9934
> URL: https://issues.jboss.org/browse/ISPN-9934
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.0.0.Alpha3, 9.4.6.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Critical
> Fix For: 10.0.0.Beta1, 9.4.7.Final
>
>
> {{\[ERROR] Failed to execute goal org.infinispan:infinispan-protocol-parser-generator-maven-plugin:9.4.6.Final-redhat-00001:generate (default) on project infinispan-server-hotrod: Execution default of goal org.infinispan:infinispan-protocol-parser-generator-maven-plugin:9.4.6.Final-redhat-00001:generate failed: character to be escaped is missing -> \[Help 1]}}
> The problem is most likely here:
> {code:java}
> File output = new File(outputDirectory, grammar.getPackage().replaceAll("\\.", File.separator) + File.separator + grammar.getSimpleName() + ".java");
> {code}
> On Windows, {{File.separator}} is {{\}}, and {{\}} has a special meaning in the {{replaceAll}} replacement string.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (ISPN-9934) infinispan-protocol-parser-generator-maven-plugin fails on Windows
by Dan Berindei (Jira)
Dan Berindei created ISPN-9934:
----------------------------------
Summary: infinispan-protocol-parser-generator-maven-plugin fails on Windows
Key: ISPN-9934
URL: https://issues.jboss.org/browse/ISPN-9934
Project: Infinispan
Issue Type: Bug
Components: Build
Affects Versions: 9.4.6.Final, 10.0.0.Alpha3
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 10.0.0.Beta1, 9.4.7.Final
{{\[ERROR] Failed to execute goal org.infinispan:infinispan-protocol-parser-generator-maven-plugin:9.4.6.Final-redhat-00001:generate (default) on project infinispan-server-hotrod: Execution default of goal org.infinispan:infinispan-protocol-parser-generator-maven-plugin:9.4.6.Final-redhat-00001:generate failed: character to be escaped is missing -> \[Help 1]}}
The problem is most likely here:
{code:java}
File output = new File(outputDirectory, grammar.getPackage().replaceAll("\\.", File.separator) + File.separator + grammar.getSimpleName() + ".java");
{code}
On Windows, {{File.separator}} is {{\}}, and {{\}} has a special meaning in the {{replaceAll}} replacement string.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (ISPN-9933) Cache components are not stopped after startup error
by Dan Berindei (Jira)
Dan Berindei created ISPN-9933:
----------------------------------
Summary: Cache components are not stopped after startup error
Key: ISPN-9933
URL: https://issues.jboss.org/browse/ISPN-9933
Project: Infinispan
Issue Type: Bug
Components: Core
Affects Versions: 9.4.6.Final, 10.0.0.Alpha3
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 10.0.0.Beta1, 9.4.7.Final
When a cache fails to start (e.g. because a store is not available on startup), the cache is not registered in {{DefaultCacheManager's}} map, and stopping the cache manager does not stop any of the components that already started (or even the component that failed).
E.g. in {{NonStringKeyPreloadTest}}, the store is not available on startup, and the threads created by HikariCP on startup (in 9.4.x) are not released. The test also leaks an Agroal thread on master, but that is because the test is keeping the connection pool factory in a static field.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (ISPN-9933) Cache components are not stopped after startup error
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9933?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9933:
-------------------------------
Status: Open (was: New)
> Cache components are not stopped after startup error
> ----------------------------------------------------
>
> Key: ISPN-9933
> URL: https://issues.jboss.org/browse/ISPN-9933
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 10.0.0.Alpha3, 9.4.6.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 10.0.0.Beta1, 9.4.7.Final
>
>
> When a cache fails to start (e.g. because a store is not available on startup), the cache is not registered in {{DefaultCacheManager's}} map, and stopping the cache manager does not stop any of the components that already started (or even the component that failed).
> E.g. in {{NonStringKeyPreloadTest}}, the store is not available on startup, and the threads created by HikariCP on startup (in 9.4.x) are not released. The test also leaks an Agroal thread on master, but that is because the test is keeping the connection pool factory in a static field.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (ISPN-9932) Avoid creating MarshallableEntry instances if no CacheWriter enabled
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9932?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9932:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/6657
> Avoid creating MarshallableEntry instances if no CacheWriter enabled
> --------------------------------------------------------------------
>
> Key: ISPN-9932
> URL: https://issues.jboss.org/browse/ISPN-9932
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Affects Versions: 10.0.0.Alpha3
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta1
>
>
> The (Dist)CacheWriterIntercepter is enabled if any loader/store is configured. The problem, is that the interceptor assumes that a CacheWriter is always configured. However, it is possible that only a CacheLoader has been configured, in which case when a write command visits the interceptor, MarshallableEntry instances are created unnecessarily in order to call the various PersistenceManager write operations.
> To avoid unnecessary allocations and the marshalling of key/value/metadata that is never stored, we should ensure that calls to PersistenceManager write methods are only called if a CacheWriter is actually configured.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (ISPN-9932) Avoid creating MarshallableEntry instances if no CacheWriter enabled
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9932?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9932:
-------------------------------
Status: Open (was: New)
> Avoid creating MarshallableEntry instances if no CacheWriter enabled
> --------------------------------------------------------------------
>
> Key: ISPN-9932
> URL: https://issues.jboss.org/browse/ISPN-9932
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Affects Versions: 10.0.0.Alpha3
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta1
>
>
> The (Dist)CacheWriterIntercepter is enabled if any loader/store is configured. The problem, is that the interceptor assumes that a CacheWriter is always configured. However, it is possible that only a CacheLoader has been configured, in which case when a write command visits the interceptor, MarshallableEntry instances are created unnecessarily in order to call the various PersistenceManager write operations.
> To avoid unnecessary allocations and the marshalling of key/value/metadata that is never stored, we should ensure that calls to PersistenceManager write methods are only called if a CacheWriter is actually configured.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months