[JBoss JIRA] (ISPN-10043) Add explicit dependency on surefire-testng
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10043?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-10043:
--------------------------------
Status: Open (was: New)
> Add explicit dependency on surefire-testng
> ------------------------------------------
>
> Key: ISPN-10043
> URL: https://issues.jboss.org/browse/ISPN-10043
> Project: Infinispan
> Issue Type: Task
> Components: Build
> Affects Versions: 10.0.0.Beta2, 9.4.9.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 10.0.0.Beta3, 9.4.10.Final
>
>
> We need to be able to collect all the dependencies in a private repository and run the build without access to Maven Central for the product.
> {{maven-surefire-plugin}} doesn't have an explicit dependency on {{surefire-testng}}, instead it resolves it dynamically when it finds {{TestNG}} in the classpath. This means {{surefire-testng}} and its transitive dependencies are not detected automatically and need to be imported manually.
> When a dependency is not imported, it is pretty hard to debug: there is only a warning during the build:
> {noformat}
> [WARNING] Missing POM for org.apache.maven.surefire:surefire-testng-utils:jar:3.0.0-M3
> {noformat}
> And then the failure message only mentions a specific class:
> {noformat}
> There was an error in the forked process
> org/apache/maven/surefire/testng/utils/Stoppable
> {noformat}
> We should add an explicit dependency on {{surefire-testng}} on core, like the modules using {{JUnit}} have an explicit dependency on {{surefire-junit47}}, in order to allow automatic detection of its transitive dependencies and to get better error messages.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (ISPN-10041) Locking interceptor should check the topology before acquiring locks
by Dan Berindei (Jira)
Dan Berindei created ISPN-10041:
-----------------------------------
Summary: Locking interceptor should check the topology before acquiring locks
Key: ISPN-10041
URL: https://issues.jboss.org/browse/ISPN-10041
Project: Infinispan
Issue Type: Bug
Components: Core
Affects Versions: 9.4.9.Final, 10.0.0.Beta2, 9.3.6.Final, 8.2.11.Final
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 10.0.0.Beta3
The distribution interceptors check the command topology is the same as the current topology before sending a command to remote nodes, but the locking interceptors do not have any check.
On a remote node, this means the inbound invocation handler acquires some locks in topology {{T}}, then the locking interceptor acquires other locks in topology {{T+1}}, and finally the distribution interceptor throws {{OutdatedTopologyException}} and releases the locks. In older versions there is also a potential for blocking a remote executor thread while waiting for the lock, but luckily that is not a problem in 9.4+. It would be more efficient if the locking interceptor was throwing {{OutdatedTopologyException}} instead.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (ISPN-10040) Embedded and server thread pool defaults should be the same
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10040?page=com.atlassian.jira.plugin... ]
Dan Berindei reassigned ISPN-10040:
-----------------------------------
Assignee: Dan Berindei
> Embedded and server thread pool defaults should be the same
> -----------------------------------------------------------
>
> Key: ISPN-10040
> URL: https://issues.jboss.org/browse/ISPN-10040
> Project: Infinispan
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 8.2.11.Final, 10.0.0.Beta2, 9.4.9.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 10.0.0.Beta3, 9.4.10.Final
>
>
> Embedded:
> {code:java}
> DEFAULT_THREAD_COUNT.put(REMOTE_COMMAND_EXECUTOR, 200);
> DEFAULT_QUEUE_SIZE.put(REMOTE_COMMAND_EXECUTOR, 0);
> {code}
> Server:
> {code:java}
> REMOTE_COMMAND("remote-command", 25, 25, 100000, 60000),
> {code}
> Using a huge queue is not ok for the remote thread pool, but I missed it before because I assumed the server was using the {{KnownComponentNames}} defaults. We should unify the thread pool defaults in another class with a more topical name and remove {{KnownComponentNames}}.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (ISPN-10040) Embedded and server thread pool defaults should be the same
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10040?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-10040:
--------------------------------
Status: Open (was: New)
> Embedded and server thread pool defaults should be the same
> -----------------------------------------------------------
>
> Key: ISPN-10040
> URL: https://issues.jboss.org/browse/ISPN-10040
> Project: Infinispan
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 8.2.11.Final, 10.0.0.Beta2, 9.4.9.Final
> Reporter: Dan Berindei
> Priority: Major
> Fix For: 10.0.0.Beta3, 9.4.10.Final
>
>
> Embedded:
> {code:java}
> DEFAULT_THREAD_COUNT.put(REMOTE_COMMAND_EXECUTOR, 200);
> DEFAULT_QUEUE_SIZE.put(REMOTE_COMMAND_EXECUTOR, 0);
> {code}
> Server:
> {code:java}
> REMOTE_COMMAND("remote-command", 25, 25, 100000, 60000),
> {code}
> Using a huge queue is not ok for the remote thread pool, but I missed it before because I assumed the server was using the {{KnownComponentNames}} defaults. We should unify the thread pool defaults in another class with a more topical name and remove {{KnownComponentNames}}.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (ISPN-10040) Embedded and server thread pool defaults should be the same
by Dan Berindei (Jira)
Dan Berindei created ISPN-10040:
-----------------------------------
Summary: Embedded and server thread pool defaults should be the same
Key: ISPN-10040
URL: https://issues.jboss.org/browse/ISPN-10040
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 9.4.9.Final, 10.0.0.Beta2, 8.2.11.Final
Reporter: Dan Berindei
Fix For: 10.0.0.Beta3, 9.4.10.Final
Embedded:
{code:java}
DEFAULT_THREAD_COUNT.put(REMOTE_COMMAND_EXECUTOR, 200);
DEFAULT_QUEUE_SIZE.put(REMOTE_COMMAND_EXECUTOR, 0);
{code}
Server:
{code:java}
REMOTE_COMMAND("remote-command", 25, 25, 100000, 60000),
{code}
Using a huge queue is not ok for the remote thread pool, but I missed it before because I assumed the server was using the {{KnownComponentNames}} defaults. We should unify the thread pool defaults in another class with a more topical name and remove {{KnownComponentNames}}.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months
[JBoss JIRA] (ISPN-9852) Invocations waiting for a new topology should resume in parallel
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9852?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9852:
-------------------------------
Affects Version/s: 8.2.11.Final
> Invocations waiting for a new topology should resume in parallel
> ----------------------------------------------------------------
>
> Key: ISPN-9852
> URL: https://issues.jboss.org/browse/ISPN-9852
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 8.2.11.Final, 10.0.0.Alpha2, 9.4.5.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 10.0.0.Beta3, 9.4.10.Final
>
>
> When a command requires a topology newer than the current topology, it uses {{StateTransferLock.transactionDataFuture()}} to wait for the newer topology. When the tx data is received for the newer topology, some (most?) of the waiting operations do not use a separate executor, instead they are all resumed on the thread that received the tx data. If some operations block (e.g. because of a store), it could take a very long time to finish all the blocked operations.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 9 months