[JBoss JIRA] (ISPN-11388) Refactor CacheIgnoreManager - AbstractProtocolServer collaboration
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/ISPN-11388?page=com.atlassian.jira.plugi... ]
Nistor Adrian updated ISPN-11388:
---------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/7963 (was: https://github.com/infinispan/infinispan/pull/7943)
> Refactor CacheIgnoreManager - AbstractProtocolServer collaboration
> ------------------------------------------------------------------
>
> Key: ISPN-11388
> URL: https://issues.redhat.com/browse/ISPN-11388
> Project: Infinispan
> Issue Type: Enhancement
> Components: Server
> Affects Versions: 10.1.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 11.0.0.Alpha2
>
>
> Given the interactions between CacheIgnoreManager and AbstractProtocolServer it seems that CacheIgnoreManager should be a global component in the registry of the EmbeddedCacheManager sitting behind the AbstractProtocolServer. It should be looked up from there, or better injected, rather than being received in ProtocolServer.start method. The start method also has an overloaded version that does not take a CacheIgnoreManager to support tests the do not need it. This lack of orthogonality is annoyoing.
> Another aspect to refactor: the startInternal method receives parametters that it assigns to fields. It seems that this should have been done already in the start method. That would get rid of some clunky hacks and some comments/excuses for the said hacks.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months
[JBoss JIRA] (ISPN-11391) AsynchronousInvocationTest doesn't cover all the commands
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11391?page=com.atlassian.jira.plugi... ]
Will Burns updated ISPN-11391:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> AsynchronousInvocationTest doesn't cover all the commands
> ---------------------------------------------------------
>
> Key: ISPN-11391
> URL: https://issues.redhat.com/browse/ISPN-11391
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Test Suite
> Affects Versions: 11.0.0.Alpha1
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 11.0.0.Alpha2
>
>
> ISPN-10362 added {{GlobalRpcCommand}}, but there is no test for {{GlobalRpcCommand}} in {{AsynchronousInvocationTest}}.
> ISPN-9814 removed {{StreamRequestCommand}} and also removed the blocking {{ReplicableCommand}} test from {{AsynchronousInvocationTest}}.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months
[JBoss JIRA] (ISPN-11391) AsynchronousInvocationTest doesn't cover all the commands
by Dan Berindei (Jira)
Dan Berindei created ISPN-11391:
-----------------------------------
Summary: AsynchronousInvocationTest doesn't cover all the commands
Key: ISPN-11391
URL: https://issues.redhat.com/browse/ISPN-11391
Project: Infinispan
Issue Type: Bug
Components: Core, Test Suite
Affects Versions: 11.0.0.Alpha1
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 11.0.0.Alpha2
ISPN-10362 added {{GlobalRpcCommand}}, but there is no test for {{GlobalRpcCommand}} in {{AsynchronousInvocationTest}}.
ISPN-9814 removed {{StreamRequestCommand}} and also removed the blocking {{ReplicableCommand}} test from {{AsynchronousInvocationTest}}.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 9 months