[JBoss JIRA] (ISPN-1764) Remove threadLocal in org.infinispan.context.AbstractInvocationContextContainer
by Sanne Grinovero (JIRA)
Sanne Grinovero created ISPN-1764:
-------------------------------------
Summary: Remove threadLocal in org.infinispan.context.AbstractInvocationContextContainer
Key: ISPN-1764
URL: https://issues.jboss.org/browse/ISPN-1764
Project: Infinispan
Issue Type: Enhancement
Reporter: Sanne Grinovero
Assignee: Manik Surtani
Fix For: 6.0.0.FINAL
The javadocs in org.infinispan.context.AbstractInvocationContextContainer mention:
{quote}// See ISPN-1397. There is no real need to store the InvocationContext in a thread local at all, since it is passed
// as a parameter to any component that requires it - except for two components at the moment that require reading
// the InvocationContext from a thread local. These two are the ClusterCacheLoader and the JBossMarshaller. The
// former can be fixed once the CacheStore SPI is changed to accept an InvocationContext (see ISPN-1416) and the
// latter can be fixed once the CacheManager architecture is changed to be associated with a ClassLoader per
// CacheManager (see ISPN-1413), after which this thread local can be removed and the getInvocationContext() method
// can also be removed.
{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months
[JBoss JIRA] (ISPN-1760) The default value for syncCommitPhase attribute is changed during CacheManager construction
by Mircea Markus (JIRA)
Mircea Markus created ISPN-1760:
-----------------------------------
Summary: The default value for syncCommitPhase attribute is changed during CacheManager construction
Key: ISPN-1760
URL: https://issues.jboss.org/browse/ISPN-1760
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.1.0.CR4
Reporter: Mircea Markus
Assignee: Pete Muir
Priority: Blocker
Fix For: 5.1.0.FINAL
See UT below.
{code}
public class SimplePutTest extends MultipleCacheManagersTest {
@Override
protected void createCacheManagers() throws Throwable {
ConfigurationBuilder dcc = getDefaultClusteredCacheConfig(CacheMode.DIST_SYNC, true);
dcc.transaction().transactionManagerLookup(new DummyTransactionManagerLookup());
assert dcc.build().transaction().syncCommitPhase();
createCluster(dcc, 2);
waitForClusterToForm();
//here's the failure
assert cache(0).getCacheConfiguration().transaction().syncCommitPhase();
}
public void testPut() {
cache(0).put("k","v");
}
}
{code}
Whilst this unit test is only for this particular attribute it's worth changing that the bug doesn't exhibit for other config attributes, in particular those that changed their default values from 5.0 to 5.1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 7 months