September 2012 - infinispan-issues

[JBoss JIRA] (ISPN-2123) Infinispan GUI demo fails to start cache due to deprecated xml config

by Adrian Nistor (JIRA)

11 years, 5 months

4
17
0 / 0

[JBoss JIRA] (ISPN-1586) inconsistent cache data in replication cluster with local (not shared) cache store

by dex chen (Created) (JIRA)

inconsistent cache data in replication cluster with local (not shared) cache store ---------------------------------------------------------------------------------- Key: ISPN-1586 URL: https://issues.jboss.org/browse/ISPN-1586 Project: Infinispan Issue Type: Bug Components: Core API Affects Versions: 5.0.0.FINAL Environment: ISPN 5.0.0. Final and ISPN 5.1 sanpshot Java 1.7 Linux Cent OS Reporter: dex chen Assignee: Manik Surtani I rerun my test (an embedded ISPN cluser) with ISPN 5.0.0. final and 5.1 Sanpshot code. It is configured in "replication", using local cache store, and preload=true, purgeOnStartup=false .. (see the whole config below). I will get the inconsistent data among the nodes in the following scenario: 1) start 2 node cluster 2) after the cluster is formed, add some data to the cache k1-->v1 k2-->v2 I will see the data replication working perfectly at this point. 3) bring node 2 down 4) delete entry k1-->v1 through node1 Note: At this point, on the local (persistent) cache store on the node2 have 2 entries. 5) start node2, and wait to join the cluster 6) after state merging, you will see now that node1 has 1 entry and nod2 has 2 entries. I am expecting that the data should be consistent across the cluster. Here is the infinispan config: <infinispan xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="urn:infinispan:config:5.0 http://www.infinispan.org/schemas/infinispan-config-5.0.xsd" xmlns="urn:infinispan:config:5.0"> <global> <transport clusterName="demoCluster" machineId="node1" rackId="r1" nodeName="dexlaptop" > <properties> <property name="configurationFile" value="./jgroups-tcp.xml" /> </properties> </transport> <globalJmxStatistics enabled="true"/> </global> <default> <locking isolationLevel="READ_COMMITTED" lockAcquisitionTimeout="20000" writeSkewCheck="false" concurrencyLevel="5000" useLockStriping="false" /> <jmxStatistics enabled="true"/> <clustering mode="replication"> <stateRetrieval timeout="240000" fetchInMemoryState="true" alwaysProvideInMemoryState="false" />  <sync replTimeout="20000"/> </clustering> <loaders passivation="false" shared="false" preload="true"> <loader class="org.infinispan.loaders.jdbc.stringbased.JdbcStringBasedCacheStore" fetchPersistentState="true" purgeOnStartup="false">  <properties> <property name="stringsTableNamePrefix" value="ISPN_STRING_TABLE"/> <property name="idColumnName" value="ID_COLUMN"/> <property name="dataColumnName" value="DATA_COLUMN"/> <property name="timestampColumnName" value="TIMESTAMP_COLUMN"/> <property name="timestampColumnType" value="BIGINT"/> <property name="connectionFactoryClass" value="org.infinispan.loaders.jdbc.connectionfactory.PooledConnectionFactory"/> <property name="connectionUrl" value="jdbc:h2:file:/var/tmp/h2cachestore;DB_CLOSE_DELAY=-1"/> <property name="userName" value="sa"/> <property name="driverClass" value="org.h2.Driver"/> <property name="idColumnType" value="VARCHAR(255)"/> <property name="dataColumnType" value="BINARY"/> <property name="dropTableOnExit" value="false"/> <property name="createTableOnStart" value="true"/> </properties>  </loader> </loaders> </default> </infinispan> Basically, current ISPN implementation in state transfer will result in data insistence among nodes in replication mode and each node has local cache store. I found code BaseStateTransferManagerImpl's applyState code does not remove stale data in the local cache store and result in inconsistent data when joins a cluster: Here is the code snipt of applyState(): public void applyState(Collection<InternalCacheEntry> state, Address sender, int viewId) throws InterruptedException { ..... for (InternalCacheEntry e : state) { InvocationContext ctx = icc.createInvocationContext(false, 1); // locking not necessary as during rehashing we block all transactions ctx.setFlags(CACHE_MODE_LOCAL, SKIP_CACHE_LOAD, SKIP_REMOTE_LOOKUP, SKIP_SHARED_CACHE_STORE, SKIP_LOCKING, SKIP_OWNERSHIP_CHECK); try { PutKeyValueCommand put = cf.buildPutKeyValueCommand(e.getKey(), e.getValue(), e.getLifespan(), e.getMaxIdle(), ctx.getFlags()); interceptorChain.invoke(ctx, put); } catch (Exception ee) { log.problemApplyingStateForKey(ee.getMessage(), e.getKey()); } } ... } As we can see that the code bascically try to add all data entryies got from the cluster (other node). Hence, it does not know any previous entries were deleted from the cluster which exist in its local cache store. This is exactly my test case (my confiuration is that each node has its own cache store and in replication mode). To fix this, we need to delete any entries from the local cache/cache store which no longer exist in the new state. I modified the above method by adding the following code before put loop, and it fixed the problem in my configuration: //Remove entries which no loger exist in the new state from local cache/cache store for (InternalCacheEntry ie: dataContainer.entrySet()) { if (!state.contains(ie)) { log.debug("Try to delete local store entry no loger exists in the new state: " + ie.getKey()); InvocationContext ctx = icc.createInvocationContext(false, 1); // locking not necessary as during rehashing we block all transactions ctx.setFlags(CACHE_MODE_LOCAL, SKIP_CACHE_LOAD, SKIP_REMOTE_LOOKUP, SKIP_SHARED_CACHE_STORE, SKIP_LOCKING, SKIP_OWNERSHIP_CHECK); try { RemoveCommand remove = cf.buildRemoveCommand(ie.getKey(), ie.getValue(), ctx.getFlags()); interceptorChain.invoke(ctx, remove); dataContainer.remove(ie.getKey()); } catch (Exception ee) { log.error("failed to delete local store entry", ee); } } } ... Obvious, the above "fix" is based on assumption/configure that dataContainer will have all local entries, i.e., preload=true, no enviction replication. The real fix, I think, we need delegate the syncState(state) to cache store impl, where we can check the configurations and do the right thing. For example, in the cache store impl, we can calculate the changes based on local data and new state, and apply the changes there. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

12
25
0 / 0

[JBoss JIRA] (ISPN-2280) Async cache store shutdown timeout default value should be -1

by Galder Zamarreño (JIRA)

Galder Zamarreño created ISPN-2280: -------------------------------------- Summary: Async cache store shutdown timeout default value should be -1 Key: ISPN-2280 URL: https://issues.jboss.org/browse/ISPN-2280 Project: Infinispan Issue Type: Feature Request Components: Configuration, Loaders and Stores Reporter: Galder Zamarreño Assignee: Mircea Markus Fix For: 5.2.0.Final We should strive for correctness really. Better to have someone complain about Infinispan not finishing rather than missing data in the cache store. To avoid confusion, we should wait for a bit of time, i.e. 1 minute, and then if the async store has not finished yet, log a WARN message indicating what's up, but then carry on waiting forever (or whatever the defined user time - minus the 60 seconds) by default. If the user defined timeout is less than 60 seconds, wait that long. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

2
2
0 / 0

[JBoss JIRA] (ISPN-2054) Incorrect cache size on CacheEntryCreated and pre=false

by Julio Faerman (JIRA)

Julio Faerman created ISPN-2054: ----------------------------------- Summary: Incorrect cache size on CacheEntryCreated and pre=false Key: ISPN-2054 URL: https://issues.jboss.org/browse/ISPN-2054 Project: Infinispan Issue Type: Bug Components: Listeners Affects Versions: 5.1.5.CR1 Reporter: Julio Faerman Assignee: Manik Surtani Priority: Minor I have found that on CacheEntryCreated the cache size is the same both when pre=true and pre=false, what can be wrong. The discussion can be read in the forum reference. Here is the reproducible test case: https://github.com/jfaerman/sandbox/blob/master/ispn-tests/src/test/java/... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

4
8
0 / 0

[JBoss JIRA] (ISPN-2090) Cache get from TransactionCompleted throws IllegalStateException

by Galder Zamarreño (JIRA)

Galder Zamarreño created ISPN-2090: -------------------------------------- Summary: Cache get from TransactionCompleted throws IllegalStateException Key: ISPN-2090 URL: https://issues.jboss.org/browse/ISPN-2090 Project: Infinispan Issue Type: Bug Components: Listeners, Transactions Reporter: Galder Zamarreño Assignee: Mircea Markus When implementing @TransactionCompleted in a sync listener, calling cache.get() even when event.isPre=false throws: {code}IllegalStateException - ActionStatus.COMMITTED is not in a valid state to be invoking cache operations on{code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

3
2
0 / 0

[JBoss JIRA] (ISPN-2269) Migrate deprecated configuration API in tests lucene-directory

by Thomas Fromm (JIRA)

Thomas Fromm created ISPN-2269: ---------------------------------- Summary: Migrate deprecated configuration API in tests lucene-directory Key: ISPN-2269 URL: https://issues.jboss.org/browse/ISPN-2269 Project: Infinispan Issue Type: Sub-task Components: Test Suite Affects Versions: 5.2.0.Alpha3 Reporter: Thomas Fromm Assignee: Thomas Fromm -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

1
5
0 / 0

[JBoss JIRA] (ISPN-2266) Migrate deprecated API usage in tests for hotrod-client

by Thomas Fromm (JIRA)

Thomas Fromm created ISPN-2266: ---------------------------------- Summary: Migrate deprecated API usage in tests for hotrod-client Key: ISPN-2266 URL: https://issues.jboss.org/browse/ISPN-2266 Project: Infinispan Issue Type: Enhancement Components: Test Suite Affects Versions: 5.2.0.Alpha3 Reporter: Thomas Fromm Assignee: Thomas Fromm Migrate tests to current configuration API -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

2
3
0 / 0

[JBoss JIRA] (ISPN-1830) L1: On topology changes we should propagate the key requestors information to the new owners

by Dan Berindei (JIRA)

Dan Berindei created ISPN-1830: ---------------------------------- Summary: L1: On topology changes we should propagate the key requestors information to the new owners Key: ISPN-1830 URL: https://issues.jboss.org/browse/ISPN-1830 Project: Infinispan Issue Type: Task Components: Distributed Cache Affects Versions: 5.1.0.FINAL Reporter: Dan Berindei Assignee: Manik Surtani Fix For: 5.2.0.FINAL I think we are losing information about where a key needs to be invalidated when a node changes from owner to non-owner (e.g. because another node joined): * We lose the list of requestors stored on this node. Even if all ClusteredGetCommands reached all the current owners (which we are about to change with ISPN-825), once all the current owners leave the new owners will not know about this node's old requestors. * We don't add ourselves as a requestor for the key on the new owners when we invalidate the entry and move it to L1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

2
13
0 / 0

[JBoss JIRA] (ISPN-2270) Migrate deprecated configuration API in tests query

by Thomas Fromm (JIRA)

Thomas Fromm created ISPN-2270: ---------------------------------- Summary: Migrate deprecated configuration API in tests query Key: ISPN-2270 URL: https://issues.jboss.org/browse/ISPN-2270 Project: Infinispan Issue Type: Sub-task Components: Test Suite Affects Versions: 5.2.0.Alpha3 Reporter: Thomas Fromm Assignee: Thomas Fromm -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

1
1
0 / 0

[JBoss JIRA] (ISPN-1797) Implement MongoDB based cache store

by Andrew Pushkin (JIRA)

Andrew Pushkin created ISPN-1797: ------------------------------------ Summary: Implement MongoDB based cache store Key: ISPN-1797 URL: https://issues.jboss.org/browse/ISPN-1797 Project: Infinispan Issue Type: Feature Request Components: Loaders and Stores Affects Versions: 5.1.0.FINAL Reporter: Andrew Pushkin Assignee: Manik Surtani I have an implementation to submit if you are interested. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 5 months

7
17
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues September 2012