[JBoss JIRA] (ISPN-3826) CacheResultInterceptor has no InterceptorBindingType
by Jozef Hartinger (JIRA)
[ https://issues.jboss.org/browse/ISPN-3826?page=com.atlassian.jira.plugin.... ]
Jozef Hartinger commented on ISPN-3826:
---------------------------------------
{quote}Is it possible to intercept those methods and being compliant with CDI{quote}
Yes, this is fully portable since CDI 1.0
> CacheResultInterceptor has no InterceptorBindingType
> ----------------------------------------------------
>
> Key: ISPN-3826
> URL: https://issues.jboss.org/browse/ISPN-3826
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Affects Versions: 5.3.0.Final
> Reporter: Nicolai Mainiero
> Assignee: Sebastian Łaskawiec
> Priority: Critical
>
> I'm migrating an enterprise application from JBoss AS 7 to WebSphere AS 8. We use Infinispan as Cache via the JCache API. On JBoss everything works fine. On WebSphere we get the following exception:
> org.apache.webbeans.exception.WebBeansConfigurationException: WebBeans XML configuration defined in file infinispan-jcache-5.3.0.Final.jar!/META-INF/beans.xml is failed. Reason is : Interceptor class : org.infinispan.jcache.annotation.CacheResultInterceptor must have at least one @InterceptorBindingType
> I think the cause is that there is no InterceptorBindingType in the CacheResultInterceptor as required by the specification (https://docs.jboss.org/cdi/spec/1.0/html/interceptors.html) and the CDI implementation of the WebSphere (OpenWebBeans) does not accept Interceptors without bindings.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (ISPN-3826) CacheResultInterceptor has no InterceptorBindingType
by Jozef Hartinger (JIRA)
[ https://issues.jboss.org/browse/ISPN-3826?page=com.atlassian.jira.plugin.... ]
Jozef Hartinger commented on ISPN-3826:
---------------------------------------
An interceptor always needs at least one interceptor binding. An interceptor binding is an annotation that either:
* is annotated with @InterceptorBinding, or
* is programatically registered as an interceptor binding
Since the annotation come from a third-party jar (API) you need the second option. That is actually very simple! For infinispan it is done here:
https://github.com/infinispan/infinispan/blob/15ecd4646fb8fd622b378514e25...
If this does not work on WebSphere then it must be a bug in WebSphere. I suspect that AnnotationInjectExtension is not run there for some reason or that its actions do not take effect.
> CacheResultInterceptor has no InterceptorBindingType
> ----------------------------------------------------
>
> Key: ISPN-3826
> URL: https://issues.jboss.org/browse/ISPN-3826
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Affects Versions: 5.3.0.Final
> Reporter: Nicolai Mainiero
> Assignee: Sebastian Łaskawiec
> Priority: Critical
>
> I'm migrating an enterprise application from JBoss AS 7 to WebSphere AS 8. We use Infinispan as Cache via the JCache API. On JBoss everything works fine. On WebSphere we get the following exception:
> org.apache.webbeans.exception.WebBeansConfigurationException: WebBeans XML configuration defined in file infinispan-jcache-5.3.0.Final.jar!/META-INF/beans.xml is failed. Reason is : Interceptor class : org.infinispan.jcache.annotation.CacheResultInterceptor must have at least one @InterceptorBindingType
> I think the cause is that there is no InterceptorBindingType in the CacheResultInterceptor as required by the specification (https://docs.jboss.org/cdi/spec/1.0/html/interceptors.html) and the CDI implementation of the WebSphere (OpenWebBeans) does not accept Interceptors without bindings.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (ISPN-2886) Using multiple DefaultCacheManager w/o jmx leads to JmxDomainConflictException
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-2886?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-2886:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 7.1.0.Final
Resolution: Done
> Using multiple DefaultCacheManager w/o jmx leads to JmxDomainConflictException
> ------------------------------------------------------------------------------
>
> Key: ISPN-2886
> URL: https://issues.jboss.org/browse/ISPN-2886
> Project: Infinispan
> Issue Type: Bug
> Components: JMX, reporting and management
> Affects Versions: 5.2.1.Final, 6.0.2.Final, 7.1.0.CR2
> Reporter: Thomas Fromm
> Assignee: Sebastian Łaskawiec
> Priority: Minor
> Fix For: 7.1.0.Final
>
>
> Creating multiple instances of DefaultCacheManager leads to CacheManagerJmxRegistrationTest, even when JMX is disabled in configuration.
> org.infinispan.jmx.JmxDomainConflictException: Domain already registered org.infinispan when trying to register: type=CacheManager,name="DefaultCacheManager"
> at org.infinispan.jmx.JmxUtil.buildJmxDomain(JmxUtil.java:75)
> at org.infinispan.jmx.CacheManagerJmxRegistration.updateDomain(CacheManagerJmxRegistration.java:101)
> at org.infinispan.jmx.CacheManagerJmxRegistration.buildRegistrar(CacheManagerJmxRegistration.java:95)
> at org.infinispan.jmx.AbstractJmxRegistration.registerMBeans(AbstractJmxRegistration.java:59)
> at org.infinispan.jmx.CacheManagerJmxRegistration.start(CacheManagerJmxRegistration.java:63)
> at org.infinispan.manager.DefaultCacheManager.start(DefaultCacheManager.java:705)
> at org.infinispan.manager.DefaultCacheManager.<init>(DefaultCacheManager.java:300)
> at org.infinispan.manager.DefaultCacheManager.<init>(DefaultCacheManager.java:171)
> h2. Update
> This also happens when using CDI Extension in Library mode with Wildfly. Attached Pull Request fixes that case.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (ISPN-2886) Using multiple DefaultCacheManager w/o jmx leads to JmxDomainConflictException
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-2886?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-2886:
-----------------------------------
Affects Version/s: 7.1.0.CR2
6.0.2.Final
> Using multiple DefaultCacheManager w/o jmx leads to JmxDomainConflictException
> ------------------------------------------------------------------------------
>
> Key: ISPN-2886
> URL: https://issues.jboss.org/browse/ISPN-2886
> Project: Infinispan
> Issue Type: Bug
> Components: JMX, reporting and management
> Affects Versions: 5.2.1.Final, 6.0.2.Final, 7.1.0.CR2
> Reporter: Thomas Fromm
> Assignee: Sebastian Łaskawiec
> Priority: Minor
> Fix For: 7.1.0.Final
>
>
> Creating multiple instances of DefaultCacheManager leads to CacheManagerJmxRegistrationTest, even when JMX is disabled in configuration.
> org.infinispan.jmx.JmxDomainConflictException: Domain already registered org.infinispan when trying to register: type=CacheManager,name="DefaultCacheManager"
> at org.infinispan.jmx.JmxUtil.buildJmxDomain(JmxUtil.java:75)
> at org.infinispan.jmx.CacheManagerJmxRegistration.updateDomain(CacheManagerJmxRegistration.java:101)
> at org.infinispan.jmx.CacheManagerJmxRegistration.buildRegistrar(CacheManagerJmxRegistration.java:95)
> at org.infinispan.jmx.AbstractJmxRegistration.registerMBeans(AbstractJmxRegistration.java:59)
> at org.infinispan.jmx.CacheManagerJmxRegistration.start(CacheManagerJmxRegistration.java:63)
> at org.infinispan.manager.DefaultCacheManager.start(DefaultCacheManager.java:705)
> at org.infinispan.manager.DefaultCacheManager.<init>(DefaultCacheManager.java:300)
> at org.infinispan.manager.DefaultCacheManager.<init>(DefaultCacheManager.java:171)
> h2. Update
> This also happens when using CDI Extension in Library mode with Wildfly. Attached Pull Request fixes that case.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (ISPN-3826) CacheResultInterceptor has no InterceptorBindingType
by Sebastian Łaskawiec (JIRA)
[ https://issues.jboss.org/browse/ISPN-3826?page=com.atlassian.jira.plugin.... ]
Sebastian Łaskawiec commented on ISPN-3826:
-------------------------------------------
Hey [~jharting] [~pmuir]!
Could you please tell me what's your opinion from CDI point of view?
In short:
We use [InjectedCacheRemoveAllInterceptor|https://github.com/infinispan/infinispa...] and similar classes to intercept JCache annotated methods (in this case annotated with [CacheRemoveAll|https://github.com/jsr107/jsr107spec/blob/c978d174bfc9b775...]). Those annotations does not have {{@InterceptorBinding}} annotations and are placed in 3rd party library for us.
Is it possible to intercept those methods and being compliant with CDI (1.0 or 1.1 in near future) spec?
Thanks!
> CacheResultInterceptor has no InterceptorBindingType
> ----------------------------------------------------
>
> Key: ISPN-3826
> URL: https://issues.jboss.org/browse/ISPN-3826
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Affects Versions: 5.3.0.Final
> Reporter: Nicolai Mainiero
> Assignee: Sebastian Łaskawiec
> Priority: Critical
>
> I'm migrating an enterprise application from JBoss AS 7 to WebSphere AS 8. We use Infinispan as Cache via the JCache API. On JBoss everything works fine. On WebSphere we get the following exception:
> org.apache.webbeans.exception.WebBeansConfigurationException: WebBeans XML configuration defined in file infinispan-jcache-5.3.0.Final.jar!/META-INF/beans.xml is failed. Reason is : Interceptor class : org.infinispan.jcache.annotation.CacheResultInterceptor must have at least one @InterceptorBindingType
> I think the cause is that there is no InterceptorBindingType in the CacheResultInterceptor as required by the specification (https://docs.jboss.org/cdi/spec/1.0/html/interceptors.html) and the CDI implementation of the WebSphere (OpenWebBeans) does not accept Interceptors without bindings.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (ISPN-3907) Define a Protobuf annotation for defining numeric IDs for types
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-3907?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-3907:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Define a Protobuf annotation for defining numeric IDs for types
> ---------------------------------------------------------------
>
> Key: ISPN-3907
> URL: https://issues.jboss.org/browse/ISPN-3907
> Project: Infinispan
> Issue Type: Enhancement
> Components: Embedded Querying
> Affects Versions: 6.0.0.Final
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Fix For: 7.1.0.Final
>
>
> Currently the wire format of all Protobuf encoded keys and values contains a header/envelope that has some metadata information, like the fully qualified type name (that is protobuf type name, not java) of the object encoded in the message. This information is needed so that the other end can decode the message. And we added it because the Protobuf spec assumes both ends are aware of the message type, which is not the case most of the time.
> While this approach solves the problem nicely, it becomes very inefficient is the FQN is long, which is usually the case, as people tend to stick the domain name of their company + package app name into it.
> Solution: provide alternative unique numeric IDs to all types. The IDs can be added to message type definitions in the protobuf schema and the user is in charge of guaranteeing their uniqueness while the system must check and enforce the uniqueness when a schema is registered ib the ProtobufMetadataManager. To do this we define a custom Protobuf Message type option that accepts a numeric value. If such a numeric ID was assigned to the type then when it is serialized in protobuf the system has to use this id in the header rather that the FQN string.
> This option should not be mandatory. Existing apps should work without requiring source code changes or recompiling providing that the relevant jars are upgraded in both client and server to support the new header encoding.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (ISPN-5127) LocalEntryRetrieverWithStoreAsBinaryTest.testFilterWithStoreAsBinaryPartialKeys random failures
by Sebastian Łaskawiec (JIRA)
[ https://issues.jboss.org/browse/ISPN-5127?page=com.atlassian.jira.plugin.... ]
Sebastian Łaskawiec updated ISPN-5127:
--------------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/infinispan/infinispan/pull/3209
> LocalEntryRetrieverWithStoreAsBinaryTest.testFilterWithStoreAsBinaryPartialKeys random failures
> -----------------------------------------------------------------------------------------------
>
> Key: ISPN-5127
> URL: https://issues.jboss.org/browse/ISPN-5127
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 7.1.0.Alpha1, 7.0.3.Final
> Reporter: Dan Berindei
> Assignee: William Burns
> Priority: Blocker
> Labels: testsuite_stability
> Fix For: 7.1.0.Final
>
>
> Sometimes the filtered retriever doesn't return any entries:
> {noformat}
> 15:16:26,328 ERROR (testng-LocalEntryRetrieverWithStoreAsBinaryTest:) [UnitTestTestNGListener] Test testFilterWithStoreAsBinaryPartialKeys(org.infinispan.iteration.LocalEntryRetrieverWithStoreAsBinaryTest) failed.java.util.NoSuchElementException
> at org.infinispan.iteration.impl.LocalEntryRetriever$Itr.next(LocalEntryRetriever.java:486)
> at org.infinispan.iteration.impl.LocalEntryRetriever$Itr.next(LocalEntryRetriever.java:428)
> at org.infinispan.iteration.LocalEntryRetrieverWithStoreAsBinaryTest.testFilterWithStoreAsBinaryPartialKeys(LocalEntryRetrieverWithStoreAsBinaryTest.java:93)
> {noformat}
> http://ci.infinispan.org/viewLog.html?buildId=14964
> The test should also use custom key/value types, as {{String}} keys/values are not marshalled when {{storeAsBinary}} is enabled (see {{MarshalledValue.isTypeExcluded()}}).
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (ISPN-5194) HotRod client using protocolVersion "1.3" sends 2.0 0x29 code
by Frank Suchy (JIRA)
Frank Suchy created ISPN-5194:
---------------------------------
Summary: HotRod client using protocolVersion "1.3" sends 2.0 0x29 code
Key: ISPN-5194
URL: https://issues.jboss.org/browse/ISPN-5194
Project: Infinispan
Issue Type: Bug
Affects Versions: 7.0.3.Final
Environment: Redhat Linux 2.6.18-400.1.1.el5 #1 SMP Sun Dec 14 06:01:17 EST 2014 x86_64 x86_64 x86_64 GNU/Linux
Reporter: Frank Suchy
Priority: Blocker
While testing the 7.0.3 HotRod client, I ran into a cluster view issue (that's for another bug report) so I attempted to work around it by specifying protocol version 1.3 by calling configurationBuilder.protocolVersion("1.3")
One of the operations used by the HotRod client is cache.isEmpty().
This call resulted in the HotRod client sending code 0x29 (41) to the server. The server rightly rejected it, so the client threw an exception.
Below is a snippet from the HotRod client. Note that Codec13 is setting the operation code to 0x29.
[2015-01-26 18:53:04,456 TRACE he_Timer-1 undRobinBalancingStrategy] Returning server: /10.22.6.227:11222
[2015-01-26 18:53:04,456 TRACE he_Timer-1 TcpTransportFactory ] Using the balancer for determining the server: /10.22.6.227:11222
[2015-01-26 18:53:04,456 TRACE he_Timer-1 TransportObjectFactory ] Fetching from pool: TcpTransport{socket=Socket[addr=/10.22.6.227,port=11222,localport=59868], serverAddress=/10.22.6.227:11222, id =93}
[2015-01-26 18:53:04,456 TRACE he_Timer-1 TcpTransportFactory ] For server /10.22.6.227:11222: active = 1; idle = 0
[2015-01-26 18:53:04,456 TRACE he_Timer-1 Codec13 ] Wrote header for message 3035. Operation code: 0x29. Flags: 0x0
[2015-01-26 18:53:04,458 TRACE he_Timer-1 Codec13 ] Received response for message id: 3035
[2015-01-26 18:53:04,458 TRACE he_Timer-1 Codec13 ] Received operation status: 0x82
[2015-01-26 18:53:04,458 TRACE he_Timer-1 AbstractTransport ] Read string is: org.infinispan.server.hotrod.HotRodUnknownOperationException: Unknown operation: 41
[2015-01-26 18:53:04,458 WARN he_Timer-1 Codec13 ] ISPN004005: Error received from the server: org.infinispan.server.hotrod.HotRodUnknownOperationException: Unknown operation: 41
[2015-01-26 18:53:04,459 TRACE he_Timer-1 TcpTransportFactory ] Dropping connection as it is no longer valid: TcpTransport{socket=Socket[addr=/10.22.6.227,port=11222,localport=59868], serverAddress=/10.22.6.227:11222, id =93}
[2015-01-26 18:53:04,459 TRACE he_Timer-1 TransportObjectFactory ] About to destroy tcp transport: TcpTransport{socket=Socket[addr=/10.22.6.227,port=11222,localport=59868], serverAddress=/10.22.6.227:11222, id =93}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months
[JBoss JIRA] (ISPN-5194) HotRod client using protocolVersion "1.3" sends 2.0 0x29 code
by Frank Suchy (JIRA)
[ https://issues.jboss.org/browse/ISPN-5194?page=com.atlassian.jira.plugin.... ]
Frank Suchy updated ISPN-5194:
------------------------------
Priority: Major (was: Blocker)
> HotRod client using protocolVersion "1.3" sends 2.0 0x29 code
> -------------------------------------------------------------
>
> Key: ISPN-5194
> URL: https://issues.jboss.org/browse/ISPN-5194
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 7.0.3.Final
> Environment: Redhat Linux 2.6.18-400.1.1.el5 #1 SMP Sun Dec 14 06:01:17 EST 2014 x86_64 x86_64 x86_64 GNU/Linux
> Reporter: Frank Suchy
> Labels: hotrod-java-client
>
> While testing the 7.0.3 HotRod client, I ran into a cluster view issue (that's for another bug report) so I attempted to work around it by specifying protocol version 1.3 by calling configurationBuilder.protocolVersion("1.3")
> One of the operations used by the HotRod client is cache.isEmpty().
> This call resulted in the HotRod client sending code 0x29 (41) to the server. The server rightly rejected it, so the client threw an exception.
> Below is a snippet from the HotRod client. Note that Codec13 is setting the operation code to 0x29.
> [2015-01-26 18:53:04,456 TRACE he_Timer-1 undRobinBalancingStrategy] Returning server: /10.22.6.227:11222
> [2015-01-26 18:53:04,456 TRACE he_Timer-1 TcpTransportFactory ] Using the balancer for determining the server: /10.22.6.227:11222
> [2015-01-26 18:53:04,456 TRACE he_Timer-1 TransportObjectFactory ] Fetching from pool: TcpTransport{socket=Socket[addr=/10.22.6.227,port=11222,localport=59868], serverAddress=/10.22.6.227:11222, id =93}
> [2015-01-26 18:53:04,456 TRACE he_Timer-1 TcpTransportFactory ] For server /10.22.6.227:11222: active = 1; idle = 0
> [2015-01-26 18:53:04,456 TRACE he_Timer-1 Codec13 ] Wrote header for message 3035. Operation code: 0x29. Flags: 0x0
> [2015-01-26 18:53:04,458 TRACE he_Timer-1 Codec13 ] Received response for message id: 3035
> [2015-01-26 18:53:04,458 TRACE he_Timer-1 Codec13 ] Received operation status: 0x82
> [2015-01-26 18:53:04,458 TRACE he_Timer-1 AbstractTransport ] Read string is: org.infinispan.server.hotrod.HotRodUnknownOperationException: Unknown operation: 41
> [2015-01-26 18:53:04,458 WARN he_Timer-1 Codec13 ] ISPN004005: Error received from the server: org.infinispan.server.hotrod.HotRodUnknownOperationException: Unknown operation: 41
> [2015-01-26 18:53:04,459 TRACE he_Timer-1 TcpTransportFactory ] Dropping connection as it is no longer valid: TcpTransport{socket=Socket[addr=/10.22.6.227,port=11222,localport=59868], serverAddress=/10.22.6.227:11222, id =93}
> [2015-01-26 18:53:04,459 TRACE he_Timer-1 TransportObjectFactory ] About to destroy tcp transport: TcpTransport{socket=Socket[addr=/10.22.6.227,port=11222,localport=59868], serverAddress=/10.22.6.227:11222, id =93}
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)
9 years, 2 months