[JBoss JIRA] (ISPN-5548) Realign JGroups subsystem with the one from WildFly
by Tristan Tarrant (JIRA)
Tristan Tarrant created ISPN-5548:
-------------------------------------
Summary: Realign JGroups subsystem with the one from WildFly
Key: ISPN-5548
URL: https://issues.jboss.org/browse/ISPN-5548
Project: Infinispan
Issue Type: Task
Components: Server
Reporter: Tristan Tarrant
Assignee: Tristan Tarrant
Fix For: 8.0.0.Final
The JGroups subsystem in WildFly has evolved to support forked channels and has also been including the relay support which he had grafted on.
We should rebase our own on the WildFly one, add any delta (SASL), package it to make it standalone (the WildFly one depends on a variety of clustering modules) and give it its own management model name to distinguish from the WildFly one to allow parallel installation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 5 months
[JBoss JIRA] (ISPN-5543) Bad tracef arguments are causing IllegalFormatConversionException
by Mikhail Dobrinin (JIRA)
[ https://issues.jboss.org/browse/ISPN-5543?page=com.atlassian.jira.plugin.... ]
Mikhail Dobrinin edited comment on ISPN-5543 at 6/12/15 3:45 PM:
-----------------------------------------------------------------
Log4j looks like it catches the exception, but still would be nice to have the logging be correct.
was (Author: mdobrinin):
Looks like these could impair functionality since it throws a RuntimeException and the next interceptors don't get a chance to execute.
> Bad tracef arguments are causing IllegalFormatConversionException
> -----------------------------------------------------------------
>
> Key: ISPN-5543
> URL: https://issues.jboss.org/browse/ISPN-5543
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 7.0.4.Final, 7.1.1.Final, 7.2.3.Final, 8.0.0.Beta2
> Environment: Infinispan-embedded-7.0.3
> log4j2-2.1
> Reporter: Mikhail Dobrinin
>
> There are two examples of this that I see consistently.
> {noformat}
> 2015-05-28 11:07:53,508 ERROR Unable to format msg: Retrying command because of topology change, current topology is %d: %s java.util.IllegalFormatConversionException: d != org.infinispan.commands.write.RemoveCommand
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4045)
> at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2748)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2702)
> at java.util.Formatter.format(Formatter.java:2488)
> at java.util.Formatter.format(Formatter.java:2423)
> at java.lang.String.format(String.java:2797)
> at org.apache.logging.log4j.message.StringFormattedMessage.formatMessage(StringFormattedMessage.java:88)
> at org.apache.logging.log4j.message.StringFormattedMessage.getFormattedMessage(StringFormattedMessage.java:60)
> at org.apache.logging.log4j.core.async.AsyncLoggerConfigHelper.callAppendersFromAnotherThread(AsyncLoggerConfigHelper.java:340)
> at org.apache.logging.log4j.core.async.AsyncLoggerConfig.callAppenders(AsyncLoggerConfig.java:114)
> at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:409)
> at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:367)
> at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:112)
> at infinispan.org.jboss.logging.Log4j2Logger.doLogf(Log4j2Logger.java:66)
> at infinispan.org.jboss.logging.Logger.logf(Logger.java:2398)
> at infinispan.org.jboss.logging.DelegatingBasicLogger.tracef(DelegatingBasicLogger.java:124)
> at org.infinispan.statetransfer.StateTransferInterceptor.handleNonTxWriteCommand(StateTransferInterceptor.java:199)
> at org.infinispan.statetransfer.StateTransferInterceptor.visitRemoveCommand(StateTransferInterceptor.java:123)
> {noformat}
> {noformat}
> 2015-05-28 11:08:37,738 ERROR Unable to format msg: Skip load for command %s? %s java.util.MissingFormatArgumentException: Format specifier 's'
> at java.util.Formatter.format(Formatter.java:2487)
> at java.util.Formatter.format(Formatter.java:2423)
> at java.lang.String.format(String.java:2797)
> at org.apache.logging.log4j.message.StringFormattedMessage.formatMessage(StringFormattedMessage.java:88)
> at org.apache.logging.log4j.message.StringFormattedMessage.getFormattedMessage(StringFormattedMessage.java:60)
> at org.apache.logging.log4j.core.async.AsyncLoggerConfigHelper.callAppendersFromAnotherThread(AsyncLoggerConfigHelper.java:340)
> at org.apache.logging.log4j.core.async.AsyncLoggerConfig.callAppenders(AsyncLoggerConfig.java:114)
> at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:409)
> at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:367)
> at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:112)
> at infinispan.org.jboss.logging.Log4j2Logger.doLogf(Log4j2Logger.java:66)
> at infinispan.org.jboss.logging.Logger.logf(Logger.java:2398)
> at infinispan.org.jboss.logging.DelegatingBasicLogger.tracef(DelegatingBasicLogger.java:124)
> at org.infinispan.interceptors.ClusteredCacheLoaderInterceptor.skipLoadForNonTxCommand(ClusteredCacheLoaderInterceptor.java:63)
> at org.infinispan.interceptors.ClusteredCacheLoaderInterceptor.skipLoadForWriteCommand(ClusteredCacheLoaderInterceptor.java:44)
> at org.infinispan.interceptors.CacheLoaderInterceptor.skipLoad(CacheLoaderInterceptor.java:265)
> at org.infinispan.interceptors.CacheLoaderInterceptor.loadIfNeeded(CacheLoaderInterceptor.java:230)
> at org.infinispan.interceptors.CacheLoaderInterceptor.visitInvalidateCommand(CacheLoaderInterceptor.java:144)
> at org.infinispan.commands.write.InvalidateCommand.acceptVisitor(InvalidateCommand.java:113)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 5 months
[JBoss JIRA] (ISPN-5543) Bad tracef arguments are causing IllegalFormatConversionException
by Mikhail Dobrinin (JIRA)
[ https://issues.jboss.org/browse/ISPN-5543?page=com.atlassian.jira.plugin.... ]
Mikhail Dobrinin commented on ISPN-5543:
----------------------------------------
Looks like these could impair functionality since it throws a RuntimeException and the next interceptors don't get a chance to execute.
> Bad tracef arguments are causing IllegalFormatConversionException
> -----------------------------------------------------------------
>
> Key: ISPN-5543
> URL: https://issues.jboss.org/browse/ISPN-5543
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 7.0.4.Final, 7.1.1.Final, 7.2.3.Final, 8.0.0.Beta2
> Environment: Infinispan-embedded-7.0.3
> log4j2-2.1
> Reporter: Mikhail Dobrinin
>
> There are two examples of this that I see consistently.
> {noformat}
> 2015-05-28 11:07:53,508 ERROR Unable to format msg: Retrying command because of topology change, current topology is %d: %s java.util.IllegalFormatConversionException: d != org.infinispan.commands.write.RemoveCommand
> at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4045)
> at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2748)
> at java.util.Formatter$FormatSpecifier.print(Formatter.java:2702)
> at java.util.Formatter.format(Formatter.java:2488)
> at java.util.Formatter.format(Formatter.java:2423)
> at java.lang.String.format(String.java:2797)
> at org.apache.logging.log4j.message.StringFormattedMessage.formatMessage(StringFormattedMessage.java:88)
> at org.apache.logging.log4j.message.StringFormattedMessage.getFormattedMessage(StringFormattedMessage.java:60)
> at org.apache.logging.log4j.core.async.AsyncLoggerConfigHelper.callAppendersFromAnotherThread(AsyncLoggerConfigHelper.java:340)
> at org.apache.logging.log4j.core.async.AsyncLoggerConfig.callAppenders(AsyncLoggerConfig.java:114)
> at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:409)
> at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:367)
> at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:112)
> at infinispan.org.jboss.logging.Log4j2Logger.doLogf(Log4j2Logger.java:66)
> at infinispan.org.jboss.logging.Logger.logf(Logger.java:2398)
> at infinispan.org.jboss.logging.DelegatingBasicLogger.tracef(DelegatingBasicLogger.java:124)
> at org.infinispan.statetransfer.StateTransferInterceptor.handleNonTxWriteCommand(StateTransferInterceptor.java:199)
> at org.infinispan.statetransfer.StateTransferInterceptor.visitRemoveCommand(StateTransferInterceptor.java:123)
> {noformat}
> {noformat}
> 2015-05-28 11:08:37,738 ERROR Unable to format msg: Skip load for command %s? %s java.util.MissingFormatArgumentException: Format specifier 's'
> at java.util.Formatter.format(Formatter.java:2487)
> at java.util.Formatter.format(Formatter.java:2423)
> at java.lang.String.format(String.java:2797)
> at org.apache.logging.log4j.message.StringFormattedMessage.formatMessage(StringFormattedMessage.java:88)
> at org.apache.logging.log4j.message.StringFormattedMessage.getFormattedMessage(StringFormattedMessage.java:60)
> at org.apache.logging.log4j.core.async.AsyncLoggerConfigHelper.callAppendersFromAnotherThread(AsyncLoggerConfigHelper.java:340)
> at org.apache.logging.log4j.core.async.AsyncLoggerConfig.callAppenders(AsyncLoggerConfig.java:114)
> at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:409)
> at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:367)
> at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:112)
> at infinispan.org.jboss.logging.Log4j2Logger.doLogf(Log4j2Logger.java:66)
> at infinispan.org.jboss.logging.Logger.logf(Logger.java:2398)
> at infinispan.org.jboss.logging.DelegatingBasicLogger.tracef(DelegatingBasicLogger.java:124)
> at org.infinispan.interceptors.ClusteredCacheLoaderInterceptor.skipLoadForNonTxCommand(ClusteredCacheLoaderInterceptor.java:63)
> at org.infinispan.interceptors.ClusteredCacheLoaderInterceptor.skipLoadForWriteCommand(ClusteredCacheLoaderInterceptor.java:44)
> at org.infinispan.interceptors.CacheLoaderInterceptor.skipLoad(CacheLoaderInterceptor.java:265)
> at org.infinispan.interceptors.CacheLoaderInterceptor.loadIfNeeded(CacheLoaderInterceptor.java:230)
> at org.infinispan.interceptors.CacheLoaderInterceptor.visitInvalidateCommand(CacheLoaderInterceptor.java:144)
> at org.infinispan.commands.write.InvalidateCommand.acceptVisitor(InvalidateCommand.java:113)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 5 months
[JBoss JIRA] (ISPN-3899) XAResourceRecovery implementation needed for transaction recovery in library mode
by Ion Savin (JIRA)
[ https://issues.jboss.org/browse/ISPN-3899?page=com.atlassian.jira.plugin.... ]
Ion Savin reassigned ISPN-3899:
-------------------------------
Assignee: (was: Ion Savin)
> XAResourceRecovery implementation needed for transaction recovery in library mode
> ---------------------------------------------------------------------------------
>
> Key: ISPN-3899
> URL: https://issues.jboss.org/browse/ISPN-3899
> Project: Infinispan
> Issue Type: Bug
> Components: Transactions
> Reporter: Galder Zamarreño
>
> According to [~pferraro], an implementation of XAResourceRecovery needs to be added to Infinispan and plugged into XAResourceRecoveryRegistry in order to get recovery of XA transactions working as expected.
> This is already done in Server/AS/Wildfly in org.jboss.as.clustering.infinispan.subsystem.CacheService class.
> A similar thing should happen when Infinispan is used in embedded/library mode.
> [~isavin], since you are going to work on the transaction changes in 7.0, maybe you can take this on too? It'd be interesting to add a test to start with which shows that XA transaction recovery is not working as expected as a result of not having this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 5 months
[JBoss JIRA] (ISPN-5547) Get MarshalledValue when iterating the persistent cache with storeAsBinary set to true
by Fei Chen (JIRA)
Fei Chen created ISPN-5547:
------------------------------
Summary: Get MarshalledValue when iterating the persistent cache with storeAsBinary set to true
Key: ISPN-5547
URL: https://issues.jboss.org/browse/ISPN-5547
Project: Infinispan
Issue Type: Bug
Components: Core
Affects Versions: 7.1.1.Final
Reporter: Fei Chen
Please see https://developer.jboss.org/thread/258545 for details. The key issue is:
The ClassCastException happens when trying to iterator the cache:
06:54:47,057 ERROR [org.jboss.as.ejb3.invocation] (http-localhost/127.0.0.1:8680-1) JBAS014134: EJB Invocation failed on component PublishManagerLocalBean for method public abstract java.util.Set com.test.PublishManager.getChannels(): javax.ejb.EJBException: java.lang.ClassCastException: org.infinispan.marshall.core.MarshalledValue cannot be cast to com.test.Channel
The problem is: I store only one entry into the cache. But afterwards when iterating the cache, 2 entries are returned. One entry is with type Channel which looks correct, but there is another entry with type MarshalledValue.
After a few investigation, we see this issue only happens when the 1. cache is persistent and 2. storeAsBinary is enabled.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 5 months
[JBoss JIRA] (ISPN-5459) StateTransferManager.waitForInitialTransferToComplete can fail if the coordinator crashes
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-5459?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-5459:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> StateTransferManager.waitForInitialTransferToComplete can fail if the coordinator crashes
> -----------------------------------------------------------------------------------------
>
> Key: ISPN-5459
> URL: https://issues.jboss.org/browse/ISPN-5459
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 7.2.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 8.0.0.Alpha2
>
>
> {{LocalTopologyManagerImpl.isRebalancingEnabled()}} will throw a {{SuspectException}} if the coordinator crashes, preventing the cache from starting up.
> This is causing random failures in {{ClusterListenerDistTxAddListenerTest}}:
> {noformat}
> 22:23:59,439 ERROR (testng-ClusterListenerDistTxAddListenerTest:) [UnitTestTestNGListener] Test testNodeJoiningAndStateNodeDiesWithExistingClusterListener(org.infinispan.notifications.cachelistener.cluster.ClusterListenerDistTxAddListenerTest) failed.
> java.util.concurrent.ExecutionException: org.infinispan.commons.CacheException: Unable to invoke method public void org.infinispan.statetransfer.StateTransferManagerImpl.waitForInitialStateTransferToComplete() throws java.lang.Exception on object of type StateTransferManagerImpl
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> at java.util.concurrent.FutureTask.get(FutureTask.java:202)
> at org.infinispan.notifications.cachelistener.cluster.AbstractClusterListenerDistAddListenerTest.testNodeJoiningAndStateNodeDiesWithExistingClusterListener(AbstractClusterListenerDistAddListenerTest.java:254)
> ...
> Caused by: org.infinispan.commons.CacheException: Unable to invoke method public void org.infinispan.statetransfer.StateTransferManagerImpl.waitForInitialStateTransferToComplete() throws java.lang.Exception on object of type StateTransferManagerImpl
> at org.infinispan.commons.util.ReflectionUtil.invokeAccessibly(ReflectionUtil.java:172)
> at org.infinispan.factories.AbstractComponentRegistry$PrioritizedMethod.invoke(AbstractComponentRegistry.java:869)
> at org.infinispan.factories.AbstractComponentRegistry.invokeStartMethods(AbstractComponentRegistry.java:638)
> at org.infinispan.factories.AbstractComponentRegistry.internalStart(AbstractComponentRegistry.java:627)
> at org.infinispan.factories.AbstractComponentRegistry.start(AbstractComponentRegistry.java:530)
> at org.infinispan.factories.ComponentRegistry.start(ComponentRegistry.java:218)
> at org.infinispan.cache.impl.CacheImpl.start(CacheImpl.java:850)
> at org.infinispan.manager.DefaultCacheManager.wireAndStartCache(DefaultCacheManager.java:599)
> at org.infinispan.manager.DefaultCacheManager.createCache(DefaultCacheManager.java:554)
> at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:424)
> at org.infinispan.test.MultipleCacheManagersTest.cache(MultipleCacheManagersTest.java:366)
> at org.infinispan.notifications.cachelistener.cluster.AbstractClusterListenerDistAddListenerTest.access$100(AbstractClusterListenerDistAddListenerTest.java:32)
> at org.infinispan.notifications.cachelistener.cluster.AbstractClusterListenerDistAddListenerTest$4.call(AbstractClusterListenerDistAddListenerTest.java:237)
> at org.infinispan.notifications.cachelistener.cluster.AbstractClusterListenerDistAddListenerTest$4.call(AbstractClusterListenerDistAddListenerTest.java:234)
> at org.infinispan.test.AbstractInfinispanTest$LoggingCallable.call(AbstractInfinispanTest.java:422)
> ... 4 more
> Caused by: org.infinispan.remoting.transport.jgroups.SuspectException: Node NodeM-34961 was suspected
> at org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher.invokeRemoteCommand(CommandAwareRpcDispatcher.java:245)
> at org.infinispan.remoting.transport.jgroups.JGroupsTransport.invokeRemotely(JGroupsTransport.java:566)
> at org.infinispan.topology.LocalTopologyManagerImpl.executeOnCoordinator(LocalTopologyManagerImpl.java:501)
> at org.infinispan.topology.LocalTopologyManagerImpl.isRebalancingEnabled(LocalTopologyManagerImpl.java:445)
> at org.infinispan.statetransfer.StateTransferManagerImpl.waitForInitialStateTransferToComplete(StateTransferManagerImpl.java:216)
> at sun.reflect.GeneratedMethodAccessor165.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.infinispan.commons.util.ReflectionUtil.invokeAccessibly(ReflectionUtil.java:168)
> ... 18 more
> Caused by: SuspectedException
> at org.jgroups.blocks.MessageDispatcher.sendMessage(MessageDispatcher.java:414)
> at org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher.processSingleCall(CommandAwareRpcDispatcher.java:427)
> at org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher.invokeRemoteCommand(CommandAwareRpcDispatcher.java:240)
> ... 26 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 5 months
[JBoss JIRA] (ISPN-5529) ClusterListenerReplTest.testPrimaryOwnerGoesDownAfterBackupRaisesEvent random failures
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-5529?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-5529:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> ClusterListenerReplTest.testPrimaryOwnerGoesDownAfterBackupRaisesEvent random failures
> --------------------------------------------------------------------------------------
>
> Key: ISPN-5529
> URL: https://issues.jboss.org/browse/ISPN-5529
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Test Suite - Core
> Affects Versions: 7.2.2.Final, 8.0.0.Alpha1
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Blocker
> Labels: testsuite_stability
> Fix For: 8.0.0.Alpha2
>
>
> Because the cache is replicated, both cache 0 or cache 2 are backup owners of the tested key, and both of them can become primary owners after cache 1 is killed. If cache 0 becomes the primary owner, {{cache.put(key, FIRST_VALUE)}} may return {{null}} and/or the cluster listener may receive only one event:
> {noformat}
> java.lang.AssertionError: expected:<null> but was:<first-value>
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:101)
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:108)
> at org.infinispan.notifications.cachelistener.cluster.ClusterListenerReplTest.testPrimaryOwnerGoesDownAfterBackupRaisesEvent(ClusterListenerReplTest.java:119)
> {noformat}
> {noformat}
> 12:23:53,438 ERROR (testng-ClusterListenerReplTest:) [UnitTestTestNGListener] Test testPrimaryOwnerGoesDownAfterBackupRaisesEvent(org.infinispan.notifications.cachelistener.cluster.ClusterListenerReplTest) failed.java.lang.AssertionError: expected:<1> but was:<2>
> at org.testng.AssertJUnit.fail(AssertJUnit.java:59)
> at org.testng.AssertJUnit.failNotEquals(AssertJUnit.java:364)
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:80)
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:245)
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:252)
> at org.infinispan.notifications.cachelistener.cluster.ClusterListenerReplTest.testPrimaryOwnerGoesDownAfterBackupRaisesEvent(ClusterListenerReplTest.java:121)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 5 months