[JBoss JIRA] (ISPN-6686) Improve fluency of persistent store configuration builders
by Krzysztof Sobolewski (JIRA)
[ https://issues.jboss.org/browse/ISPN-6686?page=com.atlassian.jira.plugin.... ]
Krzysztof Sobolewski updated ISPN-6686:
---------------------------------------
Summary: Improve fluency of persistent store configuration builders (was: Improve fluidity of persistent store configuration builders)
> Improve fluency of persistent store configuration builders
> ----------------------------------------------------------
>
> Key: ISPN-6686
> URL: https://issues.jboss.org/browse/ISPN-6686
> Project: Infinispan
> Issue Type: Enhancement
> Components: Configuration, Loaders and Stores
> Affects Versions: 8.2.2.Final
> Reporter: Krzysztof Sobolewski
>
> Configuration of cache stores has some fluidity issues. I'd like to do:
> {code:java}
> ConfigurationBuilder builder = ...;
> builder
> .persistence()
> .addStore(JdbcStringBasedStoreConfigurationBuilder.class)
> .dialect(...)
> .table() // <- compilation error
> ...
> .connectionPool() // <- compilation error
> ...;
> {code}
> but I'm forced to do:
> {code:java}
> ConfigurationBuilder builder = ...;
> JdbcStringBasedStoreConfigurationBuilder store = builder
> .persistence()
> .addStore(JdbcStringBasedStoreConfigurationBuilder.class)
> .dialect(...);
> store
> .table()
> ...;
> store
> .connectionPool()
> ...;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6686) Improve fluency of persistent store configuration builders
by Krzysztof Sobolewski (JIRA)
[ https://issues.jboss.org/browse/ISPN-6686?page=com.atlassian.jira.plugin.... ]
Krzysztof Sobolewski updated ISPN-6686:
---------------------------------------
Description:
Configuration of cache stores has some fluency issues. I'd like to do:
{code:java}
ConfigurationBuilder builder = ...;
builder
.persistence()
.addStore(JdbcStringBasedStoreConfigurationBuilder.class)
.dialect(...)
.table() // <- compilation error
...
.connectionPool() // <- compilation error
...;
{code}
but I'm forced to do:
{code:java}
ConfigurationBuilder builder = ...;
JdbcStringBasedStoreConfigurationBuilder store = builder
.persistence()
.addStore(JdbcStringBasedStoreConfigurationBuilder.class)
.dialect(...);
store
.table()
...;
store
.connectionPool()
...;
{code}
was:
Configuration of cache stores has some fluidity issues. I'd like to do:
{code:java}
ConfigurationBuilder builder = ...;
builder
.persistence()
.addStore(JdbcStringBasedStoreConfigurationBuilder.class)
.dialect(...)
.table() // <- compilation error
...
.connectionPool() // <- compilation error
...;
{code}
but I'm forced to do:
{code:java}
ConfigurationBuilder builder = ...;
JdbcStringBasedStoreConfigurationBuilder store = builder
.persistence()
.addStore(JdbcStringBasedStoreConfigurationBuilder.class)
.dialect(...);
store
.table()
...;
store
.connectionPool()
...;
{code}
> Improve fluency of persistent store configuration builders
> ----------------------------------------------------------
>
> Key: ISPN-6686
> URL: https://issues.jboss.org/browse/ISPN-6686
> Project: Infinispan
> Issue Type: Enhancement
> Components: Configuration, Loaders and Stores
> Affects Versions: 8.2.2.Final
> Reporter: Krzysztof Sobolewski
>
> Configuration of cache stores has some fluency issues. I'd like to do:
> {code:java}
> ConfigurationBuilder builder = ...;
> builder
> .persistence()
> .addStore(JdbcStringBasedStoreConfigurationBuilder.class)
> .dialect(...)
> .table() // <- compilation error
> ...
> .connectionPool() // <- compilation error
> ...;
> {code}
> but I'm forced to do:
> {code:java}
> ConfigurationBuilder builder = ...;
> JdbcStringBasedStoreConfigurationBuilder store = builder
> .persistence()
> .addStore(JdbcStringBasedStoreConfigurationBuilder.class)
> .dialect(...);
> store
> .table()
> ...;
> store
> .connectionPool()
> ...;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6754) Get rid of feature and deprecation warnings when compiling Hotrod server
by Vojtech Juranek (JIRA)
[ https://issues.jboss.org/browse/ISPN-6754?page=com.atlassian.jira.plugin.... ]
Vojtech Juranek updated ISPN-6754:
----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/4395
> Get rid of feature and deprecation warnings when compiling Hotrod server
> ------------------------------------------------------------------------
>
> Key: ISPN-6754
> URL: https://issues.jboss.org/browse/ISPN-6754
> Project: Infinispan
> Issue Type: Task
> Components: Server
> Reporter: Vojtech Juranek
> Assignee: Vojtech Juranek
> Priority: Minor
>
> there's couple of feature and deprecation warning when compiling Hotrod server:
> {noformat}
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/iteration/IterationManager.scala:120: warning: inferred existential type Option[org.infinispan.filter.KeyValueFilterConverterFactory[_$2,_$3,_$4]] forSome { type _$2; type _$3; type _$4 }, which cannot be expressed by wildcards, should be enabled
> [INFO] by making the implicit value scala.language.existentials visible.
> [INFO] This can be achieved by adding the import clause 'import scala.language.existentials'
> [INFO] or by setting the compiler option -language:existentials.
> [INFO] See the Scala docs for value scala.language.existentials for a discussion
> [INFO] why the feature should be explicitly enabled.
> [INFO] Option(filterConverterFactoryMap.get(name)).orElse(throw log.missingKeyValueFilterConverterFactory(name))
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/iteration/IterationManager.scala:123: warning: inferred existential type Some[(org.infinispan.filter.KeyValueFilterConverter[_$5,_$6,_$7], Boolean)] forSome { type _$5; type _$6; type _$7 }, which cannot be expressed by wildcards, should be enabled
> [INFO] by making the implicit value scala.language.existentials visible.
> [INFO] factory match {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:21: warning: implicit conversion method asScalaFunction should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] This can be achieved by adding the import clause 'import scala.language.implicitConversions'
> [INFO] or by setting the compiler option -language:implicitConversions.
> [INFO] See the Scala docs for value scala.language.implicitConversions for a discussion
> [INFO] why the feature should be explicitly enabled.
> [INFO] implicit def asScalaFunction[T, U](f: J8Function[T, U]): T => U = new Function[T, U] {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:25: warning: implicit conversion method asJavaFunction should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] implicit def asJavaFunction[T, U](f: T => U): J8Function[T, U] = new J8Function[T, U] {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:29: warning: implicit conversion method asJavaConsumer should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] implicit def asJavaConsumer[T](f: T => Unit): J8Consumer[T] = new J8Consumer[T] {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:33: warning: implicit conversion method asJavaBiConsumer should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] implicit def asJavaBiConsumer[T, U](f: (T, U) => Unit): J8BiConsumer[T, U] = new J8BiConsumer[T, U] {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:37: warning: implicit conversion method asJavaRunnable should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] implicit def asJavaRunnable(f: () => Unit): Runnable = new Runnable {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/AbstractTopologyAwareEncoder1x.scala:24: warning: method numVirtualNodes in class HashConfiguration is deprecated: see corresponding Javadoc for more information.
> [INFO] cfg.clustering().hash().numVirtualNodes())
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/AbstractTopologyAwareEncoder1x.scala:125: warning: method getHashFunction in trait ConsistentHash is deprecated: see corresponding Javadoc for more information.
> [INFO] val normalizedHash = ch.getHashFunction.hash(i) & Integer.MAX_VALUE
> [INFO] ^
> [WARNING] 9 warnings found
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6754) Get rid of feature and deprecation warnings when compiling Hotrod server
by Vojtech Juranek (JIRA)
[ https://issues.jboss.org/browse/ISPN-6754?page=com.atlassian.jira.plugin.... ]
Vojtech Juranek updated ISPN-6754:
----------------------------------
Status: Open (was: New)
> Get rid of feature and deprecation warnings when compiling Hotrod server
> ------------------------------------------------------------------------
>
> Key: ISPN-6754
> URL: https://issues.jboss.org/browse/ISPN-6754
> Project: Infinispan
> Issue Type: Task
> Components: Server
> Reporter: Vojtech Juranek
> Assignee: Vojtech Juranek
> Priority: Minor
>
> there's couple of feature and deprecation warning when compiling Hotrod server:
> {noformat}
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/iteration/IterationManager.scala:120: warning: inferred existential type Option[org.infinispan.filter.KeyValueFilterConverterFactory[_$2,_$3,_$4]] forSome { type _$2; type _$3; type _$4 }, which cannot be expressed by wildcards, should be enabled
> [INFO] by making the implicit value scala.language.existentials visible.
> [INFO] This can be achieved by adding the import clause 'import scala.language.existentials'
> [INFO] or by setting the compiler option -language:existentials.
> [INFO] See the Scala docs for value scala.language.existentials for a discussion
> [INFO] why the feature should be explicitly enabled.
> [INFO] Option(filterConverterFactoryMap.get(name)).orElse(throw log.missingKeyValueFilterConverterFactory(name))
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/iteration/IterationManager.scala:123: warning: inferred existential type Some[(org.infinispan.filter.KeyValueFilterConverter[_$5,_$6,_$7], Boolean)] forSome { type _$5; type _$6; type _$7 }, which cannot be expressed by wildcards, should be enabled
> [INFO] by making the implicit value scala.language.existentials visible.
> [INFO] factory match {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:21: warning: implicit conversion method asScalaFunction should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] This can be achieved by adding the import clause 'import scala.language.implicitConversions'
> [INFO] or by setting the compiler option -language:implicitConversions.
> [INFO] See the Scala docs for value scala.language.implicitConversions for a discussion
> [INFO] why the feature should be explicitly enabled.
> [INFO] implicit def asScalaFunction[T, U](f: J8Function[T, U]): T => U = new Function[T, U] {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:25: warning: implicit conversion method asJavaFunction should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] implicit def asJavaFunction[T, U](f: T => U): J8Function[T, U] = new J8Function[T, U] {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:29: warning: implicit conversion method asJavaConsumer should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] implicit def asJavaConsumer[T](f: T => Unit): J8Consumer[T] = new J8Consumer[T] {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:33: warning: implicit conversion method asJavaBiConsumer should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] implicit def asJavaBiConsumer[T, U](f: (T, U) => Unit): J8BiConsumer[T, U] = new J8BiConsumer[T, U] {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:37: warning: implicit conversion method asJavaRunnable should be enabled
> [INFO] by making the implicit value scala.language.implicitConversions visible.
> [INFO] implicit def asJavaRunnable(f: () => Unit): Runnable = new Runnable {
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/AbstractTopologyAwareEncoder1x.scala:24: warning: method numVirtualNodes in class HashConfiguration is deprecated: see corresponding Javadoc for more information.
> [INFO] cfg.clustering().hash().numVirtualNodes())
> [INFO] ^
> [WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/AbstractTopologyAwareEncoder1x.scala:125: warning: method getHashFunction in trait ConsistentHash is deprecated: see corresponding Javadoc for more information.
> [INFO] val normalizedHash = ch.getHashFunction.hash(i) & Integer.MAX_VALUE
> [INFO] ^
> [WARNING] 9 warnings found
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6754) Get rid of feature and deprecation warnings when compiling Hotrod server
by Vojtech Juranek (JIRA)
Vojtech Juranek created ISPN-6754:
-------------------------------------
Summary: Get rid of feature and deprecation warnings when compiling Hotrod server
Key: ISPN-6754
URL: https://issues.jboss.org/browse/ISPN-6754
Project: Infinispan
Issue Type: Task
Components: Server
Reporter: Vojtech Juranek
Assignee: Vojtech Juranek
Priority: Minor
there's couple of feature and deprecation warning when compiling Hotrod server:
{noformat}
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/iteration/IterationManager.scala:120: warning: inferred existential type Option[org.infinispan.filter.KeyValueFilterConverterFactory[_$2,_$3,_$4]] forSome { type _$2; type _$3; type _$4 }, which cannot be expressed by wildcards, should be enabled
[INFO] by making the implicit value scala.language.existentials visible.
[INFO] This can be achieved by adding the import clause 'import scala.language.existentials'
[INFO] or by setting the compiler option -language:existentials.
[INFO] See the Scala docs for value scala.language.existentials for a discussion
[INFO] why the feature should be explicitly enabled.
[INFO] Option(filterConverterFactoryMap.get(name)).orElse(throw log.missingKeyValueFilterConverterFactory(name))
[INFO] ^
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/iteration/IterationManager.scala:123: warning: inferred existential type Some[(org.infinispan.filter.KeyValueFilterConverter[_$5,_$6,_$7], Boolean)] forSome { type _$5; type _$6; type _$7 }, which cannot be expressed by wildcards, should be enabled
[INFO] by making the implicit value scala.language.existentials visible.
[INFO] factory match {
[INFO] ^
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:21: warning: implicit conversion method asScalaFunction should be enabled
[INFO] by making the implicit value scala.language.implicitConversions visible.
[INFO] This can be achieved by adding the import clause 'import scala.language.implicitConversions'
[INFO] or by setting the compiler option -language:implicitConversions.
[INFO] See the Scala docs for value scala.language.implicitConversions for a discussion
[INFO] why the feature should be explicitly enabled.
[INFO] implicit def asScalaFunction[T, U](f: J8Function[T, U]): T => U = new Function[T, U] {
[INFO] ^
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:25: warning: implicit conversion method asJavaFunction should be enabled
[INFO] by making the implicit value scala.language.implicitConversions visible.
[INFO] implicit def asJavaFunction[T, U](f: T => U): J8Function[T, U] = new J8Function[T, U] {
[INFO] ^
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:29: warning: implicit conversion method asJavaConsumer should be enabled
[INFO] by making the implicit value scala.language.implicitConversions visible.
[INFO] implicit def asJavaConsumer[T](f: T => Unit): J8Consumer[T] = new J8Consumer[T] {
[INFO] ^
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:33: warning: implicit conversion method asJavaBiConsumer should be enabled
[INFO] by making the implicit value scala.language.implicitConversions visible.
[INFO] implicit def asJavaBiConsumer[T, U](f: (T, U) => Unit): J8BiConsumer[T, U] = new J8BiConsumer[T, U] {
[INFO] ^
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/package.scala:37: warning: implicit conversion method asJavaRunnable should be enabled
[INFO] by making the implicit value scala.language.implicitConversions visible.
[INFO] implicit def asJavaRunnable(f: () => Unit): Runnable = new Runnable {
[INFO] ^
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/AbstractTopologyAwareEncoder1x.scala:24: warning: method numVirtualNodes in class HashConfiguration is deprecated: see corresponding Javadoc for more information.
[INFO] cfg.clustering().hash().numVirtualNodes())
[INFO] ^
[WARNING] /home/vjuranek/ws-idea/infinispan/server/hotrod/src/main/scala/org/infinispan/server/hotrod/AbstractTopologyAwareEncoder1x.scala:125: warning: method getHashFunction in trait ConsistentHash is deprecated: see corresponding Javadoc for more information.
[INFO] val normalizedHash = ch.getHashFunction.hash(i) & Integer.MAX_VALUE
[INFO] ^
[WARNING] 9 warnings found
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6753) Ignore cache not found on remote when using invalidation caches
by Karl von Randow (JIRA)
Karl von Randow created ISPN-6753:
-------------------------------------
Summary: Ignore cache not found on remote when using invalidation caches
Key: ISPN-6753
URL: https://issues.jboss.org/browse/ISPN-6753
Project: Infinispan
Issue Type: Enhancement
Components: Core
Affects Versions: 8.2.2.Final
Reporter: Karl von Randow
We are using Infinispan as a 2LC for Hibernate. Cache regions are dynamically created, named for Hibernate entities. They clone the {{entity}} cache configuration and create new regions. This works great.
We have a cluster of five application servers, each running the same stack and participating in the invalidation cluster.
When we roll out a new version across our application servers we sometimes add, remove or rename entities. If we've removed an entity this causes that cache to not exist on the newly updated application server. This causes the other application servers, not yet updated, to try to send invalidation messages to the new one and when they discover that the cache isn't running they throw a {{SuspectException}} and start to fail.
In {{AbstractTransport}} there is an option to ignore the {{CacheNotFoundResponse}}. That does not appear to be set in my case. I haven't found a configuration option to have this set. With apologies if it is already available: Would it be possible to add an option to ignore the cache not found responses?
If it is something that should be added I am happy to attempt to supply a PR.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years
[JBoss JIRA] (ISPN-6752) Add cache name to CacheNotFoundResponse
by Karl von Randow (JIRA)
Karl von Randow created ISPN-6752:
-------------------------------------
Summary: Add cache name to CacheNotFoundResponse
Key: ISPN-6752
URL: https://issues.jboss.org/browse/ISPN-6752
Project: Infinispan
Issue Type: Enhancement
Components: Core
Affects Versions: 8.2.2.Final
Reporter: Karl von Randow
Priority: Minor
When a {{CacheNotFoundResponse}} is received in {{org.infinispan.remoting.transport.AbstractTransport.java:46}} Infinispan throws a {{SuspectException}} with the message:
Cache not running on node NODE
I have a problem where I always read this as the whole caching system not running on that node and I get wondering about why JGroups hasn't FD'd that node yet. Maybe that's because it's a {{SuspectException}}? Anyway, it happens to me every time.
After I remember what that message means I'm left wondering which cache wasn't on that node. I then need to manually track down differences between my nodes. If the message contained the cache name that would be fantastic, and it might help push me towards the correct line of thinking as well!
I've had a look at {{AbstractTransport}} and I haven't seen an obvious way to see which cache was requested!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years