[JBoss JIRA] (ISPN-6771) HotRod Client - TcpTransportFactory - update topology issue with multiple caches
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-6771?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes updated ISPN-6771:
------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/4438
> HotRod Client - TcpTransportFactory - update topology issue with multiple caches
> --------------------------------------------------------------------------------
>
> Key: ISPN-6771
> URL: https://issues.jboss.org/browse/ISPN-6771
> Project: Infinispan
> Issue Type: Bug
> Components: Remote Protocols
> Affects Versions: 9.0.0.Alpha2, 8.2.2.Final
> Environment: Infinispan server 8.2.2.Final
> Hot rod client (Java) : 8.2.2.Final
> Reporter: Jean-Francois LARTAUD
> Assignee: Gustavo Fernandes
>
> After debugging :
> In TcpTransportFactory, the topologyInfo is global (whatever the number of caches), the balancing strategies are defined by cache.
> * For the 1st cache, the servers list is updated (org.infinispan.client.hotrod.impl.transport.tcp.TcpTransportFactory#updateServers(java.util.Collection<java.net.SocketAddress>, byte[], boolean), the topologyInfo is updated.
> ** The new servers list is returned only if servers have been added.
> ** As this list is not empty, the balancy strategy for the first cache is updated.
> * For the other caches, the server list is updated by calling the same "updateServers" method, the "updateTopologyInfo" method is called
> ** But as the topologyInfo has been already updated for the 1st cache, it returns "Collections.emptyList();"
> ** The associated balancing strategies are not updated.
> {code}
> public void updateServers(Collection<SocketAddress> newServers, byte[] cacheName, boolean quiet) {
> synchronized (lock) {
> Collection<SocketAddress> servers = updateTopologyInfo(newServers, quiet);
> if (!servers.isEmpty()) {
> FailoverRequestBalancingStrategy balancer = getOrCreateIfAbsentBalancer(cacheName);
> balancer.setServers(servers);
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (ISPN-6816) Remove unnecessary packages from Embedded Uber Jar
by Sebastian Łaskawiec (JIRA)
[ https://issues.jboss.org/browse/ISPN-6816?page=com.atlassian.jira.plugin.... ]
Sebastian Łaskawiec updated ISPN-6816:
--------------------------------------
Status: Open (was: New)
> Remove unnecessary packages from Embedded Uber Jar
> --------------------------------------------------
>
> Key: ISPN-6816
> URL: https://issues.jboss.org/browse/ISPN-6816
> Project: Infinispan
> Issue Type: Bug
> Reporter: Sebastian Łaskawiec
> Assignee: Sebastian Łaskawiec
> Priority: Critical
>
> Things to be removed for sure:
> * jboss modules
> Things to be checked if can be removed:
> * log4j (impl for sure, api - needs to be checked if JBoss Logging won't crash)
> * protostream (probably hotrod client needs it)
> * protobuf (probably hotrod client needs it)
> Things that need to stay:
> * hotrod client (remote cache store scenario)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (ISPN-6816) Remove unnecessary packages from Embedded Uber Jar
by Sebastian Łaskawiec (JIRA)
[ https://issues.jboss.org/browse/ISPN-6816?page=com.atlassian.jira.plugin.... ]
Sebastian Łaskawiec commented on ISPN-6816:
-------------------------------------------
Protostream and protobuf needs to stay...
A remote cache store can use custom marshallers and they in turn can be configured to use Protostream/Protobuf.
> Remove unnecessary packages from Embedded Uber Jar
> --------------------------------------------------
>
> Key: ISPN-6816
> URL: https://issues.jboss.org/browse/ISPN-6816
> Project: Infinispan
> Issue Type: Bug
> Reporter: Sebastian Łaskawiec
> Assignee: Sebastian Łaskawiec
> Priority: Critical
>
> Things to be removed for sure:
> * jboss modules
> Things to be checked if can be removed:
> * log4j (impl for sure, api - needs to be checked if JBoss Logging won't crash)
> * protostream (probably hotrod client needs it)
> * protobuf (probably hotrod client needs it)
> Things that need to stay:
> * hotrod client (remote cache store scenario)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (ISPN-6816) Remove unnecessary packages from Embedded Uber Jar
by Sebastian Łaskawiec (JIRA)
[ https://issues.jboss.org/browse/ISPN-6816?page=com.atlassian.jira.plugin.... ]
Sebastian Łaskawiec commented on ISPN-6816:
-------------------------------------------
Turns out Log4J can be safely removed.
> Remove unnecessary packages from Embedded Uber Jar
> --------------------------------------------------
>
> Key: ISPN-6816
> URL: https://issues.jboss.org/browse/ISPN-6816
> Project: Infinispan
> Issue Type: Bug
> Reporter: Sebastian Łaskawiec
> Assignee: Sebastian Łaskawiec
> Priority: Critical
>
> Things to be removed for sure:
> * jboss modules
> Things to be checked if can be removed:
> * log4j (impl for sure, api - needs to be checked if JBoss Logging won't crash)
> * protostream (probably hotrod client needs it)
> * protobuf (probably hotrod client needs it)
> Things that need to stay:
> * hotrod client (remote cache store scenario)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months