[JBoss JIRA] (ISPN-8547) LocalModeTxTest failures
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-8547?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes updated ISPN-8547:
------------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.2.0.Beta2
Resolution: Done
> LocalModeTxTest failures
> ------------------------
>
> Key: ISPN-8547
> URL: https://issues.jboss.org/browse/ISPN-8547
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.2.0.Beta1
> Reporter: Gustavo Fernandes
> Assignee: William Burns
> Labels: testsuite-stability
> Fix For: 9.2.0.Beta2
>
>
> It looks like a cascade failure, the following tests end up with error:
> [ERROR] testClassStarted(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.11 s <<< FAILURE!
> [ERROR] testKeySet2[storage=OFF_HEAP](org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.04 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.041 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.002 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0 s <<< FAILURE!
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] testClassFinished(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0 s <<< FAILURE!
> [ERROR] testClassFinished(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0 s <<< FAILURE!
> [ERROR] testClassFinished(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] testClassFinished(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> [ERROR] testClassFinished(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.002 s <<< FAILURE!
> [ERROR] testClassFinished(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.002 s <<< FAILURE!
> This is likely the root cause:
> {noformat}
> [ERROR] testClassStarted(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.11 s <<< FAILURE!
> java.lang.IllegalStateException: Two tests with the same name running in parallel: org.infinispan.tx.LocalModeTxTest[storage=OFF_HEAP]
> {noformat}
> {noformat}
> [ERROR] clearContent(org.infinispan.tx.LocalModeTxTest) Time elapsed: 0.001 s <<< FAILURE!
> org.infinispan.IllegalLifecycleStateException: Cache container has been stopped and cannot be reused. Recreate the cache container.
> at org.infinispan.manager.DefaultCacheManager.assertIsNotTerminated(DefaultCacheManager.java:944)
> at org.infinispan.manager.DefaultCacheManager.internalGetCache(DefaultCacheManager.java:458)
> at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:454)
> at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:487)
> at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:478)
> at org.infinispan.test.TestingUtil.lambda$getRunningCaches$4(TestingUtil.java:836)
> at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (IPROTO-38) ProtoSchemaGenerator fails in Karaf: CNFE: org.infinispan.protostream.RawProtobufMarshaller
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/IPROTO-38?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated IPROTO-38:
--------------------------------
Fix Version/s: 4.1.2.Final
> ProtoSchemaGenerator fails in Karaf: CNFE: org.infinispan.protostream.RawProtobufMarshaller
> -------------------------------------------------------------------------------------------
>
> Key: IPROTO-38
> URL: https://issues.jboss.org/browse/IPROTO-38
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 3.0.0.Alpha1
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Fix For: 4.2.0.Alpha5, 4.1.2.Final
>
> Attachments: stacktrace.txt
>
>
> This was tested and fails with Karaf ver. 2.4.4, 3.0.8, 4.1.3.
> This seems to be a classloading issue that is only happening when using annotation based protobuf marsahlling.
> The bytecode generation that happens under the hood using javassist fails. The reason was found to be the wrong classloader used by the javassist ClassPool. Relying on the default (thread context classloader) works usually, but not in OSGi. The fix is to pass the classloader that loaded the protostream bundle to the ClassPool instead, but ClassPool's constructors do not allow that, so we need another creative solution.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (IPROTO-38) ProtoSchemaGenerator fails in Karaf: CNFE: org.infinispan.protostream.RawProtobufMarshaller
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/IPROTO-38?page=com.atlassian.jira.plugin.... ]
Adrian Nistor commented on IPROTO-38:
-------------------------------------
Backported to 4.1.x branch too.
> ProtoSchemaGenerator fails in Karaf: CNFE: org.infinispan.protostream.RawProtobufMarshaller
> -------------------------------------------------------------------------------------------
>
> Key: IPROTO-38
> URL: https://issues.jboss.org/browse/IPROTO-38
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 3.0.0.Alpha1
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Fix For: 4.2.0.Alpha5, 4.1.2.Final
>
> Attachments: stacktrace.txt
>
>
> This was tested and fails with Karaf ver. 2.4.4, 3.0.8, 4.1.3.
> This seems to be a classloading issue that is only happening when using annotation based protobuf marsahlling.
> The bytecode generation that happens under the hood using javassist fails. The reason was found to be the wrong classloader used by the javassist ClassPool. Relying on the default (thread context classloader) works usually, but not in OSGi. The fix is to pass the classloader that loaded the protostream bundle to the ClassPool instead, but ClassPool's constructors do not allow that, so we need another creative solution.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (ISPN-7070) CacheNotifierImplInitialTransferDistTest.testIterationBeganAndSegmentNotComplete random failures
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-7070?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-7070:
--------------------------------
Status: Pull Request Sent (was: Reopened)
Git Pull Request: https://github.com/infinispan/infinispan/pull/4914, https://github.com/infinispan/infinispan/pull/4952, https://github.com/infinispan/infinispan/pull/5598 (was: https://github.com/infinispan/infinispan/pull/4914, https://github.com/infinispan/infinispan/pull/4952)
> CacheNotifierImplInitialTransferDistTest.testIterationBeganAndSegmentNotComplete random failures
> ------------------------------------------------------------------------------------------------
>
> Key: ISPN-7070
> URL: https://issues.jboss.org/browse/ISPN-7070
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Test Suite - Core
> Affects Versions: 9.0.0.Alpha4
> Reporter: Dan Berindei
> Assignee: William Burns
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 9.0.0.CR4
>
> Attachments: CacheNotifierImplInitialTransferDistTest_ISPN-5467_CompletableFuture-like_API_20161003.log, CacheNotifierImplInitialTransferDistTest_ISPN-7919_RpcManager_ResponseCollector_20171107.log.gz
>
>
> Looks like sometimes the originator listener ignores the CACHE_ENTRY_REMOVED notification:
> {noformat}
> 09:58:57,877 INFO (testng-Test:[]) [TestSuiteProgress] Test starting: org.infinispan.notifications.cachelistener.CacheNotifierImplInitialTransferDistTest.testRemoveAfterIterationBeganAndSegmentNotCompleteValueNonOwnerClustered
> 09:58:58,913 DEBUG (testng-Test:[]) [Test] Found key key-to-change-0 with primary owner != Test-NodeA-7051, segment 60
> 09:58:58,930 TRACE (remote-thread-Test-NodeA-p23726-t6:[]) [ReadCommittedEntry] Updating entry (key=key-to-change-0 removed=false valid=true changed=true created=true value=initial-value metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, providedMetadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null})
> 09:58:58,972 TRACE (remote-thread-Test-NodeC-p23887-t6:[]) [ReadCommittedEntry] Updating entry (key=key-to-change-0 removed=false valid=true changed=true created=true value=initial-value metadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null}, providedMetadata=EmbeddedExpirableMetadata{lifespan=-1, maxIdle=-1, version=null})
> 09:58:59,014 TRACE (ForkThread-1,Test:[]) [Test] Adding segment listener 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1 : org.infinispan.notifications.cachelistener.DistributedQueueingSegmentListener@68007f8
> 09:58:59,014 TRACE (ForkThread-1,Test:[]) [CacheNotifierImpl] Replicating cluster listener to other nodes [Test-NodeA-7051, Test-NodeB-10318, Test-NodeC-52778] for cluster listener with id 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1
> 09:58:58,998 TRACE (testng-Test:[]) [CheckPoint] Waiting for event pre_complete_segment_invoked * 1
> 09:58:59,063 TRACE (remote-thread-Test-NodeC-p23887-t6:[]) [ClusterListenerReplicateCallable] Registered local cluster listener for remote cluster listener from origin Test-NodeA-7051 with id 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1
> 09:58:59,098 TRACE (remote-thread-Test-NodeB-p23775-t6:[]) [ClusterListenerReplicateCallable] Registered local cluster listener for remote cluster listener from origin Test-NodeA-7051 with id 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1
> 09:58:59,145 TRACE (ForkThread-1,Test:[]) [CacheNotifierImpl] Listener 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1 requests initial state for cache
> 09:58:59,373 TRACE (ForkThread-1,Test:[]) [Test] Completed segments [48, 2, 229, 118, 71, 72, 233, 60]
> 09:58:59,373 TRACE (ForkThread-1,Test:[]) [Test] Listener received event EventImpl{type=CACHE_ENTRY_CREATED, pre=false, cache=Cache 'DistInitialTransferListener'@Test-NodeA-7051, key=key-to-change-0, value=initial-value, oldValue=null, transaction=null, originLocal=true, transactionSuccessful=false, entries=null, created=false}
> 09:58:59,373 TRACE (ForkThread-1,Test:[]) [Test] Notified for key key-to-change-0
> 09:58:59,373 TRACE (ForkThread-1,Test:[]) [CheckPoint] Triggering event pre_complete_segment_invoked * 1 (available = 1, total = 1)
> 09:58:59,373 TRACE (ForkThread-1,Test:[]) [CheckPoint] Waiting for event pre_complete_segment_released * 1
> 09:58:59,373 TRACE (testng-Test:[]) [CheckPoint] Received event pre_complete_segment_invoked * 1 (available = 0, total = 1)
> 09:58:59,577 TRACE (remote-thread-Test-NodeA-p23726-t6:[]) [ReadCommittedEntry] Updating entry (key=key-to-change-0 removed=true valid=false changed=true created=false value=initial-value metadata=EmbeddedMetadata{version=null}, providedMetadata=null)
> 09:58:59,661 TRACE (remote-thread-Test-NodeC-p23887-t5:[]) [ReadCommittedEntry] Updating entry (key=key-to-change-0 removed=true valid=false changed=true created=false value=initial-value metadata=EmbeddedMetadata{version=null}, providedMetadata=null)
> 09:58:59,661 TRACE (remote-thread-Test-NodeC-p23887-t5:[]) [RequestCorrelator] Test-NodeC-52778: invoking unicast RPC [req-id=91126] on Test-NodeA-7051
> 09:58:59,684 TRACE (OOB-2,Test-NodeA-7051:[]) [RequestCorrelator] calling (org.infinispan.remoting.transport.jgroups.CommandAwareRpcDispatcher) with request 91126
> 09:58:59,779 TRACE (remote-thread-Test-NodeA-p23726-t6:[]) [NonTotalOrderPerCacheInboundInvocationHandler] Calling perform() on DistributedExecuteCommand [cache=Cache 'DistInitialTransferListener'@Test-NodeA-7051, keys=[], callable=org.infinispan.notifications.cachelistener.cluster.ClusterEventCallable@640b0234]
> 09:58:59,780 TRACE (remote-thread-Test-NodeA-p23726-t6:[]) [ClusterEventCallable] Received cluster event(s) [ClusterEvent {type=CACHE_ENTRY_REMOVED, cache=Cache 'DistInitialTransferListener'@Test-NodeA-7051, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, retryCommand=false, origin=Test-NodeC-52778}], notifying cluster listener with id 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1
> 09:58:59,837 TRACE (testng-Test:[]) [CheckPoint] Triggering event pre_complete_segment_released * 999999999 (available = 999999999, total = 999999999)
> 09:58:59,837 TRACE (ForkThread-1,Test:[]) [CheckPoint] Received event pre_complete_segment_released * 1 (available = 999999998, total = 999999999)
> 09:58:59,898 TRACE (ForkThread-1,Test:[]) [CacheNotifierImpl] Listener 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1 initial state for cache completed
> 09:58:59,916 TRACE (remote-thread-Test-NodeB-p23775-t6:[]) [ClusterListenerRemoveCallable] Removing local cluster listener due to parent cluster listener was removed : 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1
> 09:58:59,921 TRACE (remote-thread-Test-NodeC-p23887-t5:[]) [ClusterListenerRemoveCallable] Removing local cluster listener due to parent cluster listener was removed : 2a41ec3f-c79f-4b7d-bd0e-8754170d8fc1
> 09:58:59,943 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.notifications.cachelistener.CacheNotifierImplInitialTransferDistTest.testRemoveAfterIterationBeganAndSegmentNotCompleteValueNonOwnerClustered
> java.lang.AssertionError: expected [12] but found [11]
> {noformat}
> {{CacheNotifierImplInitialTransferDistTest}} also had a different problem: it replaced the {{CacheNotifier}} component with a clone before adding the listener, but replaced it again with the original before removing the listener. Because the listener's uuid was only registered in the clone, {{removeListener}} couldn't find the uuid and disn't try to remove the listener on the other nodes. This meant the listener was leaked, resulting in logs like this:
> {noformat}
> 20:12:04,098 TRACE (remote-thread-Test-NodeB-p24127-t6:[]) [ReadCommittedEntry] Updating entry (key=key-to-change-0 removed=true valid=false changed=true created=false value=initial-value metadata=EmbeddedMetadata{version=null}, providedMetadata=null)
> 20:12:04,099 TRACE (remote-thread-Test-NodeB-p24127-t6:[]) [RemoteClusterListener] Passing Event to manager EventImpl{type=CACHE_ENTRY_REMOVED, pre=false, cache=Cache 'DistInitialTransferListener'@Test-NodeB-56142, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, originLocal=false, transactionSuccessful=false, entries=null, created=false} to send to Test-NodeA-38047
> 20:12:04,100 TRACE (remote-thread-Test-NodeB-p24127-t6:[]) [RemoteClusterListener] Passing Event to manager EventImpl{type=CACHE_ENTRY_REMOVED, pre=false, cache=Cache 'DistInitialTransferListener'@Test-NodeB-56142, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, originLocal=false, transactionSuccessful=false, entries=null, created=false} to send to Test-NodeA-38047
> 20:12:04,100 TRACE (remote-thread-Test-NodeB-p24127-t6:[]) [RemoteClusterListener] Passing Event to manager EventImpl{type=CACHE_ENTRY_REMOVED, pre=false, cache=Cache 'DistInitialTransferListener'@Test-NodeB-56142, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, originLocal=false, transactionSuccessful=false, entries=null, created=false} to send to Test-NodeA-38047
> 20:12:04,100 TRACE (remote-thread-Test-NodeB-p24127-t6:[]) [RemoteClusterListener] Passing Event to manager EventImpl{type=CACHE_ENTRY_REMOVED, pre=false, cache=Cache 'DistInitialTransferListener'@Test-NodeB-56142, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, originLocal=false, transactionSuccessful=false, entries=null, created=false} to send to Test-NodeA-38047
> 20:12:04,100 TRACE (remote-thread-Test-NodeB-p24127-t6:[]) [RemoteClusterListener] Passing Event to manager EventImpl{type=CACHE_ENTRY_REMOVED, pre=false, cache=Cache 'DistInitialTransferListener'@Test-NodeB-56142, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, originLocal=false, transactionSuccessful=false, entries=null, created=false} to send to Test-NodeA-38047
> 20:12:04,106 TRACE (remote-thread-Test-NodeA-p24103-t6:[]) [MultiClusterEventCallable] Received multiple cluster event(s) {86f77630-b1bb-4a21-97bb-b03efeae39d6=[ClusterEvent {type=CACHE_ENTRY_REMOVED, cache=Cache 'DistInitialTransferListener'@Test-NodeA-38047, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, retryCommand=false, origin=Test-NodeB-56142}], 91d05a50-4a35-4e37-8c5c-bffbabc6154b=[ClusterEvent {type=CACHE_ENTRY_REMOVED, cache=Cache 'DistInitialTransferListener'@Test-NodeA-38047, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, retryCommand=false, origin=Test-NodeB-56142}], ba09480f-c698-431b-8fe6-213f1bdefc7b=[ClusterEvent {type=CACHE_ENTRY_REMOVED, cache=Cache 'DistInitialTransferListener'@Test-NodeA-38047, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, retryCommand=false, origin=Test-NodeB-56142}], 992da014-0516-4f2a-8093-50ba3b1f358a=[ClusterEvent {type=CACHE_ENTRY_REMOVED, cache=Cache 'DistInitialTransferListener'@Test-NodeA-38047, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, retryCommand=false, origin=Test-NodeB-56142}], b4eeb9b3-85c4-4ff9-865e-076b7cf93faa=[ClusterEvent {type=CACHE_ENTRY_REMOVED, cache=Cache 'DistInitialTransferListener'@Test-NodeA-38047, key=key-to-change-0, value=null, oldValue=initial-value, transaction=null, retryCommand=false, origin=Test-NodeB-56142}]}
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (IPROTO-38) ProtoSchemaGenerator fails in Karaf: CNFE: org.infinispan.protostream.RawProtobufMarshaller
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/IPROTO-38?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated IPROTO-38:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Integrated in master and 4.2.x.
> ProtoSchemaGenerator fails in Karaf: CNFE: org.infinispan.protostream.RawProtobufMarshaller
> -------------------------------------------------------------------------------------------
>
> Key: IPROTO-38
> URL: https://issues.jboss.org/browse/IPROTO-38
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 3.0.0.Alpha1
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Fix For: 4.2.0.Alpha5
>
> Attachments: stacktrace.txt
>
>
> This was tested and fails with Karaf ver. 2.4.4, 3.0.8, 4.1.3.
> This seems to be a classloading issue that is only happening when using annotation based protobuf marsahlling.
> The bytecode generation that happens under the hood using javassist fails. The reason was found to be the wrong classloader used by the javassist ClassPool. Relying on the default (thread context classloader) works usually, but not in OSGi. The fix is to pass the classloader that loaded the protostream bundle to the ClassPool instead, but ClassPool's constructors do not allow that, so we need another creative solution.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (IPROTO-38) ProtoSchemaGenerator fails in Karaf: CNFE: org.infinispan.protostream.RawProtobufMarshaller
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/IPROTO-38?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated IPROTO-38:
--------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/infinispan/protostream/pull/32
> ProtoSchemaGenerator fails in Karaf: CNFE: org.infinispan.protostream.RawProtobufMarshaller
> -------------------------------------------------------------------------------------------
>
> Key: IPROTO-38
> URL: https://issues.jboss.org/browse/IPROTO-38
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 3.0.0.Alpha1
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Fix For: 4.2.0.Alpha5
>
> Attachments: stacktrace.txt
>
>
> This was tested and fails with Karaf ver. 2.4.4, 3.0.8, 4.1.3.
> This seems to be a classloading issue that is only happening when using annotation based protobuf marsahlling.
> The bytecode generation that happens under the hood using javassist fails. The reason was found to be the wrong classloader used by the javassist ClassPool. Relying on the default (thread context classloader) works usually, but not in OSGi. The fix is to pass the classloader that loaded the protostream bundle to the ClassPool instead, but ClassPool's constructors do not allow that, so we need another creative solution.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (ISPN-8551) JdbcStringBasedStore SQL Server upsert locks on data not key
by Ryan Emerson (JIRA)
Ryan Emerson created ISPN-8551:
----------------------------------
Summary: JdbcStringBasedStore SQL Server upsert locks on data not key
Key: ISPN-8551
URL: https://issues.jboss.org/browse/ISPN-8551
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 9.1.3.Final, 9.2.0.Alpha2
Reporter: Ryan Emerson
Assignee: Ryan Emerson
The below code applies ON function to the data column, it should be the key column
{code:java}
upsertRowSql = String.format("MERGE %1$s WITH (TABLOCK) " +
"USING (VALUES (?, ?, ?)) AS tmp (%2$s, %3$s, %4$s) " +
"ON (%1$s.%2$s = tmp.%2$s) " +
"WHEN MATCHED THEN UPDATE SET %3$s = tmp.%3$s, %4$s = tmp.%4$s " +
"WHEN NOT MATCHED THEN INSERT (%2$s, %3$s, %4$s) VALUES (tmp.%2$s, tmp.%3$s, tmp.%4$s);",
getTableName(), config.dataColumnName(), config.timestampColumnName(), config.idColumnName());
{code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (ISPN-8548) Clear post notifications can cause memory issues as it holds all entries locally
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8548?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-8548:
--------------------------------
Fix Version/s: 9.2.0.Beta2
9.1.4.Final
> Clear post notifications can cause memory issues as it holds all entries locally
> --------------------------------------------------------------------------------
>
> Key: ISPN-8548
> URL: https://issues.jboss.org/browse/ISPN-8548
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 9.2.0.Beta1, 9.1.3.Final
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.2.0.Beta2, 9.1.4.Final
>
>
> Currently clear iterates over the container and stores all entries before finally invoking clear. This can cause memory issues especially for off heap as we don't want to have all of these entries in the JVM heap at the same time.
> Something like
> {code}
> Iterator<InternalCacheEntry<Object, Object>> iterator =
> dataContainer.iterator();
> while (iterator.hasNext()) {
> InternalCacheEntry entry = iterator.next();
> iterator.remove();
> notifier.notifyCacheEntryRemoved(entry.getKey(), entry.getValue(),
> entry.getMetadata(), false, context, command);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (ISPN-8548) Clear post notifications can cause memory issues as it holds all entries locally
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8548?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-8548:
--------------------------------
Status: Open (was: New)
> Clear post notifications can cause memory issues as it holds all entries locally
> --------------------------------------------------------------------------------
>
> Key: ISPN-8548
> URL: https://issues.jboss.org/browse/ISPN-8548
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 9.2.0.Beta1, 9.1.3.Final
> Reporter: William Burns
> Assignee: William Burns
>
> Currently clear iterates over the container and stores all entries before finally invoking clear. This can cause memory issues especially for off heap as we don't want to have all of these entries in the JVM heap at the same time.
> Something like
> {code}
> Iterator<InternalCacheEntry<Object, Object>> iterator =
> dataContainer.iterator();
> while (iterator.hasNext()) {
> InternalCacheEntry entry = iterator.next();
> iterator.remove();
> notifier.notifyCacheEntryRemoved(entry.getKey(), entry.getValue(),
> entry.getMetadata(), false, context, command);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months
[JBoss JIRA] (ISPN-8548) Clear post notifications can cause memory issues as it holds all entries locally
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8548?page=com.atlassian.jira.plugin.... ]
Work on ISPN-8548 started by William Burns.
-------------------------------------------
> Clear post notifications can cause memory issues as it holds all entries locally
> --------------------------------------------------------------------------------
>
> Key: ISPN-8548
> URL: https://issues.jboss.org/browse/ISPN-8548
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 9.2.0.Beta1, 9.1.3.Final
> Reporter: William Burns
> Assignee: William Burns
>
> Currently clear iterates over the container and stores all entries before finally invoking clear. This can cause memory issues especially for off heap as we don't want to have all of these entries in the JVM heap at the same time.
> Something like
> {code}
> Iterator<InternalCacheEntry<Object, Object>> iterator =
> dataContainer.iterator();
> while (iterator.hasNext()) {
> InternalCacheEntry entry = iterator.next();
> iterator.remove();
> notifier.notifyCacheEntryRemoved(entry.getKey(), entry.getValue(),
> entry.getMetadata(), false, context, command);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 7 months