[JBoss JIRA] (ISPN-9620) Rolling Upgrade Marshaller Changes
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9620?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9620:
-------------------------------
Sprint: Sprint 10.0.0.Alpha1
> Rolling Upgrade Marshaller Changes
> ----------------------------------
>
> Key: ISPN-9620
> URL: https://issues.jboss.org/browse/ISPN-9620
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core, Loaders and Stores
> Affects Versions: 9.4.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Alpha1
>
>
> In order to allow for compatibility between infinispan versions it is necessary for us to utilise a marshalling implementation at both the cluster (internal node-to-node communication) and persistence layer that is strictly defined but allows for future changes. This is necessary in order to facilitate both rolling and start/stop upgrades. Protocol buffers should be utilised as the wire/storage format, with protostream providing the implementation.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9620) Rolling Upgrade Marshaller Changes
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9620?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9620:
-------------------------------
Status: Open (was: New)
> Rolling Upgrade Marshaller Changes
> ----------------------------------
>
> Key: ISPN-9620
> URL: https://issues.jboss.org/browse/ISPN-9620
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core, Loaders and Stores
> Affects Versions: 9.4.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Alpha1
>
>
> In order to allow for compatibility between infinispan versions it is necessary for us to utilise a marshalling implementation at both the cluster (internal node-to-node communication) and persistence layer that is strictly defined but allows for future changes. This is necessary in order to facilitate both rolling and start/stop upgrades. Protocol buffers should be utilised as the wire/storage format, with protostream providing the implementation.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9620) Rolling Upgrade Marshaller Changes
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9620?page=com.atlassian.jira.plugin.... ]
Work on ISPN-9620 started by Ryan Emerson.
------------------------------------------
> Rolling Upgrade Marshaller Changes
> ----------------------------------
>
> Key: ISPN-9620
> URL: https://issues.jboss.org/browse/ISPN-9620
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core, Loaders and Stores
> Affects Versions: 9.4.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Alpha1
>
>
> In order to allow for compatibility between infinispan versions it is necessary for us to utilise a marshalling implementation at both the cluster (internal node-to-node communication) and persistence layer that is strictly defined but allows for future changes. This is necessary in order to facilitate both rolling and start/stop upgrades. Protocol buffers should be utilised as the wire/storage format, with protostream providing the implementation.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-7409) Replace external marshaller with user marshaller
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-7409?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-7409:
-------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/infinispan/infinispan/pull/6240
> Replace external marshaller with user marshaller
> ------------------------------------------------
>
> Key: ISPN-7409
> URL: https://issues.jboss.org/browse/ISPN-7409
> Project: Infinispan
> Issue Type: Sub-task
> Components: Core, Marshalling
> Reporter: Galder Zamarreño
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Final
>
>
> ISPN-6906 brings much needed independence from JBoss Marshalling to our marshalling layer. One of the key aspects it brings it’s the separation between marshalling internal types we know about, e.g. String, byte[], CacheTopologyCommand...etc and external or unknown types, e.g. any types that extend Serializable.
> Although this separation helps achieve objectives of ISPN-6906, it’s not an ideal solution:
> * If user types map directly to primitive types supported by our internal marshaller, or types that depend on types that are marshalled by our internal marshaller, any changes made to the internal marshaller have a direct impact on the representation of the user types.
> * In the ISPN-6906 implementation, Internal marshaller exposes its own externalizer table to the external marshaller so that it can lookup how to marshall internal types. This is done to support corner cases in Hibernate Search where some of the classes that Query module marshalls rely on the fact that some Hibernate Search classes are Serializable, but these classes reference Lucene query classes that are not for which there are externalizers defined. For query logic to work, externalizers have to be found while dealing with Serializable types are being traversed. Gustavo and Sane are aware of this issue and we should soon have externalizers for those Hibernate Search classes and avoid this issue altogether (see ISPN-7156).
> So, rather than an external marshaller, a more suitable abstraction would be to have a user marshaller. The job of the user marshaller, which would be configurable, would be to marshall user types. The user marshaller should be independent of the internal marshaller, so it would not be able to piggyback on the internal externalizers.
> Externalizers for user types could still be supported, by having a user externalizer table, purely used by the user marshaller. In fact, it would make sense that all externalizers that are configured in Infinispan (regardless of whether via xml, programmatic or via annotation) to be user externalizers.
> User types are considered to be:
> * Keys and values
> * Metadata instances provided by the user via *withMetadata() calls
> The benefits of the user marshaller are the following:
> * Having the user marshaller configurable would make it easy to try out different marshallers when comparing how key/value types are marshalled, e.g. try out different ways to marshall Strings.
> * An easier upgrade path for user types. Since user types no longer rely on internal marshaller details, Infinispan upgrades are easier to deal with.
> For reference, custom commands that can be plugged via ModuleCommandFactory implementations would use the internal marshaller since these commands often marshall internal types, e.g. Address.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9692) Add ability to override maxClauseCount
by Wolf-Dieter Fink (Jira)
Wolf-Dieter Fink created ISPN-9692:
--------------------------------------
Summary: Add ability to override maxClauseCount
Key: ISPN-9692
URL: https://issues.jboss.org/browse/ISPN-9692
Project: Infinispan
Issue Type: Enhancement
Components: Remote Querying, Server
Reporter: Wolf-Dieter Fink
Assignee: Adrian Nistor
We are using the Hotrod client, and need the ability to specify or override the maxClauseCount setting, otherwise, we get the following error message:
- org.apache.lucene.search.BooleanQuery$TooManyClauses: maxClauseCount is set to 1024 setting
This will occur when there are more than 1024 "IN" conditions specified on the query builder.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month
[JBoss JIRA] (ISPN-9691) StateTransferFileCacheLoaderFunctionalTest#testConcurrentStateTransfer can hang
by William Burns (Jira)
William Burns created ISPN-9691:
-----------------------------------
Summary: StateTransferFileCacheLoaderFunctionalTest#testConcurrentStateTransfer can hang
Key: ISPN-9691
URL: https://issues.jboss.org/browse/ISPN-9691
Project: Infinispan
Issue Type: Bug
Components: Test Suite - Core
Reporter: William Burns
The test can hang and will eventually be killed after the 5 minute timeout. The CI unfortunately doesn't count it as a failure. I have been seeing this quite often when running the core suite locally.
https://ci.infinispan.org/job/Infinispan/job/master/927
The stack in the log is:
{quote}
Test org.infinispan.statetransfer.StateTransferFileCacheLoaderFunctionalTest.testConcurrentStateTransfer has been running for more than 300 seconds. Interrupting the test thread and dumping thread stacks of the test suite process and its children.
Dumping thread stacks of process 32404 to /home/infinispan/workspace/Infinispan_master-5OURPVBKVS5PLGVSKVWLBFUZPLIO2DZSV3U7HWSZJBYGBGKYSFXQ/core/threaddump-org_infinispan_statetransfer_StateTransferFileCacheLoaderFunctionalTest_testConcurrentStateTransfer-2018-11-02-32404.log
Interrupted thread testng-StateTransferFileCacheLoaderFunctionalTest (22).
Error dumping thread stacks/interrupting threads/killing processes:
[OK: 11616, KO: 1, SKIP: java.lang.InterruptedException
96] Test succeeded: org.infinispan.statetransfer.StateTransferFileCacheLoaderFunctionalTest.testConcurrentStateTransfer
at java.lang.Object.wait(Native Method)
at java.lang.Thread.join(Thread.java:1260)
{quote}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 1 month