[JBoss JIRA] (ISPN-8798) ByteString places too strict a constraint on cache name length
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-8798?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant commented on ISPN-8798:
---------------------------------------
I'd rather see the use of hashes instead, to represent the long identifiers. The cache name is included in every RPC, and the bigger it is, the larger the impact on performance.
> ByteString places too strict a constraint on cache name length
> --------------------------------------------------------------
>
> Key: ISPN-8798
> URL: https://issues.jboss.org/browse/ISPN-8798
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.1.5.Final, 9.2.0.CR2
> Reporter: Paul Ferraro
> Assignee: Paul Ferraro
> Priority: Blocker
> Fix For: 9.2.0.CR3, 9.1.6.Final
>
>
> The hibernate 2nd level cache code can easily generate cache names that exceed the byte length restriction enforced by ByteString. Cache names are generated using the fully qualified class name of the entity, which are user defined, and in the case of WildFly, also includes the deployment name, which can be particularly long for EARs.
> At the very least, we should use an unsigned byte which doubles the allowed size. Why not also consider using https://github.com/infinispan/infinispan/blob/master/commons/src/main/jav... to marshal/unmarshal the size of the byte[] containing the name? At worst, this costs an extra byte, but solves the size problem for even sizes larger than 255.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 8 months
[JBoss JIRA] (ISPN-7100) IllegalLifecycleStateException: Trying to register a component after stopping
by Dennis Reed (JIRA)
[ https://issues.jboss.org/browse/ISPN-7100?page=com.atlassian.jira.plugin.... ]
Dennis Reed commented on ISPN-7100:
-----------------------------------
Is this a duplicate of ISPN-7488?
> IllegalLifecycleStateException: Trying to register a component after stopping
> -----------------------------------------------------------------------------
>
> Key: ISPN-7100
> URL: https://issues.jboss.org/browse/ISPN-7100
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 8.2.4.Final
> Reporter: Radoslav Husar
> Priority: Minor
> Labels: infinispan_clean_shutdown
>
> Occured on server. Scenarios affected:
> eap-7x-failover-ejb-ejbremote-shutdown-dist-async
> eap-7x-failover-ejb-ejbremote-shutdown-dist-sync
> eap-7x-failover-ejb-ejbremote-shutdown-dist-sync-3owners
> eap-7x-failover-ejb-ejbremote-shutdown-dist-sync-tcpStack
> eap-7x-failover-ejb-ejbremote-shutdown-repl-sync
> eap-7x-failover-ejb-ejbservlet-shutdown-dist-async
> eap-7x-failover-ejb-ejbservlet-shutdown-repl-async
> eap-7x-failover-ejb-ejbservlet-shutdown-repl-sync
> eap-7x-failover-http-session-shutdown-dist-async
> eap-7x-failover-http-session-shutdown-dist-sync
> eap-7x-failover-http-session-shutdown-repl-async-haproxy
> Occurs after "ISPN000082: Stopping the RpcDispatcher for channel ejb" or "WFLYSRV0028: Stopped deployment clusterbench-ee7.ear":
> {code}
> 21:58:55,724 INFO [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 91) WFLYCLINF0003: Stopped client-mappings cache from ejb container
> [JBossINF] 21:58:55,726 INFO [org.jboss.as.server.deployment] (MSC service thread 1-4) WFLYSRV0208: Stopped subdeployment (runtime-name: clusterbench-ee7-web-passivating.war) in 259ms
> [JBossINF] 21:58:55,726 INFO [org.infinispan.CLUSTER] (remote-thread--p5-t43) [Context=client-mappings][Scope=dev213]ISPN100003: Finished local rebalance
> [JBossINF] 21:58:55,727 INFO [org.infinispan.remoting.transport.jgroups.JGroupsTransport] (MSC service thread 1-6) ISPN000080: Disconnecting JGroups channel ejb
> [JBossINF] 21:58:55,727 INFO [org.infinispan.remoting.transport.jgroups.JGroupsTransport] (MSC service thread 1-6) ISPN000082: Stopping the RpcDispatcher for channel ejb
> [JBossINF] 21:58:55,734 INFO [org.jboss.as.server.deployment] (MSC service thread 1-5) WFLYSRV0208: Stopped subdeployment (runtime-name: clusterbench-ee7-web-granular.war) in 267ms
> [JBossINF] 21:58:55,735 INFO [org.jboss.as.server.deployment] (MSC service thread 1-2) WFLYSRV0208: Stopped subdeployment (runtime-name: clusterbench-ee7-web-default.war) in 268ms
> [JBossINF] 21:58:55,735 INFO [org.jboss.as.server.deployment] (MSC service thread 1-8) WFLYSRV0028: Stopped deployment clusterbench-ee7.ear (runtime-name: clusterbench-ee7.ear) in 269ms
> [JBossINF] 21:58:55,736 WARN [org.infinispan.remoting.inboundhandler.GlobalInboundInvocationHandler] (remote-thread--p5-t9) ISPN000071: Caught exception when handling command CacheTopologyControlCommand{cache=client-mappings, type=REBALANCE_CONFIRM, sender=dev215, joinInfo=null, topologyId=29, rebalanceId=0, currentCH=null, pendingCH=null, availabilityMode=null, actualMembers=null, throwable=null, viewId=11}: org.infinispan.commons.CacheConfigurationException: Unable to configure component (type: class org.infinispan.topology.CacheTopologyControlCommand, instance CacheTopologyControlCommand{cache=client-mappings, type=REBALANCE_CONFIRM, sender=dev215, joinInfo=null, topologyId=29, rebalanceId=0, currentCH=null, pendingCH=null, availabilityMode=null, actualMembers=null, throwable=null, viewId=11})
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.wireDependencies(AbstractComponentRegistry.java:151)
> [JBossINF] at org.infinispan.remoting.inboundhandler.GlobalInboundInvocationHandler$2.run(GlobalInboundInvocationHandler.java:157)
> [JBossINF] at org.infinispan.util.concurrent.BlockingTaskAwareExecutorServiceImpl$RunnableWrapper.run(BlockingTaskAwareExecutorServiceImpl.java:199)
> [JBossINF] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [JBossINF] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [JBossINF] at org.jboss.as.clustering.infinispan.ClassLoaderThreadFactory.lambda$newThread$0(ClassLoaderThreadFactory.java:48)
> [JBossINF] at java.lang.Thread.run(Thread.java:745)
> [JBossINF] Caused by: org.infinispan.IllegalLifecycleStateException: Trying to register a component after stopping: org.infinispan.topology.LocalTopologyManagerFactory
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.registerComponentInternal(AbstractComponentRegistry.java:184)
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.registerComponent(AbstractComponentRegistry.java:171)
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.registerComponent(AbstractComponentRegistry.java:167)
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.createComponentFactoryInternal(AbstractComponentRegistry.java:348)
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.getFactory(AbstractComponentRegistry.java:327)
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.getOrCreateComponent(AbstractComponentRegistry.java:293)
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.invokeInjectionMethod(AbstractComponentRegistry.java:246)
> [JBossINF] at org.infinispan.factories.AbstractComponentRegistry.wireDependencies(AbstractComponentRegistry.java:147)
> [JBossINF] ... 6 more
> {code}
> Server logs:
> http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/eap-7x-failover-ejb-e...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 8 months
[JBoss JIRA] (ISPN-8865) Move AdvancedCacheLoader over to using Publisher instead of process
by William Burns (JIRA)
William Burns created ISPN-8865:
-----------------------------------
Summary: Move AdvancedCacheLoader over to using Publisher instead of process
Key: ISPN-8865
URL: https://issues.jboss.org/browse/ISPN-8865
Project: Infinispan
Issue Type: Enhancement
Components: Loaders and Stores
Reporter: William Burns
Assignee: William Burns
Fix For: 9.3.0.Final
Currently our process method on AdvancedCacheLoader is very hard to write for proper thread usage, see [1]. There is no way to utilize the main thread to help with processing as well, except by always using a WithinThreadExecutor, which prevents any parallelism.
Instead we should have the loader expose a Producer which can be properly controlled and have backpressure built in (thus not wasting threads or resources like it does currently.
[1] https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 8 months
[JBoss JIRA] (ISPN-8858) BulkOperationsTest parameter values change in every run
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-8858?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-8858:
----------------------------------
Fix Version/s: 9.2.0.Final
(was: 9.2.0.CR3)
> BulkOperationsTest parameter values change in every run
> -------------------------------------------------------
>
> Key: ISPN-8858
> URL: https://issues.jboss.org/browse/ISPN-8858
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Server
> Affects Versions: 9.2.0.CR2
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
> Fix For: 9.2.0.Final
>
>
> The {{BulkOperationsTest}} methods use a data provider, but the parameter values are lambdas, so they are logged with {{Object.toString()}}:
> {noformat}
> [OK: 3222, KO: 2, SKIP: 0] Test starting: org.infinispan.client.hotrod.BulkOperationsTest.testClear[LOCAL]([org.infinispan.client.hotrod.BulkOperationsTest$$Lambda$1387/864766760@5e4517de])
> [OK: 3223, KO: 2, SKIP: 0] Test succeeded: org.infinispan.client.hotrod.BulkOperationsTest.testClear[LOCAL]([org.infinispan.client.hotrod.BulkOperationsTest$$Lambda$1387/864766760@5e4517de])
> [OK: 3223, KO: 2, SKIP: 0] Test starting: org.infinispan.client.hotrod.BulkOperationsTest.testClear[LOCAL]([org.infinispan.client.hotrod.BulkOperationsTest$$Lambda$1388/1656036295@52bab332])
> [OK: 3224, KO: 2, SKIP: 0] Test succeeded: org.infinispan.client.hotrod.BulkOperationsTest.testClear[LOCAL]([org.infinispan.client.hotrod.BulkOperationsTest$$Lambda$1388/1656036295@52bab332])
> [OK: 3224, KO: 2, SKIP: 0] Test starting: org.infinispan.client.hotrod.BulkOperationsTest.testClear[LOCAL]([org.infinispan.client.hotrod.BulkOperationsTest$$Lambda$1389/1747688893@311c80b2])
> [OK: 3225, KO: 2, SKIP: 0] Test succeeded: org.infinispan.client.hotrod.BulkOperationsTest.testClear[LOCAL]([org.infinispan.client.hotrod.BulkOperationsTest$$Lambda$1389/1747688893@311c80b2])
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 8 months
[JBoss JIRA] (ISPN-8813) org.infinispan.server.test.query.RemoteQueryStringIT.testFullTextTermRightOperandAnalyzed fails randomly
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-8813?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-8813:
----------------------------------
Fix Version/s: (was: 9.2.0.CR3)
> org.infinispan.server.test.query.RemoteQueryStringIT.testFullTextTermRightOperandAnalyzed fails randomly
> --------------------------------------------------------------------------------------------------------
>
> Key: ISPN-8813
> URL: https://issues.jboss.org/browse/ISPN-8813
> Project: Infinispan
> Issue Type: Bug
> Components: Remote Querying
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Fix For: 9.2.0.Final
>
>
> To be fair, this failure happens almost all the time. But I've seen some rare builds where it did not fail, so I'm marking it as a random failure.
> {code}
> [0m[33m10:10:13,714 WARN [org.infinispan.factories.ComponentRegistry] (MSC service thread 1-2) ISPN000189: While stopping a cache or cache manager, one of its components failed to stop: org.infinispan.commons.CacheException: Unable to invoke method public void org.infinispan.notifications.cachelistener.CacheNotifierImpl.stop() on object of type CacheNotifierImpl
> at org.infinispan.commons.util.ReflectionUtil.invokeAccessibly(ReflectionUtil.java:172)
> at org.infinispan.factories.AbstractComponentRegistry$PrioritizedMethod.invoke(AbstractComponentRegistry.java:878)
> at org.infinispan.factories.AbstractComponentRegistry.internalStop(AbstractComponentRegistry.java:679)
> at org.infinispan.factories.AbstractComponentRegistry.stop(AbstractComponentRegistry.java:581)
> at org.infinispan.factories.ComponentRegistry.stop(ComponentRegistry.java:256)
> at org.infinispan.cache.impl.CacheImpl.performImmediateShutdown(CacheImpl.java:937)
> at org.infinispan.cache.impl.CacheImpl.stop(CacheImpl.java:901)
> at org.infinispan.cache.impl.AbstractDelegatingCache.stop(AbstractDelegatingCache.java:420)
> at org.infinispan.server.infinispan.SecurityActions$6.run(SecurityActions.java:148)
> at org.infinispan.server.infinispan.SecurityActions$6.run(SecurityActions.java:145)
> at org.infinispan.security.Security.doPrivileged(Security.java:76)
> at org.infinispan.server.infinispan.SecurityActions.doPrivileged(SecurityActions.java:69)
> at org.infinispan.server.infinispan.SecurityActions.stopCache(SecurityActions.java:152)
> at org.jboss.as.clustering.infinispan.subsystem.CacheService.stop(CacheService.java:103)
> at org.jboss.msc.service.ServiceControllerImpl$StopTask.stopService(ServiceControllerImpl.java:2150)
> at org.jboss.msc.service.ServiceControllerImpl$StopTask.run(ServiceControllerImpl.java:2101)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NullPointerException
> at org.infinispan.query.dsl.embedded.impl.BaseJPAFilterIndexingServiceProvider.stop(BaseJPAFilterIndexingServiceProvider.java:68)
> at org.infinispan.notifications.cachelistener.CacheNotifierImpl.stop(CacheNotifierImpl.java:275)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.infinispan.commons.util.ReflectionUtil.invokeAccessibly(ReflectionUtil.java:168)
> ... 18 more
> [0m[0m10:10:13,728 INFO [org.jboss.as.clustering.infinispan] (MSC service thread 1-2) DGISPN0002: Stopped default cache from local container
> [0m[33m10:10:13,748 WARN [org.infinispan.factories.ComponentRegistry] (MSC service thread 1-2) ISPN000189: While stopping a cache or cache manager, one of its components failed to stop: org.infinispan.commons.CacheException: Unable to invoke method public void org.infinispan.notifications.cachelistener.CacheNotifierImpl.stop() on object of type CacheNotifierImpl
> at org.infinispan.commons.util.ReflectionUtil.invokeAccessibly(ReflectionUtil.java:172)
> at org.infinispan.factories.AbstractComponentRegistry$PrioritizedMethod.invoke(AbstractComponentRegistry.java:878)
> at org.infinispan.factories.AbstractComponentRegistry.internalStop(AbstractComponentRegistry.java:679)
> at org.infinispan.factories.AbstractComponentRegistry.stop(AbstractComponentRegistry.java:581)
> at org.infinispan.factories.ComponentRegistry.stop(ComponentRegistry.java:256)
> at org.infinispan.cache.impl.CacheImpl.performImmediateShutdown(CacheImpl.java:937)
> at org.infinispan.cache.impl.CacheImpl.stop(CacheImpl.java:901)
> at org.infinispan.cache.impl.AbstractDelegatingCache.stop(AbstractDelegatingCache.java:420)
> at org.infinispan.manager.DefaultCacheManager.terminate(DefaultCacheManager.java:679)
> at org.infinispan.manager.DefaultCacheManager.stopCaches(DefaultCacheManager.java:719)
> at org.infinispan.manager.DefaultCacheManager.stop(DefaultCacheManager.java:696)
> at org.infinispan.manager.impl.AbstractDelegatingEmbeddedCacheManager.stop(AbstractDelegatingEmbeddedCacheManager.java:190)
> at org.infinispan.server.infinispan.SecurityActions$2.run(SecurityActions.java:98)
> at org.infinispan.server.infinispan.SecurityActions$2.run(SecurityActions.java:94)
> at org.infinispan.security.Security.doPrivileged(Security.java:76)
> at org.infinispan.server.infinispan.SecurityActions.doPrivileged(SecurityActions.java:69)
> at org.infinispan.server.infinispan.SecurityActions.stopAndUnregisterContainer(SecurityActions.java:106)
> at org.jboss.as.clustering.infinispan.subsystem.CacheContainerBuilder.stop(CacheContainerBuilder.java:106)
> at org.jboss.msc.service.ServiceControllerImpl$StopTask.stopService(ServiceControllerImpl.java:2150)
> at org.jboss.msc.service.ServiceControllerImpl$StopTask.run(ServiceControllerImpl.java:2101)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NullPointerException
> at org.infinispan.query.dsl.embedded.impl.BaseJPAFilterIndexingServiceProvider.stop(BaseJPAFilterIndexingServiceProvider.java:68)
> at org.infinispan.notifications.cachelistener.CacheNotifierImpl.stop(CacheNotifierImpl.java:275)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.infinispan.commons.util.ReflectionUtil.invokeAccessibly(ReflectionUtil.java:168)
> ... 22 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 8 months