[JBoss JIRA] (ISPN-10886) Server side objects implementing Serializable causes serialization errors
by Gustavo Fernandes (Jira)
[ https://issues.jboss.org/browse/ISPN-10886?page=com.atlassian.jira.plugin... ]
Gustavo Fernandes updated ISPN-10886:
-------------------------------------
Description:
When storing objects unmarshalled (cache configired with key/value encoding as application/x-java-object) or using custom objects in the server (filters, converters, partition handlers, etc) that implements Serializable, the following exception is thrown:
{noformat}
2019-11-05 10:54:11,389 WARN [org.infinispan.PERSISTENCE] (SINGLE_PORT-ServerIO-5-3) ISPN000559: Cannot marshall 'class org.infinispan.spark.domain.Runner': java.lang.IllegalArgumentException: No marshaller registered for Java type org.infinispan.spark.domain.Runner
at org.infinispan.protostream.impl.SerializationContextImpl.getMarshallerDelegate(SerializationContextImpl.java:279)
at org.infinispan.protostream.WrappedMessage.writeMessage(WrappedMessage.java:240)
at org.infinispan.protostream.ProtobufUtil.toWrappedStream(ProtobufUtil.java:196)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToBuffer(PersistenceMarshallerImpl.java:157)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:137)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:145)
at org.infinispan.marshall.core.GlobalMarshaller.writeRawUnknown(GlobalMarshaller.java:638)
at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:627)
at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:618)
at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:384)
at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
at org.infinispan.commands.write.PutKeyValueCommand.writeTo(PutKeyValueCommand.java:81)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:66)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:54)
at org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
at org.infinispan.commands.remote.SingleRpcCommand.writeTo(SingleRpcCommand.java:52)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
at org.infinispan.marshall.exts.CacheRpcCommandExternalizer.marshallParameters(CacheRpcCommandExternalizer.java:120)
{noformat}
This changed between 10.0.0.CR3 and 10.0.1.Final: although JBoss Marshaller is in the classpath and the Hot Rod client users Jboss marshaller, it tries to use protostream to replicate commands involving those objects
The workaround it to annotate all of them with @SerializeWith and write Externalizers
was:
When storing objects unmarshalled (application/x-java-object) or using custom objects in the server (filters, converters, partition handlers, etc) that implements Serializable, the following exception is thrown:
{noformat}
2019-11-05 10:54:11,389 WARN [org.infinispan.PERSISTENCE] (SINGLE_PORT-ServerIO-5-3) ISPN000559: Cannot marshall 'class org.infinispan.spark.domain.Runner': java.lang.IllegalArgumentException: No marshaller registered for Java type org.infinispan.spark.domain.Runner
at org.infinispan.protostream.impl.SerializationContextImpl.getMarshallerDelegate(SerializationContextImpl.java:279)
at org.infinispan.protostream.WrappedMessage.writeMessage(WrappedMessage.java:240)
at org.infinispan.protostream.ProtobufUtil.toWrappedStream(ProtobufUtil.java:196)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToBuffer(PersistenceMarshallerImpl.java:157)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:137)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:145)
at org.infinispan.marshall.core.GlobalMarshaller.writeRawUnknown(GlobalMarshaller.java:638)
at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:627)
at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:618)
at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:384)
at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
at org.infinispan.commands.write.PutKeyValueCommand.writeTo(PutKeyValueCommand.java:81)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:66)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:54)
at org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
at org.infinispan.commands.remote.SingleRpcCommand.writeTo(SingleRpcCommand.java:52)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
at org.infinispan.marshall.exts.CacheRpcCommandExternalizer.marshallParameters(CacheRpcCommandExternalizer.java:120)
{noformat}
This changed between 10.0.0.CR3 and 10.0.1.Final: although JBoss Marshaller is in the classpath and the Hot Rod client users Jboss marshaller, it tries to use protostream to replicate commands involving those objects
The workaround it to annotate all of them with @SerializeWith and write Externalizers
> Server side objects implementing Serializable causes serialization errors
> -------------------------------------------------------------------------
>
> Key: ISPN-10886
> URL: https://issues.jboss.org/browse/ISPN-10886
> Project: Infinispan
> Issue Type: Bug
> Components: Server
> Affects Versions: 10.0.0.Final, 10.0.1.Final
> Reporter: Gustavo Fernandes
> Priority: Major
>
> When storing objects unmarshalled (cache configired with key/value encoding as application/x-java-object) or using custom objects in the server (filters, converters, partition handlers, etc) that implements Serializable, the following exception is thrown:
> {noformat}
> 2019-11-05 10:54:11,389 WARN [org.infinispan.PERSISTENCE] (SINGLE_PORT-ServerIO-5-3) ISPN000559: Cannot marshall 'class org.infinispan.spark.domain.Runner': java.lang.IllegalArgumentException: No marshaller registered for Java type org.infinispan.spark.domain.Runner
> at org.infinispan.protostream.impl.SerializationContextImpl.getMarshallerDelegate(SerializationContextImpl.java:279)
> at org.infinispan.protostream.WrappedMessage.writeMessage(WrappedMessage.java:240)
> at org.infinispan.protostream.ProtobufUtil.toWrappedStream(ProtobufUtil.java:196)
> at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToBuffer(PersistenceMarshallerImpl.java:157)
> at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:137)
> at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:145)
> at org.infinispan.marshall.core.GlobalMarshaller.writeRawUnknown(GlobalMarshaller.java:638)
> at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:627)
> at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:618)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:384)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
> at org.infinispan.commands.write.PutKeyValueCommand.writeTo(PutKeyValueCommand.java:81)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:66)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:54)
> at org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
> at org.infinispan.commands.remote.SingleRpcCommand.writeTo(SingleRpcCommand.java:52)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
> at org.infinispan.marshall.exts.CacheRpcCommandExternalizer.marshallParameters(CacheRpcCommandExternalizer.java:120)
> {noformat}
> This changed between 10.0.0.CR3 and 10.0.1.Final: although JBoss Marshaller is in the classpath and the Hot Rod client users Jboss marshaller, it tries to use protostream to replicate commands involving those objects
> The workaround it to annotate all of them with @SerializeWith and write Externalizers
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (ISPN-10886) Server side objects implementing Serializable causes serialization errors
by Gustavo Fernandes (Jira)
[ https://issues.jboss.org/browse/ISPN-10886?page=com.atlassian.jira.plugin... ]
Gustavo Fernandes updated ISPN-10886:
-------------------------------------
Description:
When storing objects unmarshalled (application/x-java-object) or using custom objects in the server (filters, converters, partition handlers, etc) that implements Serializable, the following exception is thrown:
{noformat}
2019-11-05 10:54:11,389 WARN [org.infinispan.PERSISTENCE] (SINGLE_PORT-ServerIO-5-3) ISPN000559: Cannot marshall 'class org.infinispan.spark.domain.Runner': java.lang.IllegalArgumentException: No marshaller registered for Java type org.infinispan.spark.domain.Runner
at org.infinispan.protostream.impl.SerializationContextImpl.getMarshallerDelegate(SerializationContextImpl.java:279)
at org.infinispan.protostream.WrappedMessage.writeMessage(WrappedMessage.java:240)
at org.infinispan.protostream.ProtobufUtil.toWrappedStream(ProtobufUtil.java:196)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToBuffer(PersistenceMarshallerImpl.java:157)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:137)
at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:145)
at org.infinispan.marshall.core.GlobalMarshaller.writeRawUnknown(GlobalMarshaller.java:638)
at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:627)
at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:618)
at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:384)
at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
at org.infinispan.commands.write.PutKeyValueCommand.writeTo(PutKeyValueCommand.java:81)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:66)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:54)
at org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
at org.infinispan.commands.remote.SingleRpcCommand.writeTo(SingleRpcCommand.java:52)
at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
at org.infinispan.marshall.exts.CacheRpcCommandExternalizer.marshallParameters(CacheRpcCommandExternalizer.java:120)
{noformat}
This changed between 10.0.0.CR3 and 10.0.1.Final: although JBoss Marshaller is in the classpath and the Hot Rod client users Jboss marshaller, it tries to use protostream to replicate commands involving those objects
The workaround it to annotate all of them with @SerializeWith and write Externalizers
was:
This changed between 10.0.0.CR3 and 10.0.1.Final: filters/converters/entities deployed on the server that implements Serializable don't work any more: although JBoss Marshaller is in the classpath and the Hot Rod client users Jboss marshaller, it tries to use protostream to replicate commands involving those objects
The workaround it to annotate all of them with @SerializeWith and write Externalizers
> Server side objects implementing Serializable causes serialization errors
> -------------------------------------------------------------------------
>
> Key: ISPN-10886
> URL: https://issues.jboss.org/browse/ISPN-10886
> Project: Infinispan
> Issue Type: Bug
> Components: Server
> Affects Versions: 10.0.0.Final, 10.0.1.Final
> Reporter: Gustavo Fernandes
> Priority: Major
>
> When storing objects unmarshalled (application/x-java-object) or using custom objects in the server (filters, converters, partition handlers, etc) that implements Serializable, the following exception is thrown:
> {noformat}
> 2019-11-05 10:54:11,389 WARN [org.infinispan.PERSISTENCE] (SINGLE_PORT-ServerIO-5-3) ISPN000559: Cannot marshall 'class org.infinispan.spark.domain.Runner': java.lang.IllegalArgumentException: No marshaller registered for Java type org.infinispan.spark.domain.Runner
> at org.infinispan.protostream.impl.SerializationContextImpl.getMarshallerDelegate(SerializationContextImpl.java:279)
> at org.infinispan.protostream.WrappedMessage.writeMessage(WrappedMessage.java:240)
> at org.infinispan.protostream.ProtobufUtil.toWrappedStream(ProtobufUtil.java:196)
> at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToBuffer(PersistenceMarshallerImpl.java:157)
> at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:137)
> at org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:145)
> at org.infinispan.marshall.core.GlobalMarshaller.writeRawUnknown(GlobalMarshaller.java:638)
> at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:627)
> at org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:618)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:384)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
> at org.infinispan.commands.write.PutKeyValueCommand.writeTo(PutKeyValueCommand.java:81)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:66)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeObject(ReplicableCommandExternalizer.java:54)
> at org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
> at org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
> at org.infinispan.commands.remote.SingleRpcCommand.writeTo(SingleRpcCommand.java:52)
> at org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
> at org.infinispan.marshall.exts.CacheRpcCommandExternalizer.marshallParameters(CacheRpcCommandExternalizer.java:120)
> {noformat}
> This changed between 10.0.0.CR3 and 10.0.1.Final: although JBoss Marshaller is in the classpath and the Hot Rod client users Jboss marshaller, it tries to use protostream to replicate commands involving those objects
> The workaround it to annotate all of them with @SerializeWith and write Externalizers
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (ISPN-10901) Deprecate Transport configuration and always use JGroupsTransport
by Dan Berindei (Jira)
Dan Berindei created ISPN-10901:
-----------------------------------
Summary: Deprecate Transport configuration and always use JGroupsTransport
Key: ISPN-10901
URL: https://issues.jboss.org/browse/ISPN-10901
Project: Infinispan
Issue Type: Task
Components: Configuration, Core
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 10.1.0.Beta1
Deprecate the {{TransportConfiguration.transport()}} configuration and surface {{channelConfigurator}} or {{channelLookup}} (or a mixture of the 2) as attributes instead of properties.
The {{configurationX}} properties should also be attributes in {{TransportConfiguration}}.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (ISPN-9620) Rolling Upgrade Marshaller Changes
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9620?page=com.atlassian.jira.plugin.... ]
Ryan Emerson commented on ISPN-9620:
------------------------------------
[~gustavonalle] This is built upon what was discussed at last years F2F. It is a long term goal we're working towards and does not intend to replace the current rolling upgrades that we have. The idea is that we get to the stage where we can do the following types of upgrade:
# Offline upgrade (start/stop). Cache stores are dumped using the old ISPN cluster, new ISPN cluster brought up using the old date.
# [Kuberenetes Rolling updates|https://kubernetes.io/docs/tutorials/kubernetes-basics/update/update-intro/]. This is the long term goal, which requires more than marshalling changes, e.g. versioned interceptor stacks. The marshalling changes are required in this context to allow over the air compatibility between ISPN versions.
> Rolling Upgrade Marshaller Changes
> ----------------------------------
>
> Key: ISPN-9620
> URL: https://issues.jboss.org/browse/ISPN-9620
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core, Loaders and Stores
> Affects Versions: 9.4.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.Final
>
>
> In order to allow for compatibility between infinispan versions it is necessary for us to utilise a marshalling implementation at both the cluster (internal node-to-node communication) and persistence layer that is strictly defined but allows for future changes. This is necessary in order to facilitate both rolling and start/stop upgrades. Protocol buffers should be utilised as the wire/storage format, with protostream providing the implementation.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (ISPN-3843) Remove broadcast/unicast optimization in JGroupsTransport
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-3843?page=com.atlassian.jira.plugin.... ]
Dan Berindei resolved ISPN-3843.
--------------------------------
Fix Version/s: 9.1.0.Final
Resolution: Done
Fixed with ISPN-6971
> Remove broadcast/unicast optimization in JGroupsTransport
> ---------------------------------------------------------
>
> Key: ISPN-3843
> URL: https://issues.jboss.org/browse/ISPN-3843
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 6.0.0.Final
> Reporter: Dan Berindei
> Priority: Major
> Fix For: 9.1.0.Final
>
>
> The broadcast/unicast optimization in JGroupsTransport can break the message ordering for regular messages, because NAKACK[2] and UNICAST[2|3] have their own ordering.
> We should test if this optimization really brings any performance benefits and eliminate it, at least for asynchronous commands.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (ISPN-9897) ClusterExecutor shouldn't rely on JGroupsTransport
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9897?page=com.atlassian.jira.plugin.... ]
Dan Berindei updated ISPN-9897:
-------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 10.0.0.Beta1
Resolution: Done
> ClusterExecutor shouldn't rely on JGroupsTransport
> --------------------------------------------------
>
> Key: ISPN-9897
> URL: https://issues.jboss.org/browse/ISPN-9897
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Reporter: Will Burns
> Assignee: Will Burns
> Priority: Major
> Fix For: 10.0.0.Beta1
>
>
> Cluster Executor currently uses transport to send messages. However the initial implementation used JGroupsTransport. Either this was a mistake at the time or enough classes have been refactored that this is no longer needed and just the Transport class can be used instead.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months