[JBoss JIRA] (ISPN-10868) Default whitelist should allow primitives, arrays and reference arrays
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10868?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10868:
-----------------------------------
Sprint: DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #36)
> Default whitelist should allow primitives, arrays and reference arrays
> ----------------------------------------------------------------------
>
> Key: ISPN-10868
> URL: https://issues.jboss.org/browse/ISPN-10868
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Affects Versions: 9.4.16.Final, 10.0.0.Final
> Reporter: dan.berindei
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.Final
>
>
> Java serialization whitelist should include primitive wrapper classes and arrays types, if only because it's tedious to specify all of them in the configuration.
> There's a similar argument for adding {{java.util.ArrayList}} to the default whitelist, especially to use as keys, because {{Object[]}} keys do not work with {{OBJECT}} storage ({{equals()}} and {{hashCode()}} are wrong). I'm not convinced yet, because applications eventually want to use a custom key class, and POCs can get away with converting to {{String}} and concatenating.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (ISPN-10866) Wildfly InfinispanExtension Should always use jboss-marshalling
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10866?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10866:
-----------------------------------
Sprint: DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #36)
> Wildfly InfinispanExtension Should always use jboss-marshalling
> ---------------------------------------------------------------
>
> Key: ISPN-10866
> URL: https://issues.jboss.org/browse/ISPN-10866
> Project: Infinispan
> Issue Type: Bug
> Components: WildFly Server
> Affects Versions: 10.0.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.1.Final, 10.1.0.Final
>
>
> The InfinsipanExtension should always utilise the {{JBossUserMarshaller}} as it's not possible to configure a user marshaller via the DMR or server XML. This means that the marshalling behaviour is the same as in the 9.4.x stream and provided Externalizers are still used.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (ISPN-10865) NPE if DefaultCacheManager ClassWhiteList utilised on component start()
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10865?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10865:
-----------------------------------
Sprint: DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #36)
> NPE if DefaultCacheManager ClassWhiteList utilised on component start()
> -----------------------------------------------------------------------
>
> Key: ISPN-10865
> URL: https://issues.jboss.org/browse/ISPN-10865
> Project: Infinispan
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 10.0.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.1.Final, 10.1.0.Final
>
>
> A NPE is thrown if the {{DefaultCacheManager}} is created using a xml file directly, i.e {{new DefaultCacheManager("some.xml")}}. This is because the ClassWhiteList instance is initialized after the GlobalComponentRegistry is created.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (ISPN-10862) SpringCache unwrapping NullValue singleton fails with Java Serialization
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10862?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10862:
-----------------------------------
Sprint: DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #36)
> SpringCache unwrapping NullValue singleton fails with Java Serialization
> ------------------------------------------------------------------------
>
> Key: ISPN-10862
> URL: https://issues.jboss.org/browse/ISPN-10862
> Project: Infinispan
> Issue Type: Bug
> Components: Spring Integration
> Affects Versions: 10.0.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Blocker
> Fix For: 10.0.1.Final, 10.1.0.Final
>
>
> Our spring integration makes use of the {{NullValue.NULL}} singleton when wrapping null values, however the singleton semantics are not respected when Java Serialization is used as this was previously enforced by a {{Externalizer}} implementation.
> Therefore, the NullValue wrapper is never unwrapped.
> .SpringCache
> private ValueWrapper wrap(Object value) {
> if (value == null) {
> return null;
> }
> if (value == NullValue.NULL) {
> return NullValue.NULL;
> }
> return new SimpleValueWrapper(value);
> }
> private <T> T unwrapNull(Object value) {
> if (value == NullValue.NULL) {
> return null;
> }
> return (T) value;
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (ISPN-10861) Wildfly-modules integration tests marshalling failures
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10861?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10861:
-----------------------------------
Sprint: DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #36)
> Wildfly-modules integration tests marshalling failures
> ------------------------------------------------------
>
> Key: ISPN-10861
> URL: https://issues.jboss.org/browse/ISPN-10861
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 10.0.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.1.Final, 10.1.0.Beta1
>
>
> Failures in integrationtests/wildfly-modules
> {{InfinispanQueryIT}}
> {code:java}
> 2019-10-28 20:15:17,353 WARN [org.infinispan.PERSISTENCE] (remote-thread--p11-t1) ISPN000559: Cannot marshall 'class org.infinispan.test.integration.as.query.Book': java.lang.IllegalArgumentException: No marshaller registered for Java type org.infinispan.test.integration.as.query.Book
> at org.infinispan.protostream:ispn-10.0//org.infinispan.protostream.impl.SerializationContextImpl.getMarshallerDelegate(SerializationContextImpl.java:279)
> at org.infinispan.protostream:ispn-10.0//org.infinispan.protostream.WrappedMessage.writeMessage(WrappedMessage.java:240)
> at org.infinispan.protostream:ispn-10.0//org.infinispan.protostream.ProtobufUtil.toWrappedStream(ProtobufUtil.java:196)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToBuffer(PersistenceMarshallerImpl.java:157)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:137)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.persistence.impl.PersistenceMarshallerImpl.objectToByteBuffer(PersistenceMarshallerImpl.java:145)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeRawUnknown(GlobalMarshaller.java:638)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:627)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeUnknown(GlobalMarshaller.java:618)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:384)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.container.entries.ImmortalCacheEntry$Externalizer.writeObject(ImmortalCacheEntry.java:111)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.container.entries.ImmortalCacheEntry$Externalizer.writeObject(ImmortalCacheEntry.java:107)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
> at org.infinispan.commons:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.commons.marshall.MarshallUtil.marshallCollection(MarshallUtil.java:252)
> at org.infinispan.commons:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.commons.marshall.MarshallUtil.marshallCollection(MarshallUtil.java:230)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.exts.CollectionExternalizer.writeObject(CollectionExternalizer.java:76)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.exts.CollectionExternalizer.writeObject(CollectionExternalizer.java:28)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.StateChunk$Externalizer.writeObject(StateChunk.java:80)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.StateChunk$Externalizer.writeObject(StateChunk.java:65)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.BytesObjectOutput.writeObject(BytesObjectOutput.java:26)
> at org.infinispan.commons:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.commons.marshall.MarshallUtil.marshallCollection(MarshallUtil.java:252)
> at org.infinispan.commons:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.commons.marshall.MarshallUtil.marshallCollection(MarshallUtil.java:230)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.StateResponseCommand.writeTo(StateResponseCommand.java:135)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.exts.ReplicableCommandExternalizer.writeCommandParameters(ReplicableCommandExternalizer.java:70)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.exts.CacheRpcCommandExternalizer.marshallParameters(CacheRpcCommandExternalizer.java:120)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.exts.CacheRpcCommandExternalizer.writeObject(CacheRpcCommandExternalizer.java:116)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.exts.CacheRpcCommandExternalizer.writeObject(CacheRpcCommandExternalizer.java:66)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeInternal(GlobalMarshaller.java:656)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNonNullableObject(GlobalMarshaller.java:371)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeNullableObject(GlobalMarshaller.java:352)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeObjectOutput(GlobalMarshaller.java:181)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.writeObjectOutput(GlobalMarshaller.java:174)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.marshall.core.GlobalMarshaller.objectToBuffer(GlobalMarshaller.java:302)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.remoting.transport.jgroups.JGroupsTransport.marshallRequest(JGroupsTransport.java:1054)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.remoting.transport.jgroups.JGroupsTransport.sendCommand(JGroupsTransport.java:1042)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.remoting.transport.jgroups.JGroupsTransport.invokeCommand(JGroupsTransport.java:879)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.remoting.rpc.RpcManagerImpl.invokeCommand(RpcManagerImpl.java:162)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.OutboundTransferTask.sendEntries(OutboundTransferTask.java:214)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.OutboundTransferTask.access$000(OutboundTransferTask.java:47)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.OutboundTransferTask$1.onComplete(OutboundTransferTask.java:158)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.mixed.FlowableConcatMapCompletable$ConcatMapCompletableObserver.drain(FlowableConcatMapCompletable.java:223)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.mixed.FlowableConcatMapCompletable$ConcatMapCompletableObserver.onComplete(FlowableConcatMapCompletable.java:149)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.flowable.FlowableTakeUntilPredicate$InnerSubscriber.onComplete(FlowableTakeUntilPredicate.java:89)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.flowable.FlowableBuffer$PublisherBufferExactSubscriber.onComplete(FlowableBuffer.java:154)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.flowable.FlowableConcatArray$ConcatArraySubscriber.onComplete(FlowableConcatArray.java:112)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.flowable.FlowableConcatArray.subscribeActual(FlowableConcatArray.java:40)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.Flowable.subscribe(Flowable.java:14826)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.flowable.FlowableBuffer.subscribeActual(FlowableBuffer.java:47)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.Flowable.subscribe(Flowable.java:14826)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.flowable.FlowableTakeUntilPredicate.subscribeActual(FlowableTakeUntilPredicate.java:33)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.Flowable.subscribe(Flowable.java:14826)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.internal.operators.mixed.FlowableConcatMapCompletable.subscribeActual(FlowableConcatMapCompletable.java:61)
> at io.reactivex.rxjava2.rxjava:ispn-10.0//io.reactivex.Completable.subscribe(Completable.java:2309)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.OutboundTransferTask.execute(OutboundTransferTask.java:149)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.StateProviderImpl.startOutboundTransfer(StateProviderImpl.java:290)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.statetransfer.StateRequestCommand.invokeAsync(StateRequestCommand.java:103)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.remoting.inboundhandler.BasePerCacheInboundInvocationHandler.invokeCommand(BasePerCacheInboundInvocationHandler.java:116)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.remoting.inboundhandler.BaseBlockingRunnable.invoke(BaseBlockingRunnable.java:100)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.remoting.inboundhandler.BaseBlockingRunnable.runAsync(BaseBlockingRunnable.java:72)
> at org.infinispan.core:ispn-10.0@10.1.0-SNAPSHOT//org.infinispan.remoting.inboundhandler.BaseBlockingRunnable.run(BaseBlockingRunnable.java:41)
> at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (ISPN-10857) Add infinispan-jboss-marshalling to server distribution for transcoding
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10857?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10857:
-----------------------------------
Sprint: DataGrid Sprint #35, DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #35, DataGrid Sprint #36)
> Add infinispan-jboss-marshalling to server distribution for transcoding
> -----------------------------------------------------------------------
>
> Key: ISPN-10857
> URL: https://issues.jboss.org/browse/ISPN-10857
> Project: Infinispan
> Issue Type: Bug
> Components: Server
> Affects Versions: 10.0.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.1.Final, 10.1.0.Beta1, 10.1.0.Final
>
>
> ISPN-10591 made Protostream the default user marshaller, as well as removing the {{infinispan-jboss-marshalling}} from most modules. However, making the dependency optional on the remote store, stopped the jar being pulled in by {{server/runtime}}. Consequently, there is no longer a transcoder for {{application/x-jboss-marshalling}} which causes compatibility issues with older clients.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months
[JBoss JIRA] (ISPN-10856) Proto lock files not committed during .Final release
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10856?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10856:
-----------------------------------
Sprint: DataGrid Sprint #35, DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #35, DataGrid Sprint #36)
> Proto lock files not committed during .Final release
> ----------------------------------------------------
>
> Key: ISPN-10856
> URL: https://issues.jboss.org/browse/ISPN-10856
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.0.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.1.Final, 10.1.0.Final
>
>
> The {{Commit Proto.lock Files}} stage of the pipeline executed during the release build, however the generated {{proto.lock}} files were not committed to git. This occurrs because the stage is executed before the {{checkout}} phase.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 4 months