[JBoss JIRA] (ISPN-10699) Add Transcoder name to log statements to aid debugging
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10699?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10699:
-----------------------------------
Sprint: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36)
> Add Transcoder name to log statements to aid debugging
> ------------------------------------------------------
>
> Key: ISPN-10699
> URL: https://issues.jboss.org/browse/ISPN-10699
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core
> Affects Versions: 10.0.0.CR2
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.CR3
>
>
> Currently the error message returned to the client when a transcoding exception occurs is not very detailed as the stack trace is where the `HotRodClientException` is thrown and the server error message does not detail the transcoder that encountered the issue.
> We should include the name of the transcoder in the server exception to aid debugging.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-10707) Jcache: loaded entries should use ExpiryPolicy.getExpiryForCreation()
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10707?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10707:
-----------------------------------
Sprint: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36)
> Jcache: loaded entries should use ExpiryPolicy.getExpiryForCreation()
> ---------------------------------------------------------------------
>
> Key: ISPN-10707
> URL: https://issues.jboss.org/browse/ISPN-10707
> Project: Infinispan
> Issue Type: Bug
> Components: Core, JCache
> Affects Versions: 10.0.0.CR2
> Reporter: dan.berindei
> Assignee: dan.berindei
> Priority: Major
> Fix For: 10.0.0.Final
>
>
> {{MVCCEntry.isLoaded()}} is not used in the core, but JCache uses it do decide whether to call {{ExpiryPolicy.getExpiryForCreation()}} or {{ExpiryPolicy.getExpiryForAccess()}}.
> ISPN-8086 accidentally removed the {{ReadCommittedEntry}} implementation along with {{CacheEntry.isLoaded()}}, but the {{CacheExpiryTest}} test failure got ignored because Jenkins ignores the TCK test suite results (ISPN-10379).
> {noformat}
> [OK: 14, KO: 1, SKIP: 0] Test failed: CacheExpiryTest.invokeAllReadThroughEnabledGetOnNonExistentEntry
> java.lang.AssertionError:
> Expected: is <0>
> but: was <5>
> at org.jsr107.tck.expiry.CacheExpiryTest.invokeAllReadThroughEnabledGetOnNonExistentEntry(CacheExpiryTest.java:1202)
> [OK: 15, KO: 2, SKIP: 0] Test failed: CacheExpiryTest.invokeGetValueWithReadThroughForNonExistentEntryShouldCallGetExpiryForCreatedEntry
> java.lang.AssertionError:
> Expected: is <0>
> but: was <1>
> at org.jsr107.tck.expiry.CacheExpiryTest.invokeGetValueWithReadThroughForNonExistentEntryShouldCallGetExpiryForCreatedEntry(CacheExpiryTest.java:1110)
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-10718) Ensure protobuf metadata cache is predictably started when the cache manager has finished initializing
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10718?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10718:
-----------------------------------
Sprint: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36)
> Ensure protobuf metadata cache is predictably started when the cache manager has finished initializing
> ------------------------------------------------------------------------------------------------------
>
> Key: ISPN-10718
> URL: https://issues.jboss.org/browse/ISPN-10718
> Project: Infinispan
> Issue Type: Enhancement
> Components: Remote Querying
> Affects Versions: 10.0.0.CR2
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 10.0.0.Final
>
>
> Casual code browsing led me to ProtobufMetadataCacheStartedTest where I see we actually assert that protobuf metadata cache is not started on cache manager start, it is actually started lazily, when first non-internal cache starts. And the code is written as if this is a (happy) accident. That's very dangerous. We should start it predictably, when the cache manager has finished startup.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-10719) JCache: CacheManager.destroyCache should not remove internal caches
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10719?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10719:
-----------------------------------
Sprint: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36)
> JCache: CacheManager.destroyCache should not remove internal caches
> -------------------------------------------------------------------
>
> Key: ISPN-10719
> URL: https://issues.jboss.org/browse/ISPN-10719
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Affects Versions: 10.0.0.CR2
> Reporter: dan.berindei
> Assignee: dan.berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 10.0.0.Final
>
>
> {{___protobuf_metadata}} is an internal cache, but it is also exposed to users -- including JCache users, who see it as a predefined cache.
> Some JCache TCK tests try to remove all caches between test methods using
> {{CacheManager.destroyCache()}}. By removing {{___protobuf_metadata}} they break {{ProtobufMetadataManagerImpl}} and don't allow the following tests to create any new caches:
> {noformat}
> [2019-10-01T07:11:13.651Z] [OK: 144, KO: 1, SKIP: 0] Test failed: CacheExpiryTest.testCacheStatisticsRemoveAllNoneExpired
> [2019-10-01T07:11:13.651Z] org.infinispan.commons.CacheConfigurationException: ISPN000436: Cache '___protobuf_metadata' has been requested, but no cache configuration exists with that name and no default cache has been set for this container
> [2019-10-01T07:11:13.651Z] at org.infinispan.configuration.ConfigurationManager.getConfiguration(ConfigurationManager.java:65)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.wireAndStartCache(DefaultCacheManager.java:637)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.createCache(DefaultCacheManager.java:626)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.internalGetCache(DefaultCacheManager.java:511)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:495)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:488)
> [2019-10-01T07:11:13.651Z] at org.infinispan.query.remote.impl.SecurityActions.lambda$getUnwrappedCache$0(SecurityActions.java:43)
> [2019-10-01T07:11:13.651Z] at org.infinispan.security.Security.doPrivileged(Security.java:47)
> [2019-10-01T07:11:13.651Z] at org.infinispan.query.remote.impl.SecurityActions.doPrivileged(SecurityActions.java:30)
> [2019-10-01T07:11:13.651Z] at org.infinispan.query.remote.impl.SecurityActions.getUnwrappedCache(SecurityActions.java:42)
> [2019-10-01T07:11:13.651Z] at org.infinispan.query.remote.impl.ProtobufMetadataManagerImpl.addCacheDependency(ProtobufMetadataManagerImpl.java:68)
> [2019-10-01T07:11:13.651Z] at org.infinispan.query.remote.impl.LifecycleManager.cacheStarting(LifecycleManager.java:215)
> [2019-10-01T07:11:13.651Z] at org.infinispan.factories.ComponentRegistry.notifyCacheStarting(ComponentRegistry.java:223)
> [2019-10-01T07:11:13.651Z] at org.infinispan.factories.ComponentRegistry.preStart(ComponentRegistry.java:213)
> [2019-10-01T07:11:13.651Z] at org.infinispan.factories.AbstractComponentRegistry.start(AbstractComponentRegistry.java:238)
> [2019-10-01T07:11:13.651Z] at org.infinispan.factories.ComponentRegistry.start(ComponentRegistry.java:203)
> [2019-10-01T07:11:13.651Z] at org.infinispan.cache.impl.CacheImpl.start(CacheImpl.java:1082)
> [2019-10-01T07:11:13.651Z] at org.infinispan.cache.impl.AbstractDelegatingCache.start(AbstractDelegatingCache.java:512)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.wireAndStartCache(DefaultCacheManager.java:682)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.createCache(DefaultCacheManager.java:626)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.internalGetCache(DefaultCacheManager.java:511)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:495)
> [2019-10-01T07:11:13.651Z] at org.infinispan.manager.DefaultCacheManager.getCache(DefaultCacheManager.java:488)
> [2019-10-01T07:11:13.651Z] at org.infinispan.jcache.embedded.JCacheManager.create(JCacheManager.java:149)
> [2019-10-01T07:11:13.651Z] at org.infinispan.jcache.AbstractJCacheManager.createCache(AbstractJCacheManager.java:93)
> [2019-10-01T07:11:13.651Z] at org.jsr107.tck.expiry.CacheExpiryTest.testCacheStatisticsRemoveAllNoneExpired(CacheExpiryTest.java:163)
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-10721) jcache/tck-runner module should not unpack cache-tests
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10721?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10721:
-----------------------------------
Sprint: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36, DataGrid Sprint #37 (was: DataGrid Sprint #34, DataGrid Sprint #35, DataGrid Sprint #36)
> jcache/tck-runner module should not unpack cache-tests
> ------------------------------------------------------
>
> Key: ISPN-10721
> URL: https://issues.jboss.org/browse/ISPN-10721
> Project: Infinispan
> Issue Type: Bug
> Components: JCache, Test Suite
> Affects Versions: 10.0.0.CR2
> Reporter: dan.berindei
> Assignee: dan.berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 10.0.0.Final
>
>
> The {{jcache/tck-runner}} module is unpacking the {{cache-tests}} dependency (the TCK) in the target directory so that the Surefire Maven plugin can find and run the tests.
> This started breaking since the upgrade to Weld 2.3.4.Final (ISPN-10383), because Weld now finds the TCK beans in two different locations:
> {noformat}
> [2019-10-01T07:12:01.511Z] [OK: 214, KO: 1, SKIP: 0] Test failed: InterceptionUsingCacheConfigTest.test_AT_CacheResult
> [2019-10-01T07:12:01.511Z] org.jboss.weld.exceptions.AmbiguousResolutionException: WELD-001318: Cannot resolve an ambiguous dependency between:
> [2019-10-01T07:12:01.511Z] - Managed Bean [class manager.ClassLevelCacheConfigBlogManagerImpl] with qualifiers [@Any @Default],
> [2019-10-01T07:12:01.511Z] - Managed Bean [class manager.ClassLevelCacheConfigBlogManagerImpl] with qualifiers [@Any @Default]
> [2019-10-01T07:12:01.511Z] at org.jboss.weld.manager.BeanManagerImpl.resolve(BeanManagerImpl.java:1235)
> [2019-10-01T07:12:01.511Z] at org.jsr107.tck.annotations.cdi.test.CdiBeanProvider.getBeanByType(CdiBeanProvider.java:47)
> [2019-10-01T07:12:01.511Z] at org.jsr107.tck.annotation.AbstractInterceptionTest.getBeanByType(AbstractInterceptionTest.java:66)
> [2019-10-01T07:12:01.511Z] at org.jsr107.tck.annotation.InterceptionUsingCacheConfigTest.getBlogManager(InterceptionUsingCacheConfigTest.java:23)
> [2019-10-01T07:12:01.511Z] at org.jsr107.tck.annotation.AbstractBlogManagerInterceptionTest.before(AbstractBlogManagerInterceptionTest.java:26)
> {noformat}
> Fortunately we don't have to unpack the tests in our working directory, we can tell Surefire to run the tests from the jar instead:
> {code:xml}
> <dependenciesToScan>
> <dependency>javax.cache:cache-tests</dependency>
> </dependenciesToScan>
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month