[JBoss JIRA] (ISPN-10955) Reduce Primitive To Object Conversion - RequestRepository.addResponse(long, Address, Response)
by Diego Lovison (Jira)
[ https://issues.jboss.org/browse/ISPN-10955?page=com.atlassian.jira.plugin... ]
Diego Lovison reassigned ISPN-10955:
------------------------------------
Assignee: Diego Lovison
> Reduce Primitive To Object Conversion - RequestRepository.addResponse(long, Address, Response)
> ----------------------------------------------------------------------------------------------
>
> Key: ISPN-10955
> URL: https://issues.jboss.org/browse/ISPN-10955
> Project: Infinispan
> Issue Type: Enhancement
> Affects Versions: 10.0.1.Final
> Reporter: Diego Lovison
> Assignee: Diego Lovison
> Priority: Major
>
> 1 % of the total allocation (214 MiB) is caused by conversion from primitive types to object types.
> The most common object type that primitives are converted into is 'java.lang.Long', which causes 214 MiB to be allocated. The most common call site is 'org.infinispan.remoting.transport.impl.RequestRepository.addResponse(long, Address, Response):46'.
> Conversion from primitives to the corresponding object types can either be done explicitly, or be caused by autoboxing. If a considerable amount of the total allocation is caused by such conversions, consider changing the application source code to avoid this behavior. Look at the allocation stack traces to see which parts of the code to change. This rule finds the calls to the valueOf method for any of the eight object types that have primitive counterparts.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10955) Reduce Primitive To Object Conversion - RequestRepository.addResponse(long, Address, Response)
by Diego Lovison (Jira)
[ https://issues.jboss.org/browse/ISPN-10955?page=com.atlassian.jira.plugin... ]
Diego Lovison updated ISPN-10955:
---------------------------------
Status: Open (was: New)
> Reduce Primitive To Object Conversion - RequestRepository.addResponse(long, Address, Response)
> ----------------------------------------------------------------------------------------------
>
> Key: ISPN-10955
> URL: https://issues.jboss.org/browse/ISPN-10955
> Project: Infinispan
> Issue Type: Enhancement
> Affects Versions: 10.0.1.Final
> Reporter: Diego Lovison
> Priority: Major
>
> 1 % of the total allocation (214 MiB) is caused by conversion from primitive types to object types.
> The most common object type that primitives are converted into is 'java.lang.Long', which causes 214 MiB to be allocated. The most common call site is 'org.infinispan.remoting.transport.impl.RequestRepository.addResponse(long, Address, Response):46'.
> Conversion from primitives to the corresponding object types can either be done explicitly, or be caused by autoboxing. If a considerable amount of the total allocation is caused by such conversions, consider changing the application source code to avoid this behavior. Look at the allocation stack traces to see which parts of the code to change. This rule finds the calls to the valueOf method for any of the eight object types that have primitive counterparts.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10868) Default whitelist should allow primitives, arrays and reference arrays
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10868?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-10868:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Default whitelist should allow primitives, arrays and reference arrays
> ----------------------------------------------------------------------
>
> Key: ISPN-10868
> URL: https://issues.jboss.org/browse/ISPN-10868
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Affects Versions: 9.4.16.Final, 10.0.0.Final
> Reporter: Dan Berindei
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.Final
>
>
> Java serialization whitelist should include primitive wrapper classes and arrays types, if only because it's tedious to specify all of them in the configuration.
> There's a similar argument for adding {{java.util.ArrayList}} to the default whitelist, especially to use as keys, because {{Object[]}} keys do not work with {{OBJECT}} storage ({{equals()}} and {{hashCode()}} are wrong). I'm not convinced yet, because applications eventually want to use a custom key class, and POCs can get away with converting to {{String}} and concatenating.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10377) listener CacheEntryExpired callback , key is not locked
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10377?page=com.atlassian.jira.plugin... ]
Dan Berindei commented on ISPN-10377:
-------------------------------------
I've changed the type from bug to feature request because the {{CacheEntryExpired}} listener is intentionally not invoked while holding the lock (with {{pre == true}}).
> listener CacheEntryExpired callback , key is not locked
> -------------------------------------------------------
>
> Key: ISPN-10377
> URL: https://issues.jboss.org/browse/ISPN-10377
> Project: Infinispan
> Issue Type: Feature Request
> Components: API
> Affects Versions: 9.4.15.Final
> Reporter: Alexander Malysh
> Assignee: Will Burns
> Priority: Major
> Attachments: CacheTest1.java, infinispan-test.xml
>
>
> Hi,
> it looks like that CacheEntryExpired callback is called without a key lock held like CacheEntryRemoved. In this scenario I'm unable to synchronize keys if reaper thread is enabled.
> I'm attaching simple test case that will show this issue. Because it's a classical race condition please start this test multiple times if result should be ok.
> Thanks in advance!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10377) listener CacheEntryExpired callback , key is not locked
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10377?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-10377:
--------------------------------
Issue Type: Feature Request (was: Bug)
> listener CacheEntryExpired callback , key is not locked
> -------------------------------------------------------
>
> Key: ISPN-10377
> URL: https://issues.jboss.org/browse/ISPN-10377
> Project: Infinispan
> Issue Type: Feature Request
> Components: API
> Affects Versions: 9.4.15.Final
> Reporter: Alexander Malysh
> Assignee: Will Burns
> Priority: Major
> Attachments: CacheTest1.java, infinispan-test.xml
>
>
> Hi,
> it looks like that CacheEntryExpired callback is called without a key lock held like CacheEntryRemoved. In this scenario I'm unable to synchronize keys if reaper thread is enabled.
> I'm attaching simple test case that will show this issue. Because it's a classical race condition please start this test multiple times if result should be ok.
> Thanks in advance!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10924) JPA cache store (with async enabled) will log Exceptions in DEBUG for deleteBatch and is not able to remove entries from the store
by Pedro Ruivo (Jira)
[ https://issues.jboss.org/browse/ISPN-10924?page=com.atlassian.jira.plugin... ]
Pedro Ruivo updated ISPN-10924:
-------------------------------
Fix Version/s: 9.4.17.Final
10.1.0.Beta1
10.0.2.Final
> JPA cache store (with async enabled) will log Exceptions in DEBUG for deleteBatch and is not able to remove entries from the store
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-10924
> URL: https://issues.jboss.org/browse/ISPN-10924
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 9.4.16.Final, 10.0.1.Final, 10.1.0.Beta1
> Environment: Embedded mode with configured ASYNC JPA CacheStore
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 9.4.17.Final, 10.1.0.Beta1, 10.0.2.Final
>
>
> If the cache is configured with a persistence of JPAStore in async mode each modification will log a DEBUG message like followed
> Oct 22, 2019 1:51:08 PM org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor retryWork
> DEBUG: Failed to process async modifications
> org.infinispan.persistence.jpa.JpaStoreException: Exception caught in deleteBatch()
> at org.infinispan.persistence.jpa.JpaStore.deleteBatch(JpaStore.java:357)
> at org.infinispan.persistence.async.AsyncCacheWriter.applyModificationsSync(AsyncCacheWriter.java:234)
> at org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor.retryWork(AsyncCacheWriter.java:463)
> at org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor.run(AsyncCacheWriter.java:423)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.IllegalArgumentException: Parameter value [org.infinispan.persistence.async.AsyncCacheWriter$$Lambda$136/1340865907@4c7c351c] did not match expected type [java.lang.String (n/a)]
> at org.hibernate.query.spi.QueryParameterBindingValidator.validate(QueryParameterBindingValidator.java:54)
> at org.hibernate.query.spi.QueryParameterBindingValidator.validate(QueryParameterBindingValidator.java:27)
> at org.hibernate.query.internal.QueryParameterBindingImpl.validate(QueryParameterBindingImpl.java:90)
> at org.hibernate.query.internal.QueryParameterBindingImpl.setBindValue(QueryParameterBindingImpl.java:55)
> at org.hibernate.query.internal.AbstractProducedQuery.setParameter(AbstractProducedQuery.java:493)
> at org.hibernate.query.internal.AbstractProducedQuery.setParameter(AbstractProducedQuery.java:106)
> at org.hibernate.query.criteria.internal.compile.CriteriaCompiler$1$1.bind(CriteriaCompiler.java:119)
> at org.hibernate.query.criteria.internal.AbstractManipulationCriteriaQuery$1.buildCompiledQuery(AbstractManipulationCriteriaQuery.java:135)
> at org.hibernate.query.criteria.internal.compile.CriteriaCompiler.compile(CriteriaCompiler.java:149)
> at org.hibernate.internal.SessionImpl.createQuery(SessionImpl.java:3724)
> at org.hibernate.internal.SessionImpl.createQuery(SessionImpl.java:207)
> at org.infinispan.persistence.jpa.JpaStore.deleteBatch(JpaStore.java:341)
> ... 6 more
> If entries should be removed this is only done in memory but the store will fail ASYNC.
> Because of the async contract there is only a warning wihtout any exact hint:
> WARN: ISPN000053: Unable to process some async modifications after 10 retries!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10928) Counter SecurityException: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN'
by Pedro Ruivo (Jira)
[ https://issues.jboss.org/browse/ISPN-10928?page=com.atlassian.jira.plugin... ]
Pedro Ruivo updated ISPN-10928:
-------------------------------
Fix Version/s: 9.4.17.Final
> Counter SecurityException: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN'
> -----------------------------------------------------------------------------------------
>
> Key: ISPN-10928
> URL: https://issues.jboss.org/browse/ISPN-10928
> Project: Infinispan
> Issue Type: Bug
> Components: Clustered Counter, Security, WildFly Server
> Affects Versions: 10.0.1.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 9.4.17.Final, 10.1.0.Beta1, 10.0.2.Final
>
>
> {code:java}
> 12:26:41,192 ERROR [stderr] (async-thread--p6-t1) Exception in thread "async-thread--p6-t1" java.lang.SecurityException: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission
> 12:26:41,193 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.core:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.security.impl.AuthorizationHelper.checkPermission(AuthorizationHelper.java:87)
> 12:26:41,193 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.core:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.security.impl.AuthorizationHelper.checkPermission(AuthorizationHelper.java:57)
> 12:26:41,193 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.core:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.manager.DefaultCacheManager.getCacheManagerConfiguration(DefaultCacheManager.java:841)
> 12:26:41,193 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.counter:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.counter.impl.manager.CounterConfigurationManager.threadName(CounterConfigurationManager.java:239)
> 12:26:41,194 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.counter:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.counter.impl.manager.CounterConfigurationManager.lambda$startCounterCache$5(CounterConfigurationManager.java:229)
> 12:26:41,194 ERROR [stderr] (async-thread--p6-t1) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> 12:26:41,194 ERROR [stderr] (async-thread--p6-t1) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> 12:26:41,194 ERROR [stderr] (async-thread--p6-t1) at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> Also thrown when accessing event log.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months