[JBoss JIRA] (ISPN-9620) In-place Rolling Upgrade Marshaller Changes
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9620?page=com.atlassian.jira.plugin.... ]
Work on ISPN-9620 stopped by Ryan Emerson.
------------------------------------------
> In-place Rolling Upgrade Marshaller Changes
> -------------------------------------------
>
> Key: ISPN-9620
> URL: https://issues.jboss.org/browse/ISPN-9620
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core, Loaders and Stores
> Affects Versions: 9.4.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.Final
>
>
> In order to allow for compatibility between infinispan versions it is necessary for us to utilise a marshalling implementation at both the cluster (internal node-to-node communication) and persistence layer that is strictly defined but allows for future changes. This is necessary in order to facilitate both rolling and start/stop upgrades. Protocol buffers should be utilised as the wire/storage format, with protostream providing the implementation.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (ISPN-10924) JPA cache store (with async enabled) will log Exceptions in DEBUG for deleteBatch and is not able to remove entries from the store
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-10924?page=com.atlassian.jira.plugin... ]
Ryan Emerson updated ISPN-10924:
--------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/7560, https://github.com/infinispan/infinispan/pull/7566, https://github.com/infinispan/infinispan/pull/7567 (was: https://github.com/infinispan/infinispan/pull/7560)
> JPA cache store (with async enabled) will log Exceptions in DEBUG for deleteBatch and is not able to remove entries from the store
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-10924
> URL: https://issues.jboss.org/browse/ISPN-10924
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 9.4.16.Final, 10.0.1.Final, 10.1.0.Beta1
> Environment: Embedded mode with configured ASYNC JPA CacheStore
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
>
> If the cache is configured with a persistence of JPAStore in async mode each modification will log a DEBUG message like followed
> Oct 22, 2019 1:51:08 PM org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor retryWork
> DEBUG: Failed to process async modifications
> org.infinispan.persistence.jpa.JpaStoreException: Exception caught in deleteBatch()
> at org.infinispan.persistence.jpa.JpaStore.deleteBatch(JpaStore.java:357)
> at org.infinispan.persistence.async.AsyncCacheWriter.applyModificationsSync(AsyncCacheWriter.java:234)
> at org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor.retryWork(AsyncCacheWriter.java:463)
> at org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor.run(AsyncCacheWriter.java:423)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.IllegalArgumentException: Parameter value [org.infinispan.persistence.async.AsyncCacheWriter$$Lambda$136/1340865907@4c7c351c] did not match expected type [java.lang.String (n/a)]
> at org.hibernate.query.spi.QueryParameterBindingValidator.validate(QueryParameterBindingValidator.java:54)
> at org.hibernate.query.spi.QueryParameterBindingValidator.validate(QueryParameterBindingValidator.java:27)
> at org.hibernate.query.internal.QueryParameterBindingImpl.validate(QueryParameterBindingImpl.java:90)
> at org.hibernate.query.internal.QueryParameterBindingImpl.setBindValue(QueryParameterBindingImpl.java:55)
> at org.hibernate.query.internal.AbstractProducedQuery.setParameter(AbstractProducedQuery.java:493)
> at org.hibernate.query.internal.AbstractProducedQuery.setParameter(AbstractProducedQuery.java:106)
> at org.hibernate.query.criteria.internal.compile.CriteriaCompiler$1$1.bind(CriteriaCompiler.java:119)
> at org.hibernate.query.criteria.internal.AbstractManipulationCriteriaQuery$1.buildCompiledQuery(AbstractManipulationCriteriaQuery.java:135)
> at org.hibernate.query.criteria.internal.compile.CriteriaCompiler.compile(CriteriaCompiler.java:149)
> at org.hibernate.internal.SessionImpl.createQuery(SessionImpl.java:3724)
> at org.hibernate.internal.SessionImpl.createQuery(SessionImpl.java:207)
> at org.infinispan.persistence.jpa.JpaStore.deleteBatch(JpaStore.java:341)
> ... 6 more
> If entries should be removed this is only done in memory but the store will fail ASYNC.
> Because of the async contract there is only a warning wihtout any exact hint:
> WARN: ISPN000053: Unable to process some async modifications after 10 retries!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (ISPN-10855) MultipleCacheManagersTest factory issues are ignored
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10855?page=com.atlassian.jira.plugin... ]
Dan Berindei reopened ISPN-10855:
---------------------------------
The fix went in, but now the core only runs 2835 tests.
> MultipleCacheManagersTest factory issues are ignored
> ----------------------------------------------------
>
> Key: ISPN-10855
> URL: https://issues.jboss.org/browse/ISPN-10855
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.4.16.Final, 10.0.0.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 10.1.0.Beta1
>
>
> TestNG doesn't like exceptions being thrown from {{@Factory}} methods, so when {{MultipleCacheManager.defaultFactory()}} finds a problem with the concrete {{factory()}} implementation or with the annotations it replaces the test instance with a {{TestFrameworkFailure}}.
> Turns out that doesn't actually work: TestNG ignores the {{TestFrameworkFailure}} instance and runs the tests on a "default instance" of the test class. This is ok when the problem is the concrete class didn't override {{factory()}} and very likely the test author wanted a single test instance, but it's not ok for other errors like {{factory()}} being copy-pasted from super with the wrong class name.
> We can make TestNG report our factory failures if we implement {{IInstanceInfo}} and mock all the test/configuration methods to throw our exception. We just need to make all configuration methods non-final so we can mock them.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (ISPN-10928) Counter SecurityException: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN'
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-10928?page=com.atlassian.jira.plugin... ]
Ryan Emerson updated ISPN-10928:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/7563, https://github.com/infinispan/infinispan/pull/7564, https://github.com/infinispan/infinispan/pull/7565
> Counter SecurityException: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN'
> -----------------------------------------------------------------------------------------
>
> Key: ISPN-10928
> URL: https://issues.jboss.org/browse/ISPN-10928
> Project: Infinispan
> Issue Type: Bug
> Components: Clustered Counter, Security, WildFly Server
> Affects Versions: 10.0.1.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
>
> {code:java}
> 12:26:41,192 ERROR [stderr] (async-thread--p6-t1) Exception in thread "async-thread--p6-t1" java.lang.SecurityException: ISPN000287: Unauthorized access: subject 'null' lacks 'ADMIN' permission
> 12:26:41,193 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.core:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.security.impl.AuthorizationHelper.checkPermission(AuthorizationHelper.java:87)
> 12:26:41,193 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.core:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.security.impl.AuthorizationHelper.checkPermission(AuthorizationHelper.java:57)
> 12:26:41,193 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.core:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.manager.DefaultCacheManager.getCacheManagerConfiguration(DefaultCacheManager.java:841)
> 12:26:41,193 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.counter:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.counter.impl.manager.CounterConfigurationManager.threadName(CounterConfigurationManager.java:239)
> 12:26:41,194 ERROR [stderr] (async-thread--p6-t1) at org.infinispan.counter:jdg-7.3@9.4.16.CD20191104-redhat-00001//org.infinispan.counter.impl.manager.CounterConfigurationManager.lambda$startCounterCache$5(CounterConfigurationManager.java:229)
> 12:26:41,194 ERROR [stderr] (async-thread--p6-t1) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> 12:26:41,194 ERROR [stderr] (async-thread--p6-t1) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> 12:26:41,194 ERROR [stderr] (async-thread--p6-t1) at java.base/java.lang.Thread.run(Thread.java:834)
> {code}
> Also thrown when accessing event log.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months