[JBoss JIRA] (ISPN-10929) ClusterPublisher reduction combineStages concurrency level is too high
by Will Burns (Jira)
Will Burns created ISPN-10929:
---------------------------------
Summary: ClusterPublisher reduction combineStages concurrency level is too high
Key: ISPN-10929
URL: https://issues.jboss.org/browse/ISPN-10929
Project: Infinispan
Issue Type: Bug
Components: Core
Reporter: Will Burns
Assignee: Will Burns
The combineStages method in ClusterPublisherImpl currently uses flatMap without an explicit concurrency level. That means it will subscribe to up to 128 futures at the same time. This isn't a problem when only in memory is used as the stages are completed as they are received. However when a segmented store is in play, this means it will process 128 segments at the same time, even when doing sequential publisher.
We should instead limit the concurrency to the cpuCount when the publisher is parallel and just 1 when it is sequential. The latter matches how many threads the upstream publisher will use as well.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-9620) In-place Rolling Upgrade Marshaller Changes
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9620?page=com.atlassian.jira.plugin.... ]
Work on ISPN-9620 stopped by Ryan Emerson.
------------------------------------------
> In-place Rolling Upgrade Marshaller Changes
> -------------------------------------------
>
> Key: ISPN-9620
> URL: https://issues.jboss.org/browse/ISPN-9620
> Project: Infinispan
> Issue Type: Enhancement
> Components: Core, Loaders and Stores
> Affects Versions: 9.4.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.Final
>
>
> In order to allow for compatibility between infinispan versions it is necessary for us to utilise a marshalling implementation at both the cluster (internal node-to-node communication) and persistence layer that is strictly defined but allows for future changes. This is necessary in order to facilitate both rolling and start/stop upgrades. Protocol buffers should be utilised as the wire/storage format, with protostream providing the implementation.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (ISPN-10924) JPA cache store (with async enabled) will log Exceptions in DEBUG for deleteBatch and is not able to remove entries from the store
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-10924?page=com.atlassian.jira.plugin... ]
Ryan Emerson updated ISPN-10924:
--------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/7560, https://github.com/infinispan/infinispan/pull/7566, https://github.com/infinispan/infinispan/pull/7567 (was: https://github.com/infinispan/infinispan/pull/7560)
> JPA cache store (with async enabled) will log Exceptions in DEBUG for deleteBatch and is not able to remove entries from the store
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-10924
> URL: https://issues.jboss.org/browse/ISPN-10924
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 9.4.16.Final, 10.0.1.Final, 10.1.0.Beta1
> Environment: Embedded mode with configured ASYNC JPA CacheStore
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
>
> If the cache is configured with a persistence of JPAStore in async mode each modification will log a DEBUG message like followed
> Oct 22, 2019 1:51:08 PM org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor retryWork
> DEBUG: Failed to process async modifications
> org.infinispan.persistence.jpa.JpaStoreException: Exception caught in deleteBatch()
> at org.infinispan.persistence.jpa.JpaStore.deleteBatch(JpaStore.java:357)
> at org.infinispan.persistence.async.AsyncCacheWriter.applyModificationsSync(AsyncCacheWriter.java:234)
> at org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor.retryWork(AsyncCacheWriter.java:463)
> at org.infinispan.persistence.async.AsyncCacheWriter$AsyncStoreProcessor.run(AsyncCacheWriter.java:423)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.IllegalArgumentException: Parameter value [org.infinispan.persistence.async.AsyncCacheWriter$$Lambda$136/1340865907@4c7c351c] did not match expected type [java.lang.String (n/a)]
> at org.hibernate.query.spi.QueryParameterBindingValidator.validate(QueryParameterBindingValidator.java:54)
> at org.hibernate.query.spi.QueryParameterBindingValidator.validate(QueryParameterBindingValidator.java:27)
> at org.hibernate.query.internal.QueryParameterBindingImpl.validate(QueryParameterBindingImpl.java:90)
> at org.hibernate.query.internal.QueryParameterBindingImpl.setBindValue(QueryParameterBindingImpl.java:55)
> at org.hibernate.query.internal.AbstractProducedQuery.setParameter(AbstractProducedQuery.java:493)
> at org.hibernate.query.internal.AbstractProducedQuery.setParameter(AbstractProducedQuery.java:106)
> at org.hibernate.query.criteria.internal.compile.CriteriaCompiler$1$1.bind(CriteriaCompiler.java:119)
> at org.hibernate.query.criteria.internal.AbstractManipulationCriteriaQuery$1.buildCompiledQuery(AbstractManipulationCriteriaQuery.java:135)
> at org.hibernate.query.criteria.internal.compile.CriteriaCompiler.compile(CriteriaCompiler.java:149)
> at org.hibernate.internal.SessionImpl.createQuery(SessionImpl.java:3724)
> at org.hibernate.internal.SessionImpl.createQuery(SessionImpl.java:207)
> at org.infinispan.persistence.jpa.JpaStore.deleteBatch(JpaStore.java:341)
> ... 6 more
> If entries should be removed this is only done in memory but the store will fail ASYNC.
> Because of the async contract there is only a warning wihtout any exact hint:
> WARN: ISPN000053: Unable to process some async modifications after 10 retries!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months