[JBoss JIRA] (ISPN-10868) Default whitelist should allow primitives, arrays and ArrayList
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-10868?page=com.atlassian.jira.plugin... ]
Ryan Emerson updated ISPN-10868:
--------------------------------
Summary: Default whitelist should allow primitives, arrays and ArrayList (was: Default whitelist should allow primitives and arrays)
> Default whitelist should allow primitives, arrays and ArrayList
> ---------------------------------------------------------------
>
> Key: ISPN-10868
> URL: https://issues.jboss.org/browse/ISPN-10868
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Affects Versions: 9.4.16.Final, 10.0.0.Final
> Reporter: Dan Berindei
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.Final
>
>
> Java serialization whitelist should include primitive wrapper classes and arrays types, if only because it's tedious to specify all of them in the configuration.
> There's a similar argument for adding {{java.util.ArrayList}} to the default whitelist, especially to use as keys, because {{Object[]}} keys do not work with {{OBJECT}} storage ({{equals()}} and {{hashCode()}} are wrong). I'm not convinced yet, because applications eventually want to use a custom key class, and POCs can get away with converting to {{String}} and concatenating.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (ISPN-10868) Default whitelist should allow primitives and arrays
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-10868?page=com.atlassian.jira.plugin... ]
Ryan Emerson reassigned ISPN-10868:
-----------------------------------
Assignee: Ryan Emerson
> Default whitelist should allow primitives and arrays
> ----------------------------------------------------
>
> Key: ISPN-10868
> URL: https://issues.jboss.org/browse/ISPN-10868
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Affects Versions: 9.4.16.Final, 10.0.0.Final
> Reporter: Dan Berindei
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.Final
>
>
> Java serialization whitelist should include primitive wrapper classes and arrays types, if only because it's tedious to specify all of them in the configuration.
> There's a similar argument for adding {{java.util.ArrayList}} to the default whitelist, especially to use as keys, because {{Object[]}} keys do not work with {{OBJECT}} storage ({{equals()}} and {{hashCode()}} are wrong). I'm not convinced yet, because applications eventually want to use a custom key class, and POCs can get away with converting to {{String}} and concatenating.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (ISPN-10888) Genereated MetricIDs like CacheManager_CacheManager_numberOfCreatedCaches should be avoided
by Nistor Adrian (Jira)
[ https://issues.jboss.org/browse/ISPN-10888?page=com.atlassian.jira.plugin... ]
Nistor Adrian updated ISPN-10888:
---------------------------------
Fix Version/s: (was: 10.0.2.Final)
> Genereated MetricIDs like CacheManager_CacheManager_numberOfCreatedCaches should be avoided
> -------------------------------------------------------------------------------------------
>
> Key: ISPN-10888
> URL: https://issues.jboss.org/browse/ISPN-10888
> Project: Infinispan
> Issue Type: Bug
> Components: JMX, reporting and management
> Affects Versions: 10.0.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 10.1.0.Beta1
>
>
> Must avoid situations where ObjectName's type and component keys are equal, like in CacheManager_CacheManager_numberOfCreatedCaches. Same for Cache.
> In these cases do not add both, just one.
> Also, need to remove eventual dots from names. Replace them with the standard replacement character in MP metrics: ' _'
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (ISPN-10888) Genereated MetricIDs like CacheManager_CacheManager_numberOfCreatedCaches should be avoided
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10888?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-10888:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Genereated MetricIDs like CacheManager_CacheManager_numberOfCreatedCaches should be avoided
> -------------------------------------------------------------------------------------------
>
> Key: ISPN-10888
> URL: https://issues.jboss.org/browse/ISPN-10888
> Project: Infinispan
> Issue Type: Bug
> Components: JMX, reporting and management
> Affects Versions: 10.0.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 10.1.0.Beta1, 10.0.2.Final
>
>
> Must avoid situations where ObjectName's type and component keys are equal, like in CacheManager_CacheManager_numberOfCreatedCaches. Same for Cache.
> In these cases do not add both, just one.
> Also, need to remove eventual dots from names. Replace them with the standard replacement character in MP metrics: ' _'
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months
[JBoss JIRA] (ISPN-10899) Server transport and executor metrics are not unregistered on stop
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10899?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-10899:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Server transport and executor metrics are not unregistered on stop
> ------------------------------------------------------------------
>
> Key: ISPN-10899
> URL: https://issues.jboss.org/browse/ISPN-10899
> Project: Infinispan
> Issue Type: Bug
> Components: Server
> Affects Versions: 10.0.1.Final
> Reporter: Dan Berindei
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 10.1.0.Beta1
>
>
> Server transport and executor are registered in JMX with {{CacheManagerJmxRegistration.registerExternalMBean()}}, which also registers them in the metrics registry.
> But they're unregistered with {{JmxUtil.unregisterMBean()}}, which doesn't unregister them from the metrics registry.
> We really need to remove {{JmxUtil}} and only use the {{xJmxRegistration}} components everywhere except the client.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 11 months