[JBoss JIRA] (ISPN-10272) RocskDbStore BatchWrite org.rocksdb.RocksDBException: unknown WriteBatch tag
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-10272?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-10272:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> RocskDbStore BatchWrite org.rocksdb.RocksDBException: unknown WriteBatch tag
> -----------------------------------------------------------------------------
>
> Key: ISPN-10272
> URL: https://issues.jboss.org/browse/ISPN-10272
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 9.4.14.Final
> Environment: h6. OS
> Ubuntu 16.0.4 4.15.0-1045-azure x86_64
> h6. Java
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
> Reporter: Jestan Nirojan
> Assignee: Will Burns
> Priority: Major
> Fix For: 10.0.0.Beta4, 9.4.15.Final
>
>
> h6. Issue
> RocksDBStore is not closing WriteBatch native handles and under heavy write with multiple databases, following error is continuously throwing and database never recovers (following error is from infinispan 9.2.5-Final but i believe same issue exists in master , see https://github.com/infinispan/infinispan/blob/1bcfe5823e7957060080741f7d0...)
> {code:java}
> Caused by: org.rocksdb.RocksDBException: unknown WriteBatch tag
> at org.rocksdb.RocksDB.write0(Native Method)
> at org.rocksdb.RocksDB.write(RocksDB.java:602)
> at org.infinispan.persistence.rocksdb.RocksDBStore.writeBatch(RocksDBStore.java:393)
> at org.infinispan.persistence.rocksdb.RocksDBStore.writeBatch(RocksDBStore.java:374)
> at org.infinispan.persistence.manager.PersistenceManagerImpl.lambda$writeBatchToAllNonTxStores$12
> {code}
> I was also getting other errors from this list, for example "bad WriteBatch Delete"https://github.com/facebook/rocksdb/blob/cae22c53fbad071be8aa3a8543415383...
> h6. Fix
> {code:java}
> private void writeBatch(WriteBatch batch) throws InterruptedException, RocksDBException {
> semaphore.acquire();
> try {
> if (stopped)
> throw new PersistenceException("RocksDB is stopped");
> db.write(dataWriteOptions(), batch);
> } finally {
> semaphore.release();
> batch.close();
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (ISPN-10306) RocskDbStore BatchWrite org.rocksdb.RocksDBException: unknown WriteBatch tag
by Will Burns (Jira)
Will Burns created ISPN-10306:
---------------------------------
Summary: RocskDbStore BatchWrite org.rocksdb.RocksDBException: unknown WriteBatch tag
Key: ISPN-10306
URL: https://issues.jboss.org/browse/ISPN-10306
Project: Infinispan
Issue Type: Bug
Affects Versions: 9.4.14.Final
Environment: h6. OS
Ubuntu 16.0.4 4.15.0-1045-azure x86_64
h6. Java
Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
Reporter: Jestan Nirojan
Assignee: Will Burns
Fix For: 10.0.0.Beta4, 9.4.15.Final
h6. Issue
RocksDBStore is not closing WriteBatch native handles and under heavy write with multiple databases, following error is continuously throwing and database never recovers (following error is from infinispan 9.2.5-Final but i believe same issue exists in master , see https://github.com/infinispan/infinispan/blob/1bcfe5823e7957060080741f7d0...)
{code:java}
Caused by: org.rocksdb.RocksDBException: unknown WriteBatch tag
at org.rocksdb.RocksDB.write0(Native Method)
at org.rocksdb.RocksDB.write(RocksDB.java:602)
at org.infinispan.persistence.rocksdb.RocksDBStore.writeBatch(RocksDBStore.java:393)
at org.infinispan.persistence.rocksdb.RocksDBStore.writeBatch(RocksDBStore.java:374)
at org.infinispan.persistence.manager.PersistenceManagerImpl.lambda$writeBatchToAllNonTxStores$12
{code}
I was also getting other errors from this list, for example "bad WriteBatch Delete"https://github.com/facebook/rocksdb/blob/cae22c53fbad071be8aa3a8543415383...
h6. Fix
{code:java}
private void writeBatch(WriteBatch batch) throws InterruptedException, RocksDBException {
semaphore.acquire();
try {
if (stopped)
throw new PersistenceException("RocksDB is stopped");
db.write(dataWriteOptions(), batch);
} finally {
semaphore.release();
batch.close();
}
}
{code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (ISPN-10305) EmbeddedAllTest doesn't clean up its files
by Dan Berindei (Jira)
Dan Berindei created ISPN-10305:
-----------------------------------
Summary: EmbeddedAllTest doesn't clean up its files
Key: ISPN-10305
URL: https://issues.jboss.org/browse/ISPN-10305
Project: Infinispan
Issue Type: Bug
Components: Test Suite - Core
Affects Versions: 9.4.14.Final, 10.0.0.Beta3
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 10.0.0.Beta4, 9.4.15.Final
Because the store files are not deleted before/after the test, running the test suite on 2 different branch will cause random failures:
{noformat}
org.infinispan.persistence.spi.PersistenceException: java.lang.NullPointerException
at org.infinispan.persistence.rocksdb.RocksDBStore$RocksDBHandler.load(RocksDBStore.java:613)
at org.infinispan.persistence.rocksdb.RocksDBStore.load(RocksDBStore.java:289)
at org.infinispan.persistence.manager.PersistenceManagerImpl.loadFromAllStores(PersistenceManagerImpl.java:646)
at org.infinispan.persistence.internal.PersistenceUtil.loadAndCheckExpiration(PersistenceUtil.java:139)
at org.infinispan.persistence.internal.PersistenceUtil.lambda$loadAndComputeInDataContainer$0(PersistenceUtil.java:97)
at org.infinispan.container.impl.AbstractInternalDataContainer.lambda$compute$3(AbstractInternalDataContainer.java:230)
at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1908)
at org.infinispan.container.impl.AbstractInternalDataContainer.compute(AbstractInternalDataContainer.java:229)
at org.infinispan.persistence.internal.PersistenceUtil.loadAndComputeInDataContainer(PersistenceUtil.java:119)
...
at org.infinispan.all.embedded.EmbeddedAllTest.testDataSurvived(EmbeddedAllTest.java:206)
at org.infinispan.all.embedded.EmbeddedAllTest.testAllEmbeddedRocksDbStore(EmbeddedAllTest.java:175)
Caused by: java.lang.NullPointerException
at org.infinispan.marshall.core.GlobalMarshaller.readWithExternalizer(GlobalMarshaller.java:708)
at org.infinispan.marshall.core.GlobalMarshaller.readNonNullableObject(GlobalMarshaller.java:691)
at org.infinispan.marshall.core.GlobalMarshaller.readNullableObject(GlobalMarshaller.java:361)
at org.infinispan.marshall.core.GlobalMarshaller.objectFromObjectInput(GlobalMarshaller.java:194)
at org.infinispan.marshall.core.GlobalMarshaller.objectFromByteBuffer(GlobalMarshaller.java:190)
at org.infinispan.persistence.rocksdb.RocksDBStore.unmarshall(RocksDBStore.java:416)
at org.infinispan.persistence.rocksdb.RocksDBStore.access$400(RocksDBStore.java:61)
at org.infinispan.persistence.rocksdb.RocksDBStore$RocksDBHandler.load(RocksDBStore.java:604)
... 83 more
org.infinispan.commons.CacheException: java.lang.ClassCastException: class org.infinispan.metadata.EmbeddedMetadata cannot be cast to class org.infinispan.metadata.InternalMetadata (org.infinispan.metadata.EmbeddedMetadata and org.infinispan.metadata.InternalMetadata are in unnamed module of loader 'app')
at org.infinispan.interceptors.impl.InvocationContextInterceptor.rethrowException(InvocationContextInterceptor.java:134)
at org.infinispan.interceptors.impl.InvocationContextInterceptor.lambda$new$0(InvocationContextInterceptor.java:62)
at org.infinispan.interceptors.InvocationExceptionFunction.apply(InvocationExceptionFunction.java:25)
at org.infinispan.interceptors.impl.SimpleAsyncInvocationStage.addCallback(SimpleAsyncInvocationStage.java:70)
at org.infinispan.interceptors.InvocationStage.andExceptionally(InvocationStage.java:55)
at org.infinispan.interceptors.BaseAsyncInterceptor.invokeNextAndExceptionally(BaseAsyncInterceptor.java:128)
at org.infinispan.interceptors.impl.InvocationContextInterceptor.visitCommand(InvocationContextInterceptor.java:90)
at org.infinispan.interceptors.impl.AsyncInterceptorChainImpl.invoke(AsyncInterceptorChainImpl.java:248)
at org.infinispan.cache.impl.CacheImpl.executeCommandAndCommitIfNeeded(CacheImpl.java:1918)
at org.infinispan.cache.impl.CacheImpl.put(CacheImpl.java:1433)
at org.infinispan.cache.impl.CacheImpl.put(CacheImpl.java:2043)
at org.infinispan.cache.impl.CacheImpl.put(CacheImpl.java:230)
at org.infinispan.cache.impl.AbstractDelegatingCache.put(AbstractDelegatingCache.java:448)
at org.infinispan.cache.impl.EncoderCache.put(EncoderCache.java:675)
at org.infinispan.all.embedded.EmbeddedAllTest.testDataSurvived(EmbeddedAllTest.java:206)
at org.infinispan.all.embedded.EmbeddedAllTest.testAllEmbeddedFileStore(EmbeddedAllTest.java:136)
Caused by: java.lang.ClassCastException: class org.infinispan.metadata.EmbeddedMetadata cannot be cast to class org.infinispan.metadata.InternalMetadata (org.infinispan.metadata.EmbeddedMetadata and org.infinispan.metadata.InternalMetadata are in unnamed module of loader 'app')
at org.infinispan.marshall.core.MarshalledEntryImpl.getMetadata(MarshalledEntryImpl.java:91)
at org.infinispan.persistence.internal.PersistenceUtil.convert(PersistenceUtil.java:150)
at org.infinispan.persistence.internal.PersistenceUtil.lambda$loadAndComputeInDataContainer$0(PersistenceUtil.java:102)
at org.infinispan.container.impl.AbstractInternalDataContainer.lambda$compute$3(AbstractInternalDataContainer.java:230)
at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1908)
at org.infinispan.container.impl.AbstractInternalDataContainer.compute(AbstractInternalDataContainer.java:229)
at org.infinispan.persistence.internal.PersistenceUtil.loadAndComputeInDataContainer(PersistenceUtil.java:119)
at org.infinispan.persistence.internal.PersistenceUtil.loadAndStoreInDataContainer(PersistenceUtil.java:53)
{noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (ISPN-10289) SingleTargetRequest may invoke the response collector twice for same view
by Will Burns (Jira)
[ https://issues.jboss.org/browse/ISPN-10289?page=com.atlassian.jira.plugin... ]
Will Burns updated ISPN-10289:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> SingleTargetRequest may invoke the response collector twice for same view
> -------------------------------------------------------------------------
>
> Key: ISPN-10289
> URL: https://issues.jboss.org/browse/ISPN-10289
> Project: Infinispan
> Issue Type: Bug
> Components: Core, Test Suite - Core
> Affects Versions: 10.0.0.Beta3, 9.4.14.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 10.0.0.Beta4
>
>
> {{SingleTargetRequest.onNewView()}} is sometimes invoked twice:
> * From {{JGroupsTransport.invokeCommand()}}, in the thread that is sending the request
> * From {{JGroupsTransport.receiveClusterView()}}, in the thread processing the view change
> Because of insufficient synchronization, both {{onNewView()}} invocations may trigger a call to {{ResponseCollector.addResponse()}}, and the collector may not deal with the extra call properly.
> For example, the bridge response collectors used by {{ControlledRpcManager}} do not allow duplicate responses for the same target, and this causes random failures in {{GetAllCommandNodeCrashTest}}:
> {noformat}
> 12:44:56.270 [ERROR] commands.GetAllCommandNodeCrashTest(org.infinispan.commands.GetAllCommandNodeCrashTest) Time elapsed: 0.144 s <<< FAILURE!
> java.lang.AssertionError:
> at org.testng.AssertJUnit.fail(AssertJUnit.java:59)
> at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:24)
> at org.testng.AssertJUnit.assertFalse(AssertJUnit.java:41)
> at org.testng.AssertJUnit.assertFalse(AssertJUnit.java:49)
> at org.infinispan.util.ControlledRpcManager$BlockedResponseMap.receive(ControlledRpcManager.java:701)
> at org.infinispan.util.ControlledRpcManager$SentRequest.receiveAll(ControlledRpcManager.java:601)
> at org.infinispan.commands.GetAllCommandNodeCrashTest.test(GetAllCommandNodeCrashTest.java:66)
> {noformat}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (ISPN-10291) Upgrade to JGroups 4.1.1.Final
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10291?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10291:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Upgrade to JGroups 4.1.1.Final
> ------------------------------
>
> Key: ISPN-10291
> URL: https://issues.jboss.org/browse/ISPN-10291
> Project: Infinispan
> Issue Type: Component Upgrade
> Components: Dependency
> Affects Versions: 10.0.0.Beta3
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 10.0.0.Beta4
>
>
> JGroups 4.1.0.Final has several improvements for running under Quarkus, plus should be better at using the same kind of IP address everywhere when not running with {{-Djava.net.preferIPv4Stack=true}}:
> http://belaban.blogspot.com/2019/05/410-released.html
> 4.1.1.Final adds a fix for JGRP-2350 (TCP: connection close can block when send() block on full TCP send-window) and for JGRP-2354 (ForkChannel does not receive SITE_UNREACHABLE events)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (ISPN-10295) Upgrade to JGroups 4.0.20.Final
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10295?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10295:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Upgrade to JGroups 4.0.20.Final
> -------------------------------
>
> Key: ISPN-10295
> URL: https://issues.jboss.org/browse/ISPN-10295
> Project: Infinispan
> Issue Type: Component Upgrade
> Components: Dependency
> Affects Versions: 9.4.14.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 9.4.15.Final
>
>
> Includes fixes for JGRP-2350 (TCP: connection close can block when send() block on full TCP send-window) and for JGRP-2354 (ForkChannel does not receive SITE_UNREACHABLE events).
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (ISPN-7470) Distributed executor does not fail over unless future.get() is called
by Will Burns (Jira)
[ https://issues.jboss.org/browse/ISPN-7470?page=com.atlassian.jira.plugin.... ]
Will Burns resolved ISPN-7470.
------------------------------
Resolution: Out of Date
Distributed Executor no longer exists.
> Distributed executor does not fail over unless future.get() is called
> ---------------------------------------------------------------------
>
> Key: ISPN-7470
> URL: https://issues.jboss.org/browse/ISPN-7470
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 8.2.6.Final, 9.0.0.CR1
> Reporter: Dan Berindei
> Assignee: Will Burns
> Priority: Major
> Fix For: 10.0.0.Final
>
>
> After ISPN-6392, {{DistributedExecutorService.submit(...)}} nominally returns a {{CompletableFuture}}. However, it doesn't behave like a regular {{CompletableFuture}}, because it doesn't run the failure policy until the user calls {{future.get()}}.
> {{future.isComplete()}} will return {{true}} before running the failure policy, and {{future.whenComplete(callback)}} will also execute the callback before running the failure policy.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months