[JBoss JIRA] (ISPN-12279) Default value of @IndexedEmbedded.depth is not correctly interpreted
by Yoann Rodière (Jira)
[ https://issues.redhat.com/browse/ISPN-12279?page=com.atlassian.jira.plugi... ]
Yoann Rodière updated ISPN-12279:
---------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/8757
> Default value of @IndexedEmbedded.depth is not correctly interpreted
> --------------------------------------------------------------------
>
> Key: ISPN-12279
> URL: https://issues.redhat.com/browse/ISPN-12279
> Project: Infinispan
> Issue Type: Task
> Components: Embedded Querying
> Affects Versions: 12.0.0.Dev02
> Reporter: Yoann Rodière
> Priority: Major
> Fix For: 12.0.0.Dev05
>
>
> There was a problem during the migration to Search 6, and the processor for the annotation {{@IndexedEmbedded}} apparently does not correctly intepret {{@IndexedEmbedded()}} as "no depth defined".
> As a result, {{@IndexedEmbedded(includePaths = { "foo" })}} will not set the depth to 0 as it should, but to {{Integer.MAX_VALUE}} (the default defined on the {{(a)IndexedEmbedded.depth()}} attribute) and will end up incorrectly including the whole embedded document.
> The code to change is this (in {{org.hibernate.search.annotations.IndexedEmbedded}}):
> {code}
> Integer cleanedUpMaxDepth = annotation.depth();
> if ( cleanedUpMaxDepth.equals( -1 ) ) {
> cleanedUpMaxDepth = null;
> }
> {code}
> It should be instead:
> {code}
> Integer cleanedUpMaxDepth = annotation.depth();
> if ( cleanedUpMaxDepth.equals( Integer.MAX_VALUE ) ) {
> cleanedUpMaxDepth = null;
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years
[JBoss JIRA] (ISPN-12408) Remove support for the default null token on index fields
by Yoann Rodière (Jira)
[ https://issues.redhat.com/browse/ISPN-12408?page=com.atlassian.jira.plugi... ]
Yoann Rodière updated ISPN-12408:
---------------------------------
Description:
The default null token isn't supported anymore in Hibernate Search 6. Each field that takes advantage of the {{indexNullAs}} feature should define the null token explicitly.
The {{indexNullAs}} feature was deprecated in Infinispan 11: https://infinispan.org/docs/11.0.x/titles/upgrading/upgrading.html#entity...
Also, Hibernate Search 6 offers an {{exist}} predicate, which is used in Ickle for {{IS NOT NULL}} conditions; so {{indexNullAs}} is no longer as important as before.
was:
The default null token isn't supported anymore in Hibernate Search 6. Each field that takes advantage of the {{indexNullAs}} feature should define the null token explicitly.
The {{indexNullAs}} feature was deprecated in Infinispan 11: https://infinispan.org/docs/11.0.x/titles/upgrading/upgrading.html#entity...
Also, Hibernate Search 6 offers an {{exist}} predicate, which is used in Ickly for {{IS NOT NULL}} conditions; so {{indexNullAs}} is no longer as important as before.
> Remove support for the default null token on index fields
> ---------------------------------------------------------
>
> Key: ISPN-12408
> URL: https://issues.redhat.com/browse/ISPN-12408
> Project: Infinispan
> Issue Type: Task
> Components: Embedded Querying, Remote Querying
> Reporter: Yoann Rodière
> Assignee: Yoann Rodière
> Priority: Major
> Fix For: 12.0.0.Dev05
>
>
> The default null token isn't supported anymore in Hibernate Search 6. Each field that takes advantage of the {{indexNullAs}} feature should define the null token explicitly.
> The {{indexNullAs}} feature was deprecated in Infinispan 11: https://infinispan.org/docs/11.0.x/titles/upgrading/upgrading.html#entity...
> Also, Hibernate Search 6 offers an {{exist}} predicate, which is used in Ickle for {{IS NOT NULL}} conditions; so {{indexNullAs}} is no longer as important as before.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years