December 2020 - infinispan-issues

[Red Hat JIRA] (IPROTO-114) Date fields not initialized with @ProtoFactory

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-114?page=com.atlassian.jira.plugi... ] Nistor Adrian updated IPROTO-114: --------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > Date fields not initialized with @ProtoFactory > ---------------------------------------------- > > Key: IPROTO-114 > URL: https://issues.redhat.com/browse/IPROTO-114 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 4.3.0.Alpha11 > Reporter: Ryan Emerson > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > > {code:java} > public class Reproducer { > @ProtoField(number = 1) > final Date date; > @ProtoFactory > public Reproducer(Date date) { > this.date = date; > } > } > {code} > Results in the following marshaller code which does not compile: > {code:java} > @javax.annotation.Generated(value = "org.infinispan.protostream.annotations.impl.processor.AutoProtoSchemaBuilderAnnotationProcessor", > comments = "Please do not edit this file!") > @org.infinispan.protostream.annotations.impl.OriginatingClasses({ > "org.infinispan.query.dsl.embedded.testdomain.Reproducer" > }) > @SuppressWarnings("unchecked") > public final class Reproducer$___Marshaller_b7bc8e88b59172b5316adfc20e38742eb183ea955e2ff0dbf8d9fc9cd93038b7 extends org.infinispan.protostream.annotations.impl.GeneratedMarshallerBase implements org.infinispan.protostream.RawProtobufMarshaller<org.infinispan.query.dsl.embedded.testdomain.Reproducer> { > @Override > public Class<org.infinispan.query.dsl.embedded.testdomain.Reproducer> getJavaClass() { return org.infinispan.query.dsl.embedded.testdomain.Reproducer.class; } > > @Override > public String getTypeName() { return "org.infinispan.test.query.dsl.Reproducer"; } > > @Override > public org.infinispan.query.dsl.embedded.testdomain.Reproducer readFrom(org.infinispan.protostream.ImmutableSerializationContext $1, org.infinispan.protostream.RawProtoStreamReader $2) throws java.io.IOException { > java.util.Date __v$1; > boolean done = false; > while (!done) { > final int tag = $2.readTag(); > switch (tag) { > case 0: > done = true; > break; > case 9: { > __v$1 = new java.util.Date($2.readFixed64()); > break; > } > default: { > if (!$2.skipField(tag)) done = true; > } > } > } > return new org.infinispan.query.dsl.embedded.testdomain.Reproducer(__v$1); > } > > @Override > public void writeTo(org.infinispan.protostream.ImmutableSerializationContext $1, org.infinispan.protostream.RawProtoStreamWriter $2, org.infinispan.query.dsl.embedded.testdomain.Reproducer $3) throws java.io.IOException { > final org.infinispan.query.dsl.embedded.testdomain.Reproducer o = (org.infinispan.query.dsl.embedded.testdomain.Reproducer) $3; > { > final java.util.Date __v$1 = o.date; > if (__v$1 != null) $2.writeFixed64(1, __v$1.getTime()); > } > } > } > {code} -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-62) Implement annotation based schema generation support for 'oneof'

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-62?page=com.atlassian.jira.plugin... ] Nistor Adrian updated IPROTO-62: -------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > Implement annotation based schema generation support for 'oneof' > ---------------------------------------------------------------- > > Key: IPROTO-62 > URL: https://issues.redhat.com/browse/IPROTO-62 > Project: Infinispan ProtoStream > Issue Type: Enhancement > Reporter: Nistor Adrian > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-136) Avoid parsing and re-linking proto files, avoid re-registering identical marshallers

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-136?page=com.atlassian.jira.plugi... ] Nistor Adrian updated IPROTO-136: --------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > Avoid parsing and re-linking proto files, avoid re-registering identical marshallers > ------------------------------------------------------------------------------------ > > Key: IPROTO-136 > URL: https://issues.redhat.com/browse/IPROTO-136 > Project: Infinispan ProtoStream > Issue Type: Enhancement > Affects Versions: 4.3.2.Final > Reporter: Nistor Adrian > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-73) Integrate checkstyle plugin in build system and enforce the Infinispan coding style

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-73?page=com.atlassian.jira.plugin... ] Nistor Adrian updated IPROTO-73: -------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > Integrate checkstyle plugin in build system and enforce the Infinispan coding style > ----------------------------------------------------------------------------------- > > Key: IPROTO-73 > URL: https://issues.redhat.com/browse/IPROTO-73 > Project: Infinispan ProtoStream > Issue Type: Task > Reporter: Nistor Adrian > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-74) Allow repeatable fields to be written as a stream

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-74?page=com.atlassian.jira.plugin... ] Nistor Adrian updated IPROTO-74: -------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > Allow repeatable fields to be written as a stream > ------------------------------------------------- > > Key: IPROTO-74 > URL: https://issues.redhat.com/browse/IPROTO-74 > Project: Infinispan ProtoStream > Issue Type: Enhancement > Affects Versions: 4.2.0.Final > Reporter: Ryan Emerson > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > > Currently in order to write to a repeatable field it is necessary for an entire array or collection to be serialized at once. When writing larger collections it would be better if each object could be written individually from a stream. -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-42) Add Protostream support in the jvm-serializers benchmark

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-42?page=com.atlassian.jira.plugin... ] Nistor Adrian updated IPROTO-42: -------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > Add Protostream support in the jvm-serializers benchmark > -------------------------------------------------------- > > Key: IPROTO-42 > URL: https://issues.redhat.com/browse/IPROTO-42 > Project: Infinispan ProtoStream > Issue Type: Feature Request > Reporter: Nistor Adrian > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > > This is a well-known (but not a 'standard') benchmark comparing performance of various serilization libs that can be used on the JVM: > https://eishay.github.io/jvm-serializers/prototype-results-page/ > Adding Protostream support is a must before continuing any perf improvements. -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-47) A new declarative API using entity field bindings with lambdas

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-47?page=com.atlassian.jira.plugin... ] Nistor Adrian updated IPROTO-47: -------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > A new declarative API using entity field bindings with lambdas > -------------------------------------------------------------- > > Key: IPROTO-47 > URL: https://issues.redhat.com/browse/IPROTO-47 > Project: Infinispan ProtoStream > Issue Type: Feature Request > Reporter: Nistor Adrian > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null leading to wrong schema being generated

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-162?page=com.atlassian.jira.plugi... ] Nistor Adrian updated IPROTO-162: --------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > MirrorClass.getEnclosingClass() is broken and always returs null leading to wrong schema being generated > -------------------------------------------------------------------------------------------------------- > > Key: IPROTO-162 > URL: https://issues.redhat.com/browse/IPROTO-162 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 4.3.0.Final > Reporter: Nistor Adrian > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.3.4.Final, 4.4.0.Alpha5 > > > Message types generated with annotation processing during compile time should follow the nesting of the (annotated) classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types wrongly becoming top level types in the generated schema starting with 4.3.0 when this bug appeared. > > Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite and not the compile time variant so it flew under the radar. The schema generated by the runtime annotation processor does indeed follow the nesting of the initial classes. > > Fixing this issue is very important in the long run but will be disruptive for some users currently using nested annotated classes with compile time annotation processing. > The fix will have the important side effect of breaking the compatibility of data stored as a WrappedMessage (notably Infinispan) because the type name changes as a consequence of the nesting (but please note the structure of messages does not change!). These usages are not affected if the message types in question have a TypeId annotation, in which case WrappedMessage identifies the type base on its numeric id rather than its fully qualified name. > The only way to work around the data compat issue is to change your java classes so as not to use nesting with the end result of the schema being generated exactly as before this bug fix (all types are top level). > -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-63) writeObject throws IllegalArgumentException with oneof label

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-63?page=com.atlassian.jira.plugin... ] Nistor Adrian updated IPROTO-63: -------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > writeObject throws IllegalArgumentException with oneof label > ------------------------------------------------------------ > > Key: IPROTO-63 > URL: https://issues.redhat.com/browse/IPROTO-63 > Project: Infinispan ProtoStream > Issue Type: Bug > Reporter: Ryan Emerson > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > > The below schema results in the following exception: > Schema: > {code:java} > message EntryVersion { > oneof version { > NumericVersion numeric = 1; > ClusteredVersion clustered = 2; > } > // optional NumericVersion numeric = 1; > // optional ClusteredVersion clustered = 2; > } > message NumericVersion { > required int64 version = 1; > } > message ClusteredVersion { > required int64 version = 1; > required int32 topology = 2; > } > {code} > Exception: > {code:java} > java.lang.IllegalArgumentException: Declared field type is not a message or an enum : numeric > {code} > It seems this is caused because the type for the field "numeric" is null in the associated FieldDescriptor object that is retrieved in the [writeObject impl|https://github.com/infinispan/protostream/blob/master/core/src/main/...]. > If the oneof label is replaced with the commented optional fields, the marshallers work as expected. -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

[Red Hat JIRA] (IPROTO-89) Provide means to calculate serialised message size

by Nistor Adrian (Jira)

[ https://issues.redhat.com/browse/IPROTO-89?page=com.atlassian.jira.plugin... ] Nistor Adrian updated IPROTO-89: -------------------------------- Fix Version/s: 4.4.0.Alpha5 (was: 4.4.0.Alpha4) > Provide means to calculate serialised message size > -------------------------------------------------- > > Key: IPROTO-89 > URL: https://issues.redhat.com/browse/IPROTO-89 > Project: Infinispan ProtoStream > Issue Type: Enhancement > Affects Versions: 4.2.2.Final > Reporter: Ryan Emerson > Assignee: Nistor Adrian > Priority: Major > Fix For: 4.4.0.Alpha5 > > > In order to be able to better estimate the size of output buffers etc, it would be useful to provide a means for a user application to retrieved the anticipated size of a serialized message from an object's current state. For example, in the protobuf-java library this is exposed via {{com.google.protobuf.MessageLite#getSerializedSize}} -- This message was sent by Atlassian Jira (v7.13.8#713008)

5 years

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues December 2020