[JBoss JIRA] (ISPN-11885) ChannelPool can get in inconsistent state with concurrent release and close of a channel
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11885?page=com.atlassian.jira.plugi... ]
Will Burns updated ISPN-11885:
------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/8381 (was: https://github.com/infinispan/infinispan/pull/8358)
> ChannelPool can get in inconsistent state with concurrent release and close of a channel
> ----------------------------------------------------------------------------------------
>
> Key: ISPN-11885
> URL: https://issues.redhat.com/browse/ISPN-11885
> Project: Infinispan
> Issue Type: Bug
> Components: Hot Rod
> Affects Versions: 10.1.8.Final
> Reporter: Will Burns
> Assignee: Will Burns
> Priority: Major
> Fix For: 11.0.0.CR1
>
>
> While working on https://github.com/infinispan/infinispan/pull/8358 I found that the changes introduced allowed for a test failure to occur much more often. Upon investigation the issue is that the channel pool can close a channel and then release it which gets it in an inconsistent state.
> Looking closer it appears to be a bug in the ChannelPool class when a connection is closed before release completes.
> {code}
> 23:42:12,203 TRACE (DistributionRetryTest-Client-Async-1-2:[]) [ChannelPool] Closed channel [id: 0x27befd37, L:/127.0.0.1:37412 ! R:127.0.0.1/127.0.0.1:33943], created = 0, idle = false, active = 0
> 23:42:12,203 TRACE (testng-DistributionRetryTest:[]) [ChannelPool] Released channel [id: 0x27befd37, L:/127.0.0.1:37412 ! R:127.0.0.1/127.0.0.1:33943], active = -1
> {code}
> Here is the trace of it working where is is released before being closed.
> {code}
> 23:46:42,649 TRACE (testng-DistributionRetryTest:[]) [ChannelPool] Released channel [id: 0xeb9159ef, L:/127.0.0.1:39342 - R:127.0.0.1/127.0.0.1:41537], active = 0
> 23:46:42,792 TRACE (testng-DistributionRetryTest:[]) [ChannelPool] Activated record [id: 0x0b71d548, L:/127.0.0.1:51392 - R:127.0.0.1/127.0.0.1:37881], created = 1, active = 1
> 23:46:42,793 TRACE (DistributionRetryTest-Client-Async-1-3:[]) [ChannelPool] Closed channel [id: 0xeb9159ef, L:/127.0.0.1:39342 ! R:127.0.0.1/127.0.0.1:41537], created = 0, idle = true, active = 0
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11897) Internal Caches with persistence don't need availability checks
by Will Burns (Jira)
Will Burns created ISPN-11897:
---------------------------------
Summary: Internal Caches with persistence don't need availability checks
Key: ISPN-11897
URL: https://issues.redhat.com/browse/ISPN-11897
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Reporter: Will Burns
Assignee: Will Burns
Fix For: 11.0.0.CR1
The internal caches may have persistance, which is done via a SingleFileStore. They also have availability enabled, which causes them to be queried every 1 second which is a bit of overkill. We should be able to just disable this check since it is a file based store.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11849) ParamKeyValueFilterConverterFactory missing from Server Extensions
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11849?page=com.atlassian.jira.plugi... ]
Will Burns updated ISPN-11849:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> ParamKeyValueFilterConverterFactory missing from Server Extensions
> ------------------------------------------------------------------
>
> Key: ISPN-11849
> URL: https://issues.redhat.com/browse/ISPN-11849
> Project: Infinispan
> Issue Type: Bug
> Components: Server
> Affects Versions: 11.0.0.Dev05
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 11.0.0.CR1
>
>
> Currently the {{Extensions}} class is missing a lookup for {{ParamKeyValueFilterConverterFactory}} service implementations, which means that the {{iteration-filter-converter-factory}} is never available in the server.
> The {{HotRodCacheQueries}} tests currently pass with the embedded driver as the services are on the classpath of the server, however if the tests are executed in CONTAINER mode they will fail.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11837) ContainerInfinispanServerDriver missing cluster size check
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11837?page=com.atlassian.jira.plugi... ]
Will Burns updated ISPN-11837:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> ContainerInfinispanServerDriver missing cluster size check
> ----------------------------------------------------------
>
> Key: ISPN-11837
> URL: https://issues.redhat.com/browse/ISPN-11837
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 11.0.0.Dev05
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 11.0.0.CR1
>
>
> The tests in {{server/tests}} that are executed in CONTAINER mode do not currently check to ensure that a cluster of {{InfinispanServerTestConfiguration#numServers}} is formed before the tests begin. This means that it's possible for some of the {{ClusteredIT}} tests to pass even if no cluster is formed between the containers.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11896) Docs: Store SPI Javadoc Review
by Donald Naro (Jira)
[ https://issues.redhat.com/browse/ISPN-11896?page=com.atlassian.jira.plugi... ]
Donald Naro updated ISPN-11896:
-------------------------------
Sprint: DataGrid Sprint #45
> Docs: Store SPI Javadoc Review
> ------------------------------
>
> Key: ISPN-11896
> URL: https://issues.redhat.com/browse/ISPN-11896
> Project: Infinispan
> Issue Type: Enhancement
> Components: Documentation
> Reporter: Donald Naro
> Assignee: Donald Naro
> Priority: Major
>
> Add doc review to SPI changes in https://github.com/infinispan/infinispan/pull/8370
> this changes how a user would add a custom store - it is the same pluggability as before, but I hope it is a bit simpler to understand, albeit possibly a bit harder to implement as they need to be non blocking when using this SPI
> existing store implementations are unaffected currently as I added an adapter that does the conversion for them. However the goal is to eventually remove the old SPIs, probably not until ISPN 14 though according to our deprecation/removal schedule
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months