[JBoss JIRA] (ISPN-11943) Single MediaType ignored in JSON config
by Gustavo Fernandes (Jira)
[ https://issues.redhat.com/browse/ISPN-11943?page=com.atlassian.jira.plugi... ]
Gustavo Fernandes updated ISPN-11943:
-------------------------------------
Status: Open (was: New)
> Single MediaType ignored in JSON config
> ---------------------------------------
>
> Key: ISPN-11943
> URL: https://issues.redhat.com/browse/ISPN-11943
> Project: Infinispan
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 11.0.0.CR1
> Reporter: Gustavo Fernandes
> Assignee: Gustavo Fernandes
> Priority: Major
> Fix For: 11.0.0.Final
>
>
> The recently introduced single MediaType config for both keys and values is being ignored when creating a cache from JSON:
> {code:json}
> {
> "distributed-cache":{
> "encoding":{
> "media-type":"application/x-protostream"
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11691) Remove deprecated code in 14.0
by Ryan Emerson (Jira)
[ https://issues.redhat.com/browse/ISPN-11691?page=com.atlassian.jira.plugi... ]
Ryan Emerson commented on ISPN-11691:
-------------------------------------
[~dan.berindei] When this workflow was [proposed|https://infinispan.zulipchat.com/#narrow/stream/121836-internal/...] I don't think it was intended to catch all of the already deprecated features, rather it should be adopted for all deprecations/removals moving forward. As our discussion started on an open PR, this workflow is valid for that deprecation and removal.
For items that have already been deprecated without a removal Jira, we can use your git command to detect that code should be removed. However when it comes to remove the code, a sub-task on the major version's removal Jira should be created, or at the very least a link added to the Jira associated with the PR removing the code. This way we have a single source of information about all removals in a given major version.
> Remove deprecated code in 14.0
> ------------------------------
>
> Key: ISPN-11691
> URL: https://issues.redhat.com/browse/ISPN-11691
> Project: Infinispan
> Issue Type: Task
> Reporter: Tristan Tarrant
> Assignee: Tristan Tarrant
> Priority: Blocker
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11691) Remove deprecated code in 14.0
by Dan Berindei (Jira)
[ https://issues.redhat.com/browse/ISPN-11691?page=com.atlassian.jira.plugi... ]
Dan Berindei commented on ISPN-11691:
-------------------------------------
[~ryanemerson] I would have certainly run that search before the 10.0 release if I knew it was possible...
IMO the biggest problem is that we're creating sub-tasks to remove deprecated code in 14.0, but we're not doing anything for deprecated code that should be removed in 11.0/12.0/13.0. There's still code that was deprecated in 7.2 or 8.0 which does not have a sub-task in ISPN-11057, ISPN-11680, ISPN-11681, or ISPN-11691. Is anyone going to create sub-tasks for all the code that was deprecated in 8.x/9.x/10.x now, so we handle all deprecations the same way?
> Remove deprecated code in 14.0
> ------------------------------
>
> Key: ISPN-11691
> URL: https://issues.redhat.com/browse/ISPN-11691
> Project: Infinispan
> Issue Type: Task
> Reporter: Tristan Tarrant
> Assignee: Tristan Tarrant
> Priority: Blocker
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-8935) AbstractFileLookup.lookupFileStrict does not work for jar scheme
by Sammy Chu (Jira)
[ https://issues.redhat.com/browse/ISPN-8935?page=com.atlassian.jira.plugin... ]
Sammy Chu commented on ISPN-8935:
---------------------------------
Suspected the fix is not correct, considering uri `jar:file:/path/to/my/jar.jar!/infinispan.xml`, [AbstractFileLookup.java#L69]|https://github.com/infinispan/infinispan/blo... extracted `insideJarFilePath = "/infinispan.xml"`. As `getAsInputStreamFromClassLoader(...)` implementation use `ClassLoader.getResourceAsStream(...)` to lookup the resource, any resource starting with "/" actually will always return null.
> AbstractFileLookup.lookupFileStrict does not work for jar scheme
> ----------------------------------------------------------------
>
> Key: ISPN-8935
> URL: https://issues.redhat.com/browse/ISPN-8935
> Project: Infinispan
> Issue Type: Bug
> Components: Configuration, JCache
> Affects Versions: 9.1.6.Final, 9.2.0.Final
> Environment: Spring Boot 1.5.10, Infinispan 9.1.6
> Reporter: Damir Murat
> Assignee: Tristan Tarrant
> Priority: Major
> Fix For: 9.2.1.Final
>
>
> As documented [here|https://docs.oracle.com/javase/7/docs/api/java/net/JarURLConnection....], JAR URL has following syntax {{jar:<url>!/\{entry\}}}. Current implementation of {{AbstractFileLookup.lookupFileStrict}} does not rely on this syntax, and fails when correctly specified JAR URI comes in.
> I'm using Infinispan JCache implementation from Spring Boot. This works when run from gradle/maven/ide since in these cases {{file}} scheme is used. However, I'm targeting running Spring Boot app inside of Docker container where natural way for using Spring Boot apps is to deploy them as boot packaged fat jar. In that case, Spring Boot passes correct JAR URI into {{AbstractFileLookup.lookupFileStrict}}, which unfortunately fails silently and JCache reverts to default configuration.
> I believe that {{AbstractFileLookup.lookupFileStrict}} can be fixed by replacing current jar scheme handling
> {code}
> case "jar":
> String uriAsString = uri.toString();
> String fileName = uriAsString.substring(uriAsString.lastIndexOf(":") + 1);
> return new FileInputStream(new File(fileName));
> {code}
> with something like this
> {code}
> case "jar": {
> // Invalid code commented out.
> // String uriAsString = uri.toString();
> // String fileName = uriAsString.substring(uriAsString.lastIndexOf(":") + 1);
> // return new FileInputStream(new File(fileName));
> // ===== fix - start =====
> String uriAsString = uri.toString();
> String insideJarFilePath = uriAsString.substring(uriAsString.lastIndexOf("!") + 1);
> InputStream streamToBeReturned = getAsInputStreamFromClassLoader(insideJarFilePath, cl);
> if (streamToBeReturned == null) {
> throw log.unableToLoadFileUsingScheme(scheme);
> }
> return streamToBeReturned;
> // ===== fix - end =====
> }
> {code}
> I'm using Infinispan 9.1.6, but I think that 9.2.0 has same problem. I will try to submit pull request.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11918) org.infinispan.jcache.embedded.JCacheManager#create always throw CacheConfigurationException if create cache with template
by Sammy Chu (Jira)
[ https://issues.redhat.com/browse/ISPN-11918?page=com.atlassian.jira.plugi... ]
Sammy Chu updated ISPN-11918:
-----------------------------
Attachment: ISPN-11918-fail.log
ISPN-11918-success.log
> org.infinispan.jcache.embedded.JCacheManager#create always throw CacheConfigurationException if create cache with template
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-11918
> URL: https://issues.redhat.com/browse/ISPN-11918
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Affects Versions: 10.1.8.Final
> Reporter: Sammy Chu
> Priority: Major
> Attachments: ISPN-11918-fail.log, ISPN-11918-success.log, ISPN-11918.zip
>
>
> Our project upgraded from Infinispan 8.2.4.Final to 9.4.18.Final and got `org.infinispan.commons.CacheConfigurationException: ISPN000453: Attempt to define configuration for cache MY_CACHE_NAME which already exists` .
> We are defining the cache template and then programmatically define the JCache with jcache configuration. From the source code of
> [JCacheManager|https://github.com/infinispan/infinispan/blob/master/jcache...], it is reading the `baseConfig` as the template and then merge it with the jcache configuration, which is working expected in 8.2.4.Final. Now upgraded to 9.4.18.Final, it is not working due to change of ISPN-7540.
> We checked this issue also reproducible on current latest stable release (10.1.8.Final).
> [^ISPN-11918.zip] is a simple standalone application to reproduce this issue, change infinispan version from 10.1.8.Final to 8.2.12.Final will work correctly. Attached the trace log [^ISPN-11918-fail.log] when stay on 10.1.8.Final and [^ISPN-11918-success.log] when changed to 8.2.12.Final.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11918) org.infinispan.jcache.embedded.JCacheManager#create always throw CacheConfigurationException if create cache with template
by Sammy Chu (Jira)
[ https://issues.redhat.com/browse/ISPN-11918?page=com.atlassian.jira.plugi... ]
Sammy Chu updated ISPN-11918:
-----------------------------
Attachment: ISPN-11918.zip
> org.infinispan.jcache.embedded.JCacheManager#create always throw CacheConfigurationException if create cache with template
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-11918
> URL: https://issues.redhat.com/browse/ISPN-11918
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Affects Versions: 10.1.8.Final
> Reporter: Sammy Chu
> Priority: Major
> Attachments: ISPN-11918-fail.log, ISPN-11918-success.log, ISPN-11918.zip
>
>
> Our project upgraded from Infinispan 8.2.4.Final to 9.4.18.Final and got `org.infinispan.commons.CacheConfigurationException: ISPN000453: Attempt to define configuration for cache MY_CACHE_NAME which already exists` .
> We are defining the cache template and then programmatically define the JCache with jcache configuration. From the source code of
> [JCacheManager|https://github.com/infinispan/infinispan/blob/master/jcache...], it is reading the `baseConfig` as the template and then merge it with the jcache configuration, which is working expected in 8.2.4.Final. Now upgraded to 9.4.18.Final, it is not working due to change of ISPN-7540.
> We checked this issue also reproducible on current latest stable release (10.1.8.Final).
> [^ISPN-11918.zip] is a simple standalone application to reproduce this issue, change infinispan version from 10.1.8.Final to 8.2.12.Final will work correctly. Attached the trace log [^ISPN-11918-fail.log] when stay on 10.1.8.Final and [^ISPN-11918-success.log] when changed to 8.2.12.Final.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11918) org.infinispan.jcache.embedded.JCacheManager#create always throw CacheConfigurationException if create cache with template
by Sammy Chu (Jira)
[ https://issues.redhat.com/browse/ISPN-11918?page=com.atlassian.jira.plugi... ]
Sammy Chu updated ISPN-11918:
-----------------------------
Steps to Reproduce: [^ISPN-11918.zip] is a simple standalone application to reproduce this issue, change infinispan version from 10.1.8.Final to 8.2.12.Final will work correctly. Attached the trace log [^ISPN-11918-fail.log] when stay on 10.1.8.Final and [^ISPN-11918-success.log] when changed to 8.2.12.Final.
> org.infinispan.jcache.embedded.JCacheManager#create always throw CacheConfigurationException if create cache with template
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-11918
> URL: https://issues.redhat.com/browse/ISPN-11918
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Affects Versions: 10.1.8.Final
> Reporter: Sammy Chu
> Priority: Major
>
> Our project upgraded from Infinispan 8.2.4.Final to 9.4.18.Final and got `org.infinispan.commons.CacheConfigurationException: ISPN000453: Attempt to define configuration for cache MY_CACHE_NAME which already exists` .
> We are defining the cache template and then programmatically define the JCache with jcache configuration. From the source code of
> [JCacheManager|https://github.com/infinispan/infinispan/blob/master/jcache...], it is reading the `baseConfig` as the template and then merge it with the jcache configuration, which is working expected in 8.2.4.Final. Now upgraded to 9.4.18.Final, it is not working due to change of ISPN-7540.
> We checked this issue also reproducible on current latest stable release (10.1.8.Final).
> [^ISPN-11918.zip] is a simple standalone application to reproduce this issue, change infinispan version from 10.1.8.Final to 8.2.12.Final will work correctly. Attached the trace log [^ISPN-11918-fail.log] when stay on 10.1.8.Final and [^ISPN-11918-success.log] when changed to 8.2.12.Final.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months
[JBoss JIRA] (ISPN-11918) org.infinispan.jcache.embedded.JCacheManager#create always throw CacheConfigurationException if create cache with template
by Sammy Chu (Jira)
[ https://issues.redhat.com/browse/ISPN-11918?page=com.atlassian.jira.plugi... ]
Sammy Chu updated ISPN-11918:
-----------------------------
Description:
Our project upgraded from Infinispan 8.2.4.Final to 9.4.18.Final and got `org.infinispan.commons.CacheConfigurationException: ISPN000453: Attempt to define configuration for cache MY_CACHE_NAME which already exists` .
We are defining the cache template and then programmatically define the JCache with jcache configuration. From the source code of
[JCacheManager|https://github.com/infinispan/infinispan/blob/master/jcache...], it is reading the `baseConfig` as the template and then merge it with the jcache configuration, which is working expected in 8.2.4.Final. Now upgraded to 9.4.18.Final, it is not working due to change of ISPN-7540.
We checked this issue also reproducible on current latest stable release (10.1.8.Final).
[^ISPN-11918.zip] is a simple standalone application to reproduce this issue, change infinispan version from 10.1.8.Final to 8.2.12.Final will work correctly. Attached the trace log [^ISPN-11918-fail.log] when stay on 10.1.8.Final and [^ISPN-11918-success.log] when changed to 8.2.12.Final.
was:
Our project upgraded from Infinispan 8.2.4.Final to 9.4.18.Final and got `org.infinispan.commons.CacheConfigurationException: ISPN000453: Attempt to define configuration for cache MY_CACHE_NAME which already exists` .
We are defining the cache template and then programmatically define the JCache with jcache configuration. From the source code of
[JCacheManager|https://github.com/infinispan/infinispan/blob/master/jcache...], it is reading the `baseConfig` as the template and then merge it with the jcache configuration, which is working expected in 8.2.4.Final. Now upgraded to 9.4.18.Final, it is not working due to change of ISPN-7540.
> org.infinispan.jcache.embedded.JCacheManager#create always throw CacheConfigurationException if create cache with template
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-11918
> URL: https://issues.redhat.com/browse/ISPN-11918
> Project: Infinispan
> Issue Type: Bug
> Components: JCache
> Affects Versions: 10.1.8.Final
> Reporter: Sammy Chu
> Priority: Major
>
> Our project upgraded from Infinispan 8.2.4.Final to 9.4.18.Final and got `org.infinispan.commons.CacheConfigurationException: ISPN000453: Attempt to define configuration for cache MY_CACHE_NAME which already exists` .
> We are defining the cache template and then programmatically define the JCache with jcache configuration. From the source code of
> [JCacheManager|https://github.com/infinispan/infinispan/blob/master/jcache...], it is reading the `baseConfig` as the template and then merge it with the jcache configuration, which is working expected in 8.2.4.Final. Now upgraded to 9.4.18.Final, it is not working due to change of ISPN-7540.
> We checked this issue also reproducible on current latest stable release (10.1.8.Final).
> [^ISPN-11918.zip] is a simple standalone application to reproduce this issue, change infinispan version from 10.1.8.Final to 8.2.12.Final will work correctly. Attached the trace log [^ISPN-11918-fail.log] when stay on 10.1.8.Final and [^ISPN-11918-success.log] when changed to 8.2.12.Final.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 7 months