[JBoss JIRA] (ISPN-12043) Shared stores should not have (add|remove)Segments methods invoked
by Dan Berindei (Jira)
[ https://issues.redhat.com/browse/ISPN-12043?page=com.atlassian.jira.plugi... ]
Dan Berindei updated ISPN-12043:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Shared stores should not have (add|remove)Segments methods invoked
> ------------------------------------------------------------------
>
> Key: ISPN-12043
> URL: https://issues.redhat.com/browse/ISPN-12043
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 11.0.0.Final
> Reporter: Will Burns
> Assignee: Will Burns
> Priority: Major
> Fix For: 12.0.0.Final, 11.0.1.Final
>
>
> A shared store should never have its remove or add segments methods invoked as the store should always own all segments at all times. We should add this check in the PeristenceManagerImpl and technically we should only invoke these methods if the store is also configured as being segmented.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11974) Remove GenericJbossMarshaller automatic configuration
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11974?page=com.atlassian.jira.plugi... ]
Will Burns reopened ISPN-11974:
-------------------------------
> Remove GenericJbossMarshaller automatic configuration
> -----------------------------------------------------
>
> Key: ISPN-11974
> URL: https://issues.redhat.com/browse/ISPN-11974
> Project: Infinispan
> Issue Type: Task
> Components: Configuration, Hot Rod
> Affects Versions: 11.0.0.CR1
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 11.0.0.Final
>
>
> Currently if the {{infinispan-jboss-marshalling}} module is on the client classpath we automatically configure the client marshaller to be {{GenericJBossMarshaller}}. This causes issues with our testsuite, as the module is often on the classpath. Furthermore, we want users to start transitioning away from JBoss Marshalling. Therefore, from Infinispan -12- 11 we should no automatically configure this marshaller if the module is present.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11974) Remove GenericJbossMarshaller automatic configuration
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11974?page=com.atlassian.jira.plugi... ]
Will Burns closed ISPN-11974.
-----------------------------
Resolution: Done
> Remove GenericJbossMarshaller automatic configuration
> -----------------------------------------------------
>
> Key: ISPN-11974
> URL: https://issues.redhat.com/browse/ISPN-11974
> Project: Infinispan
> Issue Type: Task
> Components: Configuration, Hot Rod
> Affects Versions: 11.0.0.CR1
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 11.0.0.Final
>
>
> Currently if the {{infinispan-jboss-marshalling}} module is on the client classpath we automatically configure the client marshaller to be {{GenericJBossMarshaller}}. This causes issues with our testsuite, as the module is often on the classpath. Furthermore, we want users to start transitioning away from JBoss Marshalling. Therefore, from Infinispan -12- 11 we should no automatically configure this marshaller if the module is present.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-12027) RemoteCacheContainer missing getCache overrides
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-12027?page=com.atlassian.jira.plugi... ]
Will Burns updated ISPN-12027:
------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 12.0.0.Final
Resolution: Done
> RemoteCacheContainer missing getCache overrides
> -----------------------------------------------
>
> Key: ISPN-12027
> URL: https://issues.redhat.com/browse/ISPN-12027
> Project: Infinispan
> Issue Type: Bug
> Components: Hot Rod
> Affects Versions: 11.0.0.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 12.0.0.Final, 11.0.1.Final
>
>
> The {{RemoteCacheContainer}} inherits the {{getCache()}} and {{getCache(String)}} methods from the {{BasicCacheContainer}}, however these return a {{BasicCache}} instance when a {{RemoteCache}} is required. We should override these methods in {{RemoteCacheContainer}}.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11992) Convert RemoteStore to use new SPI
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11992?page=com.atlassian.jira.plugi... ]
Will Burns commented on ISPN-11992:
-----------------------------------
Unfortunately segmentation is currently broken as we utilize a marshaller which can change the segment a key maps to. We really need to use an identity marshaller for the remote cache in the store and do the media type conversion in the store itself.
We then must disable segmentation if the cache with the store's key storage media type doesn't match the server's key storage media type or if the number of segments don't match. We technically would need to do it for the consistent hash used but we don't have a way to check that easily atm.
> Convert RemoteStore to use new SPI
> ----------------------------------
>
> Key: ISPN-11992
> URL: https://issues.redhat.com/browse/ISPN-11992
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Reporter: Will Burns
> Priority: Major
> Fix For: 12.0.0.Final, 11.0.1.Final
>
>
> The RemoteStore already uses a non blocking client. We should convert it to the new SPI to utilize this.
> We also need to add in a check for the old server to see how many segments it has. If the number is different than the current server we need to disable the segmentation characteristic and instead do the costlier iteration.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11992) Convert RemoteStore to use new SPI
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11992?page=com.atlassian.jira.plugi... ]
Will Burns commented on ISPN-11992:
-----------------------------------
Also of note raw values currently breaks irac and other features that may require custom/private metadata.
> Convert RemoteStore to use new SPI
> ----------------------------------
>
> Key: ISPN-11992
> URL: https://issues.redhat.com/browse/ISPN-11992
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Reporter: Will Burns
> Priority: Major
> Fix For: 12.0.0.Final, 11.0.1.Final
>
>
> The RemoteStore already uses a non blocking client. We should convert it to the new SPI to utilize this.
> We also need to add in a check for the old server to see how many segments it has. If the number is different than the current server we need to disable the segmentation characteristic and instead do the costlier iteration.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months