[JBoss JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/IPROTO-162?page=com.atlassian.jira.plugi... ]
Nistor Adrian reopened IPROTO-162:
----------------------------------
Reopening, to be able to edit description, add examples and more notes to ease upgrading
> MirrorClass.getEnclosingClass() is broken and always returs null
> ----------------------------------------------------------------
>
> Key: IPROTO-162
> URL: https://issues.redhat.com/browse/IPROTO-162
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 4.3.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 4.4.0.Alpha1, 4.3.4.Final
>
>
> Message types generated with annotation processing during compile time should follow the nesting of the classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types becoming top level types in the generated schema.
>
> Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (ISPN-12309) Creating cache with invalid configuration leaves inconsistent state
by Gustavo Fernandes (Jira)
[ https://issues.redhat.com/browse/ISPN-12309?page=com.atlassian.jira.plugi... ]
Gustavo Fernandes updated ISPN-12309:
-------------------------------------
Component/s: REST
> Creating cache with invalid configuration leaves inconsistent state
> -------------------------------------------------------------------
>
> Key: ISPN-12309
> URL: https://issues.redhat.com/browse/ISPN-12309
> Project: Infinispan
> Issue Type: Bug
> Components: Core, REST
> Reporter: Katia Aresti
> Assignee: Gustavo Fernandes
> Priority: Critical
>
> When a cache is created using the EmbeddedCacheManagerAdmin with a configuration that prevents the cache from starting, it will throw an error but will persist the cache nonetheless.
> Further operations involving cache manager can throw exceptions, for example, {{Health.getHealth()}} since it tries to access the invalid cache that cannot be started
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (ISPN-12309) Creating cache with invalid configuration leaves inconsistent state
by Gustavo Fernandes (Jira)
[ https://issues.redhat.com/browse/ISPN-12309?page=com.atlassian.jira.plugi... ]
Gustavo Fernandes updated ISPN-12309:
-------------------------------------
Affects Version/s: 12.0.0.Dev04
11.0.3.Final
> Creating cache with invalid configuration leaves inconsistent state
> -------------------------------------------------------------------
>
> Key: ISPN-12309
> URL: https://issues.redhat.com/browse/ISPN-12309
> Project: Infinispan
> Issue Type: Bug
> Components: Core, REST
> Affects Versions: 11.0.3.Final, 12.0.0.Dev04
> Reporter: Katia Aresti
> Assignee: Gustavo Fernandes
> Priority: Critical
>
> When a cache is created using the EmbeddedCacheManagerAdmin with a configuration that prevents the cache from starting, it will throw an error but will persist the cache nonetheless.
> Further operations involving cache manager can throw exceptions, for example, {{Health.getHealth()}} since it tries to access the invalid cache that cannot be started
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null leading to wrong schema being generated
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/IPROTO-162?page=com.atlassian.jira.plugi... ]
Nistor Adrian updated IPROTO-162:
---------------------------------
Summary: MirrorClass.getEnclosingClass() is broken and always returs null leading to wrong schema being generated (was: MirrorClass.getEnclosingClass() is broken and always returs null)
> MirrorClass.getEnclosingClass() is broken and always returs null leading to wrong schema being generated
> --------------------------------------------------------------------------------------------------------
>
> Key: IPROTO-162
> URL: https://issues.redhat.com/browse/IPROTO-162
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 4.3.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 4.4.0.Alpha1, 4.3.4.Final
>
>
> Message types generated with annotation processing during compile time should follow the nesting of the classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types becoming top level types in the generated schema.
>
> Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/IPROTO-162?page=com.atlassian.jira.plugi... ]
Nistor Adrian closed IPROTO-162.
--------------------------------
Resolution: Done
> MirrorClass.getEnclosingClass() is broken and always returs null
> ----------------------------------------------------------------
>
> Key: IPROTO-162
> URL: https://issues.redhat.com/browse/IPROTO-162
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 4.3.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 4.4.0.Alpha1, 4.3.4.Final
>
>
> Message types generated with annotation processing during compile time should follow the nesting of the classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types becoming top level types in the generated schema.
>
> Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/IPROTO-162?page=com.atlassian.jira.plugi... ]
Nistor Adrian commented on IPROTO-162:
--------------------------------------
The fix was included here [https://github.com/infinispan/protostream/commit/0723b4e86bda16eaa9a0c400...]
It seems TypeMirror.getEnclosingType() does not work (always returns null) while TypeElement.getEnclosingElement() works corectly. Bad bad bad javac!!
So I used the alternative implementation to work around it.
> MirrorClass.getEnclosingClass() is broken and always returs null
> ----------------------------------------------------------------
>
> Key: IPROTO-162
> URL: https://issues.redhat.com/browse/IPROTO-162
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 4.3.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 4.4.0.Alpha1, 4.3.4.Final
>
>
> Message types generated with annotation processing during compile time should follow the nesting of the classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types becoming top level types in the generated schema.
>
> Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/IPROTO-162?page=com.atlassian.jira.plugi... ]
Nistor Adrian updated IPROTO-162:
---------------------------------
Fix Version/s: 4.4.0.Alpha1
4.3.4.Final
> MirrorClass.getEnclosingClass() is broken and always returs null
> ----------------------------------------------------------------
>
> Key: IPROTO-162
> URL: https://issues.redhat.com/browse/IPROTO-162
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 4.3.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 4.4.0.Alpha1, 4.3.4.Final
>
>
> Message types generated with annotation processing during compile time should follow the nesting of the classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types becoming top level types in the generated schema.
>
> Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/IPROTO-162?page=com.atlassian.jira.plugi... ]
Nistor Adrian updated IPROTO-162:
---------------------------------
Status: Open (was: New)
> MirrorClass.getEnclosingClass() is broken and always returs null
> ----------------------------------------------------------------
>
> Key: IPROTO-162
> URL: https://issues.redhat.com/browse/IPROTO-162
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 4.3.0.Final
> Reporter: Nistor Adrian
> Priority: Major
>
> Message types generated with annotation processing during compile time should follow the nesting of the classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types becoming top level types in the generated schema.
>
> Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/IPROTO-162?page=com.atlassian.jira.plugi... ]
Nistor Adrian reassigned IPROTO-162:
------------------------------------
Assignee: Nistor Adrian
> MirrorClass.getEnclosingClass() is broken and always returs null
> ----------------------------------------------------------------
>
> Key: IPROTO-162
> URL: https://issues.redhat.com/browse/IPROTO-162
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 4.3.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
>
> Message types generated with annotation processing during compile time should follow the nesting of the classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types becoming top level types in the generated schema.
>
> Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (IPROTO-162) MirrorClass.getEnclosingClass() is broken and always returs null
by Nistor Adrian (Jira)
Nistor Adrian created IPROTO-162:
------------------------------------
Summary: MirrorClass.getEnclosingClass() is broken and always returs null
Key: IPROTO-162
URL: https://issues.redhat.com/browse/IPROTO-162
Project: Infinispan ProtoStream
Issue Type: Bug
Affects Versions: 4.3.0.Final
Reporter: Nistor Adrian
Message types generated with annotation processing during compile time should follow the nesting of the classes from which they are generated. But since getEnclosingClass() always returns null that leads to all types becoming top level types in the generated schema.
Interestingly, the runtime variant of this, ReflectionClass.getEnclosingClass() works correctly and we only test that one in our suite.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months