[infinispan-issues] [JBoss JIRA] (ISPN-5801) Cache with CacheLoader and CreatedExpiryPolicy Invalidates Instantly

[ https://issues.jboss.org/browse/ISPN-5801?page=com.atlassian.jira.plugin.... ] Dan Siviter edited comment on ISPN-5801 at 10/1/15 7:02 AM: ------------------------------------------------------------ So looking at the code comments in {{JCacheInternalMetadata}} it states {{#expiry}} is: bq. // absolute time when entry should expire However, if {{CreatedExpiryPolicy}} is set to {{Duration#FIVE_MINUTES}} this value will be 300,000ms. This causes {{JCacheInternalMetadata#isExpired}} to return {{true}}. Personally, I'd say that {{#expiry}} should be the offset and not absolute time. Therefore, the issue could be fixed using: {code} @Override public boolean isExpired(long now) { return expiry > -1 && (created + expiry) <= now; } {code} ...but I'm not sure of the impact of this. was (Author: dan_siviter): So looking at the code comments in {{JCacheInternalMetadata}} it states {{#expiry}} is: bq. // absolute time when entry should expire However, if {{CreatedExpiryPolicy}} is set to {{Duration#FIVE_MINUTES}} this value will be 300,000ms. This causes {{JCacheInternalMetadata#isExpired}} to return the incorrect value. Personally, I'd say that {{#expiry}} should be the offset and not absolute time. Therefore, the issue could be fixed using: {code} @Override public boolean isExpired(long now) { return expiry > -1 && (created + expiry) <= now; } {code} ...but I'm not sure of the impact of this. -- This message was sent by Atlassian JIRA (v6.4.11#64026)