]
Galder Zamarreño updated ISPN-6935:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Use Collection instead of Set
-----------------------------
Key: ISPN-6935
URL:
https://issues.jboss.org/browse/ISPN-6935
Project: Infinispan
Issue Type: Sub-task
Components: Core
Affects Versions: 9.0.0.Alpha4
Reporter: Radim Vansa
Assignee: Radim Vansa
Fix For: 9.0.0.Beta1
Currently the xManyCommand commands hold the keys in a set internally. During marshalling
and splitting the set (when the command goes remote), we use {{HashSet}}. However, this
has drawbacks:
a) if the set passed to command uses different means of equality than
{{Object.hashCode()}} and {{Object.equals()}} we may lose some keys in the derived set -
we don't inject dataContainer's keyEquivalence to the commands
b) as these sets are usually just iterated through (contains() is rare) it's less
effective to use complex data structures as {{HashSet}} - plain {{ArrayList}} is
sufficient.