7:11 a.m.
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Affects Versions: 4.1.0.Final
Environment: any
Reporter: Edouard Boily
Assignee: Manik Surtani
Fix For: 4.2.0.Final
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:15 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-694) Create Expiration Notification
[
https://jira.jboss.org/browse/ISPN-694?page=com.atlassian.jira.plugin.sys...
]
Edouard Boily updated ISPN-694:
-------------------------------
Attachment: 01.patch
This patch implement this feature.
It creates the CacheEntryExpiredEvent and implements its usage.
It also modifies the eviction manager to include the entry value in the Eviction event.
to apply:
cd infinispan-4.1.0.FINAL
patch -p1 <../01.patch
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Affects Versions: 4.1.0.Final
Environment: any
Reporter: Edouard Boily
Assignee: Manik Surtani
Fix For: 4.2.0.Final
Attachments: 01.patch
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:17 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-694) Create Expiration Notification
[
https://jira.jboss.org/browse/ISPN-694?page=com.atlassian.jira.plugin.sys...
]
Galder Zamarreño commented on ISPN-694:
---------------------------------------
CacheEntryExpiredEvent sounds good to me.
In terms of passing the entry value, this should work like CacheEntryRemovedEvent
(http://docs.jboss.org/infinispan/4.1/apidocs/org/infinispan/notifications...):
"The getValue() method would return the old value prior to deletion, if isPre() is
true. If isPre() is false, getValue() will return null."
Haven't checked the patch but can you verify it works this way?
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Affects Versions: 4.1.0.Final
Environment: any
Reporter: Edouard Boily
Assignee: Manik Surtani
Fix For: 4.2.0.Final
Attachments: 01.patch
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:19 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-694) Create Expiration Notification
[
https://jira.jboss.org/browse/ISPN-694?page=com.atlassian.jira.plugin.sys...
]
Galder Zamarreño updated ISPN-694:
----------------------------------
Fix Version/s: 4.2.0.BETA1
Affects Version/s: (was: 4.1.0.Final)
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Environment: any
Reporter: Edouard Boily
Assignee: Manik Surtani
Fix For: 4.2.0.BETA1, 4.2.0.Final
Attachments: 01.patch
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:36 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-694) Create Expiration Notification
[
https://jira.jboss.org/browse/ISPN-694?page=com.atlassian.jira.plugin.sys...
]
Manik Surtani updated ISPN-694:
-------------------------------
Assignee: Trustin Lee (was: Manik Surtani)
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Environment: any
Reporter: Edouard Boily
Assignee: Trustin Lee
Fix For: 4.2.0.BETA1, 4.2.0.Final
Attachments: 01.patch
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:11 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-694) Create Expiration Notification
[
https://jira.jboss.org/browse/ISPN-694?page=com.atlassian.jira.plugin.sys...
]
Trustin Lee commented on ISPN-694:
----------------------------------
The patch doesn't seem to notify the entries purged by CacheStore.purgeExpired(). Is
it intended or just missed out? If the entries purged by CacheStore.purgeExpired() should
also be notified, it will also require a change in CacheStore API, which means this issue
needs to be resolved in 5.0.
By the way, Instead of adding CacheNotifier parameter to purgeExpired(), I'd modify it
to return the set of purged entries (i.e. Set<InternalCacheEntry>).
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Environment: any
Reporter: Edouard Boily
Assignee: Trustin Lee
Fix For: 4.2.0.BETA1, 4.2.0.Final
Attachments: 01.patch
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:46 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-694) Create Expiration Notification
[
https://jira.jboss.org/browse/ISPN-694?page=com.atlassian.jira.plugin.sys...
]
Manik Surtani commented on ISPN-694:
------------------------------------
@Trustin I would then defer this task. Getting a cache store to return the entries purged
is very expensive in some cases (e.g., the CloudCacheStore) which will result in remote
calls to a cloud storage provider for each entry, plus deserialization, etc etc. So in
general, -1 for this notification to be emitted via CacheStore.purgeExpired(). But that
leaves us with incomplete/inconsistent notifications for expired entries. So again, -1 to
this feature request/patch for now ... at least until there is a more workable solution
proposed.
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Environment: any
Reporter: Edouard Boily
Assignee: Trustin Lee
Fix For: 4.2.0.BETA1, 4.2.0.Final
Attachments: 01.patch
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:51 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-694) Create Expiration Notification
[
https://jira.jboss.org/browse/ISPN-694?page=com.atlassian.jira.plugin.sys...
]
Mircea Markus updated ISPN-694:
-------------------------------
Fix Version/s: 4.2.0.BETA1
(was: 4.2.0.ALPHA4)
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Environment: any
Reporter: Edouard Boily
Assignee: Trustin Lee
Fix For: 4.2.0.BETA1, 4.2.0.Final
Attachments: 01.patch
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 a.m.
New subject: [JBoss JIRA] Resolved: (ISPN-694) Create Expiration Notification
[
https://jira.jboss.org/browse/ISPN-694?page=com.atlassian.jira.plugin.sys...
]
Trustin Lee resolved ISPN-694.
------------------------------
Fix Version/s: (was: 4.2.0.Final)
(was: 4.2.0.BETA1)
Resolution: Rejected
Rejected due to the reason stated in the previous comment by Manik.
Create Expiration Notification
------------------------------
Key: ISPN-694
URL: https://jira.jboss.org/browse/ISPN-694
Project: Infinispan
Issue Type: Feature Request
Components: Eviction
Environment: any
Reporter: Edouard Boily
Assignee: Trustin Lee
Attachments: 01.patch
Create a CacheEntryExpired notification and make EvictionManager send this notification
when a cache entry is evicted because it is expired.
Also mage sure the cache entry value is sent over in the event.
CacheEntryEvicted notification should also send the entry value in the event.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5087
days inactive
5108
days old
infinispan-issues@lists.jboss.org
8 comments
5 participants
participants (5)
-
Edouard Boily (JIRA) -
Galder Zamarreño (JIRA)
-
Manik Surtani (JIRA)
-
Mircea Markus (JIRA)
-
Trustin Lee (JIRA)