6:08 a.m.
[
https://issues.jboss.org/browse/ISPN-8552?page=com.atlassian.jira.plugin....
]
Galder Zamarreño edited comment on ISPN-8552 at 11/22/17 7:07 AM:
------------------------------------------------------------------
{code}
<remerson> galderz: we stripped the infinispan version stuff out of
the bom as the argument was that if you know the version of the
bom you need, you also know the version of the artifacts you need
<remerson> galderz: the idea being that the bom should just detail the
3rd party dependencies
remerson: the whole point of the bom is that i don't need to
redefine versions of modules all around
remerson: i disagree, see what vert.x and others do
remerson: if you want a new bom without infinsipan modules, create a
separate
bom module
<remerson> galderz: I don't have particularly strong views on this, it
was just the result of a conversation between myself, ttarrant and
sanne
<remerson> galderz: I wouldn't be against a PR that reinstates the
infinispan versions to the bom and removes them from parent
remerson: i don't disagree wityh the motivations, but don't
change
the existing bom!!
all my examples are broken
remerson:
https://github.com/vert-x3/vertx-dependencies/blob/master/pom.xml
...
<remerson> galderz: 5 mins and I'll issue a PR. It shouldn't be a
difficult fix
remerson: let's have a think first
projects like vert.x are adding their own modules to the pom.xml
remerson: we need to study this in more detail
remerson: as a side note, i've not heard anyone complaining about
infinispan-bom
<remerson> galderz: me neither. The motivation was to reproduce
repetition as we didn't see much benefit in having said
content. But if it is causing issues, even just with our stuff, it
is obviously worth reconsidering
<remerson> galderz: a counter example to Vert.x is hibernate-ogm
https://github.com/hibernate/hibernate-ogm/blob/master/pom.xml
so a wider discussion is needed
at first glance, i find it convenient to not have to define
versions...
it's like with plugin management, you define versions and config
there, then you just use...
{code}
was (Author: galder.zamarreno):
{code}
<remerson> galderz: we stripped the infinispan version stuff out of
the bom as the argument was that if you know the version of the
bom you need, you also know the version of the artifacts you need
<remerson> galderz: the idea being that the bom should just detail the
3rd party dependencies
remerson: the whole point of the bom is that i don't need to
redefine versions of modules all around
remerson: i disagree, see what vert.x and others do
remerson: if you want a new bom without infinsipan modules, create a
separate
bom module
<remerson> galderz: I don't have particularly strong views on this, it
was just the result of a conversation between myself, ttarrant and
sanne
<remerson> galderz: I wouldn't be against a PR that reinstates the
infinispan versions to the bom and removes them from parent
remerson: i don't disagree wityh the motivations, but don't
change
the existing bom!!
all my examples are broken
remerson:
https://github.com/vert-x3/vertx-dependencies/blob/master/pom.xml
{code}
infinispan-bom is broken
------------------------
Key: ISPN-8552
URL: https://issues.jboss.org/browse/ISPN-8552
Project: Infinispan
Issue Type: Bug
Affects Versions: 9.2.0.Beta1
Reporter: Galder Zamarreño
Priority: Blocker
Fix For: 9.2.0.CR1
I've tried to upgrade one of my examples to 9.2.0.Beta1 but it fails. I've
changed version
[here|https://github.com/infinispan-demos/swiss-transport-datagrid/blob/ma...]
to be 9.2.0.Beta1 and I get tons of errors:
{code}
mvn clean package ⏎master ✭ ✱
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-tasks-api:jar is missing. @ line 23, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-remote-query-server:jar is missing. @ line 29, column 17
[ERROR] 'dependencies.dependency.version' for org.infinispan:infinispan-core:jar
is missing. @ line 41, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-client-hotrod:jar is missing. @ line 54, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-remote-query-client:jar is missing. @ line 58, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-tasks-api:jar is missing. @ line 30, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-remote-query-server:jar is missing. @ line 36, column 17
@
[ERROR] The build could not read 3 projects -> [Help 1]
[ERROR]
[ERROR] The project swiss-transport-datagrid:analytics-domain:1.0-SNAPSHOT
(/Users/g/1/swiss-transport-datagrid/analytics/analytics-domain/pom.xml) has 3 errors
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-tasks-api:jar is missing. @ line 23, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-remote-query-server:jar is missing. @ line 29, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-core:jar is missing. @ line 41, column 17
[ERROR]
[ERROR] The project swiss-transport-datagrid:analytics-client:1.0-SNAPSHOT
(/Users/g/1/swiss-transport-datagrid/analytics/analytics-client/pom.xml) has 2 errors
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-client-hotrod:jar is missing. @ line 54, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-remote-query-client:jar is missing. @ line 58, column 17
[ERROR]
[ERROR] The project swiss-transport-datagrid:analytics-server:1.0-SNAPSHOT
(/Users/g/1/swiss-transport-datagrid/analytics/analytics-server/pom.xml) has 2 errors
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-tasks-api:jar is missing. @ line 30, column 17
[ERROR] 'dependencies.dependency.version' for
org.infinispan:infinispan-remote-query-server:jar is missing. @ line 36, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the
following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
{code}
This seems related to changes in ISPN-8408 where the infinispan modules disappeared from
the bom (???)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
2604
days inactive
2604
days old
infinispan-issues@lists.jboss.org
0 comments
1 participants
participants (1)
-
Galder Zamarreño (JIRA)