[ https://issues.jboss.org/browse/ISPN-1162?page=com.atlassian.jira.plugin.... ] Galder Zamarreño reassigned ISPN-1162: -------------------------------------- Assignee: Galder Zamarreño (was: Manik Surtani) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1162?page=com.atlassian.jira.plugin.... ] Work on ISPN-1162 started by Galder Zamarreño. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1162?page=com.atlassian.jira.plugin.... ] Galder Zamarreño commented on ISPN-1162: ---------------------------------------- We don't currently have any way to check for duplicate command ids in the infinispan-core, we simply have a unit test that verifies that. So, rather than trying to build this, I've gone for the approach I suggested in the forum thread, where infinispan-core commands and external commands are indexed differently in the stream. So, by indexing infinispan-core modules with 0, and module commands with 1, duplicates can be discovered more easily. The unit test we have discovers duplicate commands in the core/ module, and the infrastructure in ModuleProperties checks for dups for the rest. It might not be the prettiest of solutions. A global check for duplicate ids might be the correct solution, but I think it's the most pragmatic one and the one requiring the least amount of changes. Also, with this solution, external commands can be indexed from 1 without having any effect the internal commands. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1162?page=com.atlassian.jira.plugin.... ] Galder Zamarreño updated ISPN-1162: ----------------------------------- Fix Version/s: 5.0.0.CR6 (was: 5.0.0.CR7) Git Pull Request: https://github.com/infinispan/infinispan/pull/397 (was: https://github.com/infinispan/infinispan/pull/397) Forum Reference: http://lists.jboss.org/pipermail/infinispan-dev/2011-June/008395.html (was: http://lists.jboss.org/pipermail/infinispan-dev/2011-June/008395.html) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira