3:32 p.m.
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of SerializationType
to be the following instead (just added the accept to AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:08 a.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
William Burns updated ISPN-1500:
--------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/605
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:26 a.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1500:
-----------------------------------
Fix Version/s: 5.1.0.CR1
5.1.0.FINAL
Git Pull Request: https://github.com/infinispan/infinispan/pull/605 (was:
https://github.com/infinispan/infinispan/pull/605)
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:56 a.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1500:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/605 (was:
https://github.com/infinispan/infinispan/pull/605)
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:02 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1500:
----------------------------------------
Not sure I understand what overrides exactly you're trying to implement for global
configuration.
Could you please show some code/xml of what you're trying to achieve?
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:02 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1500:
----------------------------------------
Not sure I understand what overrides exactly you're trying to implement for global
configuration.
Could you please show some code/xml of what you're trying to achieve?
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:02 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1500:
----------------------------------------
Not sure I understand what overrides exactly you're trying to implement for global
configuration.
Could you please show some code/xml of what you're trying to achieve?
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:04 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1500:
-----------------------------------
Comment: was deleted
(was: Not sure I understand what overrides exactly you're trying to implement for
global configuration.
Could you please show some code/xml of what you're trying to achieve?)
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:04 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1500:
-----------------------------------
Comment: was deleted
(was: Not sure I understand what overrides exactly you're trying to implement for
global configuration.
Could you please show some code/xml of what you're trying to achieve?)
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:12 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
William Burns commented on ISPN-1500:
-------------------------------------
So I was trying to do something similar to how you can apply overrides for the default
configuration.
This is similar to what we have now for default and named caches given N number of
infinispan.xml files which works great.
{code}
List<File> files = ...
for (File file : files) {
InfinispanConfiguration readConfig;
Reader reader = null;
try {
reader = new InputStreamReader(
new FileInputStream(file), "UTF-8");
readConfig = InfinispanConfiguration.newInfinispanConfiguration(
reader);
}
catch (IOException e) {
throw new RuntimeException("There was a problem when parsing infispan
configuration files.", e);
}
finally {
if (reader != null) {
try {
reader.close();
}
catch (IOException e) {
_logger.warn("There was a problem closing reader!", e);
}
}
// Apply overrides to default config
cacheManager.getDefaultConfiguration().applyOverrides(readConfig.parseDefaultConfiguration());
// Apply overrides/definitions to all named caches found in xml
for (Entry<String, Configuration> entry :
readConfig.parseNamedConfigurations().entrySet()) {
String name = entry.getKey();
cacheManager.defineConfiguration(name, entry.getValue());
cacheNames.add(name);
}
}
{code}
So with the move to 5.0+ we need to be able to override or add new externalizers. I
checked the available classes and there is no override class for global config, which is
fine. I ended up writing my own override class which is attached
(MocaOverrideGlobalConfiguration). So with that I can just add the below code to my
previous override code and it would allow for further infinispan.xml files to possible
reconfigure global configuration (rack, machine and site are also nice).
{code}
// This should allow overriding global configuration elements
MocaOverrideGlobalConfiguration v1 = new MocaOverrideGlobalConfiguration();
cacheManager.getGlobalConfiguration().accept(v1);
MocaOverrideGlobalConfiguration v2 = new MocaOverrideGlobalConfiguration();
GlobalConfiguration globalConfig = readConfig.parseGlobalConfiguration();
globalConfig.accept(v2);
v1.override(v2);
{code}
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Attachments: MocaOverrideGlobalConfiguration.java
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:12 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
William Burns updated ISPN-1500:
--------------------------------
Attachment: MocaOverrideGlobalConfiguration.java
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Attachments: MocaOverrideGlobalConfiguration.java
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:18 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
William Burns edited comment on ISPN-1500 at 11/1/11 2:17 PM:
--------------------------------------------------------------
So if the accept is added I can change
{code}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
// TODO: We have this hacky way until https://issues.jboss.org/browse/ISPN-1500 is
fixed
AdvancedExternalizersType type = (AdvancedExternalizersType) ReflectionUtil
.getValue(override._serializactionType, "externalizerTypes");
Collection<AdvancedExternalizerConfig> configs =
(Collection<AdvancedExternalizerConfig>) ReflectionUtil
.getValue(type, "advancedExternalizers");
for (AdvancedExternalizerConfig config : configs) {
Integer id = config.getId();
if (id != null) {
_serializactionType.addAdvancedExternalizer(
config.getId(),
(AdvancedExternalizer<?>) Util.getInstance(
config.getExternalizerClass(), null));
}
else {
_serializactionType
.addAdvancedExternalizer((AdvancedExternalizer<?>) Util
.getInstance(config.getExternalizerClass(), null));
}
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
to
{code}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
for (AdvancedExternalizerConfig config : _advancedExternalizerConfigs) {
Integer id = config.getId();
if (id != null) {
_serializactionType.addAdvancedExternalizer(
config.getId(),
(AdvancedExternalizer<?>) Util.getInstance(
config.getExternalizerClass(), null));
}
else {
_serializactionType
.addAdvancedExternalizer((AdvancedExternalizer<?>) Util
.getInstance(config.getExternalizerClass(), null));
}
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
and if AdvancedExternalizersType changes visibility I can change it to
{code}
// @see
org.infinispan.config.AbstractConfigurationBeanVisitor#visitAdvancedExternalizersType(org.infinispan.config.GlobalConfiguration.AdvancedExternalizersType)
@Override
public void visitAdvancedExternalizersType(AdvancedExternalizersType bean) {
_advancedExternalizersType = bean;
}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
for (AdvancedExternalizerConfig config : _advancedExternalizerConfigs) {
_advancedExternalizersType.addExternalizer(config);
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
was (Author: rpwburns):
So if the accept is added I can change
{code}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
// TODO: We have this hacky way until https://issues.jboss.org/browse/ISPN-1500 is
fixed
AdvancedExternalizersType type = (AdvancedExternalizersType) ReflectionUtil
.getValue(override._serializactionType, "externalizerTypes");
Collection<AdvancedExternalizerConfig> configs =
(Collection<AdvancedExternalizerConfig>) ReflectionUtil
.getValue(type, "advancedExternalizers");
for (AdvancedExternalizerConfig config : configs) {
Integer id = config.getId();
if (id != null) {
_serializactionType.addAdvancedExternalizer(
config.getId(),
(AdvancedExternalizer<?>) Util.getInstance(
config.getExternalizerClass(), null));
}
else {
_serializactionType
.addAdvancedExternalizer((AdvancedExternalizer<?>) Util
.getInstance(config.getExternalizerClass(), null));
}
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
to
{code}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
for (AdvancedExternalizerConfig config : _advancedExternalizerConfigs) {
Integer id = config.getId();
if (id != null) {
_serializactionType.addAdvancedExternalizer(
config.getId(),
(AdvancedExternalizer<?>) Util.getInstance(
config.getExternalizerClass(), null));
}
else {
_serializactionType
.addAdvancedExternalizer((AdvancedExternalizer<?>) Util
.getInstance(config.getExternalizerClass(), null));
}
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
and if AdvancedExternalizersType changes visibility I can change it to
{code}
// @see
org.infinispan.config.AbstractConfigurationBeanVisitor#visitAdvancedExternalizersType(org.infinispan.config.GlobalConfiguration.AdvancedExternalizersType)
@Override
public void visitAdvancedExternalizersType(AdvancedExternalizersType bean) {
}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
for (AdvancedExternalizerConfig config : _advancedExternalizerConfigs) {
_advancedExternalizersType.addExternalizer(config);
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Attachments: MocaOverrideGlobalConfiguration.java
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:18 p.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
William Burns commented on ISPN-1500:
-------------------------------------
So if the accept is added I can change
{code}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
// TODO: We have this hacky way until https://issues.jboss.org/browse/ISPN-1500 is
fixed
AdvancedExternalizersType type = (AdvancedExternalizersType) ReflectionUtil
.getValue(override._serializactionType, "externalizerTypes");
Collection<AdvancedExternalizerConfig> configs =
(Collection<AdvancedExternalizerConfig>) ReflectionUtil
.getValue(type, "advancedExternalizers");
for (AdvancedExternalizerConfig config : configs) {
Integer id = config.getId();
if (id != null) {
_serializactionType.addAdvancedExternalizer(
config.getId(),
(AdvancedExternalizer<?>) Util.getInstance(
config.getExternalizerClass(), null));
}
else {
_serializactionType
.addAdvancedExternalizer((AdvancedExternalizer<?>) Util
.getInstance(config.getExternalizerClass(), null));
}
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
to
{code}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
for (AdvancedExternalizerConfig config : _advancedExternalizerConfigs) {
Integer id = config.getId();
if (id != null) {
_serializactionType.addAdvancedExternalizer(
config.getId(),
(AdvancedExternalizer<?>) Util.getInstance(
config.getExternalizerClass(), null));
}
else {
_serializactionType
.addAdvancedExternalizer((AdvancedExternalizer<?>) Util
.getInstance(config.getExternalizerClass(), null));
}
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
and if AdvancedExternalizersType changes visibility I can change it to
{code}
// @see
org.infinispan.config.AbstractConfigurationBeanVisitor#visitAdvancedExternalizersType(org.infinispan.config.GlobalConfiguration.AdvancedExternalizersType)
@Override
public void visitAdvancedExternalizersType(AdvancedExternalizersType bean) {
}
@SuppressWarnings("unchecked")
public void override(MocaOverrideGlobalConfiguration override) {
for (AdvancedExternalizerConfig config : _advancedExternalizerConfigs) {
_advancedExternalizersType.addExternalizer(config);
}
// We want to override the provided transport values
overrideFields(_transportType, override._transportType);
overrideFields(_jmxType, override._jmxType);
overrideFields(_shutdownType, override._shutdownType);
}
{code}
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Attachments: MocaOverrideGlobalConfiguration.java
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:04 a.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1500:
----------------------------------------
Right, I can see what you're doing now. Pete, one of our team mates is working on
ISPN-1065 which will have an impact on the programmatic configuration as well, so I'll
check with him if this can be accommodated in the new code. It might not be worth fixing
the current code.
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Attachments: MocaOverrideGlobalConfiguration.java
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:21 a.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Pete Muir commented on ISPN-1500:
---------------------------------
The new approach will support reading in an existing configuration (both global and cache)
as the basis for a new configuration. We're moving away from the current architecture,
so the approach discussed here isn't relevant anymore, but the underlying use case
will be supported.
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Fix For: 5.1.0.CR1, 5.1.0.FINAL
Attachments: MocaOverrideGlobalConfiguration.java
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:20 a.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Manik Surtani commented on ISPN-1500:
-------------------------------------
@Pete ok, I'll close this JIRA and reject the pull request then. @William - thanks
for bringing this up and submitting the patch all the same - don't take it personally
that we're not incorporating your contribution. :-)
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Attachments: MocaOverrideGlobalConfiguration.java
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:20 a.m.
[
https://issues.jboss.org/browse/ISPN-1500?page=com.atlassian.jira.plugin....
]
Manik Surtani updated ISPN-1500:
--------------------------------
Status: Closed (was: Pull Request Sent)
Fix Version/s: (was: 5.1.0.FINAL)
(was: 5.1.0.CR1)
Resolution: Out of Date
SerializationType doesn't visit AdvancedExternalizersType
---------------------------------------------------------
Key: ISPN-1500
URL: https://issues.jboss.org/browse/ISPN-1500
Project: Infinispan
Issue Type: Bug
Components: Configuration
Affects Versions: 5.0.1.FINAL
Reporter: William Burns
Assignee: Manik Surtani
Attachments: MocaOverrideGlobalConfiguration.java
Using infinispan, we have multiple infinispan.xml files that are used to configure our
caches. The overrides used on default and cache configurations work great for this. I
noticed there is no override global configuration support. So I was trying to make my own
for the stuff we needed. One of the items we need to "override" is the
serialization configs (it is more additive than override).
When doing this I found that the SerializationType doesn't properly pass off the
vistor to the AdvancedExternalizersType and thus I can't visit the Type or Configs,
which would make doing this much easier.
I was hoping I could keep a List of AdvancedSerializationConfigs that it visits and then
in my override method just add these Configs 1 by 1 to the SerializationType since it has
the public methods to add AdvancedSerializers.
It seems to be just an oversight but I would expect the accept method of
SerializationType to be the following instead (just added the accept to
AdvancedExternalizersType).
{code}
public void accept(ConfigurationBeanVisitor v) {
this.externalizerTypes.accept(v);
v.visitSerializationType(this);
}
{code}
Side note I noticed the AdvancedExternalizersType has addExternalizer as package level.
It would be easier to just call that method instead of having to detect the id myself and
whether an object or class is configured in the AdvancedSerializerConfig to decide what
add to call, since I could just do a straight add of the Config.
Also there is no way to remove or detect what AdvancedSerializers are present on the
SerializationType, which would be very helpful when trying to replace a given
AdvancedSerializers. Or are the AdvancedSerializerConfigs used started at the end of the
list? This would be preferable, because then I wouldn't care if another existed since
the one I just added would take priority.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4807
days inactive
4813
days old
infinispan-issues@lists.jboss.org
16 comments
9 participants
participants (9)
-
Galder Zamarreño (Commented) (JIRA) -
Galder Zamarreño (Updated) (JIRA)
-
Manik Surtani (Commented) (JIRA)
-
Manik Surtani (Updated) (JIRA)
-
Pete Muir (Commented) (JIRA)
-
William Burns (Commented) (JIRA)
-
William Burns (Created) (JIRA)
-
William Burns (Issue Comment Edited) (JIRA)
-
William Burns (Updated) (JIRA)