]
Dan Berindei updated ISPN-5474:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request:
Transactions created when applying state should never be replicated
-------------------------------------------------------------------
Key: ISPN-5474
URL:
https://issues.jboss.org/browse/ISPN-5474
Project: Infinispan
Issue Type: Bug
Components: Core
Affects Versions: 7.2.1.Final
Reporter: Dan Berindei
Assignee: Dan Berindei
Priority: Critical
Labels: testsuite_stability
Fix For: 7.2.2.Final, 8.0.0.Alpha1
{{BaseRpcInterceptor.shouldInvokeRemoteTxCommand}} forces the replication of
transactional commands if the topology id changed since the start of the transaction.
However, this can also apply for transaction used internally to apply state during state
transfer.
For a state transfer tx, the collection of affected keys is empty, but
{{ReplicationLogic.getOwners(Collection)}} returns {{null}} instead of
{{Collections.emptySet()}}, and the prepare/commit command ends up being replicated to all
the other nodes.
The extra RPC sometimes causes failures in {{ReplCommandRetryTest}}.