[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Galder Zamarreño commented on ISPN-2044: ---------------------------------------- Since we've added the Externalizer in 5.1.x, I probably wanna do this for 5.1.x, to avoid changing the serialization twice: from 5.0.x to 5.1.x, and then from 5.1.x to 5.2.x. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Galder Zamarreño updated ISPN-2044: ----------------------------------- Fix Version/s: 5.1.5.FINAL -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Galder Zamarreño updated ISPN-2044: ----------------------------------- Fix Version/s: (was: 5.1.5.FINAL) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Sanne Grinovero commented on ISPN-2044: --------------------------------------- I'd avoid wrapping, that takes more memory. Taking for example PutKeyValueCommand, the Flags are transmitted to other nodes as part pf {code} Object[] getParameters(){code} still the command is extending org.infinispan.commands.AbstractFlagAffectedCommand would it not be more sensible to invoke the Externalizer explicitly rather than letting River figure out the type from the Object[] stored reference? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Sanne Grinovero edited comment on ISPN-2044 at 5/16/12 6:25 AM: ---------------------------------------------------------------- I'd avoid wrapping, that takes more memory. Taking for example PutKeyValueCommand, the Flags are transmitted to other nodes as part of {code} Object[] getParameters(){code} still the command is extending org.infinispan.commands.AbstractFlagAffectedCommand would it not be more sensible to invoke the Externalizer explicitly rather than letting River figure out the type from the Object[] stored reference? was (Author: sannegrinovero): I'd avoid wrapping, that takes more memory. Taking for example PutKeyValueCommand, the Flags are transmitted to other nodes as part pf {code} Object[] getParameters(){code} still the command is extending org.infinispan.commands.AbstractFlagAffectedCommand would it not be more sensible to invoke the Externalizer explicitly rather than letting River figure out the type from the Object[] stored reference? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Galder Zamarreño commented on ISPN-2044: ---------------------------------------- To much to change for 5.1.x, let's move this into 5.2, think it through and let the community test this. What have now is better than before anyway. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Galder Zamarreño commented on ISPN-2044: ---------------------------------------- Dan's suggestion is good too: {quote}I think I prefer writing the flags explicitly in the ReplicableCommandExternalizer, to avoid creating lots of extra object instances.{quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Galder Zamarreño commented on ISPN-2044: ---------------------------------------- Indeed. I had missed that comment :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2044?page=com.atlassian.jira.plugin.... ] Mircea Markus updated ISPN-2044: -------------------------------- Fix Version/s: 6.0.0.Final (was: 5.2.0.Final) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira