]
Gustavo Fernandes updated ISPN-12288:
-------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request:
Upgrade to Hibernate Search 6.0.0.Beta10
----------------------------------------
Key: ISPN-12288
URL:
https://issues.redhat.com/browse/ISPN-12288
Project: Infinispan
Issue Type: Task
Components: Embedded Querying, Remote Querying
Affects Versions: 12.0.0.Dev02
Reporter: Yoann Rodière
Assignee: Gustavo Fernandes
Priority: Major
Fix For: 12.0.0.Dev04
Attachments: javabean-property-access.diff
https://in.relation.to/2020/09/07/hibernate-search-6-0-0-Beta10/
Relevant changes:
* {{maxDepth}} was renamed to {{includeDepth}}; this may affect the mapping code for
Remote Query in particular. PR:
https://github.com/hibernate/hibernate-search/pull/2337
* If Infinispan calls {{SearchResult#totalHitCount()}} anywhere, then it should now call
{{total().hitCount()}} instead. {{totalHitCount}} is deprecated.
* Some SPI interfaces related to the type model have changed and Infinispan
implementation may not compile anymore. I recommend changing the Infinispan implementation
the same way we changed another mapper bundled with Search (see the attached diff). An
added benefit: with these changes, embedded mode will support annotations on both methods
and fields (which was supported in 5 but was dropped during the migration to Search 6).
* {{IndexFieldDescriptor}} now exposes a {{multiValuedInRoot()}} method, which I was told
would be very useful to Infinispan, which currently has to go through some hoops to
compute that value based on the multi-valued-ness of a field **and its parents**.
* Timeouts are now forwarded to the entity loader. If Infinispan defines an entity loader
when loading hits as entities instead of projections (and it probably should), some
changes may be necessary in this area. PR:
https://github.com/hibernate/hibernate-search/pull/2333
Optionally, the new ["total hit count
threshold"|https://in.relation.to/2020/09/07/hibernate-search-6-0-0-Beta10/#total-hit-count-threshold]
could be used to improve performance in Infinispan, but that should probably be addressed
a follow-up ticket.