6:22 a.m.
Consider removing transaction suspension code from putForExternalRead()
-----------------------------------------------------------------------
Key: ISPN-1615
URL: https://issues.jboss.org/browse/ISPN-1615
Project: Infinispan
Issue Type: Enhancement
Affects Versions: 5.1.0.CR1, 5.0.1.FINAL
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Fix For: 5.1.0.CR2, 5.1.0.FINAL
The main reason for suspending the transaction was to avoid failures impacting the result
of the transaction.
However, ever since ISPN-1556 has been implemented, any FAIL_SILENT operation (like PFER)
won't have an impact on the transaction if it fails, so this transaction suspension is
not really needed.
Removing the suspension code is apparently a performance booster in 2LC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:08 a.m.
[
https://issues.jboss.org/browse/ISPN-1615?page=com.atlassian.jira.plugin....
]
Mircea Markus commented on ISPN-1615:
-------------------------------------
removing the tx code causes the PFER not to be atomic: i.e. the put might happen on some
nodes and might not happen on some other nodes. If users can live with that then they
should enable use1PcForAutoCommitTransactions which has the same effect:speed(1PC) at the
cost of potential inconsistencies.
Consider removing transaction suspension code from
putForExternalRead()
-----------------------------------------------------------------------
Key: ISPN-1615
URL: https://issues.jboss.org/browse/ISPN-1615
Project: Infinispan
Issue Type: Enhancement
Affects Versions: 5.0.1.FINAL, 5.1.0.CR1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Fix For: 5.1.0.CR2, 5.1.0.FINAL
The main reason for suspending the transaction was to avoid failures impacting the result
of the transaction.
However, ever since ISPN-1556 has been implemented, any FAIL_SILENT operation (like PFER)
won't have an impact on the transaction if it fails, so this transaction suspension is
not really needed.
Removing the suspension code is apparently a performance booster in 2LC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:12 a.m.
[
https://issues.jboss.org/browse/ISPN-1615?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1615:
----------------------------------------
Mircea, PFER is asynchronous, so that was always in the cards, that's why we suspended
the tx :) - It's a best effort operation. I still think removing the suspend would be
a better option but I need to test it with 2LC to make sure it all looks good.
Consider removing transaction suspension code from
putForExternalRead()
-----------------------------------------------------------------------
Key: ISPN-1615
URL: https://issues.jboss.org/browse/ISPN-1615
Project: Infinispan
Issue Type: Enhancement
Affects Versions: 5.0.1.FINAL, 5.1.0.CR1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Fix For: 5.1.0.CR2, 5.1.0.FINAL
The main reason for suspending the transaction was to avoid failures impacting the result
of the transaction.
However, ever since ISPN-1556 has been implemented, any FAIL_SILENT operation (like PFER)
won't have an impact on the transaction if it fails, so this transaction suspension is
not really needed.
Removing the suspension code is apparently a performance booster in 2LC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:18 a.m.
[
https://issues.jboss.org/browse/ISPN-1615?page=com.atlassian.jira.plugin....
]
Mircea Markus commented on ISPN-1615:
-------------------------------------
As galder pointed out, the PFER does not guarnatee atomicity as it is async, so my prev
comment doesn't stand.
Anyway below is a UT that reproduces another issue to be solved by this fix:
{code}
public class NoAutoCommitAndPferTest extends SingleCacheManagerTest {
@Override
protected EmbeddedCacheManager createCacheManager() throws Exception {
Configuration dsc = getDefaultStandaloneConfig(true);
dsc.fluent().transaction().autoCommit(false);
return new DefaultCacheManager(dsc);
}
public void testPferNoAutoCommitExplicitTransaction() throws Exception {
tm().begin();
cache.putForExternalRead("k","v");
tm().commit();
assert cache.get("k").equals("v"); //here is the failure!
}
public void testPferNoAutoCommit() throws Exception {
cache.putForExternalRead("k","v");
assert cache.get("k").equals("v"); //here is the failure!
}
}
{code}
Consider removing transaction suspension code from
putForExternalRead()
-----------------------------------------------------------------------
Key: ISPN-1615
URL: https://issues.jboss.org/browse/ISPN-1615
Project: Infinispan
Issue Type: Enhancement
Affects Versions: 5.0.1.FINAL, 5.1.0.CR1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Fix For: 5.1.0.CR2, 5.1.0.FINAL
The main reason for suspending the transaction was to avoid failures impacting the result
of the transaction.
However, ever since ISPN-1556 has been implemented, any FAIL_SILENT operation (like PFER)
won't have an impact on the transaction if it fails, so this transaction suspension is
not really needed.
Removing the suspension code is apparently a performance booster in 2LC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:14 a.m.
New subject: [JBoss JIRA] (ISPN-1615) Make putForExternalRead() be non-transactional even for transactional caches
[
https://issues.jboss.org/browse/ISPN-1615?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1615:
-----------------------------------
Summary: Make putForExternalRead() be non-transactional even for transactional
caches (was: Consider removing transaction suspension code from putForExternalRead())
Forum Reference:
http://lists.jboss.org/pipermail/infinispan-dev/2011-December/009687.html
As discussed in dev email thread, best option is to make special PFER operation be
non-transactional.
Make putForExternalRead() be non-transactional even for transactional
caches
----------------------------------------------------------------------------
Key: ISPN-1615
URL: https://issues.jboss.org/browse/ISPN-1615
Project: Infinispan
Issue Type: Enhancement
Affects Versions: 5.0.1.FINAL, 5.1.0.CR1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Fix For: 5.1.0.CR2, 5.1.0.FINAL
The main reason for suspending the transaction was to avoid failures impacting the result
of the transaction.
However, ever since ISPN-1556 has been implemented, any FAIL_SILENT operation (like PFER)
won't have an impact on the transaction if it fails, so this transaction suspension is
not really needed.
Removing the suspension code is apparently a performance booster in 2LC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:16 a.m.
New subject: [JBoss JIRA] (ISPN-1615) Make putForExternalRead() be non-transactional even for transactional caches
[
https://issues.jboss.org/browse/ISPN-1615?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1615:
-----------------------------------
Fix Version/s: (was: 5.1.0.FINAL)
Affects Version/s: (was: 5.0.1.FINAL)
Forum Reference:
http://lists.jboss.org/pipermail/infinispan-dev/2011-December/009687.html (was:
http://lists.jboss.org/pipermail/infinispan-dev/2011-December/009687.html)
Make putForExternalRead() be non-transactional even for transactional
caches
----------------------------------------------------------------------------
Key: ISPN-1615
URL: https://issues.jboss.org/browse/ISPN-1615
Project: Infinispan
Issue Type: Enhancement
Affects Versions: 5.1.0.CR1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Fix For: 5.1.0.CR2
The main reason for suspending the transaction was to avoid failures impacting the result
of the transaction.
However, ever since ISPN-1556 has been implemented, any FAIL_SILENT operation (like PFER)
won't have an impact on the transaction if it fails, so this transaction suspension is
not really needed.
Removing the suspension code is apparently a performance booster in 2LC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:07 p.m.
New subject: [JBoss JIRA] (ISPN-1615) Make putForExternalRead() be non-transactional even for transactional caches
[
https://issues.jboss.org/browse/ISPN-1615?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1615:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/728
Make putForExternalRead() be non-transactional even for transactional
caches
----------------------------------------------------------------------------
Key: ISPN-1615
URL: https://issues.jboss.org/browse/ISPN-1615
Project: Infinispan
Issue Type: Enhancement
Affects Versions: 5.1.0.CR1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Fix For: 5.1.0.CR2
The main reason for suspending the transaction was to avoid failures impacting the result
of the transaction.
However, ever since ISPN-1556 has been implemented, any FAIL_SILENT operation (like PFER)
won't have an impact on the transaction if it fails, so this transaction suspension is
not really needed.
Removing the suspension code is apparently a performance booster in 2LC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 a.m.
New subject: [JBoss JIRA] (ISPN-1615) Make putForExternalRead() be non-transactional even for transactional caches
[
https://issues.jboss.org/browse/ISPN-1615?page=com.atlassian.jira.plugin....
]
Mircea Markus updated ISPN-1615:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Make putForExternalRead() be non-transactional even for transactional
caches
----------------------------------------------------------------------------
Key: ISPN-1615
URL: https://issues.jboss.org/browse/ISPN-1615
Project: Infinispan
Issue Type: Enhancement
Affects Versions: 5.1.0.CR1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Fix For: 5.1.0.CR2
The main reason for suspending the transaction was to avoid failures impacting the result
of the transaction.
However, ever since ISPN-1556 has been implemented, any FAIL_SILENT operation (like PFER)
won't have an impact on the transaction if it fails, so this transaction suspension is
not really needed.
Removing the suspension code is apparently a performance booster in 2LC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4769
days inactive
4771
days old
infinispan-issues@lists.jboss.org
7 comments
5 participants
participants (5)
-
Galder Zamarreño (Commented) (JIRA) -
Galder Zamarreño (Created) (JIRA)
-
Galder Zamarreño (Updated) (JIRA)
-
Mircea Markus (Commented) (JIRA)
-
Mircea Markus (Updated) (JIRA)