]
Ron Sigal commented on JBREM-953:
---------------------------------
Removed one line in ServerThread.doRun():
catch(SocketTimeoutException ste)
{
if(!shutdown)
{
if(trace)
{
log.trace(ste);
}
}
running = false; //. <<== removed
}
CLONE [JBREM-945] - Allow ServerThread to keep running after
SocketTImeoutException
-----------------------------------------------------------------------------------
Key: JBREM-953
URL:
http://jira.jboss.com/jira/browse/JBREM-953
Project: JBoss Remoting
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP4, 2.4.0.CR1 (Pinto)
Reporter: Ron Sigal
Assigned To: Ron Sigal
Priority: Minor
Fix For: 2.4.0.GA
Currently, org.jboss.remoting.transport.socket.ServerThread will close its socket and
return itself to the threadpool in the event of a SocketTimeoutException. However, it
could simply continue trying to read the next invocation. The javadoc for
java.net.Socket.setSoTimeout() states:
Enable/disable SO_TIMEOUT with the specified timeout, in milliseconds. With this option
set to a non-zero timeout, a read() call on the InputStream associated with this Socket
will block for only this amount of time. If the timeout expires, a
java.net.SocketTimeoutException is raised, though the Socket is still valid.
If the timeout is due to transitory circumstances, then it would be much more efficient
to allow the ServerThread to continue, rather than forcing the client to start over with a
new socket.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: